Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 9: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 9: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public

Change in vdsm[master]: hostdev: report storage model as product

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 6: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug * Check

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 8: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug *

Change in vdsm[master]: hostdev: add support for SCSI

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 10: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug * Check

Change in vdsm[master]: hostdev: add support for SCSI

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 10: Code-Review+1 partial review -- To view, visit https://gerrit.ovirt.org/55024 To unsubscribe, visit

Change in vdsm[master]: agent: Guest agent reply capability support

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: agent: Guest agent reply capability support .. Patch Set 10: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug *

Change in vdsm[master]: agent: Introduction of first_connect event

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 9: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug *

Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add the migration/hibernation event handling (GuestAgent) .. Patch Set 14: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: Introduction of the GuestAgentEvents class

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class .. Patch Set 9: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug

Change in vdsm[master]: virt: Add new guest agent API function for lifecycle-events

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add new guest agent API function for lifecycle-events .. Patch Set 8: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK,

Change in vdsm[master]: virt: Pass effective guest agent API version during migration

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 7: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Add the migration/hibernation event handling (GuestAgent) .. Patch Set 14: CI failure unrelated: 'printf "\x1b]0;\x07"', 'PATH':

Change in vdsm[master]: migrations: change convergence schedule from time to iterations

2016-04-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 3: Code-Review-1 (6 comments) The code seems to be OK to me. But please fix errors

Change in vdsm[master]: hostdev: report storage model as product

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56123 To unsubscribe, visit

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55022 To

Change in vdsm[master]: require NetworkManager-config-server

2016-04-28 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: require NetworkManager-config-server .. Patch Set 2: Code-Review+1 Good point. Looks good to me. -- To view, visit https://gerrit.ovirt.org/56622 To

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56038 To unsubscribe, visit

Change in vdsm[master]: gluster: add gluster heal info verb

2016-04-28 Thread rnachimu
Ramesh N has uploaded a new change for review. Change subject: gluster: add gluster heal info verb .. gluster: add gluster heal info verb Add gluster heal info to get list of unsynced entries present in the given gluster

Change in vdsm[master]: gluster: add gluster heal info verb

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: add gluster heal info verb .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: virt: graphics: enforce spice default mode .. virt: graphics: enforce spice default mode Libvirt grants and additional protection layer for spice channels,

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: Pass effective guest agent API version during migration

2016-04-28 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/53523 To unsubscribe,

Change in vdsm[master]: agent: Guest agent reply capability support

2016-04-28 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: agent: Guest agent reply capability support .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/53524 To unsubscribe, visit

Change in vdsm[master]: virt: Add new guest agent API function for lifecycle-events

2016-04-28 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Add new guest agent API function for lifecycle-events .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/51780 To unsubscribe,

Change in vdsm[master]: agent: Introduction of first_connect event

2016-04-28 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/54753 To unsubscribe, visit

Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)

2016-04-28 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Add the migration/hibernation event handling (GuestAgent) .. Patch Set 13: Verified+1 (1 comment)

Change in vdsm[master]: virt: Introduction of the GuestAgentEvents class

2016-04-28 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/51781 To unsubscribe, visit

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56038/7/lib/vdsm/hostdev.py File

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-28 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56038/7/lib/vdsm/hostdev.py File

Change in vdsm[master]: v2v: small test improvement

2016-04-28 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56694 To unsubscribe, visit

Change in vdsm[master]: require NetworkManager-config-server

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: require NetworkManager-config-server .. Patch Set 3: * #1326798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1326798::OK, public bug * Check

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 7: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK,

Change in vdsm[master]: vmdevices: make disk's makeName public

2016-04-28 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: vmdevices: make disk's makeName public .. vmdevices: make disk's makeName public makeName is a function that can create udev path to storage device based on

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: extend drives name to allow sata interface .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: cdrom: API change: require index

2016-04-28 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: cdrom: API change: require index .. cdrom: API change: require index Previously, changeCD call did not require anything but path to an image. This works fine

Change in vdsm[master]: cdrom: API change: require index

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cdrom: API change: require index .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmdevices: make disk's makeName public

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmdevices: make disk's makeName public .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migrations: change convergence schedule from time to iterations

2016-04-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 4: -Code-Review Thanks, the commit message is much better now. I'm still a bit

Change in vdsm[master]: automation: update glusterfs repos

2016-04-28 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit

Change in vdsm[master]: blockVolume: make _getVolumeTag public

2016-04-28 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: blockVolume: make _getVolumeTag public .. blockVolume: make _getVolumeTag public _getVolumeTag is a useful and safe utility function for getting the tags

Change in vdsm[master]: FakeLVM: LV size is rounded to VG extent size

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: FakeLVM: LV size is rounded to VG extent size .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56714/1/tests/storagefakelib.py File

Change in vdsm[master]: lvm: Use a constant to define default vg extent size

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lvm: Use a constant to define default vg extent size .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: automation: update glusterfs repos

2016-04-28 Thread dcaro
David Caro has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit

Change in vdsm[master]: monitor: Convert valid to read-only property

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 4: This version updates the tests, addressing Liron comments. -- To view, visit

Change in vdsm[master]: automation: update glusterfs repos

2016-04-28 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: automation: update glusterfs repos .. automation: update glusterfs repos - dropped Gluster community repo for Fedora23 (reposync included): the repo is

Change in vdsm[master]: automation: update glusterfs repos

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: automation: update glusterfs repos

2016-04-28 Thread amarchuk
Anton Marchukov has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit

Change in vdsm[master]: tests: Fix volume size handling in domain_manifest_test

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix volume size handling in domain_manifest_test .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56820 To unsubscribe, visit

Change in vdsm[master]: tests: marking temporarily as broken

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: Code-Review+1 (2 comments) @brokentest needs a description

Change in vdsm[master]: tests: Fix volume size handling in domain_manifest_test

2016-04-28 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Fix volume size handling in domain_manifest_test .. tests: Fix volume size handling in domain_manifest_test This test module is not testing the rounding of

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: blockVolume: make _getVolumeTag public

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockVolume: make _getVolumeTag public .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: cow wip

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cow wip .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid

Change in vdsm[master]: Support initial_size parameter

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: monitor: Convert valid to read-only property

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migrations: change convergence schedule from time to iterations

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: migrations: enhance legacy downtime alg

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migrations: enhance legacy downtime alg .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

2016-04-28 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: rpc: Make Bridge#_type_fixup more robust .. rpc: Make Bridge#_type_fixup more robust _type_fixup method assumed that all top-level arguments of rpc calls are

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 1: Code-Review+1 (3 comments) The commit message could be improved a bit, codewise seems fine.

Change in vdsm[master]: v2v: Detect VM with snapshots

2016-04-28 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 4: Verified+1 Verified with vdsClient on testing vCenter -- To view, visit https://gerrit.ovirt.org/56574 To

Change in vdsm[master]: storage: add block device naming tests

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: storage: add block device naming tests .. Patch Set 1: Code-Review-1 (1 comment) please check the inline comments

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 2: Verified+1 verified with tests, running a VM and connecting using SPICE -- To view, visit

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 27: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: rpc: Make Bridge#_type_fixup more robust .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

2016-04-28 Thread mbetak
Martin Betak has posted comments on this change. Change subject: rpc: Make Bridge#_type_fixup more robust .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56811 To unsubscribe, visit

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 14: (9 comments) https://gerrit.ovirt.org/#/c/55987/14/vdsm/storage/sdm/volume_artifacts.py File

Change in vdsm[master]: vmdevices: make disk's makeName public

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmdevices: make disk's makeName public .. Patch Set 1: Code-Review-1 (1 comment) please check the inline comment

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

2016-04-28 Thread mbetak
Martin Betak has posted comments on this change. Change subject: rpc: Make Bridge#_type_fixup more robust .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py:

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/56746/1//COMMIT_MSG Commit Message: PS1, Line 9: and >

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-28 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: storage: extend drives name to allow sata interface .. storage: extend drives name to allow sata interface SATA is widely used physical interface for storage

Change in vdsm[master]: storage: add block device naming tests

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add block device naming tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: add block device naming tests

2016-04-28 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: storage: add block device naming tests .. storage: add block device naming tests Change-Id: I492a1849109b6f852ccd015d487c6cb7441febdb Signed-off-by: Martin

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: storage: extend drives name to allow sata interface .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56803 To unsubscribe, visit

Change in vdsm[master]: FakeLVM: LV size is rounded to VG extent size

2016-04-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: FakeLVM: LV size is rounded to VG extent size .. Patch Set 1: (2 comments) Yep, fixed some broken tests with a new patch.

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-04-28 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 27: Verified+1 -- To view, visit https://gerrit.ovirt.org/53305 To unsubscribe, visit

Change in vdsm[master]: migrations: change convergence schedule from time to iterations

2016-04-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56558/3//COMMIT_MSG Commit Message:

Change in vdsm[master]: migrations: enhance legacy downtime alg

2016-04-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: migrations: enhance legacy downtime alg .. Patch Set 3: (6 comments) https://gerrit.ovirt.org/#/c/56561/3//COMMIT_MSG Commit Message: PS3, Line 12: during

Change in vdsm[master]: virt: graphics: enforce spice default mode

2016-04-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56746 To unsubscribe, visit

Change in vdsm[master]: cdrom: API change: require index

2016-04-28 Thread fromani
Francesco Romani has posted comments on this change. Change subject: cdrom: API change: require index .. Patch Set 1: Code-Review-1 (1 comment) -1 for backward compatibility concerns

Change in vdsm[master]: lvm: Use a constant to define default vg extent size

2016-04-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: lvm: Use a constant to define default vg extent size .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/56715/1/lib/vdsm/storage/constants.py File

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

2016-04-28 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56607/1//COMMIT_MSG Commit Message: Line 4:

Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli

2016-04-28 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: let VDSM consume a bond created by nmcli .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/56059/9/tests/network/networkmanager.py File

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg/connection files

2016-04-28 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg/connection files .. Patch Set 4: Code-Review+2 I'm willing to have this attempt now, to meet 4.0 timeline. -- To

Change in vdsm[master]: ifcfg: consume bond slaves owned by NetworkManager

2016-04-28 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: consume bond slaves owned by NetworkManager .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56364 To unsubscribe, visit

Change in vdsm[master]: require NetworkManager-config-server

2016-04-28 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: require NetworkManager-config-server .. Patch Set 1: reloading NM would be taken care of by https://gerrit.ovirt.org/#/c/56365/4/vdsm.spec.in@798 -- To

Change in vdsm[master]: net: add virtual port to libvirt network def

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: add virtual port to libvirt network def .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: add vlan tag to libvirt network def

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: add vlan tag to libvirt network def .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: sdm: CreateVolumeInfo.initial_size default should be None

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: CreateVolumeInfo.initial_size default should be None .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56717 To unsubscribe, visit

Change in vdsm[master]: sdm: CreateVolumeInfo.initial_size default should be None

2016-04-28 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sdm: CreateVolumeInfo.initial_size default should be None .. sdm: CreateVolumeInfo.initial_size default should be None Commit 9820797d defined the

Change in vdsm[master]: cdrom: API change: require index

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require index .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56805/1/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json:

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/55987/17/vdsm/storage/sdm/volume_artifacts.py File

Change in vdsm[master]: lvm: Use a constant to define default vg extent size

2016-04-28 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: lvm: Use a constant to define default vg extent size .. lvm: Use a constant to define default vg extent size The default vg extent size has so far been

Change in vdsm[master]: lvm: Use a constant to define default vg extent size

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lvm: Use a constant to define default vg extent size .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: Support initial_size parameter

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 10: Code-Review+1 Waiting for https://gerrit.ovirt.org/55987 -- To view, visit https://gerrit.ovirt.org/56628 To

Change in vdsm[master]: cdrom: API change: require index

2016-04-28 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require index .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py File vdsm/API.py: Line 124 Line 125 Line 126 Line

Change in vdsm[master]: FakeLVM: LV size is rounded to VG extent size

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: FakeLVM: LV size is rounded to VG extent size .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: FakeLVM: LV size is rounded to VG extent size

2016-04-28 Thread automation
gerrit-hooks has posted comments on this change. Change subject: FakeLVM: LV size is rounded to VG extent size .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: FakeLVM: LV size is rounded to VG extent size

2016-04-28 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: FakeLVM: LV size is rounded to VG extent size .. FakeLVM: LV size is rounded to VG extent size In real LVM, LV sizes must be a multiple of the VG extent

  1   2   >