Change in vdsm[master]: virt: Block stuck VMs in executor

Francesco Romani has posted comments on this change. Change subject: virt: Block stuck VMs in executor .. Patch Set 2: (5 comments) Initial review. Very nice first draft!

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

Martin Polednik has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. Patch Set 2: Everything is possible, but in this case, testing just the public API is not feasible. Since

Change in vdsm[master]: migration: move helper into Progress class

Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/56313/14/vdsm/virt/migration.py File

Change in vdsm[master]: migration: store the complete Progress instance

Francesco Romani has posted comments on this change. Change subject: migration: store the complete Progress instance .. Patch Set 2: Yes, indeed I keep the ugly name in the fist patch (56313) only out of convenience. If I

Change in vdsm[master]: migration: wait for monitor thread before to exit

gerrit-hooks has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: decorate with utils.traceback()

gerrit-hooks has posted comments on this change. Change subject: migration: decorate with utils.traceback() .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: store the complete Progress instance

Francesco Romani has uploaded a new change for review. Change subject: migration: store the complete Progress instance .. migration: store the complete Progress instance track the last Progress instance fully, not just the last

Change in vdsm[master]: migration: early exit when stopped

gerrit-hooks has posted comments on this change. Change subject: migration: early exit when stopped .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: migration: move helper into Progress class

gerrit-hooks has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: use composition in DowntimeThread

gerrit-hooks has posted comments on this change. Change subject: migration: use composition in DowntimeThread .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

gerrit-hooks has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.6]: storage: Do not reference image dir in backing volume path

Francesco Romani has posted comments on this change. Change subject: storage: Do not reference image dir in backing volume path .. Patch Set 2: Code-Review+1 Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/57419

Change in vdsm[ovirt-3.6]: storage: Do not reference image dir in backing volume path

gerrit-hooks has posted comments on this change. Change subject: storage: Do not reference image dir in backing volume path .. Patch Set 2: * #1336367::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1336367::OK,

Change in vdsm[master]: migration: use composition in DowntimeThread

gerrit-hooks has posted comments on this change. Change subject: migration: use composition in DowntimeThread .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

gerrit-hooks has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: decorate with utils.traceback()

gerrit-hooks has posted comments on this change. Change subject: migration: decorate with utils.traceback() .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: wait for monitor thread before to exit

gerrit-hooks has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: store the complete Progress instance

gerrit-hooks has posted comments on this change. Change subject: migration: store the complete Progress instance .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: move helper into Progress class

gerrit-hooks has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: add 'ongoing' property to Progress

gerrit-hooks has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: unify again performing modes

gerrit-hooks has posted comments on this change. Change subject: migration: unify again performing modes .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: early exit when stopped

gerrit-hooks has posted comments on this change. Change subject: migration: early exit when stopped .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: Limit the number of workers in executor

Francesco Romani has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/57754/2/lib/vdsm/executor.py File

Change in vdsm[master]: virt: Limit the number of workers in executor

Francesco Romani has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 2: (2 comments) Initial review. Mostly OK, but the test could be perhaps improved. Will follow

Change in vdsm[master]: virt: Alternative proposal for passing flags in/from vm/devi...

gerrit-hooks has posted comments on this change. Change subject: virt: Alternative proposal for passing flags in/from vm/device hooks .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: virt: Collect vm start flags from device hooks when running vm

gerrit-hooks has posted comments on this change. Change subject: virt: Collect vm start flags from device hooks when running vm .. Patch Set 9: * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

Francesco Romani has submitted this change and it was merged. Change subject: code coverage: add coverage for supervdsmServer .. code coverage: add coverage for supervdsmServer In our QE jobs we would like to see also coverage

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

Francesco Romani has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57735 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

gerrit-hooks has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: virt: Alternative proposal for passing flags in/from vm/devi...

Marcin Mirecki has uploaded a new change for review. Change subject: virt: Alternative proposal for passing flags in/from vm/device hooks .. virt: Alternative proposal for passing flags in/from vm/device hooks Change-Id:

Change in vdsm[master]: virt: Collect vm start flags from device hooks when running vm

gerrit-hooks has posted comments on this change. Change subject: virt: Collect vm start flags from device hooks when running vm .. Patch Set 8: * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: Configure mom to ignore missing balloon device

gerrit-hooks has posted comments on this change. Change subject: Configure mom to ignore missing balloon device .. Patch Set 1: * #1337882::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1337882::OK, public bug *

Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure .. Patch Set 2: Code-Review+1 (1 comment) minor nit

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

Nir Soffer has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57735 To unsubscribe, visit

Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: make getHardwareInfoStructure testable

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: make getHardwareInfoStructure testable .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: make _getFromDeviceTree testable

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: make _getFromDeviceTree testable .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: refactor getHardwareInfoStructure

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: refactor getHardwareInfoStructure .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: refactor _getFromDeviceTree

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: refactor _getFromDeviceTree .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. Patch Set 2: In general, we should not test private methods: if we do so, we add a too tight binding

Change in vdsm[master]: ppc64hwinfo: make getHardwareInfoStructure testable

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: make getHardwareInfoStructure testable .. Patch Set 2: Code-Review+1 seems safe enough. -- To view, visit https://gerrit.ovirt.org/57747 To

Change in vdsm[master]: ppc64hwinfo: extend cpuinfo to platform and machine

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: extend cpuinfo to platform and machine .. Patch Set 2: codewise is nice, I just wonder if we should coalesce together in the same namedtuple

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/57746/2/tests/hwinfo_test.py File

Change in vdsm[master]: ppc64hwinfo: extend cpuinfo to platform and machine

gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: extend cpuinfo to platform and machine .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

Martin Polednik has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56685 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

Sandro Bonazzola has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57735 To unsubscribe, visit

Change in vdsm[master]: migration: store the complete Progress instance

Martin Polednik has posted comments on this change. Change subject: migration: store the complete Progress instance .. Patch Set 2: Code-Review+1 I assume the previous name change is acceptable with this in... -- To view,

Change in vdsm[master]: migration: move helper into Progress class

Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/56313/14/vdsm/virt/migration.py File

Change in vdsm[master]: migration: wait for monitor thread before to exit

Martin Polednik has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57753 To unsubscribe, visit

Change in vdsm[master]: migration: add 'ongoing' property to Progress

Martin Polednik has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56314 To unsubscribe, visit

Change in vdsm[master]: virt: Block stuck VMs in executor

gerrit-hooks has posted comments on this change. Change subject: virt: Block stuck VMs in executor .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: Limit the number of workers in executor

gerrit-hooks has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: unify again performing modes

gerrit-hooks has posted comments on this change. Change subject: migration: unify again performing modes .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: store the complete Progress instance

gerrit-hooks has posted comments on this change. Change subject: migration: store the complete Progress instance .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: add 'ongoing' property to Progress

gerrit-hooks has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: MonitorThread.progress could be None

Francesco Romani has abandoned this change. Change subject: migration: MonitorThread.progress could be None .. Abandoned squashed into https://gerrit.ovirt.org/57784 -- To view, visit https://gerrit.ovirt.org/57752 To

Change in vdsm[master]: migration: MonitorThread.progress could be None

gerrit-hooks has posted comments on this change. Change subject: migration: MonitorThread.progress could be None .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/57752 To