Francesco Romani has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 10: Code-Review-1
missing tests
--
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: rpc: Lower logging priority just for getAllVmStats
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60097
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: Set vars/ssl to true in graphics tests
..
Patch Set 2: Verified+1
I believe Jenkins verification is sufficient. Milan, feel free to correct me
Francesco Romani has posted comments on this change.
Change subject: tests: Set vars/ssl to true in graphics tests
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60973
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices.
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 32:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 39:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log calls of API methods with possibly large results
..
Patch Set 1: Verified+1
Verified that getAllVmStats is logged now, with suppressed result.
--
To
Milan Zamazal has posted comments on this change.
Change subject: rpc: Lower logging priority just for getAllVmStats
..
Patch Set 1: Verified+1
Verified that getAllVmStats is still not logged.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 9: Code-Review+1
good enough commit message for me.
--
To view, visit https://gerrit.ovirt.org/57820
To
gerrit-hooks has posted comments on this change.
Change subject: netinfo: tighten exception handling in getIfaceCfg
..
Patch Set 3:
* #1141267::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1141267::OK, public
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: tighten exception handling in getIfaceCfg
..
Patch Set 2: -Verified
Only rebased and adressing the two comments from patch set 2 now.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 3: Continuous-Integration+1
unrelated CI error:
06:03:13 Error: nothing provides
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
spec: Require qemu-kvm-ev to fix aio_bh_poll hang
This qemu-kvm-ev build fixes a hang
Francesco Romani has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1: Continuous-Integration+1
Jenkins failure on fc23:
00:08:31.108
gerrit-hooks has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 2:
* #1349529::Update tracker: OK
* Set MODIFIED::bug 1349529#1349529OK
--
To view,
Milan Zamazal has posted comments on this change.
Change subject: tests: Set vars/ssl to true in graphics tests
..
Patch Set 2:
Yes, Jenkins verification + my verification that the change indeed fixes the
problem described in
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55769/7/vdsm/virt/vmxml.py
File
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
spec: Require qemu-kvm-ev to fix aio_bh_poll hang
This qemu-kvm-ev build fixes a hang
Francesco Romani has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1: Code-Review+2
Thanks Allon for the explanation.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60932
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 19: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56474/19/lib/vdsm/cmdutils.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 23: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55647/23/tests/vmUtilsTests.py
File
Petr Horáček has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60897
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1: Verified+1
Verified that
vdsClient localhost fenceNode 192.168.121.102 54321 drac5 gozo foobar
Milan Zamazal has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 1: Verified+1
Verified that (suppressed) is still logged as getAllVmStats response and
Francesco Romani has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in host devices
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56100
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in core devices
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56098
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in graphics devices
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56099
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: build: enable vdsm-gluster build
..
build: enable vdsm-gluster build
and pull in gluster client packages except on ppc
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 3:
* #1225728::Update tracker: OK
* Set MODIFIED::bug 1225728#1225728IGNORE, not all related patches are
Francesco Romani has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60897
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 2:
* #1349529::Update tracker: OK
* Set MODIFIED::bug 1349529#1349529IGNORE, not all
gerrit-hooks has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 6: Verified+1
verified running `sosreport -o vdsm`
--
To view, visit https://gerrit.ovirt.org/60605
Francesco Romani has posted comments on this change.
Change subject: rpc: Log calls of API methods with possibly large results
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60098
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in vmdevices/common.py
..
Patch Set 5: Code-Review+1
please make sure the new helper is covered by some test - either existing
gerrit-hooks has posted comments on this change.
Change subject: virt: drop legacy device config support
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: network: drop legacy network config support
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1:
this patch only adds protection, so I think it is good for 3.6.z.
--
To view, visit
Francesco Romani has submitted this change and it was merged.
Change subject: xmlrpc: Hide fenceNode password in the log
..
xmlrpc: Hide fenceNode password in the log
We enabled logging of fenceNode xmlrpc calls, however there
Francesco Romani has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60099/1//COMMIT_MSG
Commit Message:
PS1,
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 7: Verified+1
copied score (see PS3 for details)
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: network: drop legacy network config support
..
Patch Set 7: Verified+1
copied score, see PS3 for details.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: drop legacy device config support
..
Patch Set 7: Verified+1
copied score, see PS3 for details.
--
To view, visit https://gerrit.ovirt.org/60326
To
gerrit-hooks has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 2:
* #1351247::Update tracker: OK
* Set MODIFIED::bug 1351247#1351247IGNORE, not all related
Francesco Romani has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm.setLinkAndNetwork
..
Patch Set 5: Code-Review-1
(1 comment)
I want this patch, -1 only for visibility of inline comment.
Francesco Romani has posted comments on this change.
Change subject: virt: Use DOM helpers in _diskXMLGetVolumeChainInfo
..
Patch Set 5: Code-Review+1
IMO much nicer now
--
To view, visit https://gerrit.ovirt.org/58189
To
Francesco Romani has posted comments on this change.
Change subject: network/sr-iov: use device teardown to reattach device
..
Patch Set 6: Code-Review+1
I agree with Dan, code seems fine to me but worth additional check
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Set vars/ssl to true in graphics tests
..
tests: Set vars/ssl to true in graphics tests
In 8a7479c, support for graphics defaultMode was added
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: Add fake_env() helper
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60998
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 10:
* #1354344::Update tracker: OK
* Set MODIFIED::bug 1354344#1354344OK
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Set vars/ssl to true in graphics tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59815
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: reorder sampling initialization
..
vm: reorder sampling initialization
The sampling subsystem initialization is actually independent
with respect
Francesco Romani has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/60678/7/tests/containers/convirt_test.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: graphics: drop legacy configuration support
..
vm: graphics: drop legacy configuration support
We no longer need compatibility with ancient
Ramesh N has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/59600
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 1:
* #1354344::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354344::OK, public bug
*
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61033
to review the following change.
Change subject: migration: wait properly for migration to begin
..
migration: wait
Adam Litke has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/60420/9/tests/storage_sdm_copy_data_test.py
File
Adam Litke has posted comments on this change.
Change subject: storagetestlib: qemu chain verification
..
Patch Set 1:
(11 comments)
https://gerrit.ovirt.org/#/c/60999/1/tests/storagetestlib.py
File tests/storagetestlib.py:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Report qcow2 compat version
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: tests: Use FakeStorageDomainCache in fake env
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60987
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
Patch Set 2:
That fix patch comes later in the series. Unfortunately your fix depends on
other patches in
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60979
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: re-add missing import
..
Patch Set 1: Verified+1
verified running the tests.
--
To view, visit https://gerrit.ovirt.org/61037
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hsm: Use manifest in verify_untrusted_volume
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
*
Adam Litke has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/60420/9/tests/storage_sdm_copy_data_test.py
File
Francesco Romani has posted comments on this change.
Change subject: vmdisk hook: add support for booting from image file
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58748
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
Patch Set 3:
* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: vmxml.all_devices removed
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56105
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: network: drop legacy network config support
..
vm: network: drop legacy network config support
Drop the legacy Vm methods to rebuild specific
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: vm: network: drop legacy network config support
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
1 - 100 of 322 matches
Mail list logo