Change in vdsm[master]: jsonrpc: shorten executor thread system names

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jsonrpc: shorten executor thread system names .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: jsonrpc: shorten executor thread system names

2016-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: shorten executor thread system names .. jsonrpc: shorten executor thread system names We shorten the basename of the jsonrpc executor,

Change in vdsm[master]: virt: vm: switch to concurrent.thread()

2016-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: vm: switch to concurrent.thread() .. virt: vm: switch to concurrent.thread() The LiveMergeCleanupThread class used to inherit from

Change in vdsm[master]: virt: vm: switch to concurrent.thread()

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: vm: switch to concurrent.thread() .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: migration: switch to concurrent.thread() .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

2016-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: migration: switch to concurrent.thread() .. Patch Set 11: Code-Review+2 raising Milan's score for PS9 -- To view, visit https://gerrit.ovirt.org/61463

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

2016-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: migration: switch to concurrent.thread() .. virt: migration: switch to concurrent.thread() This patch moves all the migration threads

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Patch Set 4: * #1321010::Update tracker: OK * Set MODIFIED::bug 1321010#1321010::IGNORE, skipping

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

2016-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Revert "configurator: libvirt: do not jump on virtlogd" This reverts commit

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

2016-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Patch Set 3: Code-Review+2 let's jump! -- To view, visit https://gerrit.ovirt.org/61481 To

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

2016-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Add PipelineProc, pipeline wrapper object .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62094/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS3,

Change in vdsm[master]: v2v: Add helper that redirects stdin/out/err

2016-08-23 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: Add helper that redirects stdin/out/err .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62092 To unsubscribe, visit

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

2016-08-23 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: Add PipelineProc, pipeline wrapper object .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62094 To unsubscribe, visit

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

2016-08-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: Add PipelineProc, pipeline wrapper object .. Patch Set 3: Code-Review+1 temporarily lowering my score to not hid Dan's -- To view, visit

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

2016-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Add PipelineProc, pipeline wrapper object .. Patch Set 3: Code-Review-1 (1 comment) nit, but my own pet nit

Change in vdsm[ovirt-4.0]: utils: atomic file write

2016-08-23 Thread ykaul
Yaniv Kaul has posted comments on this change. Change subject: utils: atomic file write .. Patch Set 3: (2 comments) Why not use something like https://github.com/untitaker/python-atomicwrites ?

Change in vdsm[master]: v2v: Bump version requirement on python-cpopen.

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: Bump version requirement on python-cpopen. .. Patch Set 3: * #1350465::Update tracker: OK * Set MODIFIED::bug 1350465#1350465IGNORE, not all related

Change in vdsm[master]: v2v: Bump version requirement on python-cpopen.

2016-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: Bump version requirement on python-cpopen. .. v2v: Bump version requirement on python-cpopen. In order to support redirection of stderr to stdout

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

2016-08-23 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Add PipelineProc, pipeline wrapper object .. Patch Set 3: Verified+1 Verified the topic as whole. Tried successful and unsuccessful import. In both

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

2016-08-23 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 16: Verified+1 Verified the topic as whole. Tried successful and unsuccessful import. In both cases

Change in vdsm[master]: v2v: Add helper that redirects stdin/out/err

2016-08-23 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Add helper that redirects stdin/out/err .. Patch Set 3: Verified the topic as whole. Tried successful and unsuccessful import. In both cases return

Change in vdsm[master]: v2v: Add helper that redirects stdin/out/err

2016-08-23 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Add helper that redirects stdin/out/err .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/62092 To unsubscribe, visit

Change in vdsm[master]: Fix configfile for py3 to use unicode

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Fix configfile for py3 to use unicode .. Patch Set 16: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48052 To unsubscribe, visit

Change in vdsm[master]: api: Move getAllVmStats hooks and logging from API to clientIF

2016-08-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: api: Move getAllVmStats hooks and logging from API to clientIF .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60583/2/vdsm/clientIF.py File

Change in vdsm[master]: logging: Improve logging when receiving signals

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: logging: Improve logging when receiving signals .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61289 To unsubscribe, visit

Change in vdsm[master]: build: require only the same version, not release

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: build: require only the same version, not release .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62672 To unsubscribe, visit

Change in vdsm[master]: yajsonrpc: switch to concurrent.thread()

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: yajsonrpc: switch to concurrent.thread() .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61462 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: test: Introduce mock module for testing

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: test: Introduce mock module for testing .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62279 To unsubscribe, visit

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: jsonrpc: add example script to run a VM .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/62156/4/lib/vdsm/virt/vmstats.py File

Change in vdsm[master]: api: Move getAllVmStats hooks and logging from API to clientIF

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: Move getAllVmStats hooks and logging from API to clientIF .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60583/2/vdsm/clientIF.py File

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

2016-08-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Patch Set 3: Verified+1 a bit more test gave good result. I think it is good enough for master.

Change in vdsm[ovirt-4.0]: utils: atomic file write

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: atomic file write .. Patch Set 3: * #1364081::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364081::OK, public bug * Check

Change in vdsm[master]: jsonrpc: Log RPC call arguments

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Log RPC call arguments .. Patch Set 2: (1 comment) It would be good to add some tests. https://gerrit.ovirt.org/#/c/60572/2//COMMIT_MSG Commit

Change in vdsm[ovirt-4.0]: ovs: use Setup class directly

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 5: * #1364081::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364081::OK, public bug * Check

Change in vdsm[master]: after_vm_start: changed vdscli to jsonrpcvdsli

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: after_vm_start: changed vdscli to jsonrpcvdsli .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: after_vm_start: changed vdscli to jsonrpcvdsli

2016-08-23 Thread igoihman
Irit Goihman has uploaded a new change for review. Change subject: after_vm_start: changed vdscli to jsonrpcvdsli .. after_vm_start: changed vdscli to jsonrpcvdsli vdscli is deprecated and was replaced by jsonrpcvdsli

Change in vdsm[master]: Adding units to memory metrics name according to metrics2.0 ...

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Adding units to memory metrics name according to metrics2.0 spec .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/host/api.py File

Change in vdsm[master]: build: require only the same version, not release

2016-08-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: build: require only the same version, not release .. Patch Set 1: Verified+1 I updated one Centos 7.2 box of mine with patched Vdsm. The update went well,

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Adding memTotal metric

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/62154/4//COMMIT_MSG Commit Message: Line 4: Commit: Yaniv Bronhaim

Change in vdsm[master]: build: require only the same version, not release

2016-08-23 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: build: require only the same version, not release .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62672 To unsubscribe, visit

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sos: replace dumpStorageTable with dump_volume_chains .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dump_volume_chains: migrate to jsonrpcvdscli .. Patch Set 10: * #1365007::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1365007::OK, public bug *

Change in vdsm[master]: Add all MOM calls to jsonrpc client

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60492 To unsubscribe, visit

Change in vdsm[master]: health: Warn about delays in monitor threads

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: health: Warn about delays in monitor threads .. Patch Set 1: can we have this patch in? -- To view, visit https://gerrit.ovirt.org/52524 To unsubscribe,

Change in vdsm[master]: jsonrpc: shorten executor thread system names

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: shorten executor thread system names .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61978 To unsubscribe, visit

Change in vdsm[master]: enabling ppc64le builds for vdsm

2016-08-23 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: enabling ppc64le builds for vdsm .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62123 To unsubscribe, visit

Change in vdsm[master]: net: add a resolv.conf writer

2016-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: add a resolv.conf writer .. Patch Set 1: (2 comments) very very shallow review on my part

Change in vdsm[master]: net: add a resolv.conf writer

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: add a resolv.conf writer .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: move name resolver functions from netinfo to ip

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move name resolver functions from netinfo to ip .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: support configuring nameservers by ovs

2016-08-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: support configuring nameservers by ovs .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: support configuring nameservers by ovs

2016-08-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: net: support configuring nameservers by ovs .. net: support configuring nameservers by ovs Change-Id: I5fe4f82fe88e24b43e5f40e96ae4292ebf933a8e Signed-off-by:

Change in vdsm[master]: net: move name resolver functions from netinfo to ip

2016-08-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: net: move name resolver functions from netinfo to ip .. net: move name resolver functions from netinfo to ip This is a preparation to share resolv.conf

Change in vdsm[master]: net: add a resolv.conf writer

2016-08-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: net: add a resolv.conf writer .. net: add a resolv.conf writer Change-Id: I41b81b04fbe3e3e2398f28cb16fb0dbbc0382249 Signed-off-by: Ondřej Svoboda

<    1   2