Francesco Romani has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: sos: change getConnectedStoragePoolsList result key
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add mount.isMounted() timing tests
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/56565/7/tests/mountTests.py
File tests/mountTests.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: Draft for showing client address in rpc logs
..
Patch Set 1: Code-Review-1
(1 comment)
I am ok with this change if we confirm that network logic on
Piotr Kliczewski has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: readme.logging: Remove unneded storage hack
..
Patch Set 1: Code-Review+2
+2 because I added the README in the first place :)
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: Add mount.isMounted() timing tests
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/56565/7/tests/mountTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/63230/3//COMMIT_MSG
Commit
Nir Soffer has posted comments on this change.
Change subject: api: use the new devel_warn helper
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62210/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-08-24
Piotr Kliczewski has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
File
Nir Soffer has uploaded a new change for review.
Change subject: readme.logging: Remove unneded storage hack
..
readme.logging: Remove unneded storage hack
All storage loggers were unified, there no need to call setLogLevel
gerrit-hooks has posted comments on this change.
Change subject: readme.logging: Remove unneded storage hack
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: readme.logging: Remove unneded storage hack
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63671
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Prevent running periodic operations on stuck VMs
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Milan Zamazal has abandoned this change.
Change subject: virt: Prevent running periodic operations on stuck VMs
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59736
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Prevent running stuck periodic operations
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/59737
To
Piotr Kliczewski has posted comments on this change.
Change subject: Draft for showing client address in rpc logs
..
Patch Set 1:
@Dan are we still using server address in the engine?
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: tests: Add tests for un-escaping spaces
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56549
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: mount: Fix un-escaping of spaces
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56550
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63529
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Pass scheduler to jobs.start
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getSpmStatus
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for LVMVolumeGroup.getInfo
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: schema: customizable hook name
..
Patch Set 3:
ping
--
To view, visit https://gerrit.ovirt.org/59251
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Petr Horáček has uploaded a new change for review.
Change subject: net tests: replace wait_for_ipv6 with waitfor.waitfor_ipv6_addr
..
net tests: replace wait_for_ipv6 with waitfor.waitfor_ipv6_addr
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: net tests: replace wait_for_ipv6 with waitfor.waitfor_ipv6_addr
..
Patch Set 1:
* #1374328::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: net tests: raise specific MonitorError on IPv6 timeout
..
Patch Set 3:
* #1374328::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374328::OK,
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: api: use the new devel_warn helper
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62210/2//COMMIT_MSG
Commit Message:
PS2, Line 9: warnings
why
Nir Soffer has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3: Code-Review-1
This looks correct, if https://gerrit.ovirt.org/63408 was correcdt, but
I think it was
Francesco Romani has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: Add missing test for deleted mounts
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56547
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 7:
perhaps squash in the parent? It seems to me that the two patches aren't really
independent.
--
To
Francesco Romani has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15:
looks OK, I just want to have another pass later.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63661
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: readme.logging: Remove unneded storage hack
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63671
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sdm: Drop support for thread-local job_id
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Fix stopping order
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: jobs: Move run from sdm.base.Job to jobs.Job
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Pass scheduler to jobs.start
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: vdsm: Fix stopping order
..
vdsm: Fix stopping order
The jobs module uses the scheduler so it should be stopped before the
scheduler.
Change-Id:
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2: Verified+1
Fixed commit message to the 3.6 bug. Note that
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
* #1375076::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1375076::OK, public bug
Francesco Romani has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63522
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63661/1/lib/vdsm/utils.py
File
Nir Soffer has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 5: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/62002/5/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 160
Line 161
Line
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63532
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63661/1/lib/vdsm/utils.py
File
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
* #1367281::Update tracker: OK
* Set MODIFIED::bug 1367281#1367281OK
--
To view,
Francesco Romani has submitted this change and it was merged.
Change subject: Live Merge: Refresh base volume before live merge
..
Live Merge: Refresh base volume before live merge
When live merging raw base volume, engine
Francesco Romani has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63525
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63646/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Francesco Romani has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63523
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Pass scheduler to jobs.start
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62000/3/tests/jobsTests.py
File tests/jobsTests.py:
Line 18:
Petr Horáček has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 2: Code-Review-1
(1 comment)
Francesco Romani has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
..
Patch Set 1:
Looks OK, and I trust the storage people.
--
To view, visit https://gerrit.ovirt.org/63427
To
Petr Horáček has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2: Code-Review-1
(1 comment)
-1 for attention
Francesco Romani has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63528/4//COMMIT_MSG
Commit Message:
PS4,
Petr Horáček has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1: Code-Review-1
-1 for attention
--
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63526
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63527
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 4: Code-Review+1
(1 comment)
Looks like a good skeleton. If we ever want to add something there )(e.g.,
Piotr Kliczewski has posted comments on this change.
Change subject: tests: missing dispatch in jsonrpc integration tests
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/58523
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: storage: Remove unneeded multipath call
..
storage: Remove unneeded multipath call
As part of multipath rescan, we call iscsi and hba rescan.
These
Milan Zamazal has abandoned this change.
Change subject: virt: Block stuck VMs in executor
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/57755
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: virt: Block stuck VMs in executor
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57755
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
..
Patch Set 2:
* #1303578::Update tracker: OK
* Set MODIFIED::bug 1303578#1303578OK
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: Add start/stop interface to jobs module
..
Add start/stop interface to jobs module
Add interfaces similar to virt.periodic and other subsystems for
gerrit-hooks has posted comments on this change.
Change subject: Add start/stop interface to jobs module
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Task.getStatus
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit https://gerrit.ovirt.org/59705
To
Piotr Kliczewski has posted comments on this change.
Change subject: yml: schema validation tests
..
Patch Set 1:
Let's keep this patch for some time longer
--
To view, visit https://gerrit.ovirt.org/60071
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.spmStart
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit https://gerrit.ovirt.org/59707
Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connect
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
..
Patch Set 2:
Let's keep this patch for some time longer
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 22: Code-Review-1
(7 comments)
Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 16: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/63119/16//COMMIT_MSG
Commit Message:
PS16, Line
Petr Horáček has posted comments on this change.
Change subject: net test: Clean lease files on setup-cleanup
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py
File
Milan Zamazal has abandoned this change.
Change subject: virt: Prevent running stuck periodic operations
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59737
To unsubscribe, visit https://gerrit.ovirt.org/settings
1 - 100 of 241 matches
Mail list logo
