Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Remove volume run link after live merge
..
Patch Set 3:
@Francesco, based on Nir's comments on the CI, can we move forwards with this
patch
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 3: Code-Review+1
@Francesco, can we move forwards with this patch please?
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65090
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Add Fedora dockerfile
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 4: Code-Review+2
ok, let's do it.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: More standard logging format
..
logging: More standard logging format
Use nicer and more standard logging format, similar to engine log
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dockerfile: Minimize docker images
..
dockerfile: Minimize docker images
Cleaning dnf caches remove 145MiB of useless data slowing down pushing
and
Dan Kenigsberg has posted comments on this change.
Change subject: py3: fix remaining references to monitor.MonitorError as
iterable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64929/1/init/wait_for_ipv4s
File
Edward Haas has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 2: Code-Review-1
(1 comment)
The -1 is mainly for the commit message.
The scenario where both prefix and
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Minimize docker images
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dockerfile: Add Fedora dockerfile
..
dockerfile: Add Fedora dockerfile
The Fedora image should run the python 3 tests that cannot run on
CentOS
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add Fedora dockerfile
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add Fedora dockerfile
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Minimize docker images
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Use same log format in the tests
..
logging: Use same log format in the tests
Using the same format as in vdsm logs may make it easier to
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Hello Petr Horáček, Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65304
to review the following change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65305
to review the following change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
spec:
Hello Nir Soffer, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65307
to review the following change.
Change subject: virt: Make boolean values from boolean migration options
..
Hello Michal Skrivanek, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65306
to review the following change.
Change subject: virt: Don't crash in migration progress on compression bytes
Hello Petr Horáček, Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65303
to review the following change.
Change subject: net ifcfg: fix bond rollback
..
net ifcfg:
gerrit-hooks has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 1:
* #64096::Update tracker: OK
* #1367378::Update tracker: OK
* Check Bug-Url::OK
*
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1:
* #64468::Update tracker: OK
* #1380822::Update tracker: OK
* #64499::Update
gerrit-hooks has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 1:
* #59940::Update tracker: OK
* #64509::Update tracker: OK
* #1374194::Update tracker: OK
* Check Bug-Url::OK
* Check
gerrit-hooks has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1:
* #1365640::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303550::OK, public bug
Francesco Romani has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Code-Review+2 Verified+1
same code as ovirt-4.0, patch applied in the same order
ovirt-4.0.5
Francesco Romani has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1: Code-Review+2 Verified+1
same code as ovirt-4.0, patch applied in the same order
gerrit-hooks has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1:
* #65108::Update tracker: OK
* #1380822::Update tracker: OK
* #65007::Update tracker: OK
Francesco Romani has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 1: Code-Review+2 Verified+1
same code as ovirt-4.0, patch applied in the same order
Francesco Romani has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 1: Code-Review+2 Verified+1
same code as ovirt-4.0, patch applied in the same order
ovirt-4.0.5 branched too early
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162: finally:
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg map
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65112/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-10-05
Ala Hino has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65112/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-10-05
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
Patch Set 2:
Looks good, now we need to add a test to make sure our testing infrastructure
works.
I think
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg map
..
Patch Set 3:
Please fix test failures.
--
To view, visit https://gerrit.ovirt.org/65112
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65053
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline acquiring of multiple images locks
..
sp: Streamline acquiring of multiple images locks
Replace srcImageResourcesNamespace and
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65328
To
Nir Soffer has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65325
To
Nir Soffer has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65327
To
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Do not use rm.acquireResource return value
..
sp: Do not use rm.acquireResource return value
resourceManager.acquireResource is returning now a
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline usage of image.Image class
..
sp: Streamline usage of image.Image class
We used to create an image.Image an call a method in one line,
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Fix positional args calling convention
..
sp: Fix positional args calling convention
StorageDomain.setDescription and Volume.setLegality accept one
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Sort dict literal by key
..
sp: Sort dict literal by key
With more than few items, it is easier to work with sorted items, and
people are less likely
Nir Soffer has submitted this change and it was merged.
Change subject: sp: pep8 1.6.2 fix
..
sp: pep8 1.6.2 fix
Both pep8 tool and me do not like line breaks before binary operators.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove double dict key
..
sp: Remove double dict key
Commit f9cf58b7bced (Make getRepoStats() a hsm method) added a second
"pool_status" key in the
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
Nir Soffer has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
Adam Litke has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65049
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65042
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65043
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65045
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65044
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65046
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65048
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65047
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: utils: Add missing Popen methods
..
utils: Add missing Popen methods
AsyncProc should have a Popen like interface, but it is missing
terminate() and send_signal()
Nir Soffer has uploaded a new change for review.
Change subject: tests: Refine TerminationTests names
..
tests: Refine TerminationTests names
- Al the test are testing termination, there is no point in repeating
the class
Nir Soffer has uploaded a new change for review.
Change subject: tests: Use Popen.poll() for running state
..
tests: Use Popen.poll() for running state
Checking if /proc/pid exists works, but using poll() is simpler and more
Nir Soffer has uploaded a new change for review.
Change subject: utils: Wait for terminated process
..
utils: Wait for terminated process
utils.terminating was not waiting for a terminated process, passing the
process to
Nir Soffer has uploaded a new change for review.
Change subject: utils: Raise detectable error if termination fail
..
utils: Raise detectable error if termination fail
If terminating process failed because of unexpected error
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add tests for waiting on a zombie process
..
tests: Add tests for waiting on a zombie process
If a process was terminated but not waited, terminating
Nir Soffer has uploaded a new change for review.
Change subject: tests: Wait for child process in tearDown
..
tests: Wait for child process in tearDown
If the code fail to terminate a child process, we must wait for child
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add test for terminating a terminated process
..
tests: Add test for terminating a terminated process
In this case we should find that the process has
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/65112/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 497:
Adam Litke has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65041
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65052
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65050
To unsubscribe, visit https://gerrit.ovirt.org/settings
1 - 100 of 209 matches
Mail list logo