Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65322 To unsubscribe,

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65321 To unsubscribe, visit

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 3: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65294 To unsubscribe,

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Fix domain.produceVolume calling convention .. sp: Fix domain.produceVolume calling convention As a general rule positional args should be called as

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Remove useless continuation to a commented line .. sp: Remove useless continuation to a commented line Change-Id:

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline building domains list for upgrade .. sp: Streamline building domains list for upgrade Instead of creating a list of domain uuids, and

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline calls to volume methods .. sp: Streamline calls to volume methods When calling volume methods, we typically produce the domain, produce the

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Simplify long lines using continuation \ .. sp: Simplify long lines using continuation \ Eliminate fragile and hard to read continuation \ with

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Remove vol_extend_policy option .. sp: Remove vol_extend_policy option We had a vol_extend_policy option disabling the mailbox. This option is not

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 11: Continuous-Integration+1 Jenkins el7 build is broken now, wont even start. -- To view, visit

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view, visit

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 4: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 --

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 4: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view,

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 6: Continuous-Integration+1 Verified+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view, visit

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To

Change in vdsm[ovirt-4.0.5]: spec: Require selinux-policy-targeted for CephFS

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spec: Require selinux-policy-targeted for CephFS .. Patch Set 1: Continuous-Integration+1 run 'make check' manually and succesfully. -- To view, visit

Change in vdsm[ovirt-4.0.5]: virt: Don't crash in migration progress on compression bytes

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Don't crash in migration progress on compression bytes .. Patch Set 1: Continuous-Integration+1 run 'make check' manually and succesfully. -- To

Change in vdsm[ovirt-4.0.5]: net ifcfg: fix bond rollback

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: net ifcfg: fix bond rollback .. Patch Set 1: Continuous-Integration+1 run 'make check' manually and succesfully. -- To view, visit

Change in vdsm[ovirt-4.0.5]: net: Consume ifcfg files that have a non vdsm standard name

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 1: Continuous-Integration+1 run 'make check' manually and succesfully. -- To view,

Change in vdsm[master]: storagetestlib: Add sdVersion param to the test API.

2016-10-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: storagetestlib: Add sdVersion param to the test API. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65308 To unsubscribe, visit

Change in vdsm[master]: hsm:Use sd compat instead of qemu conf compat.

2016-10-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: hsm:Use sd compat instead of qemu conf compat. .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/64951 To unsubscribe, visit

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Remove double dict key

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline usage of image.Image class .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Sort dict literal by key

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Sort dict literal by key .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: designwise ACK from me. -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit

Change in vdsm[master]: logging: Unify SimpleLogAdapter format

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

2016-10-10 Thread akrejcir
Hello Piotr Kliczewski, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65288 to review the following change. Change subject: Fix API schema to align with runtime schema .. Fix API schema to align

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1348255::OK, public bug * Check merged

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: (2 comments) initial review. Looks nice, but I need to doublecheck the state machine.

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: Code-Review-1 Can we please add a supporting test for this scenario? When

Change in vdsm[master]: logging: More standard logging format

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit

Change in vdsm[master]: logging: Use same log format in the tests

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit

Change in vdsm[master]: logging: Improve log level alignment

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Does it really worth it for just saving 2 spaces? If this is just for the output format, can it be cut there

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 3: * #1373832::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1373832::OK, public bug * Check

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 3: * #1373832::Update tracker: OK * #60513::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: dockerfile: Minimize docker images

2016-10-10 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: dockerfile: Minimize docker images .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65271 To unsubscribe, visit

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: pep8 1.6.2 fix

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: pep8 1.6.2 fix .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline calls to volume methods .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: py3: let bulk_sampling_test pass under py3

2016-10-10 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: py3: let bulk_sampling_test pass under py3 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65006 To unsubscribe, visit

Change in vdsm[master]: core: Expose API for qemuimg map

2016-10-10 Thread ahino
Ala Hino has posted comments on this change. Change subject: core: Expose API for qemuimg map .. Patch Set 2: (8 comments) https://gerrit.ovirt.org/#/c/65112/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 219: Line

Change in vdsm[master]: core: Expose API for qemuimg map

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: core: Expose API for qemuimg map .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net tests: minor libvirt_tests style refactoring

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hooks: avoid redundant temporary list

2016-10-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: hooks: avoid redundant temporary list .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65273 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

2016-10-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Fix API schema to align with runtime schema .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65288 To unsubscribe, visit

Change in vdsm[master]: utils: Fix terminating context manager

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Fix terminating context manager .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit

Change in vdsm[master]: hooks: avoid redundant temporary list

2016-10-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: avoid redundant temporary list .. hooks: avoid redundant temporary list No functional change is expected. Change-Id:

Change in vdsm[master]: hooks: avoid redundant temporary list

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: avoid redundant temporary list .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: build: Disable tests during build

2016-10-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63966/6/vdsm.spec.in File vdsm.spec.in: Line 65 Line

Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge

2016-10-10 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Live Merge: Remove volume run link after live merge .. Live Merge: Remove volume run link after live merge When deleting a volume while the VM is

Change in vdsm[ovirt-4.0]: Live Merge: Teardown volume on HSM after live merge

2016-10-10 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Live Merge: Teardown volume on HSM after live merge .. Live Merge: Teardown volume on HSM after live merge If a VM is running on HSM and live merge

Change in vdsm[ovirt-4.0]: Live Merge: Teardown volume on HSM after live merge

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64985 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 4: * #64986::Update tracker: OK * #1321018::Update tracker: OK * #59725::Update tracker: OK *

Change in vdsm[ovirt-4.0]: Live Merge: Teardown volume on HSM after live merge

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge .. Patch Set 4: * #64985::Update tracker: OK * #1377849::Update tracker: OK * #64301::Update tracker: OK *

Change in vdsm[ovirt-4.0]: virt: Make boolean values from boolean migration options

2016-10-10 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: virt: Make boolean values from boolean migration options .. virt: Make boolean values from boolean migration options `compressed' and `autoConverge'

Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks

2016-10-10 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: gluster: set selinux labels while creating bricks .. gluster: set selinux labels while creating bricks brick should have correct selinux labels on

Change in vdsm[ovirt-4.0]: virt: Make boolean values from boolean migration options

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 2: * #65108::Update tracker: OK * #1380822::Update tracker: OK * #65007::Update tracker: OK

Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 1: Code-Review+2 we already merged 4.0.6 patches, so we can take this. -- To view, visit

Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 2: * #1368474::Update tracker: OK * #62773::Update tracker: OK * #64296::Update tracker: OK * Set

Change in vdsm[master]: storagetestlib: Add sdVersion param to the test API.

2016-10-10 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: storagetestlib: Add sdVersion param to the test API. .. storagetestlib: Add sdVersion param to the test API. Add a storage domain version when creating a mock

Change in vdsm[master]: hsm:Use sd compat instead of qemu conf compat.

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hsm:Use sd compat instead of qemu conf compat. .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

<    1   2   3   >