Nir Soffer has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65322
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65321
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 3: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe,
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Fix domain.produceVolume calling convention
..
sp: Fix domain.produceVolume calling convention
As a general rule positional args should be called as
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove useless continuation to a commented line
..
sp: Remove useless continuation to a commented line
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline building domains list for upgrade
..
sp: Streamline building domains list for upgrade
Instead of creating a list of domain uuids, and
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline calls to volume methods
..
sp: Streamline calls to volume methods
When calling volume methods, we typically produce the domain, produce
the
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Simplify long lines using continuation \
..
sp: Simplify long lines using continuation \
Eliminate fragile and hard to read continuation \ with
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove vol_extend_policy option
..
sp: Remove vol_extend_policy option
We had a vol_extend_policy option disabling the mailbox. This option is
not
Nir Soffer has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 11: Continuous-Integration+1
Jenkins el7 build is broken now, wont even start.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
Nir Soffer has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 6: Continuous-Integration+1 Verified+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
Nir Soffer has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To
Francesco Romani has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Continuous-Integration+1
run 'make check' manually and succesfully.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1: Continuous-Integration+1
run 'make check' manually and succesfully.
--
To
Francesco Romani has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 1: Continuous-Integration+1
run 'make check' manually and succesfully.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 1: Continuous-Integration+1
run 'make check' manually and succesfully.
--
To view,
Maor Lipchuk has posted comments on this change.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65308
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: hsm:Use sd compat instead of qemu conf compat.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
designwise ACK from me.
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64227
To unsubscribe, visit
Hello Piotr Kliczewski,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65288
to review the following change.
Change subject: Fix API schema to align with runtime schema
..
Fix API schema to align
gerrit-hooks has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1348255::OK, public bug
* Check merged
Francesco Romani has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
(2 comments)
initial review. Looks nice, but I need to doublecheck the state machine.
Edward Haas has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Code-Review-1
Can we please add a supporting test for this scenario?
When
Edward Haas has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3:
Does it really worth it for just saving 2 spaces?
If this is just for the output format, can it be cut there
gerrit-hooks has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 3:
* #1373832::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 3:
* #1373832::Update tracker: OK
* #60513::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Freddy Rolland has posted comments on this change.
Change subject: dockerfile: Minimize docker images
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: py3: let bulk_sampling_test pass under py3
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg map
..
Patch Set 2:
(8 comments)
https://gerrit.ovirt.org/#/c/65112/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 219:
Line
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg map
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File
gerrit-hooks has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: avoid redundant temporary list
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65273
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65288
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Fix terminating context manager
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65274
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: avoid redundant temporary list
..
hooks: avoid redundant temporary list
No functional change is expected.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: hooks: avoid redundant temporary list
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63966/6/vdsm.spec.in
File vdsm.spec.in:
Line 65
Line
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Remove volume run link after live merge
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64986
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: Live Merge: Remove volume run link after live merge
..
Live Merge: Remove volume run link after live merge
When deleting a volume while the VM is
Francesco Romani has submitted this change and it was merged.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Live Merge: Teardown volume on HSM after live merge
If a VM is running on HSM and live merge
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64985
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Remove volume run link after live merge
..
Patch Set 4:
* #64986::Update tracker: OK
* #1321018::Update tracker: OK
* #59725::Update tracker: OK
*
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 4:
* #64985::Update tracker: OK
* #1377849::Update tracker: OK
* #64301::Update tracker: OK
*
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Make boolean values from boolean migration options
..
virt: Make boolean values from boolean migration options
`compressed' and `autoConverge'
Francesco Romani has submitted this change and it was merged.
Change subject: gluster: set selinux labels while creating bricks
..
gluster: set selinux labels while creating bricks
brick should have correct selinux labels on
gerrit-hooks has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2:
* #65108::Update tracker: OK
* #1380822::Update tracker: OK
* #65007::Update tracker: OK
Francesco Romani has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 1: Code-Review+2
we already merged 4.0.6 patches, so we can take this.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 2:
* #1368474::Update tracker: OK
* #62773::Update tracker: OK
* #64296::Update tracker: OK
* Set
Maor Lipchuk has uploaded a new change for review.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
storagetestlib: Add sdVersion param to the test API.
Add a storage domain version when creating a mock
gerrit-hooks has posted comments on this change.
Change subject: hsm:Use sd compat instead of qemu conf compat.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
101 - 200 of 209 matches
Mail list logo