Change in vdsm[master]: register: remove persist/unpersist calls for legacy node

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: register: remove persist/unpersist calls for legacy node
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/67619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fff016704b22d19c840e858a66fe62e5d37ecb0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: register: remove persist/unpersist calls for legacy node

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: register: remove persist/unpersist calls for legacy node
..


register: remove persist/unpersist calls for legacy node

This patch removes all related to unpersist and persist
calls exclusive for oVirt Node Legacy. oVirt Node Next doesn't
require such approach.

Change-Id: I4fff016704b22d19c840e858a66fe62e5d37ecb0
Signed-off-by: Douglas Schilling Landgraf 
---
M lib/vdsm/tool/register.py
1 file changed, 0 insertions(+), 21 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/67619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fff016704b22d19c840e858a66fe62e5d37ecb0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rwtab.d: Remove vdsm entry

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: rwtab.d: Remove vdsm entry
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/67620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife3193bcb48fa28d5e648c1b28d0a0b01de9206e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-30 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding simple client for sending gauge metrics to statsd port 
using udp
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/67004/15/tests/statsd_tests.py
File tests/statsd_tests.py:

Line 38: def teardown_class(self):
Line 39: statsd.socket.socket = self.old_socket
Line 40: 
Line 41: def setUp(self):
Line 42: self.mock_socket.reset_mock()
> You can use statsd.socket.reset_mock(), no need for self.
first of all we mock statsd.socket.socket , second, i don't understand what you 
suggest.. to remove self.mock_socket and above each test to add 
@MonkeyPatch(statsd.socket.socket, 'sendto', mock.Mock()) ? 

well, if yes, its totally uglier imo and, it doesn't work
Line 43: 
Line 44: def test_send_single(self):
Line 45: data = {'hello': 3}
Line 46: statsd.send(data)


-- 
To view, visit https://gerrit.ovirt.org/67004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbc8a4c0e3afc25c205bfec58c5e77096803404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-30 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding simple client for sending gauge metrics to statsd port 
using udp
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/67004/15/tests/statsd_tests.py
File tests/statsd_tests.py:

Line 24: 
Line 25: 
Line 26: class StatsdModuleTest(TestCaseBase):
Line 27: @classmethod
Line 28: def setup_class(self):
> Why do you need module level? what is wrong with monkeypatch per test?
I can't use self in the decorator
Line 29: self.old_socket = statsd.socket.socket
Line 30: self.mock_socket = statsd.socket.socket = mock.Mock()
Line 31: try:
Line 32: statsd.start('localhost')


-- 
To view, visit https://gerrit.ovirt.org/67004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbc8a4c0e3afc25c205bfec58c5e77096803404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-30 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding simple client for sending gauge metrics to statsd port 
using udp
..


Patch Set 15: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/67004/15/tests/statsd_tests.py
File tests/statsd_tests.py:

Line 24: 
Line 25: 
Line 26: class StatsdModuleTest(TestCaseBase):
Line 27: @classmethod
Line 28: def setup_class(self):
> Why are you reinventing monkeypatch.MonkeyPatch?
the test code looks good enough, no? monkeypatch doesn't fit here to the way I 
use the Mock(). 

I should do something like
 @MonkeyPatch(statsd.socket, 'sendto', self.mock_socket.sendto)

but then I need mock_socket to be in module level.
Line 29: self.old_socket = statsd.socket.socket
Line 30: self.mock_socket = statsd.socket.socket = mock.Mock()
Line 31: try:
Line 32: statsd.start('localhost')


-- 
To view, visit https://gerrit.ovirt.org/67004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbc8a4c0e3afc25c205bfec58c5e77096803404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 2: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 2:

Please limit this to the approved list of custom properties.

We agreed to accept openstack, vmfex, macspoof

-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-30 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding simple client for sending gauge metrics to statsd port 
using udp
..


Patch Set 14: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/67004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbc8a4c0e3afc25c205bfec58c5e77096803404
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Adding simple client for sending gauge metrics to statsd port 
using udp
..


Patch Set 14: Code-Review-1

(5 comments)

https://gerrit.ovirt.org/#/c/67004/11/tests/statsd_tests.py
File tests/statsd_tests.py:

Line 25: 
Line 26: class StatsdModuleTest(TestCaseBase):
Line 27: @classmethod
Line 28: def setup_class(self):
Line 29: try:
> You are depending on internal implementation detail of the module. If we ch
sending a specific bytestring through a specific wire IS the API of this 
module. That's how it interacts with the statsd server
Line 30: self.old_socket = statsd.socket.socket
Line 31: self.mock_socket = statsd.socket.socket = mock.Mock()
Line 32: statsd.start('localhost')
Line 33: self._address = ('127.0.0.1', 8125)


Line 32: statsd.start('localhost')
Line 33: self._address = ('127.0.0.1', 8125)
Line 34: finally:
Line 35: statsd.socket.socket = self.old_socket
Line 36: 
> This does not work, if setup fails, teardown is not called.
or, we can patch statsd.socket.socket at the very last line of setup_class so 
nothing can possibly fail it.
Line 37: @classmethod
Line 38: def teardown_class(self):
Line 39: statsd.socket.socket = self.old_socket
Line 40: 


Line 44: def test_send_single(self):
Line 45: data = {'hello': 3}
Line 46: statsd.send(data)
Line 47: self.mock_socket.return_value.sendto.assert_called_once_with(
Line 48: b'hello:3|g', self._address)
> Please avoid such constants, not all developers can read this and this even
BiDi is horrible, but there is nothing wrong in Czech, Hebrew or Chinese sample 
text. Lorem ipsum is not the only valid value.
Line 49: 
Line 50: def test_send_unicode(self):
Line 51: data = {'\xd7\xa9\xd7\x9c\xd7\x95\xd7\x9d': 3}
Line 52: statsd.send(data)


https://gerrit.ovirt.org/#/c/67004/14/tests/statsd_tests.py
File tests/statsd_tests.py:

Line 26: class StatsdModuleTest(TestCaseBase):
Line 27: @classmethod
Line 28: def setup_class(self):
Line 29: try:
Line 30: self.old_socket = statsd.socket.socket
this must sit before "try"
Line 31: self.mock_socket = statsd.socket.socket = mock.Mock()
Line 32: statsd.start('localhost')
Line 33: self._address = ('127.0.0.1', 8125)
Line 34: finally:


Line 31: self.mock_socket = statsd.socket.socket = mock.Mock()
Line 32: statsd.start('localhost')
Line 33: self._address = ('127.0.0.1', 8125)
Line 34: finally:
Line 35: statsd.socket.socket = self.old_socket
this must take place only during "except:"
Line 36: 
Line 37: @classmethod
Line 38: def teardown_class(self):
Line 39: statsd.socket.socket = self.old_socket


-- 
To view, visit https://gerrit.ovirt.org/67004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbc8a4c0e3afc25c205bfec58c5e77096803404
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-30 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding simple client for sending gauge metrics to statsd port 
using udp
..


Patch Set 11:

(3 comments)

https://gerrit.ovirt.org/#/c/67004/11/lib/vdsm/metrics/statsd.py
File lib/vdsm/metrics/statsd.py:

Line 52: fam = socket.AF_INET6 if ipv6 else socket.AF_INET
Line 53: family, _, _, _, addr = socket.getaddrinfo(
Line 54: host, port, fam, socket.SOCK_DGRAM)[0]
Line 55: self._addr = addr
Line 56: self._sock = socket.socket(family, socket.SOCK_DGRAM)
> You never close this socket.
adding that
Line 57: self._maxudpsize = maxudpsize
Line 58: 
Line 59: def _send(self, data):
Line 60: try:


Line 62: except socket.error:
Line 63: # Keeping python-statsd behavior - we intintially avoid to 
log
Line 64: # any socket error to allow running this code without 
reachable
Line 65: # server.
Line 66: pass
> Are are we going to debug this when you hide the errors like this?
nice logic that im not sure how it will effect. will consider it in later 
improvement
Line 67: 
Line 68: def gauge(self, stat, value):
Line 69: """
Line 70: Sending gauge report for specific metric in the format 
stat:value|g


https://gerrit.ovirt.org/#/c/67004/11/tests/statsd_tests.py
File tests/statsd_tests.py:

Line 25: 
Line 26: class StatsdModuleTest(TestCaseBase):
Line 27: @classmethod
Line 28: def setup_class(self):
Line 29: self.old_socket = statsd.socket.socket
> You are depending on internal implementation detail of the module. If we ch
isn't that good? this is the difference between unit test to functional. we 
test the internal implementation here to be as expected
Line 30: self.mock_socket = statsd.socket.socket = mock.Mock()
Line 31: statsd.start('localhost')
Line 32: self._address = ('127.0.0.1', 8125)
Line 33: 


-- 
To view, visit https://gerrit.ovirt.org/67004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbc8a4c0e3afc25c205bfec58c5e77096803404
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: python: change python scripts to python2

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: python: change python scripts to python2
..


python: change python scripts to python2

starting from fc25, python3 will be default, and
/usr/bin/python path will point to python3.
All interpreter paths in python scripts were changed
to python2.
This is a quick fix in order to ensure the scripts will
continue to run without errors.
All scripts should be py3 compatible in the future.

Signed-off-by: Irit Goihman 
Change-Id: Ie8eaefe5f7e0831c362546733a2fa9301b7f9ad6
---
M build-aux/vercmp
M contrib/refmt
M contrib/repoplot
M contrib/runvm
M init/daemonAdapter
M init/wait_for_ipv4s
M lib/vdsm/tool/dummybr.py
M lib/vdsm/tool/nwfilter.py
M tests/alignmentScanTests.py
M tests/hooksTests.py
M tests/tests_child.py
M vdsm-tool/vdsm-tool
M vdsm/get-conf-item
M vdsm/set-conf-item
M vdsm/storage/curl-img-wrap
M vdsm/storage/fc-scan
M vdsm/supervdsmServer
M vdsm/vdsm
M vdsm/vdsm-restore-net-config
M vdsm_hooks/checkimages/before_vm_start.py
M vdsm_hooks/checkips/checkips_utils.py
M vdsm_hooks/checkips/checkipsd
M vdsm_hooks/extnet/extnet_vnic.py
M vdsm_hooks/fakesriov/after_get_caps.py
M vdsm_hooks/fakesriov/after_hostdev_list_by_caps.py
M vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
M vdsm_hooks/faqemu/after_get_caps.py
M vdsm_hooks/faqemu/before_vm_start.py
M vdsm_hooks/floppy/before_vm_migrate_source.py
M vdsm_hooks/floppy/before_vm_start.py
M vdsm_hooks/hostusb/after_vm_destroy.py
M vdsm_hooks/hostusb/before_vm_migrate_source.py
M vdsm_hooks/hostusb/before_vm_start.py
M vdsm_hooks/httpsisoboot/before_vm_start.py
M vdsm_hooks/hugepages/after_vm_destroy.py
M vdsm_hooks/hugepages/before_vm_migrate_destination.py
M vdsm_hooks/hugepages/before_vm_start.py
M vdsm_hooks/ipv6/ipv6.py
M vdsm_hooks/isolatedprivatevlan/before_vm_start.py
M vdsm_hooks/macspoof/before_vm_start.py
M vdsm_hooks/nestedvt/before_vm_start.py
M vdsm_hooks/numa/before_vm_start.py
M vdsm_hooks/openstacknet/after_device_create.py
M vdsm_hooks/openstacknet/after_device_destroy.py
M vdsm_hooks/openstacknet/after_vm_start.py
M vdsm_hooks/openstacknet/before_device_create.py
M vdsm_hooks/openstacknet/before_device_migrate_destination.py
M vdsm_hooks/openstacknet/openstacknet_utils.py
M vdsm_hooks/ovs/ovs_after_get_caps.py
M vdsm_hooks/ovs/ovs_after_get_stats.py
M vdsm_hooks/ovs/ovs_after_network_setup.py
M vdsm_hooks/ovs/ovs_after_network_setup_fail.py
M vdsm_hooks/ovs/ovs_before_device_create.py
M vdsm_hooks/ovs/ovs_before_network_setup.py
M vdsm_hooks/pincpu/before_vm_start.py
M vdsm_hooks/promisc/after_vm_start.py
M vdsm_hooks/promisc/before_vm_destroy.py
M vdsm_hooks/qemucmdline/before_vm_start.py
M vdsm_hooks/qos/before_vm_start.py
M vdsm_hooks/scratchpad/after_vm_destroy.py
M vdsm_hooks/scratchpad/before_vm_migrate_source.py
M vdsm_hooks/scratchpad/before_vm_start.py
M vdsm_hooks/smbios/before_vm_start.py
M vdsm_hooks/spiceoptions/before_vm_start.py
M vdsm_hooks/vhostmd/after_vm_destroy.py
M vdsm_hooks/vhostmd/before_vm_start.py
M vdsm_hooks/vmdisk/before_vm_start.py
M vdsm_hooks/vmfex/before_vm_migrate_destination.py
M vdsm_hooks/vmfex/before_vm_start.py
M vdsm_hooks/vmfex_dev/vmfex_vnic.py
70 files changed, 70 insertions(+), 70 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/67502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8eaefe5f7e0831c362546733a2fa9301b7f9ad6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: python: change python scripts to python2

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: python: change python scripts to python2
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/67502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8eaefe5f7e0831c362546733a2fa9301b7f9ad6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: contrib: Simple jsonrpc client
..


contrib: Simple jsonrpc client

This is a simple generic client that does not know anything about the
available methods and parameters. The user should consult the schema to
construct request that makes sense. Future version should parse the
schema and provide online help.

Invoking simple methods:

# jsonrpc Host getVMList
['b3f6fa00-b315-4ad4-8108-f73da817b5c5']

Invoking methods with simple parameters::

# jsonrpc VM getStats vmID=b3f6fa00-b315-4ad4-8108-f73da817b5c5
...

For invokinng methods with many or complex parameters, you can read the
parameters from a file:

# jsonrpc StorageDomain activate -f sd-activate
...

where sd-activate file content is:
{
"storagedomainID": "75ab40e3-06b1-4a54-a825-2df7a40b93b2",
"storagepoolID": "b3f6fa00-b315-4ad4-8108-f73da817b5c5"
}

It is also possible to read parameters from standard input, creating
complex parameters interactively:

# jsonrpc StorageDomain activate -f -
{
"storagedomainID": "75ab40e3-06b1-4a54-a825-2df7a40b93b2",
"storagepoolID": "b3f6fa00-b315-4ad4-8108-f73da817b5c5"
}
(Press Ctrl + D to finish)

Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Signed-off-by: Nir Soffer 
Signed-off-by: pkliczewski 
Signed-off-by: Irit Goihman 
---
A contrib/jsonrpc
1 file changed, 169 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: python: change python scripts to python2

2016-11-30 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: python: change python scripts to python2
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/67502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8eaefe5f7e0831c362546733a2fa9301b7f9ad6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org