Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce network initializer module .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: network: add driverloader module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: add driverloader module .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 8: Verified+1 passes ost

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. Patch Set 5: ci please build -- To view,

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 8: ci please build -- To view, visit

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 8:

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/80327 ) Change subject: net: Introduce network initializer module .. Removed reviewer gerrit-hooks

Change in vdsm[master]: net tests func: Fix IPv4 default route assertion

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests func: Fix IPv4 default route assertion .. Patch Set 3: Code-Review+2 raising -- To view, visit

Change in vdsm[master]: move vdsm.config to common

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 8: passes ost http://jenkins.ovirt.org/job/ovirt-system-tests_manual/996/ --

Change in vdsm[master]: move vdsm.config to common

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/79980 To

Change in vdsm[master]: net tests func: Fix IPv4 default route assertion

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80777 ) Change subject: net tests func: Fix IPv4 default route assertion .. net tests func: Fix

Change in vdsm[master]: net tests: Setup a network marked with default route but no GW

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Setup a network marked with default route but no GW .. Patch Set 5: Code-Review-1 (1 comment)

Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm tool configurators: bond_defaults - do not depend on time .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80804 ) Change subject: net: place bonding defaults under /var/run .. net: place bonding defaults

Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80805 ) Change subject: vdsm tool configurators: bond_defaults - do not depend on time .. vdsm

Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: place bonding defaults under /var/run .. Patch Set 2: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report lldp through new getLldp command .. Patch Set 10: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Enable LLDP on NICs .. Patch Set 8: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/80192

Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Add info lldp to lldp .. Patch Set 8: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/80193

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. Patch Set 5: Code-Review+2 Verified+1

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80390 ) Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces ..

Change in vdsm[ovirt-4.1]: network: add driverloader module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80186 ) Change subject: network: add driverloader module .. network: add driverloader module

Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80193 ) Change subject: net: Add info lldp to lldp .. net: Add info lldp to lldp lldp is

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80327 ) Change subject: net: Introduce network initializer module .. net: Introduce network

Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80192 ) Change subject: net: Enable LLDP on NICs .. net: Enable LLDP on NICs lldpad has to be

Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80187 ) Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. net: Introduce

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80194 ) Change subject: net: Report lldp through new getLldp command .. net: Report lldp through

Change in vdsm[master]: move vdsm.config to common

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/79980/7/tests/config_test.py

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: vdsm.tool.service: unbreak tool.service .. vdsm.tool.service: unbreak tool.service In commit 53a2562 I have avoided

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm.tool.service: unbreak tool.service .. Patch Set 2: ci please build -- To view, visit

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm.tool.service: unbreak tool.service .. Patch Set 2: Verified+1 11:24:19 @ Run test: 002_bootstrap.py: 11:24:19

Change in vdsm[master]: tests: improve faking

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80756 ) Change subject: tests: improve faking .. tests: improve faking This patch avoids this

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm.tool.service: unbreak tool.service .. Patch Set 2:

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80908 ) Change subject: vdsm.tool.service: unbreak tool.service .. vdsm.tool.service: unbreak

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80212 ) Change subject: checkimages hook: avoid using execCmd(sync=False) .. checkimages hook:

Change in vdsm[master]: vhostuser: convert macAddr to string

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vhostuser: convert macAddr to string .. Patch Set 3: Code-Review-1 (1 comment)