Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 1:
All tests were made using 'Run Once'.
--
To view, visit http://gerrit.ovirt.org/22925
To
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 1: Code-Review-1
-1 because proper unit testing is still missing.
--
To view, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22923
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
I'd like to see a follow-up test about vmPayload as well...
Francesco Romani has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 9:
(2 comments)
I'm fine with the code once the dan's comment get addressed.
Francesco Romani has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 5:
(4 comments)
Commit
Francesco Romani has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
I'm fine with the code once existing comments get addressed. More tests are
needed in
Francesco Romani has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21963
To
Francesco Romani has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 9:
(2 comments)
File vdsm/vm.py
Line 1794:
Tomáš Došek has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2:
Improved the commit message.
--
To view, visit http://gerrit.ovirt.org/22925
To
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment)
Michal Skrivanek has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6528/ :
Francesco Romani has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
vdsm: prepareVolumePath payload misdetection fix
The changeset http://gerrit.ovirt.org/#/c/22324/3
used
Francesco Romani has abandoned this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/22935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2:
updated the commit message
--
To view, visit http://gerrit.ovirt.org/22923
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2: Verified+1
Verified the following, all on an is28 snapshot running on RHEL65 using Run
Once
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing python-cpopen requirement
..
Changing python-cpopen requirement
To allow replacing vdsm-python-cpopen, python-cpopen packages
provides new version
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing python-cpopen requirement
..
Patch Set 1: Verified-1
not available yet..
--
To view, visit http://gerrit.ovirt.org/22936
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing python-cpopen requirement
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6529/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22925
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment)
File
Vinzenz Feenstra has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22923
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2: Code-Review-1
(1 comment)
Commit Message
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22925
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 2: Verified+1
verified ok on my side
--
To view, visit http://gerrit.ovirt.org/22925
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
vdsm: prepareVolumePath payload misdetection fix
The changeset http://gerrit.ovirt.org/#/c/22324/3
Vinzenz Feenstra has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: storage replace/remove too generic except handlers
..
Patch Set 2:
(2 comments)
File
Francesco Romani has restored this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Restored
--
To view, visit http://gerrit.ovirt.org/22935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment)
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22935
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/22923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 1: Verified+1
Verified with same tests as for master
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
vdsm: prepareVolumePath payload misdetection fix
The changeset http://gerrit.ovirt.org/#/c/22324/3
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload misdetection fix
..
Patch Set 1: Code-Review+2
As needed here as in master.
--
To view, visit http://gerrit.ovirt.org/22935
Nir Soffer has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 7:
Build Successful
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment)
Adam Litke has posted comments on this change.
Change subject: Move fenceNode out of API.py
..
Patch Set 8: -Code-Review
--
To view, visit http://gerrit.ovirt.org/7191
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6532/ :
Nir Soffer has posted comments on this change.
Change subject: vdsm: storage replace/remove too generic except handlers
..
Patch Set 2:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6531/ :
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 3:
PatchSet 2: added unit tests, using just a bit of black magic.
PatchSet 3: removed
Nir Soffer has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Verified+1
Verified using jenkins:
Francesco Romani has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 4:
PatchSet 4: there is no real need for globals.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6533/ :
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 9:
(8 comments)
File vdsm/caps.py
Line 340:
Francesco Romani has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 10: Code-Review+1
(1 comment)
File vdsm/vm.py
Francesco Romani has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 9:
(1 comment)
File vdsm/vm.py
Line 982:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6534/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 4:
(10 comments)
The new method is clean and not tricky, and the tests are simple and clean. I
Nir Soffer has posted comments on this change.
Change subject: vdsm: prepareVolumePath payload detection cleanup
..
Patch Set 4:
(3 comments)
Some more comments about the tests.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18718
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtconnection: Fix a race when starting the eventloop
..
Patch Set 3: -Code-Review
The commit message needs updating. I of course prefer my suggested code
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: do not check permissions on dos filesystem
..
tests: do not check permissions on dos filesystem
commit 0b147dc2e247e787ad760ba30a8b8815eb65daca
62 matches
Mail list logo
