Yaniv Bronhaim has posted comments on this change.
Change subject: packaging: update python-cpopen requirement to 1.3
..
Patch Set 2:
please verify on that branch
--
To view, visit http://gerrit.ovirt.org/24874
To
Francesco Romani has posted comments on this change.
Change subject: vm: cleanup post-libvirt merge code
..
Patch Set 3: Verified+1
(1 comment)
marking as verified because:
* _monitorDependentInit seems never called from
Nir Soffer has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG
Commit Message:
Line 16: methods are used only on Python
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: recover must finish with libvirt connection
..
Patch Set 5:
no need for relates-to title. only one Bug-Url targeted to 3.3 (relates can be
shown in the
Francesco Romani has posted comments on this change.
Change subject: vm: recover must finish with libvirt connection
..
Patch Set 5:
Just cloned the 3.4 bz into https://bugzilla.redhat.com/1069095.
Will drop the relates-to.
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Disable needless and slow dns lookup
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24871
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24862
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: xmlrpc: Support HTTP 1.1
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG
Commit Message:
Line 16: methods are used only on Python
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: vm: cleanup post-libvirt merge code
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24744/3/vdsm/vm.py
File vdsm/vm.py:
Line 3714:
Francesco Romani has posted comments on this change.
Change subject: vm: cleanup post-libvirt merge code
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/24744/3/vdsm/vm.py
File vdsm/vm.py:
Line 3714: # we
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Use same constants for configuring and check configure of
sanlock
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6468/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixing ssl config validation
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/24500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Federico Simoncelli has posted comments on this change.
Change subject: vmDevices: add mechanism to persist vmDevice defaults
..
Patch Set 3: Code-Review+1
(1 comment)
I'd like to see _defaults being renamed.
Federico Simoncelli has posted comments on this change.
Change subject: vmDevices: introduce VmDeviceContainer
..
Patch Set 7: Code-Review-1
We probably want to squash this with http://gerrit.ovirt.org/#/c/21162/
--
To view,
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/24733/8/client/vdsClient.py
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8:
(1 comment)
why don't you use the parse function I provided to parse password with special
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/7/client/vdsClient.py
File
Francesco Romani has posted comments on this change.
Change subject: vmDevices: add mechanism to persist vmDevice defaults
..
Patch Set 3:
I agree with Federico's remark. +1 for me once the _defaults() name is improved.
--
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/6/tests/functional/virtTests.py
File
Federico Simoncelli has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22631
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 5:
(8 comments)
http://gerrit.ovirt.org/#/c/24603/5/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/24603
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: spice support to clipboard copypaste disable
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/22646/3/vdsm/vm.py
File
Federico Simoncelli has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21790
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8:
(3 comments)
no reason to keep reviewing this if you ignore the proper parsing of password.
Francesco Romani has posted comments on this change.
Change subject: vm: spice support to clipboard copypaste disable
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/22646/3/vdsm/vm.py
File vdsm/vm.py:
Line 1134:
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Disable needless and slow dns lookup
..
Patch Set 1: Code-Review+2
(3 comments)
http://gerrit.ovirt.org/#/c/24871/1//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20029
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/9/client/vdsClient.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6472/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: cleanup post-libvirt merge code
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6473/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: report migration progress in VmStats
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24465
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/9/client/vdsClient.py
File
Nir Soffer has posted comments on this change.
Change subject: xmlrpc: Disable needless and slow dns lookup
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24871/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: xmlrpc:
Itamar Heim has posted comments on this change.
Change subject: vdsm: export mininum kernel via caps
..
Patch Set 3:
ping?
--
To view, visit http://gerrit.ovirt.org/19792
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: lvm: refresh on mda permission mismatch
..
Patch Set 1:
ping?
--
To view, visit http://gerrit.ovirt.org/20121
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: More precise exception when multipath failed.
..
Patch Set 4:
ping?
--
To view, visit http://gerrit.ovirt.org/17145
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: vdsm: Get underlying device info moved to Device classes
..
Patch Set 2:
ping?
--
To view, visit http://gerrit.ovirt.org/19732
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: mount: Reassign mount specification in case of backup option
..
Patch Set 2:
ping?
--
To view, visit http://gerrit.ovirt.org/16534
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: Refactor StoragePool.getPoolParams()
..
Patch Set 4:
ping?
--
To view, visit http://gerrit.ovirt.org/19232
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: Avoid hsm image deletions.
..
Patch Set 4:
ping?
--
To view, visit http://gerrit.ovirt.org/17193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Itamar Heim has posted comments on this change.
Change subject: vdsm: Refactoring of retrieving device info from xml
..
Patch Set 7:
ping?
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: [WIP] Adding monitorDomains.
..
Patch Set 8:
ping?
--
To view, visit http://gerrit.ovirt.org/14674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Itamar Heim has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV
..
Patch Set 6:
ping?
--
To view, visit http://gerrit.ovirt.org/13363
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: gluster: geo replication status and status detail
..
Patch Set 2:
ping?
--
To view, visit http://gerrit.ovirt.org/18414
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: Refactoring of retrieving device info from xml
..
Patch Set 7: Code-Review+1
I like the idea.
--
To view, visit http://gerrit.ovirt.org/17694
To
Francesco Romani has posted comments on this change.
Change subject: vdsm: Refactoring of retrieving device info from xml
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/7/vdsm/vm.py
File vdsm/vm.py:
Line 2794:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: update python-cpopen requirement to 1.3
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24874
To unsubscribe,
Yeela Kaplan has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
..
Patch Set 7:
(3 comments)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 10:
completely untested, but attempting to reduce ping-pong, I wrote the
implementation I would
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 10: Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24603/7/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:
Line
Nir Soffer has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 8: Code-Review+1
Elegant
--
To view, visit http://gerrit.ovirt.org/24603
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6475/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6479/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6476/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] destroy storage pool using command type 1
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6477/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create storage pool using command type 1
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create storage domain using command type 1
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6480/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: destroy storage pool using command type 1
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6482/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/24603
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Towards a more (block) secure HSM.
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6483/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6484/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create storage domain using command type 1
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6485/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Create storage pool using command type 1
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 9: Code-Review+1
I liked that line but never mind.
--
To view, visit http://gerrit.ovirt.org/24603
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 10:
no, did not run anything, I just wanted to move us to closure track.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netlink: Introduce socket pool
..
netlink: Introduce socket pool
If a lot of netlink requests happened _nl_connect would fail at
the C level, more
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 9: Code-Review+2
I liked that line but never mind.
;-)
--
To view, visit http://gerrit.ovirt.org/24603
To
Saggi Mizrahi has posted comments on this change.
Change subject: Schema: Typemap changes
..
Patch Set 1: Code-Review-2
Since we no longer do code generation I think we need to wait until after we
get past the discussion on
Douglas Schilling Landgraf has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 10:
Toni, did you send it to 3.4 branch too?
--
To view, visit http://gerrit.ovirt.org/24603
To
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Disable needless and slow dns lookup
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24871/1//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: update python-cpopen requirement to 1.3
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24874
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_scale: Don't instantiate NetInfo needlessly
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6488/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_scale: Allow NetInfo update just the devices
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6487/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_scale: Allow NetInfo update just the devices
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6489/ :
Itamar Heim has posted comments on this change.
Change subject: vdsm: add support for multiple iSCSI interfaces
..
Patch Set 1:
ping? still relevnat?
--
To view, visit http://gerrit.ovirt.org/20981
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 10:
(4 comments)
http://gerrit.ovirt.org/#/c/24733/10/client/vdsClient.py
File
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: packaging: update python-cpopen requirement to 1.3
..
packaging: update python-cpopen requirement to 1.3
update both dependencies and build
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: recover must finish with libvirt connection
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24822
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: recover must finish with libvirt connection
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/24822
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: update python-cpopen requirement to 1.3
..
Patch Set 2:
Build Successful
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: recover must finish with libvirt connection
..
Patch Set 7: -Verified
--
To view, visit http://gerrit.ovirt.org/24822
To unsubscribe, visit
86 matches
Mail list logo
