Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 5: Code-Review-1
(5 comments)
http://gerrit.ovirt.org/#/c/31301/5//COMMIT_MSG
Commit Message:
Line 11:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 2: Code-Review-1
also the rest of the files under tool folder document the code in the same
style,
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34046/1//COMMIT_MSG
Commit Message:
Line 7: tool: change enumeration
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2: Code-Review+1
(1 comment)
hard to find mistakes. it looks good to me
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: configurators package should only contain configurators.
..
Patch Set 2:
odd.. it was under vdsm/tool/ , we just installed it wrongly under libvirt.. im
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: configurators package should only contain configurators.
..
Patch Set 2:
under configurators i meant..
--
To view, visit http://gerrit.ovirt.org/34048
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: configurator module names optional, defaults to file name.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34099
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: autoload modules.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34049/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 14: Code-Review+1
I don't have strong feelings about your argument . I agree with the patch as is
--
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: change persistFile to persist
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34073/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Ido Barkan has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 1: Verified+1
(8 comments)
Ido Barkan has posted comments on this change.
Change subject: make isVDSMInterface and it's helpers static
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34139
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 2:
Pep8 is still unhappy.
--
To view, visit http://gerrit.ovirt.org/34114
To
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: remove AUTHOR from vdsm-tool manual page.
..
tool: remove AUTHOR from vdsm-tool manual page.
lists authors of the documentation or program. Use
Yaniv Bronhaim has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34215
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: nwfilter: Do not attempt to re-define the nwfilter when not
undefining
..
nwfilter: Do not attempt to re-define the nwfilter when not undefining
Yaniv Bronhaim has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 1:
can't merge. please rebase
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: remove AUTHOR from vdsm-tool manual page.
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: nwfilter: Do not attempt to re-define the nwfilter when not
undefining
..
Patch Set 2:
Build Failed
Ido Barkan has posted comments on this change.
Change subject: refactor StaticSourceRoute for better testability
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/34067/4/tests/functional/networkTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: refactor StaticSourceRoute for better testability
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12986/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: make isVDSMInterface and it's helpers static
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12987/ :
Nir Soffer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2: Code-Review-1
(22 comments)
I don't we need this change, as it does not help anyone, and does
Shahar Havivi has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 5:
(2 comments)
No need to -1 yet..., this is still marked as draft ;)
Shahar Havivi has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/33309/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 96:
Line 97: auth =
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 3:
Build Failed
mooli tayer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/31301/5/lib/vdsm/infra/zombiereaper/Makefile.am
File
Shahar Havivi has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 4:
(10 comments)
http://gerrit.ovirt.org/#/c/33309/4//COMMIT_MSG
Commit Message:
Line 7: PATCH: external VMs
mooli tayer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File
mooli tayer has posted comments on this change.
Change subject: tool: configurators package should only contain configurators.
..
Patch Set 2:
@Yaniv: I do not understand...
--
To view, visit http://gerrit.ovirt.org/34048
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12989/ :
mooli tayer has posted comments on this change.
Change subject: tool: autoload modules.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34049/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line
Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34045/3/lib/vdsm/tool/configurators/__init__.py
File
mooli tayer has posted comments on this change.
Change subject: tool: change configure verb logic.
..
Patch Set 1:
(1 comment)
@Nir I believe this bug can manifest
(for example : 'vdsm-tool --module= certificates' should
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12990/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12991/ : SUCCESS
Dima Kuznetsov has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 14: Verified+1
Verified by adding vdsm to engine, adding nfs storage domain and de/activating
a few
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 16: Verified+1
Verified by adding vdsm to engine, adding nfs storage domain and de/activating
a few
mooli tayer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurator.py
File
Saggi Mizrahi has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 14:
(1 comment)
http://gerrit.ovirt.org/#/c/29392/14/tests/sigutilsTests.py
File
mooli tayer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 14:
(1 comment)
http://gerrit.ovirt.org/#/c/29392/14/tests/sigutilsTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12992/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 17: Verified+1
Change only in tests code of parent patch, see comment there.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/31301/6/vdsm.spec.in
File vdsm.spec.in:
Line 320: %description
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6: Verified+1
Tested on rhel 6.6 and 7.
--
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe,
Dima Kuznetsov has posted comments on this change.
Change subject: protocolDetector: Remove unneeded poll flags
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33912
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 17:
Change only in tests code of parent patch
Dima, I fail to follow. Why did you drop the approved
Nir Soffer has uploaded a new change for review.
Change subject: hba: Rescan using SCSI layer
..
hba: Rescan using SCSI layer
Commit 66c24c1996 (iscsi: Iscsi rescan cleanup) was little too deep,
disabling rescanning of HBAs.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12995/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 1:
I did not test it yet with FC server where I can add devices, so I don't know
if this will actually work, or we will
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
Version 2 adds scsi_minimal_timeout delay after scanning, so multipath can
discover new devices.
This is horrible
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12996/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: multiapth: Disable hba rescanning by default
..
Patch Set 1:
If http://gerrit.ovirt.org/34245 works, it can replace this one.
--
To view, visit
61 matches
Mail list logo
