Francesco Romani has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 1: Code-Review+1
I want to avoid nasty surprises in the future, when is_attached_to could be
exte
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 21:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Set MODIFIED::bug 1134256#113
Nir Soffer has submitted this change and it was merged.
Change subject: vm: check operation result for vm nic hotunplug
..
vm: check operation result for vm nic hotunplug
After detaching a device we need to verify that this dev
Francesco Romani has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 20: Code-Review+2
I see Marcin posted https://gerrit.ovirt.org/#/c/49554/1. I'd be happier with a
Francesco Romani has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 1: Code-Review+1
waiting for more reviews from HE devs
--
To view, visit https://gerrit.ovirt.org
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 175:
Francesco Romani has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 1: Code-Review+1
waiting for more reviews from HE devs
--
To view, visit https://gerrit.ovirt.org/49597
Francesco Romani has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1:
waiting for more reviews from HE devs
--
To view, visit https://gerrit.ovirt.org/49596
To un
Francesco Romani has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49596
To unsubscribe, visit https://
Ido Barkan has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/49198/12/vdsm.spec.in
File vdsm.spec.in:
Line 1098: %{python_sitelib}/%{vdsm_n
gerrit-hooks has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 1:
* #1255114::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1255114::OK, public bug
* Check
Hello Piotr Kliczewski, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49607
to review the following change.
Change subject: spec: remove leftover directories on host
..
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49570/1/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 169:
gerrit-hooks has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 3:
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1279431#1279431OK
--
To view, visit https://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: daemon: keep running without affinity.
..
daemon: keep running without affinity.
The cpu affinity is one (important) performance setting,
but Vdsm shou
gerrit-hooks has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https
gerrit-hooks has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 12:
* #1286462::Update tracker: OK
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1286462#12
Dan Kenigsberg has submitted this change and it was merged.
Change subject: daemon: reformat __set_cpu_affinity
..
daemon: reformat __set_cpu_affinity
Reformat the code to use the 'early return' idiom.
No intended changes in fu
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: daemon: autodetect online cpus for affinity
..
lib: daemon: autodetect online cpus for affinity
In commit a1d4e23 we enabled by default the cpu af
Nir Soffer has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2: Code-Review+2
(search query works)
--
To view, visit https://gerrit.ovirt.org/49562
To unsubscribe, visit h
Nir Soffer has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2: Code-Review-1
(testing my search query)
--
To view, visit https://gerrit.ovirt.org/49562
To unsubscribe, vi
Ido Barkan has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 2:
(1 comment)
Alona, can you please confirm the engine exception?
https://gerrit.ovirt.org/#/c/49580/2//COMM
Ido Barkan has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py
File tests/modprobe.py:
Line 38:
Ido Barkan has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://g
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie
..
Patch Set 35:
This patch has been obsoleted by https://gerrit.ovirt.org/49257. GA releases
are easier
Sandro Bonazzola has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1: Code-Review+1
CI failed on FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo) which doesn't
David Caro has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 14:
@yaniv: This now is able to run the tests, but the tests are failing with:
ERROR:
gerrit-hooks has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has posted comments on this change.
Change subject: Include vmfex-dev-hook in vdsm install
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49566/2/vdsm.spec.in
File vdsm.spec.in:
Line 256
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: remove files properly on the node
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49575
To unsubscribe, visit https://gerrit.ov
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: remove files properly on the node
..
Patch Set 1: Continuous-Integration+1
unrelated failure:
14:47:24 FAIL: testFakeNics (netinfoTests.TestNetinfo)
14:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py
File tests/modprobe.
Nir Soffer has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 2:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/49561
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/49562
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 11:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/49402
To unsubscribe, visit https://g
Nir Soffer has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1: Verified+1
Tested together with other patches on setup with 2 hosts, did several storage
and virt f
Nir Soffer has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 1: Verified+1
Tested together with other patches on setup with 2 hosts, did several storage
and virt flo
Nir Soffer has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 1: Verified+1
Tested together with other patches on setup with 2 hosts, did several storage
and virt flows.
-
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 20:
Francesco, can you approve this?
I don't think we need the change your requested, but we have a an
gerrit-hooks has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 13:
* #1134256::Update tracker: OK
* Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classificat
Nir Soffer has submitted this change and it was merged.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
vm: unit test for vm._waitForDriveRemoval
Added unit tests for vm._waitForDriveRemoval, in
preparation to make
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 12: Code-Review+2
Thanks Marcin!
--
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit htt
Marcin Mirecki has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerr
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovi
Marcin Mirecki has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit https://gerrit
Marcin Mirecki has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1: Continuous-Integration+1
Test failure is not relevant:
17:32:47 FAIL: testEnablePromisc (ipwrapperTe
Shahar Havivi has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 175:
gerrit-hooks has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 1:
* #1282187::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1282187::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 1:
* #1269768::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269768::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1:
* #1269768::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269768::OK, public bug
*
Hello Adam Litke, Sandro Bonazzola, Martin Sivák, Roy Golan, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49596
to review the following change.
Change subject: monitor: Do not release host id during shutdown
...
Hello Adam Litke, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49597
to review the following change.
Change subject: sp: Allow attaching of monitored domain
..
sp: Allow attachin
Hello Adam Litke, Yaniv Bronhaim, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49598
to review the following change.
Change subject: hsm: Prevent stop monitoring of a pool domain
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 2:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Nir Soffer has posted comments on this change.
Change subject: schema: introduce HostJobs basic types
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49450/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.jso
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 175:
Dan Kenigsberg has posted comments on this change.
Change subject: automation: Eliminate unneeded variables
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49283
To unsubscribe, visit https://gerrit.ov
gerrit-hooks has posted comments on this change.
Change subject: automation: Eliminate unneeded variables
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: Eliminate unneeded variables
..
automation: Eliminate unneeded variables
There is no point in variables which are used once and are not exp
Sagi Shnaidman has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.o
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
(2 comments)
Looks nice to me. Just docstrings are missing and see my comments on tests.
https://gerrit.ovirt.org/#/
gerrit-hooks has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit https://ger
Oved Ourfali has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2:
the test issue is with:
14:51:28 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo)
14:51:28 -
Oved Ourfali has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit https://ge
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple initial tags when creating an LV
..
Patch Set 6: Code-Review-1
(2 comments)
Partial review.
https://gerrit.ovirt.org/#/c/44051/6/vdsm/storage/
Sagi Shnaidman has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.
gerrit-hooks has posted comments on this change.
Change subject: Always propagate bonding mode to engine
..
Patch Set 1:
* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Pr
Sagi Shnaidman has uploaded a new change for review.
Change subject: Always propagate bonding mode to engine
..
Always propagate bonding mode to engine
Now the mode is not propagated if it's not equal to 0 (default)
although eng
Edward Haas has uploaded a new change for review.
Change subject: net: Compare kernel vs running bond config opt vals
..
net: Compare kernel vs running bond config opt vals
Comparing between the bond running config and the
bond
gerrit-hooks has posted comments on this change.
Change subject: net: Compare kernel vs running bond config opt vals
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Sivák has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49387/5/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Lin
gerrit-hooks has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 4:
* #1269768::Update tracker: OK
* Set MODIFIED::bug 1269768#1269768IGNORE, not all related
Nir Soffer has submitted this change and it was merged.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
hsm: Prevent stop monitoring of a pool domain
When hosted engine agent is entering local maintenance, it m
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Allow attaching of monitored domain
..
sp: Allow attaching of monitored domain
When attaching a storage domain to the pool, the storage domain may be
a
gerrit-hooks has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 6:
* #1269768::Update tracker: OK
* Set MODIFIED::bug 1269768#1269768OK
--
To view, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 6:
* #1282187::Update tracker: OK
* Set MODIFIED::bug 1282187#1282187FAILED, illegal change fro
Nir Soffer has submitted this change and it was merged.
Change subject: monitor: Do not release host id during shutdown
..
monitor: Do not release host id during shutdown
When shutting down, all domain monitors are stopped and
Nir Soffer has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 3:
I discussed this with Dan, and we agreed to take this is the best solution.
--
To view, visit http
Adam Litke has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
Thanks Michal and Arik.
@Nir/Francesco - can we move forward with this then?
--
To view, visit https:
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: remove files properly on the node
..
Patch Set 1:
* #1283628::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283628::OK, public bug
* Check P
Sagi Shnaidman has uploaded a new change for review.
Change subject: ifcfg: remove files properly on the node
..
ifcfg: remove files properly on the node
Since change-id I02ae28c345 we are always persisting ifcfg files on the
no
Dan Kenigsberg has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 12: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49198/12/vdsm.spec.in
File vdsm.spec.in:
Line 1098: %{python
gerrit-hooks has posted comments on this change.
Change subject: guestagent: Use %r for logging message
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Dan Kenigsberg has posted comments on this change.
Change subject: guestagent: Use %r for logging message
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49340
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: guestagent: Add missing log on disconnect
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: guestagent: Rename connect() to start()
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: guestagent: Add missing log on disconnect
..
guestagent: Add missing log on disconnect
Add debug log when detecting a disconnect after empty read. This
Dan Kenigsberg has posted comments on this change.
Change subject: guestagent: Use %r for logging message
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/49340
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: guestagent: Rename connect() to start()
..
guestagent: Rename connect() to start()
GuestAgent was started by invoking connect() and stopped by invoking
Dan Kenigsberg has submitted this change and it was merged.
Change subject: guestagent: Use %r for logging message
..
guestagent: Use %r for logging message
A message is a json object with a newline - logging it will create an
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49557
To unsubscri
Shahar Havivi has abandoned this change.
Change subject: v2v: add try/except to get_external_vms
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/49557
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mes
Nir Soffer has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44566/7/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Line 50
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
* #1287066::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287066::OK, public bug
* Check
1 - 100 of 175 matches
Mail list logo