Milan Zamazal has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49675
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 12:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 2:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 16:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
Nir Soffer has submitted this change and it was merged.
Change subject: vm: add test for nic unplug wait
..
vm: add test for nic unplug wait
Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Signed-off-by: Marcin Mirecki
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 13:
* #1134256::Update tracker: OK
* Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classification but
Arik Hadas has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2: Code-Review+1
yeah, if memory snapshot is not taken along with disk snapshots, as it seems to
be the
Nir Soffer has posted comments on this change.
Change subject: Remove koji build flag and use specific one for vhostmd
..
Patch Set 2: Code-Review+1
(3 comments)
I like this very much.
Waiting for Pitor approval.
Francesco Romani has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 14: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py
File vdsm/v2v.py:
Line
Nir Soffer has posted comments on this change.
Change subject: virt: Correct VM state before vm.cont() in _recover()
..
Patch Set 2:
I would like another review from virt developer.
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 154:
Martin Polednik has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1: Code-Review+1
Great effort, I'm ok with Dan's comments added in later patches.
--
To view,
Martin Polednik has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 4:
Ping? Lookign at brew, ceph-common is still not available.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: debuging: Use __repr__ instead of __str__
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: debuging: Use __repr__ instead of __str__
..
debuging: Use __repr__ instead of __str__
Recently we are implementing __str__ for objects, for improved
Dan Kenigsberg has posted comments on this change.
Change subject: debuging: Use __repr__ instead of __str__
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48865
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 5: Code-Review+1
I'm not fan of adding translation layers. That being said, I don't like the
Francesco Romani has posted comments on this change.
Change subject: vm: always return bond mode in Host.getCapabilities
..
Patch Set 1: Code-Review-1
(2 comments)
a question inside
Shahar Havivi has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 154:
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 23:
This version fix bad name __putMetadata -> _putMetadata and add the missing
redirection tests.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 23:
This version moves up the recorded _putMetadata to match the actual class that
implements it.
--
To view,
Martin Polednik has abandoned this change.
Change subject: virt: un-memoize getNumaTopology
..
Abandoned
Even libvirt has problems and will not correctly detect NUMA topology changes
without restart. Abandoning before more
gerrit-hooks has posted comments on this change.
Change subject: virt: un-memoize getNumaTopology
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/48006
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: guestagent: Add note about unneeded encoding
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: guestagent: Add note about unneeded encoding
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49338
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: guestagent: Send complete messages
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: guestagent: Send complete messages
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49339
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: guestagent: Send complete messages
..
guestagent: Send complete messages
When forwarding message to the guest agent, we used socket.send(), which
may
gerrit-hooks has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 2: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
gerrit-hooks has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2:
* #1279431::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279431::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 25:
This version fixes the broken calls to __putMetadata that was renamed to
_putMetadata in this patch.
--
To
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Shahar Havivi has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 3: Code-Review-1
no need to review
--
To view, visit https://gerrit.ovirt.org/49505
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 4: Code-Review-1
(1 comment)
thanks, almost there, but exception() is not yet used correctly.
Martin Polednik has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49140
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: guestagent: Add note about unneeded encoding
..
guestagent: Add note about unneeded encoding
In Python 2, the output of json.dumps() is always a str
gerrit-hooks has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 2:
* #1286462::Update tracker: OK
* #1279431::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has uploaded a new change for review.
Change subject: DONTMERGE virt: use "run_async" helper
..
DONTMERGE virt: use "run_async" helper
Quick hack demo to see how it will look when we use run_async
to throttle
gerrit-hooks has posted comments on this change.
Change subject: DONTMERGE virt: use "run_async" helper
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Shahar Havivi has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 154:
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has posted comments on this change.
Change subject: vm: fix misleading XML log
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49139
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3:
(2 comments)
part of Milan's comment was unanswered, and I'm reposting it :)
Besides that, looks
gerrit-hooks has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 1:
* #1279431::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279431::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 12: Verified+1
Verified that the new tests succeeds after rebase.
--
To view, visit https://gerrit.ovirt.org/49104
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has uploaded a new change for review.
Change subject: net: publicise misc._visible_devs
..
net: publicise misc._visible_devs
It is used in many netinfo submodules
Change-Id: Ia836988f57aecb817f67655f2e33cd94dd3031d2
Ido Barkan has uploaded a new change for review.
Change subject: net: consolidate nics.py naming
..
net: consolidate nics.py naming
the functions names are noe relative to the module name (e.g
nics.speed instead of
gerrit-hooks has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Ido Barkan has uploaded a new change for review.
Change subject: net: consolidate nics.py naming
..
net: consolidate nics.py naming
Change-Id: I807c9c4a78e0e9e02fb034987c8667d76f42fbad
Signed-off-by: Ido Barkan
gerrit-hooks has posted comments on this change.
Change subject: net: move tc library under lib/vdsm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has uploaded a new change for review.
Change subject: net: consolidate bondings.py naming
..
net: consolidate bondings.py naming
This is only a partial change. More cleanup needs to be done soon after
gerrit-hooks has posted comments on this change.
Change subject: net: publicise misc._visible_devs
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has uploaded a new change for review.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
Those 2 constants were the same. only
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bondings.py naming
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bridges.py names
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Send complete messages
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49339
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: debuging: Use __repr__ instead of __str__
..
Patch Set 1: Verified+1
Verfied using setup with host and one vm.
Most changes are related to the executor, here is
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Add note about unneeded encoding
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49338
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49535/2//COMMIT_MSG
Commit Message:
Line 11:
Line 12: Hence,
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
..
Patch Set 3:
ping
--
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 647: if
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2: Code-Review-1
I think the corresponding master patch is actually
https://gerrit.ovirt.org/49507. Not
Allon Mureinik has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49598
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 1: -Code-Review
Francosco, lets get more opinions on this.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2: Code-Review+1
Waiting for Pitor approval.
--
To view, visit https://gerrit.ovirt.org/49060
To
Nir Soffer has submitted this change and it was merged.
Change subject: vm: move device attached check to device itself
..
vm: move device attached check to device itself
Moving the check for being attached to the device in
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 17:
* #1134256::Update tracker: OK
* Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt
Dan Kenigsberg has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49198
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: guestagent: Send complete messages
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/49339
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: guestagent: Add note about unneeded encoding
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49338
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: guestagent: Send complete messages
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49339
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49596
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: move network library under lib/vdsm
..
Patch Set 9: Code-Review-1
(1 comment)
09:03:03 ERROR: Failure: ImportError (cannot import name getDeviceByIP)
Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 657:
Nir Soffer has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 2:
Francesco, what is wrong with:
>>> Device()._xpath
Traceback (most recent call last):
File "",
Ido Barkan has uploaded a new change for review.
Change subject: net: move qos reporting to netinfo
..
net: move qos reporting to netinfo
Up until now, qos reporting was part of caps.py, which lies in an
upper layer then
gerrit-hooks has posted comments on this change.
Change subject: net: move qos reporting to netinfo
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has uploaded a new change for review.
Change subject: net: consolidate bridges.py names
..
net: consolidate bridges.py names
Functions names became relative to the module
Change-Id:
Ido Barkan has uploaded a new change for review.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
net: privatize IFCFG_ZERO_SUFFIXED
Only used inside netinfo.misc
Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
gerrit-hooks has posted comments on this change.
Change subject: net: move network library under lib/vdsm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ido Barkan has uploaded a new change for review.
Change subject: net: remove unused constant
..
net: remove unused constant
Change-Id: I516607327f42fc66314ddd827adcbb67ab0b9194
Signed-off-by: Ido Barkan
---
1 - 100 of 331 matches
Mail list logo