Change in vdsm[master]: jobs: Take lock once when deleting a job

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: jobs: Take lock once when deleting a job
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: jobs: Add Job.__repr__ for easier debugging
..


Patch Set 3: Code-Review+1

Not +2 because I am unsure if we need the ProgressingJob class.

-- 
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getImageVolumes
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Set status when creating a job

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: tests: Set status when creating a job
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd393a501860c773ea0c25391a56f22b3b22df7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move refreshVolume

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: move refreshVolume
..


Patch Set 23: Verified+1

Using unit tests

-- 
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: volume share utilities

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: volume share utilities
..


Patch Set 23: Verified+1

Using unit tests

-- 
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c7aaf4a8a8b8bce18331c0a55ba533192777f7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: move newVolumeLease
..


Patch Set 24: Verified+1

Using unit tests

-- 
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Replace validation method with a property

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: jobs: Replace validation method with a property
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23facf952529f3e811c9e179af25cfe39b2db0fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: startup: Change system default encoding to utf8

2016-01-04 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: startup: Change system default encoding to utf8
..


startup: Change system default encoding to utf8

In Python 2, the system default encoding is 'ascii'. This causes mixing
of unicode and non-ascii strings (e.g. utf8 encoded) to fail with
UnicodeDecodeError or UnicodeEncodeError. The trigger for this failures
is starting using the built-in json library, that returns all values as
unicode strings, even if the value is ascii.

For example:

>>> u'ascii' + '\xd7\x90'
Traceback (most recent call last):
  File "", line 1, in 
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd7 in position 0:
ordinal not in range(128)

Python tries to decode the second value implicitly, and fails since this
is a utf8 encoded string.

To avoid such issues, the entire application must be changed to use only
strings or only unicode internally, and never mix these types.  In the
distant future, when we run on Python 3, this will be true. For now, the
only way to prevent these issues systematically is to change the system
default encoding to 'utf8'.

Changing the default encoding is done with sys.setdefaultencoding(), but
this function exists only during startup, and can be called only from
sitecustomize module.

We keep now sitecustomize.py module, and change PYTHONPATH so it will be
loaded on startup.

This change is not needed in Python 3 since the default encoding is
already utf8, and Python does not do any implicit decoding or encoding
when mixing 'str' and 'bytes' types.

Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Bug-Url: https://bugzilla.redhat.com/1281940
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/48661
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Francesco Romani 
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/51273
---
M debian/vdsm.install
M init/daemonAdapter
M tests/Makefile.am
A tests/unicode_test.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/sitecustomize.py
7 files changed, 84 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-04 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: mtu should be reported as a string through caps
..


Patch Set 5: Code-Review+2

Let us unbreak master first.

-- 
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 1:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: keep README on wiki

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: keep README on wiki
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: keep README on wiki

2016-01-04 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: ovs: keep README on wiki
..


hooks: ovs: keep README on wiki

Keeping OVS README on wiki would give the hook more visibility and
it will be easier to edit it.

Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/51294
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M vdsm_hooks/ovs/README
1 file changed, 1 insertion(+), 112 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: keep README on wiki

2016-01-04 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: keep README on wiki
..


Patch Set 2: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: keep README on wiki

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: keep README on wiki
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: keep README on wiki

2016-01-04 Thread phoracek 
Petr Horáček has uploaded a new change for review.

Change subject: hooks: ovs: keep README on wiki
..

hooks: ovs: keep README on wiki

Keeping OVS README on wiki would give the hook more visibility and
easier editation.

Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Signed-off-by: Petr Horáček 
---
M vdsm_hooks/ovs/README
1 file changed, 1 insertion(+), 112 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/51294/1

diff --git a/vdsm_hooks/ovs/README b/vdsm_hooks/ovs/README
index 9899330..b583dcf 100644
--- a/vdsm_hooks/ovs/README
+++ b/vdsm_hooks/ovs/README
@@ -1,115 +1,4 @@
 Open vSwitch VDSM hook
 ==
 
-This hook enables us to create selected networks and bonds as Open vSwitch
-devices.
-
-
-Warning

-
-This hook is not yet ready to be used in real environment. It passes some VDSM
-networks tests, but it is not able to run with oVirt Engine as a native Linux
-networking replacement. See TODO below.
-
-
-Installation
-
-
-In case of missing openvswitch package in repositories, you might install the
-package manualy.
-
-Install vdsm-hook-ovs package on a host:
-yum install vdsm-hook-ovs
-
-Configure engine for hook's custom network properties:
-PROPERTIES='ovs=.*'
-engine-config -s "UserDefinedNetworkCustomProperties=$PROPERTIES" --cver='3.5'
-systemctl restart ovirt-engine
-
-Don't forget to include the names of other custom network properties you may
-want to use, such as 'ethtool_opts'.
-
-
-Usage
--
-
-Setup network:
-In the oVirt UI open the 'Setup Host Networks' dialog. Proceed to editing
-a desired logical network's properties. Among them you will find 'ovs', set
-it to 'true' or '1' to mark is as OVS Network.
-
-Setup bonding:
-In the oVirt UI open the 'Setup Host Networks' dialog. Merge two networks.
-In opened 'Create New Bond' dialog select 'Bonding Mode' 'Custom' and set
-it to 'ovs=True'.
-
-
-Limitations

-
-- Only one untagged network
-- STP only on untagged network
-- All networks are bridged
-- Tested only with ifcfg configurator. OVS rollback probably won't be working
-  with iproute2 or pyroute2 configurators
-
-
-TODO
-
-
-- Faster rollback:
-  + Now in case of a rollback, we remove all OVS networks and bonds and then
-recreate them. This could be improved with changing just what have to
-be changed as we do in iproute2 rollback.
-- Implement QoS:
-  + Linux HFSC QoS is supported by OVS and could be set up via ovs-vsctl
-as described here: [1]
-- Implement 'multicast_router' and 'multicast_snooping':
-  + This feature is not supported by openvswitch until 2.4.0
-  + We need to be able to set and get those values. It should be possible
-via 'mcast_snooping_enable' records, described here [1]
-- Implement implicitBonding
-- Defined multiple OVS Bridge instances:
-  + Now custom network property 'ovs' is passing only True, we could change it
-to pass an integer and then create OVS network under 'ovsbr$INT'
-OVS Bridge instance.
-- Fix networkTestsOVS.py dependencies:  # TO BE CHECKED
-  + It is possible that this test fail would cause problems when
-vdsm-hook-ovs package is installed without vdsm-tests.
-- Better OVS command logging:
-  + Now we log created OVS command as one long string. It would be nice to
-split commands with new lines and add 'comment' about what was done with
-certain sub-command.
-- Allow non-OVS=>OVS and OVS=>non-OVS changes:
-  + Now we do not handle the situation when OVS network is changed into
-non-OVS and vice versa.
-  + non-OVS=>OVS editation should be easy, we could handle it within
-a before_network_setup hook.
-  + OVS=>non-OVS editation is harder, while we have to first remove non-OVS
-network and then create OVS network after_network_setup.
-- Better handling of traceback and logging:
-  + We need more logging.
-  + Traceback sometimes provides hooking mess, but not an initial error.
-- Network persistence:
-  + An easy way would be to remove all OVS networks on startup (as we do in
-rollback) and then let persistence restoration to recreate it all.
-- Bond does not turn UP:  # TO BE CHECKED
-  + When we create OVS Bond and attach real NICs to it, it does not turn UP,
-even after `ip link set ovsbond up`
-  + Check if it OK or a BUG.
-- Call `sysctl enable openvswitch` on hook installation
-- Report bridge options (like netinfo._bridge_options):
-  + We need to report at least some of bridge options. It is not possible to
-read them the same way as with native Linux bridges.
-- Implement ports:
-  + We should report NICs and VM nets attached to bridge/network in caps.
-- Move needed VDSM non-libraries to vdsm/lib:
-  + Now we use hacky sys.path.append('/usr/share/vdsm') to access some VDSM
-modules. They should be moved to vdsm/lib.
-- When we configure dhclient over a network and then setup fails, dhclient
-

Change in vdsm[master]: build: update libvirt dependency for fedora

2016-01-04 Thread frolland 
Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/51295

to review the following change.

Change subject: build: update libvirt dependency for fedora
..

build: update libvirt dependency for fedora

Require a libvirt version that fixes the problem of reporting
physical=0 for COW2 volumes on block storage on Fedora. The given
version 1.1.2.18.1 exists in Fedora 23 and fixes the issue.

See Fedora BZ: https://bugzilla.redhat.com/1253754

Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Bug-Url: https://bugzilla.redhat.com/1253756
Signed-off-by: Fred Rolland 
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/51295/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 97bdfd2..c53fee8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -150,14 +150,14 @@
 %endif # centos
 %endif # rhel
 
-%if 0%{?fedora} >= 22
+%if 0%{?fedora} == 22
 Requires: libvirt-daemon >= 1.2.13
 Requires: libvirt-python >= 1.2.9-2
 %endif
 
-%if 0%{?fedora}
-Requires: libvirt-daemon >= 1.2.9.3-1
-Requires: libvirt-python >= 1.2.9-2
+%if 0%{?fedora} >= 23
+Requires: libvirt-daemon >= 1.2.18.1-1
+Requires: libvirt-python >= 1.2.18.1-1
 %endif
 
 Requires: libvirt-lock-sanlock, libvirt-client


-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: mtu should be reported as a string through caps

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: net: mtu should be reported as a string through caps
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread ishaby 
Idan Shaby has posted comments on this change.

Change subject: fileSD: Do not try to remove non-existent lease file
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: keep README on wiki

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: keep README on wiki
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: fileSD: Do not try to remove non-existent lease file
..


Patch Set 3:

* #1291207::Update tracker: OK
* Set MODIFIED::bug 1291207#1291207OK

-- 
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: drop isolatedCommand handling

2016-01-04 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: drop isolatedCommand handling
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad10ec7013b280d78f60703d741e72334358f39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: fileSD: Do not try to remove non-existent lease file
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread ybronhei 
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: fileSD: Do not try to remove non-existent lease file
..


fileSD: Do not try to remove non-existent lease file

The volume.lease file exists only if a domain has volume leases. Avoid
removing the non-existent lease file and the bogus exception in the log
when the operation "fails".

This is the same patch from master, applied to FileStorageDomain instead
of FileStorageDomainManifest, since deleteImage was not moved to the
manifest class in 3.6.

Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Bug-Url: https://bugzilla.redhat.com/1291207
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/50589
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik 
Reviewed-by: Adam Litke 
Reviewed-by: Liron Aravot 
Reviewed-on: https://gerrit.ovirt.org/51132
Reviewed-by: Francesco Romani 
Reviewed-by: Freddy Rolland 
Reviewed-by: Idan Shaby 
Reviewed-by: Yaniv Bronhaim 
---
M vdsm/storage/fileSD.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: fileSD: Do not try to remove non-existent lease file
..


Patch Set 2: Code-Review+1

looks fine to not-storage-expert-me. I'd like another ACK from one storage dev 
before to merge. Partial ACK meantime.

-- 
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread frolland 
Freddy Rolland has posted comments on this change.

Change subject: fileSD: Do not try to remove non-existent lease file
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I525704678707dfef40e34497bc4917dd19d73034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Require safelease 1.0-6 for fedora 23 due to wrong build

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..


Patch Set 2:

* #1287862::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287862::OK, public bug
* Check Product::#1287862::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a0e36f6da05b463b46d8c86be9b82bff78257c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ceph: Support OVF_STORE upload for ceph.

2016-01-04 Thread mlipchuk 
Maor Lipchuk has posted comments on this change.

Change subject: ceph: Support OVF_STORE upload for ceph.
..


Patch Set 2:

draft

-- 
To view, visit https://gerrit.ovirt.org/43296
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffcc1af9861a5580786340c2e5a325d1663b3a5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: startup: Change system default encoding to utf8

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: startup: Change system default encoding to utf8
..


Patch Set 2:

* #1281940::Update tracker: OK
* Set MODIFIED::bug 1281940#1281940OK

-- 
To view, visit https://gerrit.ovirt.org/51273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: startup: Change system default encoding to utf8

2016-01-04 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: startup: Change system default encoding to utf8
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: drop isolatedCommand handling

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: drop isolatedCommand handling
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad10ec7013b280d78f60703d741e72334358f39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: drop isolatedCommand handling

2016-01-04 Thread phoracek 
Petr Horáček has uploaded a new change for review.

Change subject: net: drop isolatedCommand handling
..

net: drop isolatedCommand handling

Since addNetwork and delNetwork API was dropped, we don't need
isolatedCommand handling anymore.

Change-Id: Ifad10ec7013b280d78f60703d741e72334358f39
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/api.py
1 file changed, 1 insertion(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/51281/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index 893e2d6..d29b7b0 100755
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -212,18 +212,6 @@
 attrs = kwargs.copy()
 attrs.update(dict(zip(spec.args, args)))
 
-isolatedCommand = attrs.get('configurator') is None
-# Detect if we are running an isolated command, i.e., a command that is
-# not called as part of composed API operation like setupNetworks or
-# editNetwork, but rather as its own API verb. This is necessary in
-# order to maintain behavior of the addNetwork and delNetwork API
-# verbs
-if isolatedCommand:
-attrs['configurator'] = configurator = ConfiguratorClass()
-configurator.begin()
-else:
-configurator = attrs['configurator']
-
 ret = func(**attrs)
 
 nics = attrs.pop('nics', None)
@@ -233,12 +221,11 @@
 if nics:
 attrs['nic'], = nics
 
+configurator = attrs['configurator']
 if func.__name__ == '_delNetwork':
 configurator.runningConfig.removeNetwork(attrs.pop('network'))
 else:
 configurator.runningConfig.setNetwork(attrs.pop('network'), attrs)
-if isolatedCommand:  # Commit the no-rollback transaction.
-configurator.commit()
 return ret
 return wrapped
 


-- 
To view, visit https://gerrit.ovirt.org/51281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifad10ec7013b280d78f60703d741e72334358f39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: register: handle non uuid machines

2016-01-04 Thread fabiand 
Fabian Deutsch has posted comments on this change.

Change subject: register: handle non uuid machines
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/47385/2/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 258: self.uuid = self.vdsm_uuid
Line 259: else:
Line 260: self.uuid = getHostUUID(legacy=False)
Line 261: 
Line 262: if self.uuid is None:
> I agree with Dan, just improve the error to make the issue clear.
+1
Line 263: self.uuid = str(uuid.uuid4())
Line 264: self.logger.debug("Generated UUID: {0}".format(self.uuid))
Line 265: 
Line 266: self.url_reg += "={u}".format(u=self.uuid)


-- 
To view, visit https://gerrit.ovirt.org/47385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9429e46895a73178cf459d5ced5d39499e993922
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: restoring correct vm nic device after HotunplugTimeout

2016-01-04 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1055a9c6b19143edf98da7f82459d96f3a406712
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test default Job.progress implementation

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Test default Job.progress implementation
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jobs: Add Job.__repr__ for easier debugging
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Set status when creating a job

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Set status when creating a job
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd393a501860c773ea0c25391a56f22b3b22df7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test default Job.progress implementation

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: tests: Test default Job.progress implementation
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Take lock once when deleting a job

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jobs: Take lock once when deleting a job
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Replace validation method with a property

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jobs: Replace validation method with a property
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23facf952529f3e811c9e179af25cfe39b2db0fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: Move getImageVolumes
..


Patch Set 13: Verified+1

Used the unit tests.

-- 
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sslTests.py: Fix typos

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: sslTests.py: Fix typos
..


sslTests.py: Fix typos

Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/51311
Reviewed-by: Tal Nisan 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M tests/sslTests.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Tal Nisan: Looks good to me, but someone else must approve
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sslTests.py: Fix typos

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: sslTests.py: Fix typos
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sslTests.py: Fix typos

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: sslTests.py: Fix typos
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test: Make pep8 happy again

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: rwlock_test: Make pep8 happy again
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sigutils: Fix typo "the the" -> "the"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: sigutils: Fix typo "the the" -> "the"
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If37c6e3e542368355f2349998f94445f1c4a7c5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dump_volume_chains.py: Spelling in comment

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: dump_volume_chains.py: Spelling in comment
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sigutils: Fix typo "the the" -> "the"

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: sigutils: Fix typo "the the" -> "the"
..


sigutils: Fix typo "the the" -> "the"

Change-Id: If37c6e3e542368355f2349998f94445f1c4a7c5a
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/51304
Reviewed-by: Tal Nisan 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M lib/vdsm/infra/sigutils/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Tal Nisan: Looks good to me, but someone else must approve
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If37c6e3e542368355f2349998f94445f1c4a7c5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dump_volume_chains.py: Spelling in comment

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: dump_volume_chains.py: Spelling in comment
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dump_volume_chains.py: Spelling in comment

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: dump_volume_chains.py: Spelling in comment
..


dump_volume_chains.py: Spelling in comment

Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/51306
Reviewed-by: Tal Nisan 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/vdsm/tool/dump_volume_chains.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Tal Nisan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sigutils: Fix typo "the the" -> "the"

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: sigutils: Fix typo "the the" -> "the"
..


Patch Set 1: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If37c6e3e542368355f2349998f94445f1c4a7c5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: verify.py: Fix typo "attribets" -> "attributes"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: verify.py: Fix typo "attribets" -> "attributes"
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test default Job.progress implementation

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Test default Job.progress implementation
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test default Job.progress implementation

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: tests: Test default Job.progress implementation
..


tests: Test default Job.progress implementation

Test jobs.Job.progress, and add ProgressingJob class for testing job
that report a progress.

Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/51213
Reviewed-by: Adam Litke 
Continuous-Integration: Jenkins CI
---
M tests/jobsTests.py
1 file changed, 17 insertions(+), 8 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: verify.py: Fix typo "attribets" -> "attributes"

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: verify.py: Fix typo "attribets" -> "attributes"
..


verify.py: Fix typo "attribets" -> "attributes"

Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/51312
Reviewed-by: Tal Nisan 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M tests/verify.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Tal Nisan: Looks good to me, but someone else must approve
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: verify.py: Fix typo "attribets" -> "attributes"

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: verify.py: Fix typo "attribets" -> "attributes"
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test: Make pep8 happy again

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: rwlock_test: Make pep8 happy again
..


Patch Set 1: Verified+1 Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging

2016-01-04 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: jobs: Add Job.__repr__ for easier debugging
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sigutils: Fix typo "the the" -> "the"

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: sigutils: Fix typo "the the" -> "the"
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If37c6e3e542368355f2349998f94445f1c4a7c5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test: Make pep8 happy again

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: rwlock_test: Make pep8 happy again
..


Patch Set 1:

Unbreaking master

-- 
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test: Make pep8 happy again

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rwlock_test: Make pep8 happy again
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test: Make pep8 happy again

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: rwlock_test: Make pep8 happy again
..


rwlock_test: Make pep8 happy again

Fixing typo (shold -> should) increased the line length to 80
characters, making pep8 grumpy. Rewrap to make it happy again.

Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/51346
Reviewed-by: Allon Mureinik 
Tested-by: Allon Mureinik 
Continuous-Integration: Jenkins CI
---
M tests/rwlock_test.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Set status when creating a job

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Set status when creating a job
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd393a501860c773ea0c25391a56f22b3b22df7c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Set status when creating a job

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: tests: Set status when creating a job
..


tests: Set status when creating a job

Instead of setting job private instance variables, set the status when
creating the job.

Change-Id: Idd393a501860c773ea0c25391a56f22b3b22df7c
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/51269
Reviewed-by: Adam Litke 
Continuous-Integration: Jenkins CI
---
M tests/jobsTests.py
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd393a501860c773ea0c25391a56f22b3b22df7c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test: Make pep8 happy again

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rwlock_test: Make pep8 happy again
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ec89503af810834048612e14b63f35b106cc414
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: momTests.py: Fix typo "paramters" -> "parameters"

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: momTests.py: Fix typo "paramters" -> "parameters"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test.py: Fix typo "shold" -> "should"

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..


rwlock_test.py: Fix typo "shold" -> "should"

Change-Id: I6dff56805732b0675c980a92910a281978050f36
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/51310
Reviewed-by: Tal Nisan 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M tests/rwlock_test.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Tal Nisan: Looks good to me, but someone else must approve
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6dff56805732b0675c980a92910a281978050f36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test.py: Fix typo "shold" -> "should"

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dff56805732b0675c980a92910a281978050f36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test.py: Fix typo "shold" -> "should"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dff56805732b0675c980a92910a281978050f36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: momTests.py: Fix typo "paramters" -> "parameters"

2016-01-04 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..


momTests.py: Fix typo "paramters" -> "parameters"

Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/51309
Reviewed-by: Martin Sivák 
Reviewed-by: Tal Nisan 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M tests/functional/momTests.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Tal Nisan: Looks good to me, but someone else must approve
  Martin Sivák: Looks good to me, but someone else must approve
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Require safelease 1.0-6 for fedora 23 due to wrong build

2016-01-04 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..


Patch Set 2:

btw, I promised to nir that we'll continue the work on vdsm-arch and remove 
this safelease hack ...

-- 
To view, visit https://gerrit.ovirt.org/51228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a0e36f6da05b463b46d8c86be9b82bff78257c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: Fix Typos

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: schema: Fix Typos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51302
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic204be54f6f257ece07394f9836c0731f15920f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: try to configure sebool after upgrade

2016-01-04 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: try to configure sebool after upgrade
..


Patch Set 1:

what to say ? maybe better to run sebool configurations as well :\ not sure 
about it

-- 
To view, visit https://gerrit.ovirt.org/50382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1200572a1bb5afb3c578a887d9269d1bf0dfbd9f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

2016-01-04 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: Enable VDSM to listen on IPv6 addresses
..


Patch Set 1:

Verified by running the unit tests and functional tests.
The unit tests include an IPv6 connection check (with and without SSL)

-- 
To view, visit https://gerrit.ovirt.org/51319
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c893d8f38f6abf183dcccbc2a5e328b492235e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsClient: Fix typo parmeter->parameter

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: vdsClient: Fix typo parmeter->parameter
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14a3c09f263f4ded2fb5898312d20645cf556e7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: nfs-check.py: apostrophe

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: nfs-check.py: apostrophe
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66a903100dba4616083d19c18e292645896f79db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sslTests.py: Fix typos

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: sslTests.py: Fix typos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test.py: Fix typo "shold" -> "should"

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dff56805732b0675c980a92910a281978050f36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sslTests.py: Fix typos

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: sslTests.py: Fix typos
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: verify.py: Fix typo "attribets" -> "attributes"

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: verify.py: Fix typo "attribets" -> "attributes"
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: momTests.py: Fix typo "paramters" -> "parameters"

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: momTests.py: Fix typo "paramters" -> "parameters"

2016-01-04 Thread msivak 
Martin Sivák has posted comments on this change.

Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 3:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: betterAsyncore.py: Fix typo "enought"->"enough"

2016-01-04 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia59d5c43a0770964f08e6d3a789b90824d0809c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: momTests.py: Fix typo "paramters" -> "parameters"

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6bb6c032276b9bfa69f61bcf05dbb4ade6338e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils.py: Fix typo "placeholer" -> "placeholder"

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: utils.py: Fix typo "placeholer" -> "placeholder"
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1406b8b01daaa3807c51f60e3c5bebe8767ada8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: betterAsyncore.py: Fix typo "enought"->"enough"

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia59d5c43a0770964f08e6d3a789b90824d0809c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test.py: Fix typo "shold" -> "should"

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dff56805732b0675c980a92910a281978050f36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dump_volume_chains.py: Spelling in comment

2016-01-04 Thread tnisan 
Tal Nisan has posted comments on this change.

Change subject: dump_volume_chains.py: Spelling in comment
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: fileSD: improve error handling in deleteImage

2016-01-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: fileSD: improve error handling in deleteImage
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22ceee059cce1ec65cd455ce567cba0e49c00db2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: zombiereaper: Fix typo "happend" -> "happened"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: zombiereaper: Fix typo "happend" -> "happened"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43cd496ad77cd59756fed7e711d5f8d243b186a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: verify.py: Fix typo "attribets" -> "attributes"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: verify.py: Fix typo "attribets" -> "attributes"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dump_volume_chains.py: Spelling in comment

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: dump_volume_chains.py: Spelling in comment
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: betterAsyncore.py: Fix typo "enought"->"enough"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia59d5c43a0770964f08e6d3a789b90824d0809c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sslTests.py: Fix typos

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: sslTests.py: Fix typos
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils.py: Fix typo "placeholer" -> "placeholder"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: utils.py: Fix typo "placeholer" -> "placeholder"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1406b8b01daaa3807c51f60e3c5bebe8767ada8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: compat.py: Fixed typo "libary"->"library"

2016-01-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: compat.py: Fixed typo "libary"->"library"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51303
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id96ccb0a172c4c11541ac6343047a994aa004a75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock_test.py: Fix typo "shold" -> "should"

2016-01-04 Thread amureini 
Allon Mureinik has uploaded a new change for review.

Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..

rwlock_test.py: Fix typo "shold" -> "should"

Change-Id: I6dff56805732b0675c980a92910a281978050f36
Signed-off-by: Allon Mureinik 
---
M tests/rwlock_test.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/51310/1

diff --git a/tests/rwlock_test.py b/tests/rwlock_test.py
index 4e3ba0f..440c459 100644
--- a/tests/rwlock_test.py
+++ b/tests/rwlock_test.py
@@ -264,7 +264,7 @@
"holding a write lock")
 lock.acquireRead()
 # I hold both a read lock and a write lock now
-# I released the write lock. Having read lock, reader shold get the
+# I released the write lock. Having read lock, reader should get 
the
 # lock.
 self.assertTrue(reader.acquired.wait(0.5),
 "Reader could not acuire the lock")


-- 
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dff56805732b0675c980a92910a281978050f36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

  1   2   3   >