Nir Soffer has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55164
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55231
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55164
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55231
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 1:
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public
gerrit-hooks has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 3:
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55231
to review the following change.
Change subject: blockVolume: Remove stale links to image directory
..
blockVolume: Remove
gerrit-hooks has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2:
* #1319987::Update tracker: OK
* Set MODIFIED::bug 1319987#1319987IGNORE, not oVirt
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Clean up image links during teardownImage
..
storage: Clean up image links during teardownImage
In commit 736ab9 we began cleaning up volume
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 3:
* #1319987::Update tracker: OK
* Set MODIFIED::bug 1319987#1319987IGNORE, not oVirt
Nir Soffer has submitted this change and it was merged.
Change subject: blockVolume: Remove stale links to image directory
..
blockVolume: Remove stale links to image directory
Since we started to create the image directory
Nir Soffer has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55227
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55175
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Move legality check in prepareImage
..
Patch Set 1: Code-Review-1
(1 comment)
Need more thinking before we touch this.
Adam Litke has posted comments on this change.
Change subject: storage: Move legality check in prepareImage
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55228
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55227
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55175
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55164/2/vdsm/storage/blockSD.py
File
gerrit-hooks has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 1:
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public
gerrit-hooks has posted comments on this change.
Change subject: storage: Move legality check in prepareImage
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: storage: Move legality check in prepareImage
..
storage: Move legality check in prepareImage
The legality check causes volume objects to be produced so that the
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 2:
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public
Adam Litke has uploaded a new change for review.
Change subject: storage: Clean up image links during teardownImage
..
storage: Clean up image links during teardownImage
In commit 736ab9 we began cleaning up volume links that
Jenkins CI has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 8: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 7
Jenkins CI has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3:
Propagate review hook: Continuous Integration value inherited from patch 2
--
To view, visit
Jenkins CI has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 2
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 6:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 2:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vmstats: reformat function to make pep8 friendly
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
gerrit-hooks has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3: -Verified
* #1318902::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318902::OK,
gerrit-hooks has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
gerrit-hooks has posted comments on this change.
Change subject: vmstats: reformat function to make pep8 friendly
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55225
to review the following change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
gerrit-hooks has posted comments on this change.
Change subject: vmstats: reformat function to make pep8 friendly
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
gerrit-hooks has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
gerrit-hooks has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/54999/6//COMMIT_MSG
Commit Message:
Line 7: spec:
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 5:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
Francesco Romani has uploaded a new change for review.
Change subject: vm: destroy: retry to gracefully destroy
..
vm: destroy: retry to gracefully destroy
Add support to retry gracefully to destroy a VM
before to go
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 9: Verified+1
Rebase only. Verified by upgrading existing vdsm and running and stopping a vm.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 26: Verified+1
Fixed schema to align with storage method removal. No other code changes.
Verified by upgrading
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 14: Verified+1
Fixed Nir's comments. Verified by upgrading existing vdsm and running and
stopping a vm.
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 9: Verified+1
Fixed Nir's comments. Verified by upgrading existing vdsm and running and
stopping a vm.
--
To
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has submitted this change and it was merged.
Change subject: commit-template: Refine the example text
..
commit-template: Refine the example text
Improve the long description, making the template closer to how a
Dan Kenigsberg has posted comments on this change.
Change subject: commit-template: Refine the example text
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55105
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 11: Code-Review+2 Verified+1
copying scores.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: commit-template: Refine the example text
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: bridge: fix naming style
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Skipping networkTests if alien bonds presents in the system
Alien bonds causes to tests
gerrit-hooks has posted comments on this change.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Amit Aviram has uploaded a new change for review.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
volume: Add internal info from qemuimg in getVolumeInfo.
Currently Volume's getInfo() fetches
Nir Soffer has posted comments on this change.
Change subject: commit-template: Refine the example text
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55105
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Amit Aviram has abandoned this change.
Change subject: :
short summary under 50 chars
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/55220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
gerrit-hooks has posted comments on this change.
Change subject: vm: safer early return if destroyed on startup
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 6:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 4:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: :
short summary under 50 chars
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/55220
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: HACK: BROKEN: patch to test destroy on startup
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: :
short summary under 50 chars
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Amit Aviram has uploaded a new change for review.
Change subject: :
short summary under 50 chars
..
: short summary under
50 chars
Longer description using lines' length under 72 chars.
With multiple paragraphs if necessary.
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 28:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55150/3//COMMIT_MSG
Commit Message:
Line 3:
gerrit-hooks has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Edward Haas has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53498
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Amit Aviram has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes
..
Patch Set 1:
(6 comments)
https://gerrit.ovirt.org/#/c/55199/1//COMMIT_MSG
Commit Message:
Line 8:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network tests: remove bonds after use
..
network tests: remove bonds after use
Change-Id: Ic1dc00ce35acf57726725956c5d2f83e20b2122c
Signed-off-by:
Dan Kenigsberg has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 10: Code-Review+2 Verified+1
Raising Edy's score, copying V+1 after fixing minor nits.
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: Run unittests only over fedora mock
..
Patch Set 1: Verified+1
ran mock_runner with that. works cool
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: network tests: remove bonds after use
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: commit-template: Refine the example text
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55105
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 2: Code-Review+2
ok, let us wait with it.
--
To view, visit https://gerrit.ovirt.org/55189
To
gerrit-hooks has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configurator: libvirt: do not jump on virtlogd
..
configurator: libvirt: do not jump on virtlogd
Libvirt 1.3.0 adds and uses by default a new service
gerrit-hooks has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Yaniv Bronhaim has uploaded a new change for review.
Change subject: automation: Run unittests only over fedora mock
..
automation: Run unittests only over fedora mock
Change-Id: I827d1c31bfc0edf907ff9c7210428facea9f01cb
gerrit-hooks has posted comments on this change.
Change subject: automation: Run unittests only over fedora mock
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55189/1//COMMIT_MSG
Commit Message:
Line 6:
Line
gerrit-hooks has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has posted comments on this change.
Change subject: udevadm: add udev name matching
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55194/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-03-24
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 6: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/54999/6//COMMIT_MSG
Commit Message:
gerrit-hooks has posted comments on this change.
Change subject: commit-template: Refine the example text
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ondřej Svoboda has posted comments on this change.
Change subject: shell_helper: ignore iproute2's @master notation to obtain
device names
..
Patch Set 2: Verified+1
Lingering devices can now be cleaned up again. And since
Nir Soffer has posted comments on this change.
Change subject: supervdsm_udev: factor out permission handling
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/55192/3/vdsm/supervdsm_api/udev.py
File
Ondřej Svoboda has posted comments on this change.
Change subject: network tests: remove bonds after use
..
Patch Set 3: Verified+1
Renamed test_static_ip_configuration_* now don't complain about
"AssertionError: Nic
Francesco Romani has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 6: Verified+1
re-verified on fc23
--
To view, visit https://gerrit.ovirt.org/54999
To
gerrit-hooks has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55189/1//COMMIT_MSG
Commit Message:
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 27:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 1:
Done:
https://bugzilla.redhat.com/show_bug.cgi?id=1321010
--
To view, visit
1 - 100 of 236 matches
Mail list logo
