Change in vdsm[master]: net: native ovs: ovsnettestlib.py

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 12: Code-Review+1 Very nice, thanks. -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: store constants in __init__

Edward Haas has posted comments on this change. Change subject: net: native ovs: store constants in __init__ .. Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56451/10/lib/vdsm/network/ovs/switch.py File

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/53214/9/lib/vdsm/module_loader.py File

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg/connection files

Edward Haas has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg/connection files .. Patch Set 4: I am in favor of "keyfile" plugin approach, where you specify the devices that should

Change in vdsm[master]: v2v: Detect VM with snapshots

gerrit-hooks has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: v2v: Detect VM with snapshots

gerrit-hooks has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: add device setup and teardown

Nir Soffer has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 11: (7 comments) Partial review https://gerrit.ovirt.org/#/c/55135/11/tests/vmTests.py File tests/vmTests.py:

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

Nir Soffer has submitted this change and it was merged. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. tests: volume_artifacts: validate FileVolumeArtifacts metadata We now have the

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: Support initial_size parameter

Nir Soffer has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 3: Code-Review-1 (3 comments) Looks good https://gerrit.ovirt.org/#/c/56628/3/tests/storage_volume_artifacts_test.py

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 10: Rebase on master so we can merge it now safely. -- To view, visit

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 11: Code-Review-1 (5 comments) Partial review https://gerrit.ovirt.org/#/c/55987/11/vdsm/storage/blockSD.py

Change in vdsm[master]: tests: marking temporarily as broken

Nir Soffer has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56650 To unsubscribe, visit

Change in vdsm[master]: client: do not protect requests on client side

Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: Yaniv's comments fixed. Simone can you verify it one more time? -- To view, visit

Change in vdsm[master]: client: do not protect requests on client side

gerrit-hooks has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: marking temporarily as broken

Piotr Kliczewski has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: Verified+1 Verified by building locally -- To view, visit https://gerrit.ovirt.org/56650 To

Change in vdsm[master]: tests: marking temporarily as broken

Piotr Kliczewski has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: It is sad that I need to do :/. Hopefully will have some time soon to fix them. -- To view, visit

Change in vdsm[master]: tests: marking temporarily as broken

Piotr Kliczewski has uploaded a new change for review. Change subject: tests: marking temporarily as broken .. tests: marking temporarily as broken Change-Id: Id673e92e73ae93994e002ac47b83af7031faeec0 Signed-off-by:

Change in vdsm[master]: tests: marking temporarily as broken

gerrit-hooks has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 9: Adam, does this patch really depend on the previous patches? can you rebase it on

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 9: Verified+1 Jenkins is happy with the new test, seems verified. -- To view, visit

Change in vdsm[master]: storage: sdm: consolidate create validation

gerrit-hooks has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: storage: sdm: consolidate create validation

Nir Soffer has submitted this change and it was merged. Change subject: storage: sdm: consolidate create validation .. storage: sdm: consolidate create validation The validation of VolumeArtifacts.create parameters can be

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

Nir Soffer has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56626 To unsubscribe, visit

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

gerrit-hooks has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

Nir Soffer has submitted this change and it was merged. Change subject: tests: Add test_create_same_volume_in_image .. tests: Add test_create_same_volume_in_image Add a new test (which will be broken until support for creating

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

Adam Litke has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56626 To unsubscribe, visit

Change in vdsm[master]: storage: sdm: consolidate create validation

Adam Litke has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56627 To unsubscribe, visit

Change in vdsm[master]: storage: sdm: consolidate create validation

gerrit-hooks has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

gerrit-hooks has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Support initial_size parameter

gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: cow wip

gerrit-hooks has posted comments on this change. Change subject: cow wip .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 8: Can you rebase this on master? I want to merge it now. -- To view, visit

Change in vdsm[master]: storage: organize imports in clusterlock.py

Nir Soffer has posted comments on this change. Change subject: storage: organize imports in clusterlock.py .. Patch Set 1: Code-Review-1 See the comments. -- To view, visit https://gerrit.ovirt.org/56639 To unsubscribe,

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55252 To unsubscribe, visit

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

Milan Zamazal has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56038/5/lib/vdsm/hostdev.py File

Change in vdsm[master]: Let the engine control the guest lifecycle events

Piotr Kliczewski has posted comments on this change. Change subject: Let the engine control the guest lifecycle events .. Patch Set 6: Code-Review+2 Based on Franceso's score and schema change being OK I raise. -- To view,

Change in vdsm[master]: vm: handle destroy request while starting up

Francesco Romani has posted comments on this change. Change subject: vm: handle destroy request while starting up .. Patch Set 6: Verified+1 verified both positive and negative flow, the negative (aka triggering the failure)

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

Nir Soffer has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56626/2/tests/storage_volume_artifacts_test.py

Change in vdsm[master]: hostdev: use libvirt flags to select capability

Milan Zamazal has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 5: Code-Review+1 (Although I still insist on that there is a grammar error in the commit message.)

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

gerrit-hooks has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Support initial_size parameter

gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: storage: sdm: consolidate create validation

gerrit-hooks has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: cow wip

gerrit-hooks has posted comments on this change. Change subject: cow wip .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid

Change in vdsm[master]: jsonrpc: handle strings as correct response

gerrit-hooks has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: jsonrpc: handle strings as correct response

Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: handle strings as correct response .. jsonrpc: handle strings as correct response There is bunch of different response types. Currnetly we

Change in vdsm[master]: jsonrpc: handle strings as correct response

Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 3: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/56207 To unsubscribe,

Change in vdsm[master]: vm: handle destroy request while starting up

gerrit-hooks has posted comments on this change. Change subject: vm: handle destroy request while starting up .. Patch Set 6: * #912390::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#912390::OK, public bug *

Change in vdsm[master]: client: do not protect requests on client side

Sandro Bonazzola has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit

Change in vdsm[master]: client: do not protect requests on client side

Simone Tiraboschi has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Verified on ovirt-hosted-engine-setup -- To view, visit https://gerrit.ovirt.org/56288 To

Change in vdsm[master]: jsonrpc: handle strings as correct response

Simone Tiraboschi has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 3: Verified+1 Verified with hosted-engine-setup -- To view, visit https://gerrit.ovirt.org/56207

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

Simone Tiraboschi has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: Verified+1 Verified on iSCSI and NFS -- To view, visit https://gerrit.ovirt.org/55252 To unsubscribe,

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

Milan Zamazal has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/55022/6/lib/vdsm/hostdev.py File

Change in vdsm[master]: hostdev: add is_assignable flag

gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: hostdev: add is_assignable flag

Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: add is_assignable flag .. hostdev: add is_assignable flag is_assignable is new flag that uses underlying PCI_HEADER_TYPE. We can only assign

Change in vdsm[master]: hostdev: use libvirt flags to select capability

gerrit-hooks has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 5: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug *

Change in vdsm[master]: hostdev: add support for SCSI

Martin Polednik has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/55024/5//COMMIT_MSG Commit Message: PS5, Line 12: udev pat > Sorry,

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

Nir Soffer has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56626/1/tests/storage_volume_artifacts_test.py File

Change in vdsm[master]: storage: sdm: consolidate create validation

Nir Soffer has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 1: -Verified Jenkins failure caused by the previous patch. -- To view, visit

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

Francesco Romani has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 6: Code-Review+1 (1 comment) please check inline comment (very minor, should be trivial to

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

Martin Polednik has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/55023/6/vdsm/virt/vmdevices/hostdevice.py File

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

Martin Betak has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/53305/21/vdsm/API.py File vdsm/API.py:

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

gerrit-hooks has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: hostdev: add support for SCSI

gerrit-hooks has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 8: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug * Check

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

gerrit-hooks has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 7: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

gerrit-hooks has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 7: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public

Change in vdsm[master]: hostdev: report storage model as product

gerrit-hooks has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 4: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug * Check

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

gerrit-hooks has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 5: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK,

Change in vdsm[master]: hostdev: add support for SCSI

Francesco Romani has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 7: Code-Review+1 (1 comment) please check the inline comment

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

Francesco Romani has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55023 To unsubscribe, visit

Change in vdsm[master]: hostdev: report storage model as product

Martin Polednik has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56123/3//COMMIT_MSG Commit Message: Line 11: is a special

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

Francesco Romani has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 4: Code-Review-1 (3 comments) looks good, but few questions inside, -1 for visibility

Change in vdsm[master]: storage: sdm: consolidate create validation

Nir Soffer has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 1: Verified-1 This fails with: 14:58:37 pyflakes-1.1.0 14:58:45

Change in vdsm[master]: hostdev: use libvirt flags to select capability

Martin Polednik has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56037/4//COMMIT_MSG Commit Message: PS4, Line 10:

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

Francesco Romani has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55022 To

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

gerrit-hooks has posted comments on this change. Change subject: tests: Move artifacts tests to their approproate classes .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

Nir Soffer has submitted this change and it was merged. Change subject: tests: Move artifacts tests to their approproate classes .. tests: Move artifacts tests to their approproate classes The tests: -

Change in vdsm[master]: hostdev: report storage model as product

Francesco Romani has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56123/3//COMMIT_MSG Commit Message: Line 11: is a special

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

Nir Soffer has posted comments on this change. Change subject: tests: Move artifacts tests to their approproate classes .. Patch Set 1: Continuous-Integration+1 Jenkins failed, ignoring it. -- To view, visit

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

Adam Litke has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56626/1/tests/storage_volume_artifacts_test.py File

Change in vdsm[master]: hostdev: report storage model as product

Francesco Romani has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56123 To unsubscribe, visit

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

Adam Litke has posted comments on this change. Change subject: tests: Move artifacts tests to their approproate classes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56625 To unsubscribe, visit

Change in vdsm[master]: hostdev: use libvirt flags to select capability

Francesco Romani has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 4: Code-Review+1 please check Milan's comment. I don't have any other. -- To view, visit

Change in vdsm[master]: storage: sdm: consolidate create validation

Nir Soffer has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56627 To unsubscribe, visit

Change in vdsm[master]: storage: organize imports in clusterlock.py

Nir Soffer has posted comments on this change. Change subject: storage: organize imports in clusterlock.py .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/56639/1/vdsm/storage/clusterlock.py File

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56172 To unsubscribe,

Change in vdsm[master]: migration: move helper into Progress class

Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit

Change in vdsm[master]: migration: validate progress fields from libvirt

Martin Polednik has posted comments on this change. Change subject: migration: validate progress fields from libvirt .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56378 To unsubscribe, visit

Change in vdsm[master]: storage: organize imports in clusterlock.py

Idan Shaby has posted comments on this change. Change subject: storage: organize imports in clusterlock.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56639 To unsubscribe, visit

Change in vdsm[master]: hostdev: use libvirt flags to select capability

Milan Zamazal has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56037/4//COMMIT_MSG Commit Message: PS4, Line 10:

Change in vdsm[master]: storage: move clusterlock.py to vdsm storage lib

Idan Shaby has uploaded a new change for review. Change subject: storage: move clusterlock.py to vdsm storage lib .. storage: move clusterlock.py to vdsm storage lib This patch moves the module vdsm/storage/clusterlock.py to

Change in vdsm[master]: storage: move curlImgWrap.py to vdsm storage lib

gerrit-hooks has posted comments on this change. Change subject: storage: move curlImgWrap.py to vdsm storage lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: move clusterlock.py to vdsm storage lib

gerrit-hooks has posted comments on this change. Change subject: storage: move clusterlock.py to vdsm storage lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: move curlImgWrap.py to vdsm storage lib

Idan Shaby has uploaded a new change for review. Change subject: storage: move curlImgWrap.py to vdsm storage lib .. storage: move curlImgWrap.py to vdsm storage lib This patch moves the module vdsm/storage/curlImgWrap.py to

Change in vdsm[master]: virt: Set timeout on boot menu

Martin Polednik has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 3: Code-Review+1 (2 comments) Some disagreement not worth blocking for.

  1   2   3   >