Change in vdsm[master]: storage: fix disconnecting multiple iSCSI sessions

[edwardh]

Edward Haas has posted comments on this change.

Change subject: storage: fix disconnecting multiple iSCSI sessions
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55578/2//COMMIT_MSG
Commit Message:

PS2, Line 12: Linux ethernet bonding in mode=2 or 4 with 
xmit_hash_policy=layer3+4 on
: iSCSI target allows to spread tcp connections over different 
interfaces,
: so each tcp connection automatically uses some different interface
: inside bond. Thus it's possible to sum bandwidths without creating
: dedicated networks. Also it increases performance over networks 
with
: high latency.
This statement has limitations:
- The distribution of connections based on hashing assumes there are a large 
number of connections in place, for the balance to be statistically correct.
- The distribution requires a peer network device with a bond in place that 
performs the same for the ingress traffic (usually this will be a switch).

If these limitations are acceptable, then you are fine.


-- 
To view, visit https://gerrit.ovirt.org/55578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d576f6fe262d9576fb99a674ba921dc4a141a32
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Gashev 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cleanup: remove persist/unpersist calls for legacy node

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: cleanup: remove persist/unpersist calls for legacy node
..


Patch Set 4:

Sure, no problem Nir. I can split the patch and try to test all of it. I was 
kind of less worried since it's master branch and doesn't look a hurt patch.

-- 
To view, visit https://gerrit.ovirt.org/63715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca0cfa0e2254a5a8af6b3591ffe47689410415
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Allow run and abort only from valid states

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63711/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 126: return self.status in (STATUS.PENDING, STATUS.RUNNING)
Line 127: 
Line 128: def abort(self):
Line 129: if not self.active:
Line 130: raise JobNotActive()
If _abort() failed in a previous attempt, we change the state to ABORTED, so 
this check will skip the next abort.

I don't see a race free solution, and it will probably never happen, maybe 
document this issue here.
Line 131: self._status = STATUS.ABORTED
Line 132: logging.info('Job %r aborting...', self._id)
Line 133: self._abort()
Line 134: if self.autodelete:


-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/62002/7/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 117
Line 118
Line 119
Line 120
Line 121
Please add a comment explaining why we *must* not delete the job if _abort() 
fails.

One issue - if _abort() failed after stopping the job we are leaking the job. 
If engine try to abort again we are doing nothing because the state is ABORTED.


-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Guard against racy state changes

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Guard against racy state changes
..


Patch Set 2:

(2 comments)

Partial review

https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 147:(self._id, self.status))
Line 148: self._status = STATUS.RUNNING
Line 149: try:
Line 150: self._run()
Line 151: status = STATUS.DONE
> Throughout the module I am using the property (status) for reading and the 
I would use always _status in this module, leaving status for external use, but 
better keep it consistent as you suggest in this patch.
Line 152: except Exception as e:
Line 153: status = STATUS.FAILED
Line 154: logging.exception("Job (id=%s desc=%s) failed",
Line 155:   self.id, self.description)


https://gerrit.ovirt.org/#/c/63712/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 37: RUNNING = 'running'  # Job is running
Line 38: DONE = 'done'# Job has finished successfully
Line 39: ABORTED = 'aborted'  # Job was aborted by user request
Line 40: FAILED = 'failed'# Job has failed
Line 41: CLEARED = 'cleared'  # Job is being deleted
Lets chose one term - cleared or deleted?

Since we use delete and autodelete, I think we should use DELETED.
Line 42: 
Line 43: 
Line 44: class ClientError(Exception):
Line 45: ''' Base class for client error '''


-- 
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5366fcb962e9d34da6fca47b5171a6b132cf2e3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 7: Code-Review+1

Looks good, waiting for more reviews.

-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Allow run and abort only from valid states

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
..


Patch Set 2: Code-Review+1

Looks good, waiting for more reviews.

-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Rely on system for logrotation

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Rely on system for logrotation
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG
Commit Message:

Line 10: is no real reason to invoke logrotate manualy.
Line 11: 
Line 12: Also if we rely on system to run logrotate we can remove the dependency
Line 13: on it from RPMs. It is enough to install the configuration file into 
the
Line 14: the directory with logrotate configuration.
> It's not our problem. Whether logrotate is installed or not should be admin
This approach is problematic.

Previously we rotated the log, now you want to let the user decide. We don't 
have any user or customer bug complaining about rotated logs, and we know that 
vdsm logs are huge.

I don't think we can do this, this can be harmful on machines with small 
harddisks (like node).

Using logrotate is little nicer, filling /var/log is not. Please require 
logrotate in this patch.

If a user want to disable vdsm log rotation she can disable the vdsm logrotate 
configuration or edit it.
Line 15: 
Line 16: The patch also renames script vdsm-logrotate to vdsm-remove-logs 
because
Line 17: it doesn't run logrotate anymore. It only removes old log files.
Line 18: 


https://gerrit.ovirt.org/#/c/63682/1/static/Makefile.am
File static/Makefile.am:

Line 36:./etc/vdsm/mom.d/04-cputune.policy \
Line 37:./etc/vdsm/mom.d/05-iotune.policy \
Line 38:$(NULL)
Line 39: 
Line 40: vdsmconfrotatedir = $(sysconfdir)/logrotate.d
> You mean to define new variable like:
Yes
Line 41: 
Line 42: vdsmconfrotate_DATA = \
Line 43:./etc/logrotate.d/vdsm \
Line 44:$(NULL)


https://gerrit.ovirt.org/#/c/63682/1/vdsm/vdsm-remove-logs
File vdsm/vdsm-remove-logs:

Line 10: if [ -d /var/log/core ] ; then
Line 11: /usr/bin/find /var/log/core -type f -name '*xz' -mtime +7 -exec 
/bin/rm -f '{}' \;
Line 12: EXITVALUE=$?
Line 13: if [ $EXITVALUE != 0 ]; then
Line 14: /usr/bin/logger -t logrotate "ALERT clean old core files 
exited abnormally with [$EXITVALUE]"
If we depend on logrotate running from cron, why do we need to run it here?
Line 15: fi
Line 16: fi
Line 17: 
Line 18: if [ -d /var/log/vdsm/import ] ; then


Line 18: if [ -d /var/log/vdsm/import ] ; then
Line 19: /usr/bin/find /var/log/vdsm/import -type f -mtime +30 -exec 
/bin/rm -f '{}' \;
Line 20: EXITVALUE=$?
Line 21: if [ $EXITVALUE != 0 ]; then
Line 22: /usr/bin/logger -t logrotate "ALERT clean of old import log 
files exited abnormally with [$EXITVALUE]"
Same
Line 23: fi
Line 24: fi
Line 25: 


-- 
To view, visit https://gerrit.ovirt.org/63682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add mount.isMounted() timing tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add mount.isMounted() timing tests
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84396450abaa17fee402d024e0ae99c36b68ce4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add mount.isMounted() timing tests

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Add mount.isMounted() timing tests
..


tests: Add mount.isMounted() timing tests

Add timing tests to understand how much time it takes to check if a
mountpoint is mounted when having lot of mounts. This used to be a
bottleneck on EL6 when having lot of file storage domains.

Here are the results on i7-4770 CPU @ 3.40GHz:

mountTests.TestIsMountedTiming
test_is_mounted(1) 1 mounts: 0.68 seconds
test_is_mounted(50)   50 mounts: 0.000480 seconds
test_is_mounted(100) 100 mounts: 0.000927 seconds
test_is_mounted(1000)   1000 mounts: 0.008862 seconds

Running the tests:

./run_tests_local.sh mountTests.py --enable-stress-tests -s

Change-Id: Ib84396450abaa17fee402d024e0ae99c36b68ce4
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/56565
Reviewed-by: Idan Shaby 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M tests/mountTests.py
1 file changed, 31 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib84396450abaa17fee402d024e0ae99c36b68ce4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: formatConverter: Use module logger
..


formatConverter: Use module logger

Make formatConverter to use module logger.

Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Signed-off-by: Maor Lipchuk 
Reviewed-on: https://gerrit.ovirt.org/63630
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 5: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/63630/4/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 28
Line 29
Line 30
Line 31
Line 32
> We need 2 blank lines before between functions (pep8 tool).
done


-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade from v3 to v4.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 4:

(1 comment)

Please run "make pep8 pyflakes" before uploading patches.

https://gerrit.ovirt.org/#/c/63630/4/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 28
Line 29
Line 30
Line 31
Line 32
We need 2 blank lines before between functions (pep8 tool).


-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade from v3 to v4.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Run mount tests multiple times

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Run mount tests multiple times
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idaed2e8e1c5b2bd04c412233d94e94005c23189c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Wait for systemd temporary mount unit
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Wait for systemd temporary mount unit
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storageServer: Remove dead code

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: storageServer: Remove dead code
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e827eb7c9e18d4bf521f2b415879c6142c433a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Allow run and abort only from valid states

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Guard against racy state changes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Guard against racy state changes
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5366fcb962e9d34da6fca47b5171a6b132cf2e3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storageServer: Remove dead code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storageServer: Remove dead code
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e827eb7c9e18d4bf521f2b415879c6142c433a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Guard against racy state changes

[alitke]

Adam Litke has posted comments on this change.

Change subject: jobs: Guard against racy state changes
..


Patch Set 1:

(7 comments)

https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 154
Line 155
Line 156
Line 157
Line 158
> Before we set status here and in the else path, we should check if the job 
Done


Line 158
Line 159
Line 160
Line 161
Line 162
> Here we can set the status safely:
I like using the finally clause for this.  Will adopt it in this patch.


Line 179
Line 180
Line 181
Line 182
Line 183
> To avoid races between jobs.stop() and _delete() called from autodelete, we
Implemented a variation of this idea.  Please check.


PS1, Line 1: 2015
> please update
Done


Line 146: if self.autodelete:
Line 147: self._autodelete()
Line 148: 
Line 149: def run(self):
Line 150: with self._status_lock:
> If job was aborted we should not fail. I think this will ensure this (needs
Done in previous patch and test added.
Line 151: if self.status != STATUS.PENDING:
Line 152: raise CannotRunJob()
Line 153: self._status = STATUS.RUNNING
Line 154: try:


PS1, Line 151: status
> please change to _status
Throughout the module I am using the property (status) for reading and the 
underlying variable (_status) when writing.  This patch maintains that 
convention.


PS1, Line 162: self._status = STATUS.FAILED
 : else:
 : self._status = STATUS.DONE
> if we want to protect status field we need to lock here as well.
Done


-- 
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5366fcb962e9d34da6fca47b5171a6b132cf2e3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storageServer: Remove dead code

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storageServer: Remove dead code
..


Patch Set 6:

Rebae and remove conflict introduced by the latest logging cleanup.

-- 
To view, visit https://gerrit.ovirt.org/56552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e827eb7c9e18d4bf521f2b415879c6142c433a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Simplify deleted suffix stripping

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Simplify deleted suffix stripping
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mounts: Use more meaningful names

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mounts: Use more meaningful names
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Remove EL 6 /etc/mtab support
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add mount.isMounted() timing tests

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add mount.isMounted() timing tests
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84396450abaa17fee402d024e0ae99c36b68ce4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add tests for un-escaping spaces

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add tests for un-escaping spaces
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I772b7e7e48f888f9b9790cd6963d65cd86912699
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Fix un-escaping of spaces

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Fix un-escaping of spaces
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add missing test for deleted mounts

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add missing test for deleted mounts
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id280a9e8e3d6db273eb3398dd38e4553750c4631
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Don't un-escape mount options

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Don't un-escape mount options
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Allow run and abort only from valid states

[alitke]

Adam Litke has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/63711/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 69: ''' Only pending jobs may be run '''
Line 70: name = 'CannotRunJob'
Line 71: 
Line 72: 
Line 73: class JobNotRunnable(ClientError):
> Leftover? I don't see any use.
oops.  Removing.
Line 74: ''' Job cannot be run from its current state '''
Line 75: name = 'JobNotRunnable'
Line 76: 
Line 77: 


Line 136: return self.status in (STATUS.PENDING, STATUS.RUNNING)
Line 137: 
Line 138: def abort(self):
Line 139: if not self.active:
Line 140: raise CannotAbortJob()
> CannotAbortJob means that job was in a state which can be aborted, but the 
Yeah agreed.  I was debating about going this route but your comments seal it.
Line 141: self._status = STATUS.ABORTED
Line 142: logging.info('Job %r aborting...', self._id)
Line 143: self._abort()
Line 144: if self.autodelete:


Line 145: self._autodelete()
Line 146: 
Line 147: def run(self):
Line 148: if self.status != STATUS.PENDING:
Line 149: raise CannotRunJob()
> We have two case here:
Done
Line 150: self._status = STATUS.RUNNING
Line 151: try:
Line 152: self._run()
Line 153: except Exception as e:


-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 137: 
Line 138: legacy_switch.add_missing_networks(configurator, networks,
Line 139:bondings, _netinfo)
Line 140: 
Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, 
_netinfo)
> When bonds_setup takes place, some networks are not there and we are not ab
If you put it like that:
bonds_setup creates bonds attached to networks?
I guess this is not true for new bonds, but may be true for edited ones (is 
it?).
add_missing_networks edits the bonds and specify if they are slaves of a bridge 
(or a vlan).

So it looks like we must have it after add_missing_networks and bonds_setup.
After bonds_setup because the non-vlan network could have been removed in 
remove_networks and nothing added at add_missing.
After add_missing because...

Lets call it 'bonds_post_setup' to be less specific in this abstraction level.
Line 142: 
Line 143: connectivity.check(options)
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: build: Remove python 3 test run

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: Remove python 3 test run
..


Patch Set 1:

ping?

-- 
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6723272a95b407e3fa9ad8e12f595d0b8f0d6a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cleanup: remove persist/unpersist calls for legacy node

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: cleanup: remove persist/unpersist calls for legacy node
..


Patch Set 4:

I agree with Dan, we don't expect to improve the current code, just remove the 
usage of persist/unpersist, and leave a comment where we need to improve the 
old code.

-- 
To view, visit https://gerrit.ovirt.org/63715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca0cfa0e2254a5a8af6b3591ffe47689410415
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cleanup: remove persist/unpersist calls for legacy node

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: cleanup: remove persist/unpersist calls for legacy node
..


Patch Set 4: Code-Review-1

Thanks for this much needed cleanup.

At the very least, you can split network-related changes to separate patches. 
myakove is usually happy to give a tier2 run to a 4.0 backport of such a patch.

I don't think that you should fix atomicity in this cleanup patchset. At most, 
a reviewer can ask you to add a FIXME where such a fix is required.

-- 
To view, visit https://gerrit.ovirt.org/63715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca0cfa0e2254a5a8af6b3591ffe47689410415
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: fix testGetBondingOptions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: fix testGetBondingOptions
..


Patch Set 2:

* #1374328::Update tracker: OK
* Set MODIFIED::bug 1374328#1374328IGNORE, not all related patches are 
closed, check 63486

-- 
To view, visit https://gerrit.ovirt.org/63541
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: fix testGetBondingOptions

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: fix testGetBondingOptions
..


tests: fix testGetBondingOptions

Bonding options are reported only if they differ from defaults.
Bond 'mode' is exceptional, it is reported always. We are not
interested in this one as it may differ from machine to machine.

With this path we introduce new helper method which hides 'mode'
option.

Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/63424
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1374328
Reviewed-on: https://gerrit.ovirt.org/63541
---
M tests/network/netinfo_test.py
1 file changed, 11 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63541
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: introducting broken_on_ci decorator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 2:

* #1374328::Update tracker: OK
* Set MODIFIED::bug 1374328#1374328IGNORE, not all related patches are 
closed, check 63486

-- 
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: introducting broken_on_ci decorator

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: introducting broken_on_ci decorator
..


tests: introducting broken_on_ci decorator

With this decorator we skip failed test only when it was executed on
Jenkins.

Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/63407
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Martin Polednik 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1374328
Reviewed-on: https://gerrit.ovirt.org/63540
Reviewed-by: Irit Goihman 
---
M automation/check-patch.sh
M tests/network/netinfo_test.py
M tests/testValidation.py
3 files changed, 23 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: build net tests: Create a test target for networking tests.
..


build net tests: Create a test target for networking tests.

It is usefull to run only the networking test during development,
speeding the test run and allowing the developer to run them frequently
in a few seconds.

Before pushing changes, all tests should be run, including functional
ones.

Run example:
./autogen.sh --system && make pep8 pyflakes && make -C tests/ check-net

Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63649
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: build tests: Disable the builtin check target.
..


build tests: Disable the builtin check target.

There is no need to recursively check the tests/ folder for check-local
targets as there are none.

Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63646
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Irit Goihman 
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 1:

* #1374988::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374988::OK, public bug
* Check Product::#1374988::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: switch to concurrent.thread()

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: network: switch to concurrent.thread()
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/61459/13//COMMIT_MSG
Commit Message:

Line 9: This patch:
Line 10: 1. replaces good usages of threading.Thread() with
Line 11:more modern concurrent.thread()
Line 12: 2. replaces bad usages of threading.Thread() - inheritance
Line 13:with composition, leveraging concurrent.thread()
the commit message seems stale - I see no inheritance removed by this patch.
Line 14: 
Line 15: there are no intended changes in behaviour.
Line 16: 
Line 17: Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8


-- 
To view, visit https://gerrit.ovirt.org/61459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Unify stoage logger name

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: storage: Unify stoage logger name
..


storage: Unify stoage logger name

We had both "Storage" and "storage" loggers, but configuration was only
for "Storage". Unify all logger names and the configuration to
"storage", matching other loggers names.

We need more work to unify the sub loggers - I'm not touching them now
since I want to move to module level loggers or even subsystem level
loggers instead of class based loggers we have now.

Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/61261
Reviewed-by: Allon Mureinik 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/storage/clusterlock.py
M lib/vdsm/storage/fileUtils.py
M lib/vdsm/storage/hba.py
M lib/vdsm/storage/misc.py
M lib/vdsm/storage/persistent.py
M lib/vdsm/storage/volumemetadata.py
M static/etc/vdsm/logger.conf.in
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/dispatcher.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/imageRepository/formatConverter.py
M vdsm/storage/imageSharing.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/monitor.py
M vdsm/storage/multipath.py
M vdsm/storage/outOfProcess.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/resourceManager.py
M vdsm/storage/sd.py
M vdsm/storage/sdc.py
M vdsm/storage/sdm/volume_artifacts.py
M vdsm/storage/sp.py
M vdsm/storage/spbackends.py
M vdsm/storage/storageServer.py
M vdsm/storage/storage_mailbox.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/threadPool.py
M vdsm/storage/volume.py
33 files changed, 64 insertions(+), 64 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Unify stoage logger name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Unify stoage logger name
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[smelamud]

Shmuel Leib Melamud has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/storage/sdm/api/sparsify_volume.py:

Line 28: from . import base
Line 29: 
Line 30: 
Line 31: class Job(base.Job):
Line 32: def __init__(self, job_id, host_id, vol_info):
> Not any more, see the current code in master.
Done
Line 33: super(Job, self).__init__(job_id, 'sparsify_volume', host_id)
Line 34: self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True)
Line 35: 
Line 36: def _run(self):


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check Product::#734120::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Rely on system for logrotation

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: vdsm: Rely on system for logrotation
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-09-11 13:33:20 +0200
Line 6: 
Line 7: vdsm: Rely on system for logrotation
Line 8: 
Line 9: When logrotate is installed it is normaly run periodicaly by cron. There
> I am missing value of this change here. Why do we want to do it?
The value is simplification at least on the two fronts: 

1) We are duplicating code that is already present in the system. If logrotate 
is already installed it knows how to make sure it is run properly.

2) We are enforcing dependency on logrotate. The dependency is not necessary. 
See next comment.
Line 10: is no real reason to invoke logrotate manualy.
Line 11: 
Line 12: Also if we rely on system to run logrotate we can remove the dependency
Line 13: on it from RPMs. It is enough to install the configuration file into 
the


Line 10: is no real reason to invoke logrotate manualy.
Line 11: 
Line 12: Also if we rely on system to run logrotate we can remove the dependency
Line 13: on it from RPMs. It is enough to install the configuration file into 
the
Line 14: the directory with logrotate configuration.
> Based on spec change in line 134 it was installed with vdsm.
It's not our problem. Whether logrotate is installed or not should be 
administrator's decision and not ours. We are present with a .d directory where 
to put our configuration. If and how the configuraiton is used shouldn't be our 
concern (arguably in d/s, but definitely not in u/s).

NB: IIRC logrotate is installed as part of base system on RHEL and CentOS. So 
if the package is not installed there is probably a reason for that.
Line 15: 
Line 16: The patch also renames script vdsm-logrotate to vdsm-remove-logs 
because
Line 17: it doesn't run logrotate anymore. It only removes old log files.
Line 18: 


https://gerrit.ovirt.org/#/c/63682/1/static/Makefile.am
File static/Makefile.am:

Line 36:./etc/vdsm/mom.d/04-cputune.policy \
Line 37:./etc/vdsm/mom.d/05-iotune.policy \
Line 38:$(NULL)
Line 39: 
Line 40: vdsmconfrotatedir = $(sysconfdir)/logrotate.d
> This looks more like syslogrotatedir - nothing in this path is related to v
You mean to define new variable like:

syslogrotatedir=${sysconfdir}/logrotate.d

and use the variable in Makefile? (sysconfdir comes from configure)
Line 41: 
Line 42: vdsmconfrotate_DATA = \
Line 43:./etc/logrotate.d/vdsm \
Line 44:$(NULL)


https://gerrit.ovirt.org/#/c/63682/1/vdsm/vdsm-remove-logs
File vdsm/vdsm-remove-logs:

Line 20: EXITVALUE=$?
Line 21: if [ $EXITVALUE != 0 ]; then
Line 22: /usr/bin/logger -t logrotate "ALERT clean of old import log 
files exited abnormally with [$EXITVALUE]"
Line 23: fi
Line 24: fi
> Can we use logrotate for this?
That would be nice. But unfortunately I have no idea how to do that.
Line 25: 


-- 
To view, visit https://gerrit.ovirt.org/63682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[alitke]

Adam Litke has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 6:

(6 comments)

https://gerrit.ovirt.org/#/c/62002/3/tests/jobsTests.py
File tests/jobsTests.py:

Line 277: job = TestingJob(exception=exception.VdsmException())
Line 278: self.run_job(job)
Line 279: self.assertEqual(jobs.STATUS.FAILED, job.status)
Line 280: self.assertIsInstance(job.error, exception.VdsmException)
Line 281: 
> Fragile, use fake scheduler instead.
Done
Line 282: @permutations(((None, ), (Exception(),)))
Line 283: def test_autodelete_when_finished(self, error):
Line 284: cfg = make_config([('jobs', 'autodelete_delay', '10')])
Line 285: job = AutodeleteJob(exception=error)


https://gerrit.ovirt.org/#/c/62002/5/tests/jobsTests.py
File tests/jobsTests.py:

Line 75: class FakeScheduler(object):
Line 76: 
Line 77: def __init__(self):
Line 78: self.calls = []
Line 79: 
> This works, but this does not test that callable will delete job.
Good idea.  Changed.
Line 80: def schedule(self, delay, callable):
Line 81: self.calls.append((delay, callable))
Line 82: return schedule.ScheduledCall(delay, callable)
Line 83: 


Line 281: 
Line 282: @permutations(((None, ), (Exception(),)))
Line 283: def test_autodelete_when_finished(self, error):
Line 284: cfg = make_config([('jobs', 'autodelete_delay', '10')])
Line 285: job = AutodeleteJob(exception=error)
> This does not verify that the job was removed after the configured delay.
Applied your suggestion from above.
Line 286: jobs.add(job)
Line 287: with MonkeyPatchScope([(jobs, 'config', cfg)]):
Line 288: self.run_job(job)
Line 289: self.assertEqual(1, len(self.scheduler.calls))


Line 289: self.assertEqual(1, len(self.scheduler.calls))
Line 290: delay, callable = self.scheduler.calls[0]
Line 291: self.assertEqual(10, delay)
Line 292: self.assertIn(job.id, jobs.info())
Line 293: callable()
> Same
Same.
Line 294: self.assertNotIn(job.id, jobs.info())
Line 295: 
Line 296: def test_autodelete_when_aborted(self):
Line 297: cfg = make_config([('jobs', 'autodelete_delay', '10')])


https://gerrit.ovirt.org/#/c/62002/6/tests/jobsTests.py
File tests/jobsTests.py:

Line 290: delay, callable = self.scheduler.calls[0]
Line 291: self.assertEqual(10, delay)
Line 292: self.assertIn(job.id, jobs.info())
Line 293: callable()
Line 294: self.assertNotIn(job.id, jobs.info())
> Nice tests
Thanks!
Line 295: 
Line 296: def test_autodelete_when_aborted(self):
Line 297: cfg = make_config([('jobs', 'autodelete_delay', '10')])
Line 298: job = AutodeleteJob()


Line 303: delay, callable = self.scheduler.calls[0]
Line 304: self.assertEqual(10, delay)
Line 305: self.assertIn(job.id, jobs.info())
Line 306: callable()
Line 307: self.assertNotIn(job.id, jobs.info())
> Both tests are exactly the same except the line when we run or abort the jo
done.
Line 308: 
Line 309: def test_autodelete_disabled(self):
Line 310: cfg = make_config([('jobs', 'autodelete_delay', '-1')])
Line 311: job = AutodeleteJob()


-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 10: Code-Review-1

Functionality needs to move to a test run level.

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require ioprocess 0.15.2
..


Patch Set 1:

The el7 build succeeded, but it does not mean anything since we test centos 
which has 0.16.1, but on rhel 3.6 channel it is not available.

-- 
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Allow run and abort only from valid states

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63711/1/lib/vdsm/exception.py
File lib/vdsm/exception.py:

Line 345: class HostdevDetachFailed(VdsmException):
Line 346: code = 83
Line 347: message = 'Could not detach host device'
Line 348: 
Line 349: 
> After we finish with this, the new error codes should be added to engine. T
I see in the engine codes up to 77. There is bunch of missing codes which were 
already merged. I just want to make sure that those codes are properly handled.
Line 350: class CannotAbortJob(VdsmException):
Line 351: code = 84
Line 352: message = 'Job cannot be aborted from this state'
Line 353: 


-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 24: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 137: 
Line 138: legacy_switch.add_missing_networks(configurator, networks,
Line 139:bondings, _netinfo)
Line 140: 
Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, 
_netinfo)
> I think it belongs at the tail of legacy_switch.bonds_setup, no? Is there a
When bonds_setup takes place, some networks are not there and we are not able 
to tell if the bond is to be detached from bridge or not.

Well maybe we are! Do you think it would be better to pass networks to 
bonds_setup as well and check if used bridge-network is to be changed?
Line 142: 
Line 143: connectivity.check(options)
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 24: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 665: 'Reconfigurating bond %s that were detached from 
bridge', bond)
Line 666: configurator.configureBond(bond)
Line 667: 
Line 668: 
Line 669: def _ifcfg_attached_to_bridge(iface_name):
Should be implemented through the configurator API, it is ifcfg specific.
Line 670: path = NET_CONF_PREF + iface_name
Line 671: if os.path.isfile(path):
Line 672: with open(path) as f:
Line 673: for line in f.readlines():


https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 137: 
Line 138: legacy_switch.add_missing_networks(configurator, networks,
Line 139:bondings, _netinfo)
Line 140: 
Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, 
_netinfo)
I think it belongs at the tail of legacy_switch.bonds_setup, no? Is there a 
reason why it needs to be exposed at this abstraction level?
Line 142: 
Line 143: connectivity.check(options)
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 23: Code-Review-1

(1 comment)

just a nit

https://gerrit.ovirt.org/#/c/62831/23/tests/network/link_setup_test.py
File tests/network/link_setup_test.py:

PS23, Line 73: ({},
 :setup_edit_bond,
 :{},
 :config_mock)
what is this ugly column? use ugly columns for all SetupBonds or nowhere.


-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: remove default route before adding a new one

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: remove default route before adding a new one
..


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/63220/2/lib/vdsm/network/ip/address.py
File lib/vdsm/network/ip/address.py:

Line 183: if ipv4.gateway and ipv4.defaultRoute:
Line 184: try:
Line 185: ipwrapper.routeAdd(['default', 'via', ipv4.gateway])
Line 186: except ipwrapper.IPRoute2Error:  # there already is a 
default route
Line 187: ipwrapper.routeDel('default')
How about logging that we removed a route?
Line 188: ipwrapper.routeAdd(['default', 'via', ipv4.gateway])
Line 189: if ipv6:
Line 190: _add_ipv6_address(iface, ipv6)
Line 191: elif ipv6_supported():


PS2, Line 185: ipwrapper.routeAdd(['default', 'via', 
ipv4.gateway])
 : except ipwrapper.IPRoute2Error:  # there already is 
a default route
 : ipwrapper.routeDel('default')
 : ipwrapper.routeAdd(['default', 'via', 
ipv4.gateway])
worth its own function, can be shared with the ipv6 version.


-- 
To view, visit https://gerrit.ovirt.org/63220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cleanup: remove persist/unpersist calls for legacy node

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: cleanup: remove persist/unpersist calls for legacy node
..


Patch Set 4: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/63715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca0cfa0e2254a5a8af6b3591ffe47689410415
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cleanup: remove persist/unpersist calls for legacy node

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: cleanup: remove persist/unpersist calls for legacy node
..


Patch Set 4:

Douglass, this his very big and risky patch. "make rpm works, clicking 
verified" is not a valid way to verify it.

I suggest to separate to smaller patches that are easier to verify by the 
different teams.

Also, in lot of places, we could not write correct code using atomic operations 
because of the persist/unpersist requirement. Can we use now atomic write 
(write temp file, rename) on node?

-- 
To view, visit https://gerrit.ovirt.org/63715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca0cfa0e2254a5a8af6b3591ffe47689410415
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/storage/sdm/api/sparsify_volume.py:

Line 28: from . import base
Line 29: 
Line 30: 
Line 31: class Job(base.Job):
Line 32: def __init__(self, job_id, host_id, vol_info):
> copy_data do the same: Job constructor accepts host_id parameter, while Non
Not any more, see the current code in master.
Line 33: super(Job, self).__init__(job_id, 'sparsify_volume', host_id)
Line 34: self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True)
Line 35: 
Line 36: def _run(self):


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/4//COMMIT_MSG
Commit Message:

Line 9: After rhbz#1264149 we learned that way that the warnings
Line 10: module doesn't really fit the needs of Vdsm.
Line 11: 
Line 12: This patch adds and make the code use a new logger, 'devel',
Line 13: set by default to ERROR level, to be used for the messages
> Why not CRITICAL?
ERROR is good enough, since we want to use that logger for warnings. I think 
both are ok if Francesco want to change this.
Line 14: that only the developers should see.
Line 15: 
Line 16: To see more 'devel' messages, which can be useful for troubleshooting,
Line 17: edit /etc/vdsm/logger.conf to read like:


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Allow run and abort only from valid states

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63711/1/lib/vdsm/exception.py
File lib/vdsm/exception.py:

Line 345: class HostdevDetachFailed(VdsmException):
Line 346: code = 83
Line 347: message = 'Could not detach host device'
Line 348: 
Line 349: 
> It looks like those codes are unknown to the engine and would be handled as
After we finish with this, the new error codes should be added to engine. There 
is no point in adding them at this point since we did not finish the review.
Line 350: class CannotAbortJob(VdsmException):
Line 351: code = 84
Line 352: message = 'Job cannot be aborted from this state'
Line 353: 


-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: ifup: shorten name of the thread

[fromani]

Francesco Romani has posted comments on this change.

Change subject: network: ifup: shorten name of the thread
..


Patch Set 4: Verified+1

trivial patch; runned Vdsm for a while with no issues. is that sufficient or 
should I exercise this flow properly? if so, which steps do i need to take?

-- 
To view, visit https://gerrit.ovirt.org/62617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e59d97c16850521f4c45339677ee43c9f9bdd1e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: dhclient: shorten name of the thread

[fromani]

Francesco Romani has posted comments on this change.

Change subject: network: dhclient: shorten name of the thread
..


Patch Set 4: Verified+1

trivial patch; runned Vdsm for a while with no issues. is that sufficient or 
should I exercise this flow properly? if so, which steps do i need to take?

-- 
To view, visit https://gerrit.ovirt.org/62616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id413830191bebec9f17d8845e791ee66cdbcd2d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: switch to concurrent.thread()

[fromani]

Francesco Romani has posted comments on this change.

Change subject: network: switch to concurrent.thread()
..


Patch Set 13: Verified+1

trivial patch, verified running vdsm for a short while. If deeper verification 
is needed, please just tell me how I can make sure I exercise those flows.

-- 
To view, visit https://gerrit.ovirt.org/61459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/62628/5/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 57
Line 58
Line 59
Line 60
Line 61
> how is this removal related to the use of dump-volume-chains?
Done


Line 126: self.collectExtOutput("/usr/bin/iostat")
Line 127: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 128: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 129: 
Line 130: with closing(jsonrpcvdscli.connect()) as cli:
> this change can be done in different patch
Done
Line 131: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 132: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
Line 133: self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")
Line 134: self.addObjectAsFile(cli.list(), "list")


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..

sos: remove jsonrpcvdscli.connect parameters

patch https://gerrit.ovirt.org/#/c/62730/ added default value to
requestQueue parameter in jsonrpcvdscli.connect() function.
This patch removes the creation of requestQueue parameter when
connecting to jsonrpcvdscli

Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/63728/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 5939d58..3a55ef9 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -53,12 +53,6 @@
 search = os.path.join(search, name)
 return module
 
-def _connectToVdsm():
-requestQueues = config.get("addresses", "request_queues")
-requestQueue = requestQueues.split(",")[0]
-return jsonrpcvdscli.connect(requestQueue=requestQueue)
-
-config = _importVdsmPylibModule("vdsm.config").config
 jsonrpcvdscli = _importVdsmPylibModule("vdsm.jsonrpcvdscli")
 
 
@@ -133,7 +127,7 @@
 self.collectExtOutput("/sbin/iscsiadm -m node")
 self.collectExtOutput("/sbin/iscsiadm -m session")
 
-with closing(_connectToVdsm()) as cli:
+with closing(jsonrpcvdscli.connect()) as cli:
 self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
 self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
 self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")


-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mounts: Use more meaningful names

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: mounts: Use more meaningful names
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Fix un-escaping of spaces

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: mount: Fix un-escaping of spaces
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Simplify deleted suffix stripping

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: mount: Simplify deleted suffix stripping
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

Yes Nir, I really don't understand your concern, we remove here the status 
field to avoid overriding for that key. returning a list means that the value 
of vmList key is a list. all return vals are dicts and those patches don't 
change it.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yajsonrpc: switch to concurrent.thread()

[fromani]

Francesco Romani has abandoned this change.

Change subject: yajsonrpc: switch to concurrent.thread()
..


Abandoned

squashed in already-merged patch

-- 
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I42841c79e70755c0be5455949e33b84006930af0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yajsonrpc: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: yajsonrpc: switch to concurrent.thread()
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42841c79e70755c0be5455949e33b84006930af0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: WIP vm: add utility to get sublogger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP vm: add utility to get sublogger
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/61992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a378a36de93ebf2ab2b9dcf099deed44f7765b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: WIP vm: add utility to get sublogger

[fromani]

Francesco Romani has abandoned this change.

Change subject: WIP vm: add utility to get sublogger
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/61992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia1a378a36de93ebf2ab2b9dcf099deed44f7765b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: mount: Remove EL 6 /etc/mtab support
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Don't un-escape mount options

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: mount: Don't un-escape mount options
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org