Change in vdsm[master]: betterasynccore: Prevent double close
gerrit-hooks has posted comments on this change. Change subject: betterasynccore: Prevent double close .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia293deb79affc2f740d825e24ce8c66449385111 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: betterasynccore: Prevent double close
Nir Soffer has uploaded a new change for review.
Change subject: betterasynccore: Prevent double close
..
betterasynccore: Prevent double close
asyncore.dispatcher is defining a closing attribute, but never use it.
This make it possible to close a dispatcher multiple times, failing with
KeyError after the first call.
Because of the asynchronous nature of the reactor, it is very hard to
ensure that all dispatchers are closed before the reactor, so we need a
more robust close method.
This patch uses the closing attribute to eliminate double close errors.
Change-Id: Ia293deb79affc2f740d825e24ce8c66449385111
Signed-off-by: Nir Soffer
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/65209/1
diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py
index c32b54c..b86c919 100644
--- a/lib/yajsonrpc/betterAsyncore.py
+++ b/lib/yajsonrpc/betterAsyncore.py
@@ -69,6 +69,12 @@
def handle_write(self):
self._delegate_call("handle_write")
+def close(self):
+if self.closing:
+return
+self.closing = True
+asyncore.dispatcher.close(self)
+
def switch_implementation(self, impl):
self.__impl = impl
--
To view, visit https://gerrit.ovirt.org/65209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia293deb79affc2f740d825e24ce8c66449385111
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline image namespace locking
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21fe6224059f1624facd95c3a6e1ba671c7deda6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline image namespace locking
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline image namespace locking .. sp: Streamline image namespace locking Replace imageResourcesNamespace with img_ns, streamlining acquiring of image namespace locks. The namespace is used in the context of single function, mostly very small functions, so we don't need a long and descriptive name. Shorter variables names are better in such context. Change-Id: I21fe6224059f1624facd95c3a6e1ba671c7deda6 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/65040 Reviewed-by: Adam Litke Continuous-Integration: Jenkins CI --- M vdsm/storage/sp.py 1 file changed, 15 insertions(+), 24 deletions(-) Approvals: Nir Soffer: Verified Adam Litke: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21fe6224059f1624facd95c3a6e1ba671c7deda6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: Add qcow2_compat on create
gerrit-hooks has posted comments on this change. Change subject: vm: Add qcow2_compat on create .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: Add qcow2_compat on create
Nir Soffer has submitted this change and it was merged. Change subject: vm: Add qcow2_compat on create .. vm: Add qcow2_compat on create Pass qcow2 compat on create. Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538 Signed-off-by: Maor Lipchuk Reviewed-on: https://gerrit.ovirt.org/64377 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/64377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/65208/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 67: Line 68: class InvalidOutput(QImgError): Line 69: """ Line 70: Raised when the command output is not valid. Line 71: """ > You wan to use class attributes (like java static member): Done Line 72: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.ecode = 0 Line 71: """ Line 72: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.ecode = 0 > This creates an instance variable with constant value for each instance. Done Line 76: self.stdout = stdout Line 77: self.stderr = "" Line 78: self.message = message Line 79: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.ecode = 0 Line 76: self.stdout = stdout Line 77: self.stderr = "" > Same Done Line 78: self.message = message Line 79: Line 80: def __str__(self): Line 81: return "cmd=%s, stdout=%s, message=%s" % ( -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/65208/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 67: Line 68: class InvalidOutput(QImgError): Line 69: """ Line 70: Raised when the command output is not valid. Line 71: """ You wan to use class attributes (like java static member): ecode = 0 stderr = "" Unlike java, you can access these like an instance attribute: e = InvalidOutput([], "", "") e.ecode -> 0 e.stderr -> "" Line 72: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.ecode = 0 Line 71: """ Line 72: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.ecode = 0 This creates an instance variable with constant value for each instance. Line 76: self.stdout = stdout Line 77: self.stderr = "" Line 78: self.message = message Line 79: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.ecode = 0 Line 76: self.stdout = stdout Line 77: self.stderr = "" Same Line 78: self.message = message Line 79: Line 80: def __str__(self): Line 81: return "cmd=%s, stdout=%s, message=%s" % ( -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65208/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 67: Line 68: class InvalidOutput(QImgError): Line 69: """ Line 70: Raised when the command output is not valid. Line 71: """ > We can do this ugly hack to make sure that no client fail to get ecode and Done Line 72: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.stdout = stdout -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
Ala Hino has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 218 Line 219 Line 220 Line 221 Line 222 > You want to save the wrapped command, not the original. Done -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 218 Line 219 Line 220 Line 221 Line 222 You want to save the wrapped command, not the original. -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65208/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 67: Line 68: class InvalidOutput(QImgError): Line 69: """ Line 70: Raised when the command output is not valid. Line 71: """ We can do this ugly hack to make sure that no client fail to get ecode and stderr attributes from this subclass: ecode = 0 stderr = "" A better design would probably be to inherit from qemuimg.Error, and have two different sub classes, inheriting nothing from the base class. class Error(Exception): """ Base class for qemuimg errors """ CommandFailed(Error): def __init__(self, msg, cmd, rc, out, err): ... InvalidOutput(Error): def __init__(self, msg, cmd, out): ... This require changing callers to check for qemuimg.Error. Line 72: Line 73: def __init__(self, cmd, stdout, message): Line 74: self.cmd = cmd Line 75: self.stdout = stdout -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65208/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-10-06 21:31:05 +0300 Line 6: Line 7: qemuimg: Introduce InvalidOutput exception Line 8: Line 9: Raised when the command output is not valid. > Lets give some more context: Done Line 10: Line 11: Change-Id: If3f801f05f130c2417e4946877e31030260269a1 -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 86: if format:
Line 87: cmd.extend(("-f", format))
Line 88:
Line 89: cmd.append(image)
Line 90: out = _run_cmd(cmd, raw=True)
> raw=True is not needed, it enforced by _run_cmd.
Done
Line 91:
Line 92: try:
Line 93: qemu_info = _parse_qemuimg_json(out)
Line 94: except ValueError:
Line 148: if format:
Line 149: cmd.extend(("-f", format))
Line 150:
Line 151: cmd.append(image)
Line 152: out = _run_cmd(cmd, raw=True)
> raw=True is not needed, it enforced by _run_cmd.
Done
Line 153:
Line 154: try:
Line 155: qemu_check = _parse_qemuimg_json(out)
Line 156: except ValueError:
Line 360:
Line 361: def _run_cmd(cmd, cwd=None):
Line 362: rc, out, err = commands.execCmd(cmd, raw=True, cwd=cwd)
Line 363: if rc != 0:
Line 364: raise QImgError(rc, out, err)
> cmd missing
Done
--
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
Ala Hino has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 2: > (1 comment) how do I get the cmd from the CPopen instance? -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 86: if format:
Line 87: cmd.extend(("-f", format))
Line 88:
Line 89: cmd.append(image)
Line 90: out = _run_cmd(cmd, raw=True)
raw=True is not needed, it enforced by _run_cmd.
Line 91:
Line 92: try:
Line 93: qemu_info = _parse_qemuimg_json(out)
Line 94: except ValueError:
Line 148: if format:
Line 149: cmd.extend(("-f", format))
Line 150:
Line 151: cmd.append(image)
Line 152: out = _run_cmd(cmd, raw=True)
raw=True is not needed, it enforced by _run_cmd.
Line 153:
Line 154: try:
Line 155: qemu_check = _parse_qemuimg_json(out)
Line 156: except ValueError:
Line 360:
Line 361: def _run_cmd(cmd, cwd=None):
Line 362: rc, out, err = commands.execCmd(cmd, raw=True, cwd=cwd)
Line 363: if rc != 0:
Line 364: raise QImgError(rc, out, err)
cmd missing
--
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: (1 comment) Nice https://gerrit.ovirt.org/#/c/65208/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-10-06 21:31:05 +0300 Line 6: Line 7: qemuimg: Introduce InvalidOutput exception Line 8: Line 9: Raised when the command output is not valid. Lets give some more context: Raised when qemu-img command succeeded, but its output cannot be parsed or missing required properties. In this case we know that rc is 0, and stderr is probably empty, so including it in the error is not very useful. Line 10: Line 11: Change-Id: If3f801f05f130c2417e4946877e31030260269a1 -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 279: raise exception.ActionStopped()
Line 280:
Line 281: cmdutils.retcode_log_line(self._command.returncode,
self.error)
Line 282: if self._command.returncode != 0:
Line 283: raise QImgError(self._command, self._command.returncode,
"",
_commnad is a CPopen instance, not a list or arguments.
This is not your fault, this name is very bad. Please review this series fixing
this issue:
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:procwatch
Line 284: self.error)
Line 285:
Line 286: def wait_for_completion(self):
Line 287: timeout = config.getint("irs", "progress_interval")
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jobs: Fix abort semantics
Nir Soffer has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: Code-Review+1 (5 comments) https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 146 Line 147 Line 148 Line 149 Line 150 We can log here that we are starting the job. Line 132: if self.status == STATUS.PENDING: Line 133: # Autodelete should only be handled here for pending state. Line 134: # There is no operation running so we can go straight to Line 135: # aborted state. In all other cases, autodelete is handled as Line 136: # the _run method finishes. We need to log here, something like: Aborted Job xxxyyy Line 137: self._status = STATUS.ABORTED Line 138: if self.autodelete: Line 139: self._autodelete() Line 140: elif self.status == STATUS.RUNNING: Line 148: raise JobNotActive() Line 149: Line 150: def run(self): Line 151: if not self._may_run(): Line 152: return We need log info for starting the job - maybe inside _may_run? Line 153: try: Line 154: self._run() Line 155: except exception.ActionStopped: Line 156: self._abort_completed() Line 155: except exception.ActionStopped: Line 156: self._abort_completed() Line 157: except Exception as e: Line 158: self._run_failed(e) Line 159: else: For extra consistency, we can introduce _run_completed() for these lines. Line 160: with self._status_lock: Line 161: self._status = STATUS.DONE Line 162: finally: Line 163: if self.autodelete: Line 157: except Exception as e: Line 158: self._run_failed(e) Line 159: else: Line 160: with self._status_lock: Line 161: self._status = STATUS.DONE What we miss in the successful case ia log info about job completing. Line 162: finally: Line 163: if self.autodelete: Line 164: self._autodelete() Line 165: -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jobs: Fix abort semantics
gerrit-hooks has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Require explicit start of QemuImgOperation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Require explicit start of QemuImgOperation .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e427c909a8dffc3ba2a5c838c7d1e7ce7cce55d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jobs: Fix abort semantics
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3:
(7 comments)
https://gerrit.ovirt.org/#/c/65102/3/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 168
Line 169
Line 170
Line 171
Line 172
> Should raise?
Done
Line 169
Line 170
Line 171
Line 172
Line 173
> We must remove this line, _abort cannot know if the job was aborted, it is
Done
Line 152: return
Line 153: try:
Line 154: self._run()
Line 155: except exception.ActionStopped:
Line 156: self._handle_completed_abort()
> Maybe _abort_completed?
Done
Line 157: except Exception as e:
Line 158: self._handle_execution_error(e)
Line 159: else:
Line 160: # We always mark the job done. Even if we were in
aborting state
Line 154: self._run()
Line 155: except exception.ActionStopped:
Line 156: self._handle_completed_abort()
Line 157: except Exception as e:
Line 158: self._handle_execution_error(e)
> Maybe _run_failed?
Done
Line 159: else:
Line 160: # We always mark the job done. Even if we were in
aborting state
Line 161: # _run might finish normally before the abort action
executes.
Line 162: with self._status_lock:
Line 157: except Exception as e:
Line 158: self._handle_execution_error(e)
Line 159: else:
Line 160: # We always mark the job done. Even if we were in
aborting state
Line 161: # _run might finish normally before the abort action
executes.
> I think this comment is confusing, setting status to DONE in the else is pr
Done
Line 162: with self._status_lock:
Line 163: self._status = STATUS.DONE
Line 164: finally:
Line 165: if self.autodelete:
Line 162: with self._status_lock:
Line 163: self._status = STATUS.DONE
Line 164: finally:
Line 165: if self.autodelete:
Line 166: self._autodelete()
> Cannot be more elegant!
Thanks!
Line 167:
Line 168: def _prepare_to_run(self):
Line 169: with self._status_lock:
Line 170: if self.status == STATUS.ABORTED:
Line 164: finally:
Line 165: if self.autodelete:
Line 166: self._autodelete()
Line 167:
Line 168: def _prepare_to_run(self):
> May be _may_run?
Done
Line 169: with self._status_lock:
Line 170: if self.status == STATUS.ABORTED:
Line 171: logging.debug('Refusing to run aborted job %r',
self._id)
Line 172: return False
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Fix abort race in SDM.copy_data
gerrit-hooks has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c7d9aadb981e8b851a70c7ad0fdc0d75b46dc51 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception
Ala Hino has uploaded a new change for review.
Change subject: qemuimg: Introduce InvalidOutput exception
..
qemuimg: Introduce InvalidOutput exception
Raised when the command output is not valid.
Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Signed-off-by: Ala Hino
---
M lib/vdsm/qemuimg.py
1 file changed, 20 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/65208/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index 28cddee..8f6dc35 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -65,6 +65,21 @@
self.cmd, self.ecode, self.stdout, self.stderr, self.message)
+class InvalidOutput(QImgError):
+"""
+Raised when the command output is not valid.
+"""
+
+def __init__(self, cmd, stdout, message):
+self.cmd = cmd
+self.stdout = stdout
+self.message = message
+
+def __str__(self):
+return "cmd=%s, stdout=%s, message=%s" % (
+self.cmd, self.stdout, self.message)
+
+
def info(image, format=None):
cmd = [_qemuimg.cmd, "info", "--output", "json"]
@@ -79,7 +94,7 @@
try:
qemu_info = _parse_qemuimg_json(out)
except ValueError:
-raise QImgError(cmd, rc, out, err, "Failed to process qemu-img output")
+raise InvalidOutput(cmd, out, "Failed to process qemu-img output")
try:
info = {
@@ -87,7 +102,7 @@
'virtualsize': qemu_info['virtual-size'],
}
except KeyError as key:
-raise QImgError(cmd, rc, out, err, "Missing field: %r" % key)
+raise InvalidOutput(cmd, out, "Missing field: %r" % key)
if 'cluster-size' in qemu_info:
info['clustersize'] = qemu_info['cluster-size']
@@ -97,7 +112,7 @@
try:
info['compat'] = qemu_info['format-specific']['data']['compat']
except KeyError:
-raise QImgError(cmd, rc, out, err, "'compat' expected but not
found")
+raise InvalidOutput(cmd, out, "'compat' expected but not found")
return info
@@ -148,11 +163,11 @@
try:
qemu_check = _parse_qemuimg_json(out)
except ValueError:
-raise QImgError(cmd, rc, out, err, "Failed to process qemu-img output")
+raise InvalidOutput(cmd, out, "Failed to process qemu-img output")
try:
return {"offset": qemu_check["image-end-offset"]}
except KeyError:
-raise QImgError(cmd, rc, out, err, "unable to parse qemu-img check
output")
+raise InvalidOutput(cmd, out, "unable to parse qemu-img check output")
def convert(srcImage, dstImage, srcFormat=None, dstFormat=None,
--
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jobs: Fix abort semantics
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3: Code-Review+1
(7 comments)
Nice and simple!
Please check the comments.
https://gerrit.ovirt.org/#/c/65102/3/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 168
Line 169
Line 170
Line 171
Line 172
Should raise?
Line 169
Line 170
Line 171
Line 172
Line 173
We must remove this line, _abort cannot know if the job was aborted, it is
async.
Line 152: return
Line 153: try:
Line 154: self._run()
Line 155: except exception.ActionStopped:
Line 156: self._handle_completed_abort()
Maybe _abort_completed?
Line 157: except Exception as e:
Line 158: self._handle_execution_error(e)
Line 159: else:
Line 160: # We always mark the job done. Even if we were in
aborting state
Line 154: self._run()
Line 155: except exception.ActionStopped:
Line 156: self._handle_completed_abort()
Line 157: except Exception as e:
Line 158: self._handle_execution_error(e)
Maybe _run_failed?
Line 159: else:
Line 160: # We always mark the job done. Even if we were in
aborting state
Line 161: # _run might finish normally before the abort action
executes.
Line 162: with self._status_lock:
Line 157: except Exception as e:
Line 158: self._handle_execution_error(e)
Line 159: else:
Line 160: # We always mark the job done. Even if we were in
aborting state
Line 161: # _run might finish normally before the abort action
executes.
I think this comment is confusing, setting status to DONE in the else is pretty
clear to me.
Line 162: with self._status_lock:
Line 163: self._status = STATUS.DONE
Line 164: finally:
Line 165: if self.autodelete:
Line 162: with self._status_lock:
Line 163: self._status = STATUS.DONE
Line 164: finally:
Line 165: if self.autodelete:
Line 166: self._autodelete()
Cannot be more elegant!
Line 167:
Line 168: def _prepare_to_run(self):
Line 169: with self._status_lock:
Line 170: if self.status == STATUS.ABORTED:
Line 164: finally:
Line 165: if self.autodelete:
Line 166: self._autodelete()
Line 167:
Line 168: def _prepare_to_run(self):
May be _may_run?
Line 169: with self._status_lock:
Line 170: if self.status == STATUS.ABORTED:
Line 171: logging.debug('Refusing to run aborted job %r',
self._id)
Line 172: return False
--
To view, visit https://gerrit.ovirt.org/65102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Fail if abort was not called
gerrit-hooks has posted comments on this change. Change subject: tests: Fail if abort was not called .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Fail if abort was not called
Nir Soffer has uploaded a new change for review.
Change subject: tests: Fail if abort was not called
..
tests: Fail if abort was not called
The StuckJob was waiting one second and terminating silently even if the
test never called abort. Now we raise RuntimeError in this case.
Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Signed-off-by: Nir Soffer
---
M tests/jobsTests.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65207/1
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 3b39277..520c98d 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -85,7 +85,8 @@
def _run(self):
self.event_running.set()
-self.event_aborted.wait(1)
+if not self.event_aborted.wait(1):
+raise RuntimeError("Timeout waiting for abort")
def _abort(self):
self.event_aborted.set()
--
To view, visit https://gerrit.ovirt.org/65207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: protocoldetector: Fix random double close
gerrit-hooks has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: clientIF: Fix reactor life cycle
gerrit-hooks has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: protocoldetector: Fix random double close
Nir Soffer has uploaded a new change for review.
Change subject: protocoldetector: Fix random double close
..
protocoldetector: Fix random double close
Previously we stopped the reactor before closing the acceptor. This
works most of the time, but once in a while, it fails with this error:
Traceback (most recent call last):
File "vdsm/tests/protocoldetectorTests.py", line 113, in tearDown
self.acceptor.stop()
File "vdsm/lib/vdsm/protocoldetector.py", line 211, in stop
self._acceptor.close()
File "/usr/lib64/python2.7/asyncore.py", line 407, in close
self.del_channel()
File "vdsm/lib/yajsonrpc/betterAsyncore.py", line 137, in del_channel
asyncore.dispatcher.del_channel(self, map)
File "/usr/lib64/python2.7/asyncore.py", line 292, in del_channel
del map[fd]
KeyError: 63
The flow of events leading to this error is:
1. Stooping reactor, signaling the reactor thread via eventfd
2. Context switch to the reactor thread
3. Reactor find it it was closed and close all dispatchers
4. Context switch to the original thread
5. Closing acceptor, fd is not in asyncore map
This patch fixes this issue by closing the acceptor before stopping the
reactor.
Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Signed-off-by: Nir Soffer
---
M lib/vdsm/protocoldetector.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/65187/1
diff --git a/lib/vdsm/protocoldetector.py b/lib/vdsm/protocoldetector.py
index 196a2ab..e505aa7 100644
--- a/lib/vdsm/protocoldetector.py
+++ b/lib/vdsm/protocoldetector.py
@@ -207,8 +207,8 @@
def stop(self):
self.log.debug("Stopping Acceptor")
-self._reactor.stop()
self._acceptor.close()
+self._reactor.stop()
class _CannotDetectProtocol(Exception):
--
To view, visit https://gerrit.ovirt.org/65187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: clientIF: Fix reactor life cycle
Nir Soffer has uploaded a new change for review.
Change subject: clientIF: Fix reactor life cycle
..
clientIF: Fix reactor life cycle
Previously we created the reactor when initializing clientIF, and
started the reactor thread in clientIF.start(). However, the reactor was
closed from the acceptor. This works since we stop both the acceptor and
reactor during shutdown, but it is wrong design, leftover from the time
the reactor was created by the acceptor.
Things should be started and stopped in the same place. If clientIF is
starting the reactor, it should also stop it. The reactor cannot depend
on the acceptor using it.
This patch fixes the wrong dependency by stopping the reactor in
clientIF.prepareForShutdown.
Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d
Signed-off-by: Nir Soffer
---
M lib/vdsm/protocoldetector.py
M tests/protocoldetectorTests.py
M vdsm/clientIF.py
3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/65188/1
diff --git a/lib/vdsm/protocoldetector.py b/lib/vdsm/protocoldetector.py
index e505aa7..09226b9 100644
--- a/lib/vdsm/protocoldetector.py
+++ b/lib/vdsm/protocoldetector.py
@@ -208,7 +208,6 @@
def stop(self):
self.log.debug("Stopping Acceptor")
self._acceptor.close()
-self._reactor.stop()
class _CannotDetectProtocol(Exception):
diff --git a/tests/protocoldetectorTests.py b/tests/protocoldetectorTests.py
index 887a8c6..d30a6df 100644
--- a/tests/protocoldetectorTests.py
+++ b/tests/protocoldetectorTests.py
@@ -112,6 +112,8 @@
def tearDown(self):
if self.acceptor:
self.acceptor.stop()
+if self.reactor:
+self.reactor.stop()
# Testing
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index fefc915..6404e27 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -289,6 +289,7 @@
self._acceptor.stop()
for binding in self.bindings.values():
binding.stop()
+self._reactor.stop()
self._enabled = False
secret.clear()
--
To view, visit https://gerrit.ovirt.org/65188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Create all instance variables in setUp
gerrit-hooks has posted comments on this change. Change subject: tests: Create all instance variables in setUp .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0360932b3a7515fe8f87cd0ccc2cc4f6b2c90381 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance
gerrit-hooks has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance
Arik Hadas has uploaded a new change for review.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
[WIP] use libvirt domain xml prepared in advance
Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af
Signed-off-by: Arik Hadas
---
M vdsm/virt/vmxml.py
1 file changed, 30 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/65182/1
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index b868a25..ee1a381 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -22,6 +22,7 @@
import xml.dom
import xml.dom.minidom
import xml.etree.ElementTree as etree
+from xml.dom.minidom import parseString as _domParseStr
from vdsm import constants
from vdsm import cpuarch
@@ -113,8 +114,11 @@
class Element(object):
-def __init__(self, tagName, text=None, namespaceUri=None, **attrs):
-if namespaceUri is not None:
+def __init__(self, tagName, text=None, namespaceUri=None, elem=None,
+ **attrs):
+if elem is not None:
+self._elem = elem
+elif namespaceUri is not None:
self._elem = xml.dom.minidom.Document().createElementNS(
namespaceUri, tagName)
else:
@@ -149,6 +153,29 @@
class Domain(object):
def __init__(self, conf, log, arch):
+self.conf = conf
+self.log = log
+
+self.arch = arch
+
+if ('xml' in self.conf):
+self._parseDomainXml()
+else:
+self._buildSkeleton()
+
+
+def _parseDomainXml(self):
+"""
+Parse given libvirt domain xml
+"""
+self.doc = _domParseStr(self.conf['xml'])
+domainElement = self.doc.getElementsByTagName('domain')[0]
+self.dom = Element(None, elem=domainElement)
+devicesElement = self.doc.childNodes[0].\
+getElementsByTagName('devices')[0]
+self._devices = Element(None, elem=devicesElement)
+
+def _buildSkeleton(self):
"""
Create the skeleton of a libvirt domain xml
@@ -163,13 +190,7 @@
"""
-self.conf = conf
-self.log = log
-
-self.arch = arch
-
self.doc = xml.dom.minidom.Document()
-
if utils.tobool(self.conf.get('kvmEnable', 'true')):
domainType = 'kvm'
else:
@@ -200,6 +221,7 @@
self.dom.appendChild(self._devices)
self.appendMetadata()
+self.doc.appendChild(self.dom)
def appendClock(self):
"""
--
To view, visit https://gerrit.ovirt.org/65182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance
gerrit-hooks has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add the command to QImgError
Ala Hino has uploaded a new change for review. Change subject: qemuimg: Add the command to QImgError .. qemuimg: Add the command to QImgError Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Signed-off-by: Ala Hino --- M lib/vdsm/qemuimg.py 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/65179/1 diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py index c9e72ec..26d0ec1 100644 --- a/lib/vdsm/qemuimg.py +++ b/lib/vdsm/qemuimg.py @@ -53,15 +53,16 @@ class QImgError(Exception): -def __init__(self, ecode, stdout, stderr, message=None): +def __init__(self, cmd, ecode, stdout, stderr, message=None): +self.cmd = cmd self.ecode = ecode self.stdout = stdout self.stderr = stderr self.message = message def __str__(self): -return "ecode=%s, stdout=%s, stderr=%s, message=%s" % ( -self.ecode, self.stdout, self.stderr, self.message) +return "cmd=%s, ecode=%s, stdout=%s, stderr=%s, message=%s" % ( +self.cmd, self.ecode, self.stdout, self.stderr, self.message) def info(image, format=None): @@ -344,5 +345,5 @@ def _run_cmd(cmd, cwd=None): rc, out, err = commands.execCmd(cmd, raw=True, cwd=cwd) if rc != 0: -raise QImgError(rc, out, err) +raise QImgError(cmd, rc, out, err) return out -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add wrapper to execute command
Ala Hino has uploaded a new change for review.
Change subject: qemuimg: Add wrapper to execute command
..
qemuimg: Add wrapper to execute command
Add wrapper to execute qemuimg command and raise QImgError if error
encountered.
Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Signed-off-by: Ala Hino
---
M lib/vdsm/qemuimg.py
1 file changed, 11 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/65178/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index ef98149..c9e72ec 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -71,9 +71,7 @@
cmd.extend(("-f", format))
cmd.append(image)
-rc, out, err = commands.execCmd(cmd, raw=True)
-if rc != 0:
-raise QImgError(rc, out, err)
+out = _run_cmd(cmd)
try:
qemu_info = _parse_qemuimg_json(out)
@@ -125,10 +123,7 @@
if size is not None:
cmd.append(str(size))
-rc, out, err = commands.execCmd(cmd, cwd=cwdPath)
-
-if rc != 0:
-raise QImgError(rc, out, err)
+_run_cmd(cmd, cwd=cwdPath)
def check(image, format=None):
@@ -138,11 +133,7 @@
cmd.extend(("-f", format))
cmd.append(image)
-rc, out, err = commands.execCmd(cmd, raw=True)
-
-# FIXME: handle different error codes and raise errors accordingly
-if rc != 0:
-raise QImgError(rc, out, err)
+out = _run_cmd(cmd)
try:
qemu_check = _parse_qemuimg_json(out)
@@ -300,10 +291,7 @@
cmd.extend(("-f", format))
cmd.extend((image, str(newSize)))
-rc, out, err = commands.execCmd(cmd)
-
-if rc != 0:
-raise QImgError(rc, out, err)
+_run_cmd(cmd)
def rebase(image, backing, format=None, backingFormat=None, unsafe=False,
@@ -351,3 +339,10 @@
if value not in _QCOW2_COMPAT_SUPPORTED:
raise ValueError("Invalid compat version %r" % value)
return value
+
+
+def _run_cmd(cmd, cwd=None):
+rc, out, err = commands.execCmd(cmd, raw=True, cwd=cwd)
+if rc != 0:
+raise QImgError(rc, out, err)
+return out
--
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Mark integration tests
Nir Soffer has abandoned this change. Change subject: tests: Mark integration tests .. Abandoned These tests pass now on travis in master, fixed by adding missing packages. -- To view, visit https://gerrit.ovirt.org/55730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention
gerrit-hooks has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable
Nir Soffer has abandoned this change. Change subject: tests: Make the run_tests*.sh scripts readable .. Abandoned Similar change was already merged. -- To view, visit https://gerrit.ovirt.org/55729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iff09b1e71e2ca91ec3ef01490d019a893ff55b23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Nir Soffer has submitted this change and it was merged. Change subject: tests: Change offset and len arguments type .. tests: Change offset and len arguments type Change offset and len arguments type from string to integer. Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/65174 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M tests/qemuimg_test.py M tests/storagetestlib.py M tests/storagetestlib_test.py 3 files changed, 17 insertions(+), 16 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Mark integration tests
gerrit-hooks has posted comments on this change. Change subject: tests: Mark integration tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable
gerrit-hooks has posted comments on this change. Change subject: tests: Make the run_tests*.sh scripts readable .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff09b1e71e2ca91ec3ef01490d019a893ff55b23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Let move quicker. -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
gerrit-hooks has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Simplify and complete map tests
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Simplify and complete map tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/65151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie765a13167ebd6f92c2125e6e634f227606854bb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Simplify and complete map tests
Nir Soffer has abandoned this change. Change subject: qemuimg: Simplify and complete map tests .. Abandoned Squashed into previous patch -- To view, visit https://gerrit.ovirt.org/65151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie765a13167ebd6f92c2125e6e634f227606854bb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention
Nir Soffer has submitted this change and it was merged. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. tests: Rename storagetestlibTests.py to new Vdsm convention Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/65173 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI --- M tests/Makefile.am R tests/storagetestlib_test.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention
Nir Soffer has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Code-Review+1 Waiting for Adam ack. -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Code-Review+2 Looks good, hopefully we did not forget any other caller. -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention
Ala Hino has uploaded a new change for review. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. tests: Rename storagetestlibTests.py to new Vdsm convention Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Signed-off-by: Ala Hino --- M tests/Makefile.am R tests/storagetestlib_test.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/65173/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index dcb36f8..1ee0b45 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -119,7 +119,7 @@ storagefakelibTests.py \ storageMailboxTests.py \ storageServerTests.py \ - storagetestlibTests.py \ + storagetestlib_test.py \ storage_asyncevent_test.py \ storage_check_test.py \ storage_directio_test.py \ @@ -233,7 +233,7 @@ storage_volume_metadata_test.py \ storage_workarounds_test.py \ storagefakelibTests.py \ - storagetestlibTests.py \ + storagetestlib_test.py \ toolBondingTests.py \ unicode_test.py \ utilsTests.py \ diff --git a/tests/storagetestlibTests.py b/tests/storagetestlib_test.py similarity index 100% rename from tests/storagetestlibTests.py rename to tests/storagetestlib_test.py -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Ala Hino has uploaded a new change for review.
Change subject: tests: Change offset and len arguments type
..
tests: Change offset and len arguments type
Change offset and len arguments type from string to integer.
Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9
Signed-off-by: Ala Hino
---
M tests/qemuimg_test.py
M tests/storagetestlib.py
M tests/storagetestlib_test.py
3 files changed, 17 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/65174/1
diff --git a/tests/qemuimg_test.py b/tests/qemuimg_test.py
index f6e8b35..238985f 100644
--- a/tests/qemuimg_test.py
+++ b/tests/qemuimg_test.py
@@ -408,14 +408,14 @@
op.wait_for_completion()
for i in range(base, top + 1):
-offset = "{}k".format(i)
+offset = i * 1024
pattern = 0xf0 + i
# The base volume must have the data from all the volumes
# merged into it.
format = (qemuimg.FORMAT.RAW if i == 0 else
qemuimg.FORMAT.QCOW2)
qemu_pattern_verify(base_vol, format, offset=offset,
-len='1k', pattern=pattern)
+len=1024, pattern=pattern)
if i > base:
# internal and top volumes should keep the data, we
# may want to wipe this data when deleting the volumes
@@ -440,5 +440,6 @@
def make_image(path, size, format, index, qcow2_compat, backing=None):
qemuimg.create(path, size=size, format=format, qcow2Compat=qcow2_compat,
backing=backing)
-qemu_pattern_write(path, format, offset="%dk" % index, len='1k',
+offset = index * 1024
+qemu_pattern_write(path, format, offset=offset, len=1024,
pattern=0xf0 + index)
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index 24cd27e..959a5fa 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -272,16 +272,16 @@
pass
-def qemu_pattern_write(path, format, offset='512', len='1k', pattern=5):
-write_cmd = 'write -P %d %s %s' % (pattern, offset, len)
+def qemu_pattern_write(path, format, offset=512, len=1024, pattern=5):
+write_cmd = 'write -P %d %d %d' % (pattern, offset, len)
cmd = ['qemu-io', '-f', format, '-c', write_cmd, path]
rc, out, err = commands.execCmd(cmd, raw=True)
if rc != 0:
raise cmdutils.Error(cmd, rc, out, err)
-def qemu_pattern_verify(path, format, offset='512', len='1k', pattern=5):
-read_cmd = 'read -P %d -s 0 -l %s %s %s' % (pattern, len, offset, len)
+def qemu_pattern_verify(path, format, offset=512, len=1024, pattern=5):
+read_cmd = 'read -P %d -s 0 -l %d %d %d' % (pattern, len, offset, len)
cmd = ['qemu-io', '-f', format, '-c', read_cmd, path]
rc, out, err = commands.execCmd(cmd, raw=True)
if rc != 0:
@@ -304,10 +304,10 @@
# This allows us to verify the integrity of the whole chain.
for i, vol in enumerate(vol_list):
vol_fmt = sc.fmt2str(vol.getFormat())
-offset = "{}k".format(i)
+offset = i * 1024
pattern = 0xf0 + i
qemu_pattern_write(vol.volumePath, vol_fmt, offset=offset,
- len='1k', pattern=pattern)
+ len=1024, pattern=pattern)
def verify_qemu_chain(vol_list):
@@ -317,24 +317,24 @@
top_vol = vol_list[-1]
top_vol_fmt = sc.fmt2str(top_vol.getFormat())
for i, vol in enumerate(vol_list):
-offset = "{}k".format(i)
+offset = i * 1024
pattern = 0xf0 + i
# Check that the correct pattern can be read through the top volume
qemu_pattern_verify(top_vol.volumePath, top_vol_fmt, offset=offset,
-len='1k', pattern=pattern)
+len=1024, pattern=pattern)
# Check the volume where the pattern was originally written
vol_fmt = sc.fmt2str(vol.getFormat())
-qemu_pattern_verify(vol.volumePath, vol_fmt, offset=offset, len='1k',
+qemu_pattern_verify(vol.volumePath, vol_fmt, offset=offset, len=1024,
pattern=pattern)
# Check that the next offset contains zeroes. If we know this layer
# has zeroes at next_offset we can be sure that data read at the same
# offset in the next layer belongs to that layer.
-next_offset = "{}K".format(i + 1)
+next_offset = (i + 1) * 1024
qemu_pattern_verify(vol.volumePath, vol_fmt, offset=next_offset,
-len='1k', pattern=0)
+len=1024, pattern=0)
def make_qemu_chain(env, size, base_vol_fmt, chain_len):
diff --git a/tests/storagetestlib_test.py b/tests/storagetestlib_test.py
index a7d6a2c..170082d 100644
--- a/tests/storagetestlib_test.py
+++ b/test
Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention
Ala Hino has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
Ala Hino has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Remove vol_extend_policy option
Nir Soffer has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/65053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib067c09a985a633a452c476e21d8c2c073e6ca50 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Change offset and len arguments type
gerrit-hooks has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0118332c75db873c3fb8c54fc0bced208d9c50e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention
gerrit-hooks has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida07628aba9ab9813489f75c2ddd77ef6ed437e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline building domains list for upgrade
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2be0a4816d733fdae13bcb933201b1ede795ca68 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Do not use rm.acquireResource return value
gerrit-hooks has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff5653f0b15861d2034011f7fccc76bf25788f6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Rename closed property to watching
gerrit-hooks has posted comments on this change. Change subject: procwatch: Rename closed property to watching .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d6ec49a848af3ba95ebbcb70333e63b9a28b732 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Specify stdin, stdout, and stderr
gerrit-hooks has posted comments on this change. Change subject: procwatch: Specify stdin, stdout, and stderr .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a88d14f02763290116b167f83462edb28235ad2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Port to python 3
gerrit-hooks has posted comments on this change. Change subject: procwatch: Port to python 3 .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2761035a9a503ca283568e530c7b83ec53d104b6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Rename CommandStream to ProcessWatcher
gerrit-hooks has posted comments on this change. Change subject: procwatch: Rename CommandStream to ProcessWatcher .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13981d80786bda2f185851febfd40754a38282a8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Move CommandStream to new module
gerrit-hooks has posted comments on this change. Change subject: procwatch: Move CommandStream to new module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I045569d350aad19049a8a72b59e68ba91e5b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Replace command with process
gerrit-hooks has posted comments on this change. Change subject: procwatch: Replace command with process .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a0265d7847d0fffd7cf0c60d1feb87621ee5ac5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Modernize and clarify helper name
gerrit-hooks has posted comments on this change. Change subject: procwatch: Modernize and clarify helper name .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5375f57aebf977d9f78c01f1b25253d0a9b1675 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: There is no need for _private helpers
gerrit-hooks has posted comments on this change. Change subject: procwatch: There is no need for _private helpers .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c7acf9c599716527ae3b4919fc19bdbe7de5c1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: procwatch: Move test helpers to bottom
gerrit-hooks has posted comments on this change. Change subject: procwatch: Move test helpers to bottom .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5909a0016b04d67cbdeec845234bcfcb61fbde7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Remove double dict key
Nir Soffer has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05f6aeda1858e85b8660d972593e82bcb7e3bff3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Remove vol_extend_policy option
gerrit-hooks has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib067c09a985a633a452c476e21d8c2c073e6ca50 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Sort dict literal by key
gerrit-hooks has posted comments on this change. Change subject: sp: Sort dict literal by key .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I128ed804fcdbdf7b6b562f5cef662ae2ba2c9014 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Remove double dict key
gerrit-hooks has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05f6aeda1858e85b8660d972593e82bcb7e3bff3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Fix positional args calling convention
gerrit-hooks has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d73df3daa59efb512bfdc9f6e400bacb3c08c49 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline usage of image.Image class
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline usage of image.Image class .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc9de180542cd81a6d563d52b4b30b9520046469 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline acquiring of multiple images locks
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20bcebeb11f3ccbe10b029a424f4c27a890eea8c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: pep8 1.6.2 fix
gerrit-hooks has posted comments on this change. Change subject: sp: pep8 1.6.2 fix .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e561da219c31aa26d32dcb615eacf223050f5c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Remove useless continuation to a commented line
gerrit-hooks has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b8a0f989fbd55280163c54481f1748bcfff7b6a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Fix domain.produceVolume calling convention
gerrit-hooks has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id804b4754507f1c6bf4e85f006f6db6fdda2e330 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Simplify long lines using continuation \
gerrit-hooks has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51fc21b452f2f1d920ad1353d2b14067d432a837 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline calls to volume methods
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline calls to volume methods .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbdfbd5cf6a4a7345c350359e76c2156720c683 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Streamline image namespace locking
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21fe6224059f1624facd95c3a6e1ba671c7deda6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Fix domain.produceVolume calling convention
Nir Soffer has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 7: Continuous-Integration+1 Test failures not relevant. -- To view, visit https://gerrit.ovirt.org/65046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id804b4754507f1c6bf4e85f006f6db6fdda2e330 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sp: Fix positional args calling convention
Nir Soffer has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d73df3daa59efb512bfdc9f6e400bacb3c08c49 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
