Francesco Romani has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65328
To unsubscribe, visit htt
Francesco Romani has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65327
To unsubscribe, visit https:/
Francesco Romani has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/65325/4//COMMIT_MSG
Commit Message:
Francesco Romani has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe, visit https://gerrit
Francesco Romani has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65322
To unsubscribe, visit https://gerrit
Francesco Romani has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65321
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
-
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
T
Nir Soffer has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view, visi
Nir Soffer has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 4: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
Nir Soffer has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 6: Continuous-Integration+1 Verified+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
Nir Soffer has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view,
Nir Soffer has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 3: Continuous-Integration+1
Verfied on travis:
https://travis-ci.org/nirs/vdsm/builds/166549485
--
To view, visit ht
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove vol_extend_policy option
..
sp: Remove vol_extend_policy option
We had a vol_extend_policy option disabling the mailbox. This option is
not usef
Nir Soffer has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 11: Continuous-Integration+1
Jenkins el7 build is broken now, wont even start.
--
To view, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File tests/protocoldetectorTests.p
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetec
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Expose API for qemuimg map
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/65112/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 497:
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://ger
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline usage of image.Image class
..
sp: Streamline usage of image.Image class
We used to create an image.Image an call a method in one line, makin
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Fix positional args calling convention
..
sp: Fix positional args calling convention
StorageDomain.setDescription and Volume.setLegality accept one
pos
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Sort dict literal by key
..
sp: Sort dict literal by key
With more than few items, it is easier to work with sorted items, and
people are less likely t
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visi
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove double dict key
..
sp: Remove double dict key
Commit f9cf58b7bced (Make getRepoStats() a hsm method) added a second
"pool_status" key in the sam
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.
Nir Soffer has submitted this change and it was merged.
Change subject: sp: pep8 1.6.2 fix
..
sp: pep8 1.6.2 fix
Both pep8 tool and me do not like line breaks before binary operators.
Change-Id: Ic8e561da219c31aa26d32dcb615eac
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vis
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit h
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Simplify long lines using continuation \
..
sp: Simplify long lines using continuation \
Eliminate fragile and hard to read continuation \ with tempora
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline building domains list for upgrade
..
sp: Streamline building domains list for upgrade
Instead of creating a list of domain uuids, and removi
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline calls to volume methods
..
sp: Streamline calls to volume methods
When calling volume methods, we typically produce the domain, produce
the
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Do not use rm.acquireResource return value
..
sp: Do not use rm.acquireResource return value
resourceManager.acquireResource is returning now a Resourc
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Fix domain.produceVolume calling convention
..
sp: Fix domain.produceVolume calling convention
As a general rule positional args should be called as po
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To v
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Remove useless continuation to a commented line
..
sp: Remove useless continuation to a commented line
Change-Id: I7b8a0f989fbd55280163c54481f1748bcfff
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline acquiring of multiple images locks
..
sp: Streamline acquiring of multiple images locks
Replace srcImageResourcesNamespace and dstImageResou
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 3: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe, vis
Nir Soffer has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65328
To unsubsc
Nir Soffer has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit https:
Nir Soffer has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65327
To unsubscribe
Nir Soffer has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit http
Nir Soffer has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65325
To unsubscrib
Nir Soffer has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65322
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Nir Soffer has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65321
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Nir Soffer has uploaded a new change for review.
Change subject: tests: Refine TerminationTests names
..
tests: Refine TerminationTests names
- Al the test are testing termination, there is no point in repeating
the class name
Nir Soffer has uploaded a new change for review.
Change subject: tests: Use Popen.poll() for running state
..
tests: Use Popen.poll() for running state
Checking if /proc/pid exists works, but using poll() is simpler and more
cle
Nir Soffer has uploaded a new change for review.
Change subject: utils: Wait for terminated process
..
utils: Wait for terminated process
utils.terminating was not waiting for a terminated process, passing the
process to zombier
Nir Soffer has uploaded a new change for review.
Change subject: utils: Raise detectable error if termination fail
..
utils: Raise detectable error if termination fail
If terminating process failed because of unexpected error (f
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add tests for waiting on a zombie process
..
tests: Add tests for waiting on a zombie process
If a process was terminated but not waited, terminating contex
Nir Soffer has uploaded a new change for review.
Change subject: utils: Add missing Popen methods
..
utils: Add missing Popen methods
AsyncProc should have a Popen like interface, but it is missing
terminate() and send_signal()
Nir Soffer has uploaded a new change for review.
Change subject: tests: Wait for child process in tearDown
..
tests: Wait for child process in tearDown
If the code fail to terminate a child process, we must wait for child
proces
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add test for terminating a terminated process
..
tests: Add test for terminating a terminated process
In this case we should find that the process has termi
Adam Litke has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65042
To unsubscribe, visit https://gerrit.
1 - 100 of 201 matches
Mail list logo