Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65294 To unsubscribe, visit https://gerr

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65328 To unsubscribe, visit htt

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65327 To unsubscribe, visit https:/

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/65325/4//COMMIT_MSG Commit Message:

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit https://gerrit

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65322 To unsubscribe, visit https://gerrit

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65321 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 4: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 4: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- T

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 4: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view, visi

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view, visit

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 4: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 --

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view,

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 6: Continuous-Integration+1 Verified+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view,

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 3: Continuous-Integration+1 Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485 -- To view, visit ht

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Remove vol_extend_policy option .. sp: Remove vol_extend_policy option We had a vol_extend_policy option disabling the mailbox. This option is not usef

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 11: Continuous-Integration+1 Jenkins el7 build is broken now, wont even start. -- To view, visit https://gerrit.o

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File tests/protocoldetectorTests.p

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetec

Change in vdsm[master]: qemuimg: Expose API for qemuimg map

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Expose API for qemuimg map .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/65112/4/tests/qemuimg_test.py File tests/qemuimg_test.py: Line 497:

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sp: Remove double dict key

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerri

Change in vdsm[master]: sp: Sort dict literal by key

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Sort dict literal by key .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://ger

Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline usage of image.Image class .. sp: Streamline usage of image.Image class We used to create an image.Image an call a method in one line, makin

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Fix positional args calling convention .. sp: Fix positional args calling convention StorageDomain.setDescription and Volume.setLegality accept one pos

Change in vdsm[master]: sp: Sort dict literal by key

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Sort dict literal by key .. sp: Sort dict literal by key With more than few items, it is easier to work with sorted items, and people are less likely t

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view

Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline usage of image.Image class .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visi

Change in vdsm[master]: sp: Remove double dict key

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Remove double dict key .. sp: Remove double dict key Commit f9cf58b7bced (Make getRepoStats() a hsm method) added a second "pool_status" key in the sam

Change in vdsm[master]: sp: pep8 1.6.2 fix

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: pep8 1.6.2 fix .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.

Change in vdsm[master]: sp: pep8 1.6.2 fix

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: pep8 1.6.2 fix .. sp: pep8 1.6.2 fix Both pep8 tool and me do not like line breaks before binary operators. Change-Id: Ic8e561da219c31aa26d32dcb615eac

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline calls to volume methods .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit h

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Simplify long lines using continuation \ .. sp: Simplify long lines using continuation \ Eliminate fragile and hard to read continuation \ with tempora

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline building domains list for upgrade .. sp: Streamline building domains list for upgrade Instead of creating a list of domain uuids, and removi

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline calls to volume methods .. sp: Streamline calls to volume methods When calling volume methods, we typically produce the domain, produce the

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vi

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Do not use rm.acquireResource return value .. sp: Do not use rm.acquireResource return value resourceManager.acquireResource is returning now a Resourc

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To vie

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Fix domain.produceVolume calling convention .. sp: Fix domain.produceVolume calling convention As a general rule positional args should be called as po

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To v

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Remove useless continuation to a commented line .. sp: Remove useless continuation to a commented line Change-Id: I7b8a0f989fbd55280163c54481f1748bcfff

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-10 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline acquiring of multiple images locks .. sp: Streamline acquiring of multiple images locks Replace srcImageResourcesNamespace and dstImageResou

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65325 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 3: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65294 To unsubscribe, vis

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65328 To unsubsc

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit https:

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65327 To unsubscribe

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit http

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65325 To unsubscrib

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65322 To unsubscribe, visit

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65321 To unsubscribe, visit https://

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Refine TerminationTests names .. tests: Refine TerminationTests names - Al the test are testing termination, there is no point in repeating the class name

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Use Popen.poll() for running state .. tests: Use Popen.poll() for running state Checking if /proc/pid exists works, but using poll() is simpler and more cle

Change in vdsm[master]: utils: Wait for terminated process

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: utils: Wait for terminated process .. utils: Wait for terminated process utils.terminating was not waiting for a terminated process, passing the process to zombier

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: utils: Raise detectable error if termination fail .. utils: Raise detectable error if termination fail If terminating process failed because of unexpected error (f

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Add tests for waiting on a zombie process .. tests: Add tests for waiting on a zombie process If a process was terminated but not waited, terminating contex

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: utils: Add missing Popen methods .. utils: Add missing Popen methods AsyncProc should have a Popen like interface, but it is missing terminate() and send_signal()

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Wait for child process in tearDown .. tests: Wait for child process in tearDown If the code fail to terminate a child process, we must wait for child proces

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-10 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Add test for terminating a terminated process .. tests: Add test for terminating a terminated process In this case we should find that the process has termi

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65042 To unsubscribe, visit https://gerrit.

  1   2   3   >