Edward Haas has posted comments on this change.
Change subject: pep8: Fix long line in vdsm sos plugin
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65402
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3:
Edward, 2 spaces on each log line, millions of spaces per day :-)
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/65327
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6:
This version removes the now unneeded re module.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: utils: Raise detectable error if termination fail
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 5: Verified+1
This version simplifies the helpers for detecting a zombie.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Refine TerminationTests names
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for waiting on a zombie process
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/65404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: automation: Create coverage report sooner
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65414
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/65404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File
gerrit-hooks has posted comments on this change.
Change subject: pep8: Fix long line in vdsm sos plugin
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove cPopenTests.py
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: automation: Create coverage report sooner
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: automation: Create coverage report sooner
..
automation: Create coverage report sooner
For some reason a build artifacts step was inserted before creating the
Nir Soffer has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/65150/5/tests/storage_sdm_copy_data_test.py
File
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Explicit run semantics for QemuImgOperation
..
Patch Set 5: Code-Review-1
(10 comments)
https://gerrit.ovirt.org/#/c/65148/5/lib/vdsm/qemuimg.py
File
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 5: Code-Review+1
(1 comment)
Francesco, would take another look?
https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py
Nir Soffer has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 6: Verified+1
Verified locally and on travis:
https://travis-ci.org/nirs/vdsm/builds/167181752
--
To
Nir Soffer has posted comments on this change.
Change subject: tests: Remove cPopenTests.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65407
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove cPopenTests.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: tests: Remove cPopenTests.py
..
tests: Remove cPopenTests.py
We kept an old and broken version of cpopen tests in vdsm when cpopen
was separated into a standalone
Jenkins CI has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 1
--
Nir Soffer has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 2:
Few tests fail when running via tox, not sure why. Some of the tests (cpopen)
should be removed anyway,
gerrit-hooks has posted comments on this change.
Change subject: build: Ensure nose 1.3.7 is used for tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Ensure nose 1.3.7 is used for tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: tests: Ensure nose 1.3.7 is used for tests
..
tests: Ensure nose 1.3.7 is used for tests
Run the tests via tox, installing the correct version of nose in a
gerrit-hooks has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 5: Verified+1
copying score, no code change
--
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 1: Verified+1
Tested locally.
--
To view, visit https://gerrit.ovirt.org/65403
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: pep8: Fix long line in sos plugin
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65402
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: pep8: Fix long line in sos plugin
..
pep8: Fix long line in sos plugin
Change-Id: I81c2f558f7e34505b9873a8b379f88339859f589
Signed-off-by: Nir Soffer
gerrit-hooks has posted comments on this change.
Change subject: pep8: Fix long line in sos plugin
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: build: Replace pep8 and pyflakes with flake8
..
build: Replace pep8 and pyflakes with flake8
flake8 is an extensible and configurable tool combining pep8,
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 45:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 52:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 34:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: WIP: docs: add tutorial
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 32:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has uploaded a new change for review.
Change subject: WIP: docs: add tutorial
..
WIP: docs: add tutorial
Probably not worth merging
Change-Id: I3a9e947c30f2978fd9670fd64d99bf380181aa9c
Signed-off-by: Francesco
Piotr Kliczewski has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3:
I checked and it was not used on master, 3.6 and 4.0 engine.
What you need to do is to remove following
Milan Zamazal has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(10 comments)
I tried to address all the suggestions for improvements, so hopefully we can
move
Piotr Kliczewski has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 4: Code-Review+1
(3 comments)
Minor date in copyrights update but the patch looks good.
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3: Code-Review-1
please drop buildtime from lib/api/vdsm-api.yml as well.
(ask piotr how to do that properly)
--
Piotr Kliczewski has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3:
Updating yml spec file should be enough. Before we will merge I will make sure
that it was really not used on
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make DomainDescriptor use XML helpers
..
virt: Make DomainDescriptor use XML helpers
We are going to stop using xml.dom.minidom and to use xml.etree
Francesco Romani has posted comments on this change.
Change subject: static: move man under static
..
Patch Set 5: Code-Review+1
(3 comments)
https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am
File static/Makefile.am:
Francesco Romani has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 6: Code-Review+1
(1 comment)
Moving to static/ -> +2
hardcoding paths? not really sure. So just
Francesco Romani has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 1: Code-Review+2
(2 comments)
worth switching now to logging.exception()? no big deal, your
Francesco Romani has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3: Code-Review+2
farewell to this unused bit.
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe,
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4:
(1 comment)
I investigated this a little and we can get the device size with libvirt call
Andrej Krejcir has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65288
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 1: Verified+1
network test failures...
--
To view, visit https://gerrit.ovirt.org/65379
To
Martin Polednik has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 33:
(11 comments)
https://gerrit.ovirt.org/#/c/59824/33/lib/vdsm/virt/containers/command.py
gerrit-hooks has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 7:
* #1341106::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1341106::OK, public bug
*
Michal Skrivanek has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3: Code-Review+1
I casually checked engine 3.0 and it's not used there either
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 44:
The code is somewhat fine considering the TODOs, but question remains: if I
install
gerrit-hooks has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 2:
* #1348255::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1348255::OK, public bug
*
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py
Francesco Romani has submitted this change and it was merged.
Change subject: Add all MOM calls to jsonrpc client
..
Add all MOM calls to jsonrpc client
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832#1373832OK, already on MODIFIED
Francesco Romani has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 1:
run 'make check' locally and manually with no issues.
--
To view, visit https://gerrit.ovirt.org/65378
Francesco Romani has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/65378
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832#1373832OK
--
To view,
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 1:
Run 'make check' manually. Unrelated, known test failures.
--
To view, visit
Francesco Romani has submitted this change and it was merged.
Change subject: Fix return value names for VM.ioTune calls
..
Fix return value names for VM.ioTune calls
Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65378
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/64243/2//COMMIT_MSG
Commit Message:
Line
Martin Polednik has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 23: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/60481/23/vdsm/virt/vmxml.py
File
gerrit-hooks has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: static: move man under static
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
1 - 100 of 116 matches
Mail list logo
