Change in vdsm[master]: cleanup: remove persist/unpersist calls for legacy node

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cleanup: remove persist/unpersist calls for legacy node .. Patch Set 4: could you find the time to split this up,

Change in vdsm[master]: tests: Avoid global state modification using forked

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Avoid global state modification using forked .. Patch Set 1: -Code-Review (1 comment)

Change in vdsm[master]: net: dhclient.is_active result caching due to slowdown

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: dhclient.is_active result caching due to slowdown .. Patch Set 1: (4 comments)

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 11: Code-Review+2 -- To view,

Change in vdsm[refs/meta/config]: Modify Permissions for VDSM project

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Modify Permissions for VDSM project .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66573

Change in vdsm[master]: autoconf: make data-center location customizable

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: autoconf: make data-center location customizable .. autoconf: make data-center location customizable

Change in vdsm[master]: autoconf: make data-center location customizable

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: autoconf: make data-center location customizable .. Patch Set 38: Code-Review+2 -- To view, visit

Change in vdsm[master]: virt: Don't crash on missing in MutableDomainDescri...

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Don't crash on missing in MutableDomainDescriptor .. virt: Don't crash on missing in

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 10: Verified+1 failure is not

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 9: (4 comments)

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 9: unrelated failure 10:09:15

Change in vdsm[master]: tests: Avoid global state modification using forked

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Avoid global state modification using forked .. Patch Set 1: (2 comments)

Change in vdsm[master]: containers: tests: reduce duplication

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: containers: tests: reduce duplication .. containers: tests: reduce duplication Kill some leftovers from the

Change in vdsm[master]: containers: tests: reduce duplication

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: containers: tests: reduce duplication .. Patch Set 10: Code-Review+2 -- To view, visit

Change in vdsm[master]: containers: tests: reduce duplication

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: containers: tests: reduce duplication .. Patch Set 10: raising -- To view, visit https://gerrit.ovirt.org/67124 To

Change in vdsm[master]: tests: deeper libvirtconnection test

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: deeper libvirtconnection test .. Patch Set 2: (1 comment)

Change in vdsm[master]: storage: move threadPool module to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move threadPool module to vdsm storage lib .. Patch Set 5: Verified+1 -- To view, visit

Change in vdsm[master]: virtio-scsi: add support for IO threads

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virtio-scsi: add support for IO threads .. virtio-scsi: add support for IO threads virtio-scsi supports

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-11-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 11: (2 comments)

Change in vdsm[master]: py3: take Queue from six.moves

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: py3: take Queue from six.moves .. Patch Set 2: Verified+1 passes QE tier1 -- To view, visit

Change in vdsm[master]: storage: move outOfProcess module to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move outOfProcess module to vdsm storage lib .. Patch Set 8: Verified+1 passes QE tier1 -- To view, visit

Change in vdsm[master]: storage: move threadPool module to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move threadPool module to vdsm storage lib .. Patch Set 5: passes QE tier1 -- To view, visit

Change in vdsm[master]: storage: move iscsi.py to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move iscsi.py to vdsm storage lib .. Patch Set 6: Verified+1 passes QE tier1 -- To view, visit

Change in vdsm[master]: storage: move imageSharing.py to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move imageSharing.py to vdsm storage lib .. Patch Set 6: Verified+1 passes QE tier1 -- To view, visit

Change in vdsm[master]: storage: move iscsiadm.py to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move iscsiadm.py to vdsm storage lib .. Patch Set 6: Verified+1 passes QE tier1 -- To view, visit

Change in vdsm[master]: storage: move imagetickets.py to vdsm storage lib

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: storage: move imagetickets.py to vdsm storage lib .. Patch Set 6: Verified+1 passes QE tier1 -- To view, visit

Change in vdsm[master]: tests: Mark flaky tests on travis as broken

2016-11-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: tests: Mark flaky tests on travis as broken .. Patch Set 3: Code-Review+1 -- To view, visit

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 8: (4 comments)

Change in vdsm[master]: tests: Avoid global state modification using forked

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Avoid global state modification using forked .. Patch Set 1: Code-Review-1 (2 comments)

Change in vdsm[master]: Adding simple client for sending gauge metrics to statsd por...

2016-11-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding simple client for sending gauge metrics to statsd port using udp .. Patch Set 8: (1 comment)