Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has restored this change. ( https://gerrit.ovirt.org/81155 )

Change subject: [wip] fix vmdevices.storage.makeName
..


Restored

wrong click. Francesco can abandon again if needed

-- 
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81150 )

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
..


Abandoned

was a silly attempt to debug the CI failure

-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81155 )

Change subject: [wip] fix vmdevices.storage.makeName
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80859 )

Change subject: move sitecustomize to static
..


move sitecustomize to static


Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Signed-off-by: Piotr Kliczewski 
---
M Makefile.am
M static/Makefile.am
R static/usr/share/vdsm/sitecustomize.py
M tests/run_tests_local.sh.in
M vdsm/Makefile.am
5 files changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ovs-dpdk: support ovs 2.7

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80818 )

Change subject: ovs-dpdk: support ovs 2.7
..


ovs-dpdk: support ovs 2.7

Compatibility with the old dpdk naming is broken in ovs 2.7, and as
such a device will not be available for use until a valid dpdk-devargs is
specified.
When adding dpdk devices to ovs bridge, the PCI address must be
set using the 'dpdk-devargs' option.
Device naming is arbitrary.

Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Signed-off-by: Irit Goihman 
---
M lib/vdsm/network/link/dpdk.py
M lib/vdsm/network/ovs/driver/__init__.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/network/ovs/switch.py
M vdsm.spec.in
5 files changed, 15 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Edward Haas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ovs-dpdk: support ovs 2.7

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ovs-dpdk: support ovs 2.7
..


Patch Set 7:

unrelated failure

ERROR: test_with_device (loopback_test.TestDevice)
--
Traceback (most recent call last):
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/testValidation.py",
 line 191, in wrapper
return f(*args, **kwargs)
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback_test.py",
 line 42, in test_with_device
with loopback.Device(filename) as device:
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py",
 line 92, in __enter__
self.attach()
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py",
 line 56, in attach
raise cmdutils.Error(cmd, rc, out, err)
Error: Command ['losetup', '--find', '--show', '/tmp/tmpzf6_TD/file'] failed 
with rc=1 out='' err='losetup: /tmp/tmpzf6_TD/file: failed to set up loop 
device: No such file or directory\n'

-- 
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80819 )

Change subject: automation: Fix - Add iproute-tc package to fc25
..


automation: Fix - Add iproute-tc package to fc25

On recent fedora25, the tc tool has been extracted out of iproute
package and moved to its own package.
This package is now added as a VDSM dependency (used by
vdsm-networking for QoS).

This patch fixes an older patch where the dependency has not been
correctly added to the spec file:
e23586b6d9c913786b06ec063649c8eb56d73a49

Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Signed-off-by: Edward Haas 
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/80819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/80859/6/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

PS6, Line 21: @top_srcdir@/vdsm
I think that this should be dropped. nothing is left there.


-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Fix exploding tox

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/81172 )

Change subject: Fix exploding tox
..


Fix exploding tox

It seems that a new 'pluggy' version (0.5.0) was added in PyPi and this
causes check-patch.sh to explode when trying to create the Python 3.x
environments.

This patch forces installation of pluggy 0.4.0 or lower.

Change-Id: Ie68af2b3e749f3c670d5031402ea2d10840fd770
Signed-off-by: Barak Korren 
---
M automation/check-patch.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Edward Haas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/81172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie68af2b3e749f3c670d5031402ea2d10840fd770
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Barak Korren 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/80859/5/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

Line 17: NOSE_EVAL_ATTR \
Line 18: NOSE_LOGFORMAT='%(asctime)s %(levelname)-5s (%(threadName)s) 
[%(name)s] %(message)s (%(module)s:%(lineno)d)' \
Line 19: NOSE_VERBOSE=${NOSE_VERBOSE:-3} \
Line 20: PYTHONDONTWRITEBYTECODE=1 \
Line 21: 
PYTHONPATH="@top_srcdir@/static/usr/share/vdsm:@top_srcdir@/lib:@top_srcdir@/vdsm:@top_srcdir@/client:@top_srcdir@/vdsm_api:$PYTHONPATH"
 \
why is this needed?
Line 22: $NULL
Line 23: 
Line 24: "$PYTHON_EXE" @top_srcdir@/tests/testrunner.py --local-modules $@ &
Line 25: runner_pid=$!


-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 5:

ok, now I recalled. so why do you need to add the static path it in 
run_tests_local ?

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: introduce restore_subscriptions in client

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78919 )

Change subject: stomp: introduce restore_subscriptions in client
..


stomp: introduce restore_subscriptions in client

restore_subscriptions is required for persisting subscriptions
after client reconnects to server.

Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncClientTests.py
2 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/78919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: introduce restore_subscriptions in client

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: introduce restore_subscriptions in client
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: calls are now blocking

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: calls are now blocking
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/81167
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia23da36d261251ddd4484479fc4214c461467c86
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/81088/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Enabled selinux boolean virt_use_glusterd for glusterd
Line 8: 
Line 9: bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1458257
Line 10: 
redundant empty line, and please use capital letter for Bug-Url: ..
Line 11: Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12


-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/81088/1/lib/vdsm/tool/configurators/sebool.py
File lib/vdsm/tool/configurators/sebool.py:

Line 1: # Copyright 2012 Red Hat, Inc.
please change to 2012-2017
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 5:

mmm... I don't see any usage of this thing... why not just to remove it ?

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: [wip] fix vmdevices.storage.makeName
..

[wip] fix vmdevices.storage.makeName

it should mimic 
http://elixir.free-electrons.com/linux/latest/ident/sd_format_disk_name

Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/virt/vmdevices/storage.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/81155/1

diff --git a/lib/vdsm/virt/vmdevices/storage.py 
b/lib/vdsm/virt/vmdevices/storage.py
index a67d4f8..f34deb7 100644
--- a/lib/vdsm/virt/vmdevices/storage.py
+++ b/lib/vdsm/virt/vmdevices/storage.py
@@ -806,8 +806,10 @@
 devindex = ''
 
 i = int(index)
-while i > 0:
+while True:
 devindex = chr(ord('a') + (i % 26)) + devindex
-i //= 26
+i = i // 26 - 1
+if i < 0:
+break
 
 return devname.get(interface, 'hd') + (devindex or 'a')


-- 
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: metrics: stop sending host metrics except storage

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80050 )

Change subject: metrics: stop sending host metrics except storage
..


metrics: stop sending host metrics except storage

stop sending host metrics except storage
to statsd, since they will be collected by collectd.

Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Bug-Url: https://bugzilla.redhat.com/1469109
Signed-off-by: Shirly Radco 
---
M lib/vdsm/host/api.py
1 file changed, 0 insertions(+), 40 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shirly Radco 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Hello Jenkins CI, gerrit-hooks, Irit Goihman, Edward Haas,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/81150

to review the following change.

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
..

Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

This reverts commit 936e6cc89aec8fb6a5894382ea1a349979c3fc06.

Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/81150/1

diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py
index 64930c9..cff51b9 100644
--- a/lib/vdsm/network/ovs/switch.py
+++ b/lib/vdsm/network/ovs/switch.py
@@ -124,8 +124,7 @@
 nic = attrs.get('nic')
 bond = attrs.get('bonding')
 sb = nic or bond
-if not dpdk.is_dpdk(sb):
-self._acquired_ifaces.add(sb)
+self._acquired_ifaces.add(sb)
 
 bridge = self._get_ovs_bridge(sb)
 self._create_nb(bridge, net)


-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/81150 )

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
..


Uploaded patch set 1.

-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: revert
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: automation: Fix - Add iproute-tc package to fc25
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dpdk: add only non dpdk nics to aqcuired ifaces

2017-08-29 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80688 )

Change subject: dpdk: add only non dpdk nics to aqcuired ifaces
..


dpdk: add only non dpdk nics to aqcuired ifaces

Acquirement should not be done on DPDK based ifaces
since the actions are not supported on these devices.

Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Signed-off-by: Irit Goihman 
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Edward Haas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org