Assaf Muller has posted comments on this change.
Change subject: Ifcfg: Fix file writing races
..
Patch Set 1: Code-Review+1
Wow, big up Antoni... Sounds like a painful debug session.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 9: Verified-1 Code-Review-1
(2 comments)
New generateTableId won't work for IPv6 addresses whose value
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
Will do.
File
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20803
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1:
A note to future selves: There is an open 3.4 target release bug whose solution
will introduce an API
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1: -Code-Review
Dan, if you do end up using vdsm-tool then you might want to use the upgrade
mechanism :)
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
File
Assaf Muller has uploaded a new change for review.
Change subject: Fix minor network functional tests issues
..
Fix minor network functional tests issues
Some tests were asserting that networks existed based on out
of date
Assaf Muller has posted comments on this change.
Change subject: Fix minor network functional tests issues
..
Patch Set 1: Verified+1
Touched functional tests still work.
--
To view, visit http://gerrit.ovirt.org/20859
To
Assaf Muller has uploaded a new change for review.
Change subject: Change netinfo gateway default value from 0.0.0.0 to ''
..
Change netinfo gateway default value from 0.0.0.0 to ''
Previously, if a device does not have an ip
Assaf Muller has posted comments on this change.
Change subject: Change netinfo gateway default value from 0.0.0.0 to ''
..
Patch Set 1: Verified+1
Verification:
Passes all unit and functional tests.
Engine behaves correctly
Assaf Muller has posted comments on this change.
Change subject: Change netinfo gateway default value from 0.0.0.0 to ''
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/20912
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Change netinfo gateway default value from 0.0.0.0 to ''
..
Patch Set 2:
Jenkins failures are unrelated to this patch.
--
To view, visit
Assaf Muller has uploaded a new change for review.
Change subject: Remove onboot, delay from setupNetworks API
..
Remove onboot, delay from setupNetworks API
The engine never sends those keys. If they are sent, however,
as part
Assaf Muller has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol
..
Patch Set 11: Verified+1
Empty rebase.
--
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 13:
(5 comments)
Commit
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 14: Verified+1
Verification:
Compared manually what the unified network
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 11:
Jenkins failure unrelated to patch's code.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Remove onboot, delay from setupNetworks API
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/20967
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Transmogrify netinfo gateway default value from 0.0.0.0 to ''
..
Patch Set 2:
(2 comments)
Commit Message
Assaf Muller has posted comments on this change.
Change subject: Remove onboot, delay from setupNetworks API
..
Patch Set 1:
(1 comment)
Commit Message
Line 12:
Line 13:
Assaf Muller has posted comments on this change.
Change subject: Remove onboot, delay from setupNetworks API
..
Patch Set 1:
(1 comment)
Commit Message
Line 12:
Line 13:
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/20803
To unsubscribe, visit
Assaf Muller has uploaded a new change for review.
Change subject: Add lib/tool/restore_nets.py to debian/vdsm-python-install
..
Add lib/tool/restore_nets.py to debian/vdsm-python-install
Change-Id:
Assaf Muller has posted comments on this change.
Change subject: Transmogrify netinfo gateway default value from 0.0.0.0 to ''
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20912
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: iproute2 ip link wrapper
..
Patch Set 8:
(1 comment)
File lib/vdsm/netinfo.py
Line 78:
Line 79:
Assaf Muller has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol
..
Patch Set 12:
(3 comments)
File lib/vdsm/netinfo.py
Line 471:
Line
Assaf Muller has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit
Assaf Muller has uploaded a new change for review.
Change subject: Add unit tests for unified network persistence
..
Add unit tests for unified network persistence
Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21269
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Remove onboot, delay, forward_delay from setupNetworks API
..
Patch Set 2: Verified+1
Verification - Sent onboot, ONBOOT, delay, DELAY and forward_delay as
Assaf Muller has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 14:
(1 comment)
File tests/netinfoTests.py
Assaf Muller has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 6:
(1 comment)
File
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 4:
(2 comments)
File
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/21269
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 4:
(1 comment)
File
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 6: Verified+1
The test that fails on Jenkins works on my host.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
(9 comments)
Pushing new patch set in a second...
I had an offline session with
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 17:
Patch set 17 is a rebase.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Makes getIfaceByIp return a set instead of a string
..
Patch Set 2:
Now the test passes on hosts running python-ethtool-0.6-5.el6.x86_64.
I suggest we merge
Assaf Muller has uploaded a new change for review.
Change subject: Mark netinfoTests.testGetIfaceByIP as a broken test
..
Mark netinfoTests.testGetIfaceByIP as a broken test
The test has been failing since python-ethtool-0.6-5.
Assaf Muller has uploaded a new change for review.
Change subject: Add ipwrapper.routeGet
..
Add ipwrapper.routeGet
Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da
Signed-off-by: Assaf Muller amul...@redhat.com
---
M
Assaf Muller has posted comments on this change.
Change subject: Add ipwrapper.routeGet
..
Patch Set 1: Code-Review-1
Did not mean to push this patch yet :)
--
To view, visit http://gerrit.ovirt.org/21470
To unsubscribe,
Assaf Muller has posted comments on this change.
Change subject: Makes getIfaceByIp return a set instead of a string
..
Patch Set 2:
I suggest we abandon and merge:
http://gerrit.ovirt.org/#/c/21471/
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Makes getIfaceByIp return a set instead of a string
..
Patch Set 2: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/21197
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Mark netinfoTests.testGetIfaceByIP as a broken test
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21471
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Mark netinfoTests.testGetIfaceByIP as a broken test
..
Patch Set 2:
It shouldn't, no.
--
To view, visit http://gerrit.ovirt.org/21471
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 3:
netinfo.getRouteTo is missing a test - I plan to add a functional test which
will bring up a dummy nic,
Assaf Muller has posted comments on this change.
Change subject: Mark netinfoTests.testGetIfaceByIP as a broken test
..
Patch Set 2:
Sorry about that. Here's the context:
The problem with getIfaceByIP as it is now is in the
Assaf Muller has posted comments on this change.
Change subject: execCmd: Make loggign when successful optional
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21515
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 16:
(3 comments)
Commit
Assaf Muller has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 4: Verified+1
Patch 4: Rebased off latest master, and changed from:
getRouteTo(destinationIP=None)
To:
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 14:
(3 comments)
File
Assaf Muller has uploaded a new change for review.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Added lib/vdsm/utils.py:touchFile
Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820
Signed-off-by: Assaf Muller
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21590
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: netconf: Add limit to rollback for recursive configurator
..
Patch Set 2: Code-Review-1
There's some sort of rebase issue?
There is no
Assaf Muller has posted comments on this change.
Change subject: netconf: Add limit to rollback for recursive configurator
..
Patch Set 4:
With the current approach the before_setup_networks hook doesn't know if the
current
Assaf Muller has uploaded a new change for review.
Change subject: Optimize netinfo.py:get()
..
Optimize netinfo.py:get()
Changed from 4 iterations of links to 1.
Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0
Assaf Muller has posted comments on this change.
Change subject: Optimize netinfo.py:get()
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Assaf Muller has posted comments on this change.
Change subject: Optimize netinfo.py:get()
..
Patch Set 2:
(5 comments)
File lib/vdsm/ipwrapper.py
Line 230: Returns a
Assaf Muller has posted comments on this change.
Change subject: Prettify/simplify netinfo.py:get()
..
Patch Set 3:
(3 comments)
File lib/vdsm/netinfo.py
Line 525:
Assaf Muller has posted comments on this change.
Change subject: Prettify/simplify netinfo.py:get()
..
Patch Set 4:
The Jenkins failure is really weird and worrying, I'm looking into it.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Prettify/simplify netinfo.py:get()
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/21652
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Prettify/simplify netinfo.py:get()
..
Patch Set 4:
It seems like the testing suite is calling the setup code before VDSM is ready
to answer the initial
Assaf Muller has posted comments on this change.
Change subject: Prettify/simplify netinfo.py:get()
..
Patch Set 4:
(1 comment)
File lib/vdsm/netinfo.py
Line 540:
Assaf Muller has posted comments on this change.
Change subject: netconfpersistence: overload the subtraction operator
..
Patch Set 1:
I think that I suggested to use the sub operator in the first place, but now
that I
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 1:
(2 comments)
File lib/vdsm/utils.py
Line 102: path =
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21590
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21590
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 4: Verified-1
Needs more work. Fails vdsGetCaps on a local host.
--
To view, visit
Assaf Muller has uploaded a new change for review.
Change subject: Made ipwrapper.py:Route class more robust
..
Made ipwrapper.py:Route class more robust
Change-Id: Id2d62ad31bd9d5c7bea28605a0b195c1886f0dab
Signed-off-by: Assaf
Assaf Muller has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21788
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Made ipwrapper.py:Route class more robust
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21788
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: Added lib/vdsm/utils.py:touchFile
..
Patch Set 3:
(1 comment)
File lib/vdsm/utils.py
Line 110: updated
Assaf Muller has posted comments on this change.
Change subject: Report device to engine in a new fashion
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/21470
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 2: Code-Review-1
Had an off-line review session with Toni. Currently the design allows an
Assaf Muller has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1:
I did test the offending patch on a machine with no networks (Remember I had
trouble with libvirt and
Assaf Muller has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1: Code-Review+1
Investigated into it and talked to Toni. I took a lot of time to get a host
running with no
Assaf Muller has uploaded a new change for review.
Change subject: Added netinfoTests:testGetEmpty
..
Added netinfoTests:testGetEmpty
The new test should prevent the regression introduced in:
http://gerrit.ovirt.org/#/c/21652/
Assaf Muller has posted comments on this change.
Change subject: Added netinfoTests:testGetEmpty
..
Patch Set 1: Verified+1
I ran the unit test without Toni's fix and the test picked up the regression.
The test passes with
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 18:
(1 comment)
File
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 3:
(5 comments)
File init/vdsmd_init_common.sh.in
Line
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(1 comment)
File
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(1 comment)
File
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 16:
There's still outstanding comments by Yaniv (I haven't forgotten them).
--
To view,
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(6 comments)
File
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 17: Verified+1
All outstanding comments handled.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/18425
To
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 3:
(1 comment)
File vdsm/clientIF.py
Line 394:
Assaf Muller has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge This hook
support binding specified mac address to custom/other bridge than the currently
defined bridge in ovirt. This hook is also capable of binding a mac address to
Assaf Muller has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge This hook
support binding specified mac address to custom/other bridge than the currently
defined bridge in ovirt. This hook is also capable of binding a mac address to
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/20803
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3:
If an admin used the CLI to configure QoS with only average - Caps would return
a
Assaf Muller has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3: Code-Review+1
(1 comment)
Please add qosInbound and qosOutbound to the
Assaf Muller has posted comments on this change.
Change subject: vm: janitorial: replace file() with open()
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22034
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: netconf: Make vdsm-restore-net-config use _inRollback
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21977
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21868
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 1:
Do you really want to use the _parse method of Link? I think that It's easier
to maintain the code when you
1 - 100 of 536 matches
Mail list logo
