Douglas Schilling Landgraf has posted comments on this change.
Change subject: setup: configure selinux for sanlock on nfs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: build: improve the gitignore Makefile check
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: remove MAC address from vds unique id
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#833425 Change source of CPU sockets/cores to libvirt
..
Patch Set 15: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Store engine web CA cert in engine_web_ca.pem
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Adding new resourceFactory that only opens fd
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: proposed cleanup for Amador's patch
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8302
Douglas Schilling Landgraf has posted comments on this change.
Change subject: proposed cleanup for Amador's patch
..
Patch Set 3:
Looks good to me, however I do believe Amador will take this change and send a
new version of
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#833425 Change source of CPU sockets/cores to libvirt
..
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4: Abandoned
Get deprecated by: http://gerrit.ovirt.org/#/c/8038/
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: setNetworking(): set bridge status
..
setNetworking(): set bridge status
Currently, if the bridge for some reason is not created, users are
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setNetworking(): set bridge status
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8345
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Change source of CPU sockets/cores to libvirt capabilities
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setup: move the the certificate generation
..
Patch Set 1:
humm, IMHO, I still think we could use `if isOvirt` in init script and persist
the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setup: move the certificate generation
..
Patch Set 2:
Agreed with Alon comment about node.
--
To view, visit http://gerrit.ovirt.org/8368
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg does not use traceroute for quite some time
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: specfile: require selinux-policy 3.10.0-149
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: generate deployUtil.py and config.py
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8511
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: generate deployUtil.py and config.py
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8511
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Validating number of required args in spmStart()
..
Patch Set 1: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Validating number of required args in spmStart()
..
Patch Set 1: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage: set block schedule elevator using udev
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Don't require fingerprint
..
Patch Set 1: No score
I have generated a ISO for tests and looks like the issue still exists. I will
keep digging it
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setup: configure selinux for sanlock on nfs
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: sos/vdsm.py: Add vdsm-reg dir
..
sos/vdsm.py: Add vdsm-reg dir
Collect file(s) from /etc/vdsm-reg
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos/vdsm.py: Add vdsm-reg dir
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8756
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Validating number of required args in spmStart()
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Don't require fingerprint
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Thanks Juan!
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirt_password: remove new line char
..
libvirt_password: remove new line char
Do not generate different passwords.
In the past we created the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 4: I would prefer that you didn't submit this
agreed with dan's comment
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: generate deployUtil.py and config.py
..
Patch Set 1: (1 inline comment)
Commit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: generate deployUtil.py and config.py
..
Patch Set 2:
I will push a shorter commit msg...
--
To view, visit http://gerrit.ovirt.org/8511
Douglas Schilling Landgraf has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
..
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
Looks good to me, however, can
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 2: Looks good to me, but someone else must approve
looks good to me, we
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4530
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 3: (1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 3: (1 inline comment)
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configure.ac: pyflakes/python-pep8 reduce to warn
..
configure.ac: pyflakes/python-pep8 reduce to warn
Replace error message for warning message
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configure.ac: pyflakes/python-pep8 reduce to warn
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8939
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: pyflakes/python-pep8 BuildRequirement
..
vdsm.spec: pyflakes/python-pep8 BuildRequirement
pyflakes and python-pep8 are not default RHEL
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: pyflakes/python-pep8 BuildRequirement
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8940
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: clienteIF: replace MOM self.log.error to warn
..
clienteIF: replace MOM self.log.error to warn
If mom package is not installed, at this point vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: clienteIF: replace MOM self.log.error to warn
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9132
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Alert if vdsm log has wrong user\group permissions
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
vdsm.spec: Add vdsm-xmlrpc as Requirement
For vdsm-json stuff and vdsm initialization, we should
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9136
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9136
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
Patch Set 2:
I got this error if vdsm-xmlrpc is not installed:
# systemctl start vdsmd.service
#
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
Patch Set 2:
Forgot to share, tested on F18...
--
To view, visit http://gerrit.ovirt.org/9136
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
Patch Set 2:
thanks Dan, I will provide a new patch with your description.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add vdsm-xmlrpc as Requirement
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9136
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configure.ac: check python-pthreading module
..
configure.ac: check python-pthreading module
Adding AX_PYTHON_MODULE macro to check if
Douglas Schilling Landgraf has posted comments on this change.
Change subject: logging: report the node hostname when vdsm starts
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Handle a race where it takes some time fot the cmdline to
disappear after killing a process
..
Patch Set 1: Verified; Looks good to me, but someone
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix problem where a 0 error code will cause remoteFileHandler
to become a zombie
..
Patch Set 7: Verified; Looks good to me, but someone else must
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Integrate zombie reaper in test framework
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Implement a zombie reaper
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8937
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: add the sebool configuration module
..
Patch Set 2: Looks good to me, but someone else must approve
Much better. I just noticed that you
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: add the sebool configuration module
..
Patch Set 2:
Ah, just noticed that you changed the order of files... sorry the confusion,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: add the nested virtualization hook
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: Add packages versions for rhel7
..
vdsm.spec: Add packages versions for rhel7
Add macro for RHEL7 packages.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
..
Patch Set 1: I would prefer that you didn't submit this
I think I will submit a new version.
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
..
Patch Set 1: No score
No need new version
--
To view, visit http://gerrit.ovirt.org/9428
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
..
Patch Set 1: (2 inline comments)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9428
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: forceVMstart: Initial commit
..
Patch Set 3:
Hi Pablo, thanks for bringing it to upstream, adding Dan for review as well.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9428
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: Move mom requirement to Fedora condition
..
vdsm.spec: Move mom requirement to Fedora condition
Mom requirement is based on oVirt 3.2,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Move mom requirement to Fedora condition
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9515
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Move mom requirement
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9515
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: storage/misc.py: fix raise call for pep8
..
storage/misc.py: fix raise call for pep8
The commit 08b9f16a6213298b31ca68f2c89556f0b23874a4
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage/misc.py: fix raise call for pep8
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9523
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage/misc.py: fix raise call for pep8
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9523
To unsubscribe, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: storage/misc.py: fix raise call for pep8
..
Patch Set 2: Abandoned
http://danken.fedorapeople.org/python-pep8-1.3.3-3.el6.noarch.rpm resolve the
issue.
--
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Extract a method _getCapsXMLStr() to get capabilities from
libvirt
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Prepare each vm volumes instead of prepare blockSD
..
Patch Set 7: I would prefer that you didn't submit this
agreed with Saggi's comments.
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: our tests requires 'import selinux'
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg/define.py: drop unused file
..
Patch Set 1: Looks good to me, but someone else must approve
You are right Dan.
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vmfex hook: generating rpm
..
vmfex hook: generating rpm
Generate vmfex rpm with others hooks.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vmfex hook: generating rpm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9829
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Online check ksmState and ksmPages.
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
Test:
# vdsClient -s 0 getVdsStats |
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Checking accessibility to vdsm log file
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: two minor beautifications
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: caps.py: osversion() validate OVIRT
..
caps.py: osversion() validate OVIRT
Currently we are only validating RHEV-H node.
This patch will validate
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps.py: osversion() validate OVIRT
..
Patch Set 1:
I have created python script to verify the output of osversion., also tried to
upgrade via
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: caps.py: osversion() validate OVIRT
..
caps.py: osversion() validate OVIRT
Currently we are only validating RHEV-H node.
This patch will validate
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps.py: osversion() validate OVIRT
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10177
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: require policycoreutils and skip sebool errors
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Make advanced process invocations part of execCmd
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tests: Test schema validity
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10050
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: increase selinux-policy for rhel distro
..
vdsm.spec: increase selinux-policy for rhel distro
sanlock_use_fusefs was introduced in
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: increase selinux-policy for rhel distro
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10622
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: python-ordereddict only for rhel 7
..
vdsm.spec: python-ordereddict only for rhel 7
rhel7 contains python 2.7 which already includes
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: python-ordereddict only for rhel 7
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10649
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel = 7
..
vdsm.spec: BuildRequires: python-pthreading for rhel = 7
Adding python-pthreading as
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel = 7
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel = 7
..
Patch Set 1:
Mark, I got the point and agreed, thanks!
--
To view, visit
101 - 200 of 1676 matches
Mail list logo
