Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 16:
(1 comment)
http://gerrit.ovirt.org/#/c/28244/16/vdsm_reg/vdsm-upgrade
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: utils: must unpersist files for remove
..
Abandoned
Abandoned since this gerrit should cover soon:
http://gerrit.ovirt.org/#/c/28879/
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 17:
jenkins failure (needs to update the jenkins repo):
Error: Package:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 17:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: ifcfg: use oVirt node's to remove files
..
Patch Set 4: Verified+1 Code-Review+1
nice to have it as soon as possible in master! :)
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28356
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: log: Remove metadata.log
..
Patch Set 1: Code-Review+1
please verify
--
To view, visit http://gerrit.ovirt.org/28903
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator.py: Node unpersist must be called before removing
a file.
..
Patch Set 2:
(1 comment)
Please proceed with this patch.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 17:
(2 comments)
http://gerrit.ovirt.org/#/c/28244/17/vdsm.spec.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 18:
looks like now it's jenkins error:
03:48:14 ERROR:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29279
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29279
to review the following change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
vdsm-upgrade: adds
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29213
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdscli: no need to generate using autoconf
..
Patch Set 3: Code-Review+1
go for it
--
To view, visit http://gerrit.ovirt.org/28676
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator.py: fix _removeFile to do as described in it's doc
string.
..
Patch Set 7:
(1 comment)
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: move reconfigure logic from %postun to %post
..
spec: move reconfigure logic from %postun to %post
During the upgrade process, the %postun
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: move reconfigure logic from %postun to %post
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29364
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Remove non-existing requirement
..
Patch Set 1: Code-Review-1
+1 for abandon since we now have the packages available.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator.py: call Node's delete() for file deletion on node.
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28821
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
libvirt_configure.sh: Unpersist logrotate libvirt
Before commenting previous logrotate
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29731
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: deployUtil: add %s for logging call
..
deployUtil: add %s for logging call
In commit d78b36b50 introduces a logging call missing
%s which
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: add %s for logging call
..
Patch Set 1: Verified+1
pretty urgent for master branch.
--
To view, visit http://gerrit.ovirt.org/29819
Douglas Schilling Landgraf has posted comments on this change.
Change subject: upgrade: fix seal persistence for oVirt node
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29545
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
Patch Set 1:
for the new schema let's add Mooli.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
Patch Set 1:
(1 comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/29731
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure.sh: Unpersist logrotate libvirt
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/29731/2//COMMIT_MSG
Commit Message:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Arrange pthreading requirement to 0.1.3-3 which includes
locked() impl
..
Patch Set 2: Code-Review+1
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Arrange pthreading requirement to 0.1.3-3 which includes
locked() impl
..
Patch Set 2:
this version is available in the stable branch of Fedora
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Arrange pthreading requirement to 0.1.3-3 which includes
locked() impl
..
Patch Set 2:
rhel6.5 is downstream build.
Centos 6 Yes
Fedora 19 Yes
Douglas Schilling Landgraf has abandoned this change.
Change subject: spec: move reconfigure logic from %postun to %post
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/29364
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: connectivity log: add to spec with proper ownership
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30507
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: connectivity log: add to spec with proper ownership
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30576
To unsubscribe,
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: test gerrit
..
test gerrit
Change-Id: I2c92bd32ac52acabf0c47b1be0fa60334bfd0313
---
A test-gerrit
1 file changed, 0 insertions(+), 0 deletions(-)
Douglas Schilling Landgraf has abandoned this change.
Change subject: test gerrit
..
Patch Set 1: Abandoned
test only, testing gerrit from my side.
--
To view, visit http://gerrit.ovirt.org/266
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 1:
During my tests I have used
http://IP:8080/ENGINEanagerWeb/RegisterServlet/register.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 1:
I know that the URL I have used was generated because a wrong sed command that
will be
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 1: I would prefer that you didn't submit this
Hello Roy,
Looking the file:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vds_boostrap: rename rhevm to engine
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
I have tested this change, worked
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 2:
Moved to POST BZ753879 and BZ753571
--
To view, visit http://gerrit.ovirt.org/310
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: replace /rhev repository to /ovirt
..
replace /rhev repository to /ovirt
This patch will fix the below behaviour and will remove all /rhev
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: deployUtil: isOvirt() check oVirt release
..
deployUtil: isOvirt() check oVirt release
Adding support to isOvirt() to validate oVirt Node
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
..
Patch Set 1:
Going to provide a new version without the space character in the end. git diff
--check
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: storage/misc.py: Add validation to oVirt Node
..
storage/misc.py: Add validation to oVirt Node
Check if /etc/ovirt-node-image-release exists too
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 2:
Roy,
Can you please update the commit message and include the BZ# 752464? If you
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: [WIP] scripts: Add oVirt validation
..
[WIP] scripts: Add oVirt validation
Change-Id: Ice28890457e6329c245aaa99057958d7555f4c05
---
M vdsm.spec.in
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: change registration servlet name
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm/caps.py: getos() include oVirt Node
..
Patch Set 1:
Agreed, I am preparing a much better patch.
--
To view, visit http://gerrit.ovirt.org/454
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vds_boostrap: rename rhevm to engine
..
Patch Set 4:
Sorry Ayal, just ignore this patchset. I was trying to create a remote branch.
:/
--
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: deployUtil.py.in: setService() add support to restart vdsm
daemon on ovirt Node
..
deployUtil.py.in: setService() add support to restart vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
..
Patch Set 3:
There is another patch which will change vdsmd.init.in.
http://gerrit.ovirt.org/455
--
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil.py.in: add support to restart vdsmd
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps.py/clientIF/libvirtvm: include oVirt Node
..
Patch Set 4: I would prefer that you didn't submit this
I will prepare a new version of this
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
vdsm.spec.in/vdsm.rwtab: create /rhev repository
Currently, the repository /rhev is not
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 1: (1 inline comment)
File
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsmd.8: update man page to reference oVirt
..
vdsmd.8: update man page to reference oVirt
Replace any remaining reference from RHEV to oVirt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.8: update man page to reference oVirt
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/550
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps.py: include oVirt Node to OSName
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/454
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage/misc.py: Add validation to oVirt Node
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/453
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
..
Patch Set 3: (3 inline comments)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
..
Patch Set 3: (2 inline comments)
File
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec.in: Requires: tree
..
vdsm.spec.in: Requires: tree
vdsm-sosplugin.py requires the /usr/bin/tree command.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in: Requires: tree
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/555
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: fix typo
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/580
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 2:
Agreed Dan, new patch will be fix that.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 4:
Hi,
I have tested it only building a new vdsm rpm and it worked. Currently, my
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 4:
Just to share that mburns could reproduce my oVirt Node installation error.
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 4: (2 inline comments)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 3: (1 inline comment)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#716573 make `ulimit -u` configurable, too
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Support changing retransmission number and timeout for nfs
mounts
..
Patch Set 2: Looks good to me, but someone else must approve
Just a note
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 5: I would prefer that you didn't submit this
going to provide a new version. I got
Douglas Schilling Landgraf has abandoned this change.
Change subject: replace /rhev repository to /var/lib/vdsm
..
Patch Set 3: Abandoned
We are going with /rhev directory for now.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Add ovirt_functions script
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/455
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: rename rhevm bridge to brVDSM
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/311
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 7: Verified
I could start/stop a vm (with CDROM attached)
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Add ovirt_functions script
..
Patch Set 4:
Agreed Dan, commit message fixed. Thanks!
--
To view, visit http://gerrit.ovirt.org/455
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage_connection: fix mount.Mount() argument
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
..
Patch Set 8: No score; I would prefer that you didn't submit this
Dan, please wait a little bit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: rename rhevm bridge to brVDSM
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/311
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: mount.py: fix __init()__
..
mount.py: fix __init()__
Add missing parameter (timeout).
Also, added timeout as parameter for 2 callers inside
Douglas Schilling Landgraf has posted comments on this change.
Change subject: mount.py: fix __init()__
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: mount.py: fix __init()__
..
Patch Set 4:
going to improve the commit message. New version ...
--
To view, visit http://gerrit.ovirt.org/734
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: create /rhev repository
..
Patch Set 10: Verified
Dan, I have rebased my code and applied your suggestions to the code.
Currenlyt, I can start,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: create /rhev repository
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: deployUtil: replace rhevm cert to engine
..
deployUtil: replace rhevm cert to engine
This patch will replace the rhevm cert to engine
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: make vds_bootstrap executable again
..
Patch Set 1:
Hello Haim,
Curious question, are you facing any problem that requires shebang to make it
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: replace bridge name from brVDSM to engine
..
replace bridge name from brVDSM to engine
Change-Id: I8115192b65b431e8066313bda357f8aa86880c86
---
M
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add Fedora support to vdsm-bootstrap
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/767
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add Fedora support to vdsm-bootstrap
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
801 - 900 of 1676 matches
Mail list logo