Change in vdsm[master]: sdm: Move create_volume parent uuids into separate type

2016-04-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: sdm: Move create_volume parent uuids into separate type .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55830 To unsubscribe, visit ht

Change in vdsm[master]: qemuimg: Make QCOW2_COMPAT configurable

2016-04-14 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54759 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: qemuimg: Validate qcow2_compat configuration

2016-04-14 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: qemuimg: Validate qcow2_compat configuration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56110 To unsubscribe, visit https://gerri

Change in vdsm[master]: qemuimg: Validate qcow2_compat configuration

2016-04-15 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: qemuimg: Validate qcow2_compat configuration .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56110 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-3.6]: virt: storage: avoid empty serials to domain XML

2016-04-18 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: virt: storage: avoid empty serials to domain XML .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56274 To unsubscribe, visit https://g

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

2016-04-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[ovirt-3.6]: qemuimg: Make QCOW2_COMPAT configurable

2016-04-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56522 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-3.6]: qemuimg: Validate qcow2_compat configuration

2016-04-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: qemuimg: Validate qcow2_compat configuration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56523 To unsubscribe, visit https://gerri

Change in vdsm[master]: Refactor metadata operations

2016-04-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: Refactor metadata operations .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52671 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

2016-04-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52672 To unsubscribe, visit https://gerr

Change in vdsm[master]: mount: Streamline backing file path building

2016-04-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: mount: Streamline backing file path building .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56518 To unsubscribe, visit https://gerri

Change in vdsm[master]: mounts: Use more meaningful names

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: mounts: Use more meaningful names .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56551 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: mount: Simplify deleted suffix stripping

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: mount: Simplify deleted suffix stripping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56548/1/lib/vdsm/storage/mount.py File lib/vdsm/storage/mount

Change in vdsm[master]: mount: Simplify deleted suffix stripping

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: mount: Simplify deleted suffix stripping .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56548 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: tests: Add missing test for deleted mounts

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: tests: Add missing test for deleted mounts .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56547 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: tests: Add tests for un-escaping spaces

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: tests: Add tests for un-escaping spaces .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56549 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: storage: move threadPool module to vdsm storage lib

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move threadPool module to vdsm storage lib .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56571/1/vdsm/storage/storage_mailbox.py File vdsm

Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib

2016-04-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/56575/3/vdsm/storage/sdm/api/base.py File vdsm/s

Change in vdsm[master]: storage: organize imports in misc.py

2016-04-26 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: organize imports in misc.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56613 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: storage: move threadPool module to vdsm storage lib

2016-04-26 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move threadPool module to vdsm storage lib .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56571 To unsubscribe, visit https:

Change in vdsm[master]: storage: move outOfProcess module to vdsm storage lib

2016-04-26 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move outOfProcess module to vdsm storage lib .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/56576/6/tests/outOfProcessTests.py File tests/o

Change in vdsm[master]: storage: move misc module to vdsm storage lib

2016-04-26 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move misc module to vdsm storage lib .. Patch Set 1: (9 comments) https://gerrit.ovirt.org/#/c/56614/1/tests/mountTests.py File tests/mountTests.py:

Change in vdsm[master]: storage: move fuser module to vdsm storage lib

2016-04-26 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move fuser module to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56620 To unsubscribe, visit https://ger

Change in vdsm[master]: storage: move clusterlock.py to vdsm storage lib

2016-04-27 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move clusterlock.py to vdsm storage lib .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56641 To unsubscribe, visit https://g

Change in vdsm[master]: storage: move misc module to vdsm storage lib

2016-04-27 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move misc module to vdsm storage lib .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56614 To unsubscribe, visit https://gerr

Change in vdsm[master]: storage: move curlImgWrap.py to vdsm storage lib

2016-04-27 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move curlImgWrap.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56642 To unsubscribe, visit https://g

Change in vdsm[master]: storage: move clusterlock.py to vdsm storage lib

2016-04-27 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move clusterlock.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56641 To unsubscribe, visit https://g

Change in vdsm[master]: storage: organize imports in imageSharing.py

2016-05-04 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: organize imports in imageSharing.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56890 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: move misc module to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move misc module to vdsm storage lib .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56614 To unsubscribe, visit https://gerr

Change in vdsm[master]: storage: organize imports in devicemapper.py

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: organize imports in devicemapper.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56887 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: move devicemapper.py to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move devicemapper.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56888 To unsubscribe, visit https://

Change in vdsm[master]: storage: move hba.py to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move hba.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56889 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: storage: move imageSharing.py to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move imageSharing.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56891 To unsubscribe, visit https://

Change in vdsm[master]: storage: organize imports in iscsiadm.py

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: organize imports in iscsiadm.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56893 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: storage: move imagetickets.py to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move imagetickets.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56892 To unsubscribe, visit https://

Change in vdsm[master]: storage: move iscsiadm.py to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move iscsiadm.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56894 To unsubscribe, visit https://gerr

Change in vdsm[master]: storage: organize imports in iscsi.py

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: organize imports in iscsi.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56895 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: storage: move iscsi.py to vdsm storage lib

2016-05-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move iscsi.py to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56896 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: storage: move outOfProcess module to vdsm storage lib

2016-05-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move outOfProcess module to vdsm storage lib .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56576 To unsubscribe, visit http

Change in vdsm[master]: storage: move iscsi.py to vdsm storage lib

2016-05-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move iscsi.py to vdsm storage lib .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56896 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: storage: organize imports in iscsi.py

2016-05-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: organize imports in iscsi.py .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56895 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: storage: move misc module to vdsm storage lib

2016-05-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move misc module to vdsm storage lib .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56614 To unsubscribe, visit https://gerr

Change in vdsm[master]: storage: move hba.py to vdsm storage lib

2016-05-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move hba.py to vdsm storage lib .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56889 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: storage: move devicemapper.py to vdsm storage lib

2016-05-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move devicemapper.py to vdsm storage lib .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56888 To unsubscribe, visit https://

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-05-10 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55987 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-3.6]: issci: Fix equality and hash when username or password are None

2015-12-23 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: issci: Fix equality and hash when username or password are None .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50939 To unsubscribe,

Change in vdsm[ovirt-3.6]: iscsi: Fix credentials initialization when not using CHAP

2015-12-23 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: iscsi: Fix credentials initialization when not using CHAP .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50940 To unsubscribe, visit

Change in vdsm[master]: fileSD: improve error handling in deleteImage

2015-12-23 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: fileSD: improve error handling in deleteImage .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50804 To unsubscribe, visit https://gerr

Change in vdsm[master]: fileSD: use fileVolume constants for file extensions

2015-12-23 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: fileSD: use fileVolume constants for file extensions .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51040 To unsubscribe, visit https

Change in vdsm[master]: storage: perform image deletion in task

2015-12-27 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: perform image deletion in task .. Patch Set 7: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/48477/7//COMMIT_MSG Commit Message: Line 14: de

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

2016-01-03 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50631 To unsubscribe, visit http

Change in vdsm[master]: build: update libvirt dependency for fedora

2016-01-04 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/51295 to review the following change. Change subject: build: update libvirt dependency for fedora .. build: update libvirt depend

Change in vdsm[ovirt-3.6]: fileSD: Do not try to remove non-existent lease file

2016-01-04 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: fileSD: Do not try to remove non-existent lease file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51132 To unsubscribe, visit https

Change in vdsm[master]: build: update libvirt dependency for fedora

2016-01-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: build: update libvirt dependency for fedora .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/51295 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: VolumeMetadata: move refreshVolume

2016-01-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: move refreshVolume .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42003 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

2016-01-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: move newVolumeLease .. Patch Set 24: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42002 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: VolumeMetadata: volume share utilities

2016-01-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: volume share utilities .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42004 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-3.6]: build: update libvirt dependency for fedora

2016-01-05 Thread frolland
Hello Nir Soffer, Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/51369 to review the following change. Change subject: build: update libvirt dependency for fedora .. build: update li

Change in vdsm[ovirt-3.6]: build: update libvirt dependency for fedora

2016-01-05 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: build: update libvirt dependency for fedora .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51369 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: localFsSD: Use the right manifest.

2016-02-18 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: localFsSD: Use the right manifest. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53688 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: fileUtils: Add atomic_symlink utility

2016-02-24 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: fileUtils: Add atomic_symlink utility .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53680 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

2016-03-06 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info .. Patch Set 11: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/53785/11//COMMIT_MSG Commit

Change in vdsm[master]: storage: create lib storage directory

2016-03-06 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54381 to review the following change. Change subject: storage: create lib storage directory .. storage: create lib storage direct

Change in vdsm[master]: storage: create lib storage directory

2016-03-06 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: create lib storage directory .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54381 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: storage: create lib storage directory

2016-03-06 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: create lib storage directory .. Patch Set 1: Verified by : - Build RPM - Install - Check that dir is created [root@RHEL7 /]# ll /usr/lib/python2.7/sit

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-07 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54404 to review the following change. Change subject: storage: Move constants module to site-packages .. storage: Move constants

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: Move securable module to site-packages

2016-03-07 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54424 to review the following change. Change subject: storage: Move securable module to site-packages .. storage: Move securable

Change in vdsm[master]: storage: add storage folder to spec

2016-03-07 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54431 to review the following change. Change subject: storage: add storage folder to spec .. storage: add storage folder to spec

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/fileSD.py File vdsm/storage/file

Change in vdsm[master]: spec: add virt and netinfo dir in spec

2016-03-07 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54439 to review the following change. Change subject: spec: add virt and netinfo dir in spec .. spec: add virt and netinfo dir in

Change in vdsm[master]: storage: add storage folder to spec

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: add storage folder to spec .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54431 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: storage: Move securable module to site-packages

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54424 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://gerri

Change in vdsm[master]: virt: Add the missing tests for Drive.getLeasesXML

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: virt: Add the missing tests for Drive.getLeasesXML .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54324 To unsubscribe, visit https:/

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: (12 comments) https://gerrit.ovirt.org/#/c/54404/2/lib/vdsm/storage/Makefile.am File lib/vdsm/s

Change in vdsm[master]: storage: Move securable module to site-packages

2016-03-07 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: (10 comments) https://gerrit.ovirt.org/#/c/54424/2/lib/vdsm/storage/Makefile.am File lib/vdsm/s

Change in vdsm[master]: hsm: group vdsm imports in hsm.py

2016-03-08 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54451 to review the following change. Change subject: hsm: group vdsm imports in hsm.py .. hsm: group vdsm imports in hsm.py Gro

Change in vdsm[master]: storage: Move storage_exception module to lib

2016-03-08 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54467 to review the following change. Change subject: storage: Move storage_exception module to lib .. storage: Move storage_exce

Change in vdsm[master]: spec: add virt and netinfo dir in spec

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54439 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: hsm: group vdsm imports in hsm.py

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: hsm: group vdsm imports in hsm.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54451 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: spec: add virt and netinfo dir in spec

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 2: I verified by installing and check that the directories were removed. Before this patch the directories w

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: Move constants module to site-packages

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: Move securable module to site-packages

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/54424 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: Move storage_exception module to lib

2016-03-08 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 4: (8 comments) https://gerrit.ovirt.org/#/c/54467/4/tests/functional/storageTests.py File tests/fun

Change in vdsm[master]: storage: Move storage_exception module to lib

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 6: (7 comments) https://gerrit.ovirt.org/#/c/54467/6/debian/vdsm-python.install File debian/vdsm-pyt

Change in vdsm[master]: storage: add copyright info

2016-03-09 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54508 to review the following change. Change subject: storage: add copyright info .. storage: add copyright info Add copyright i

Change in vdsm[master]: imagetickets: add tests

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py File vdsm/storage/imageti

Change in vdsm[master]: storage: add copyright info

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterSD.py File vdsm/storage/glusterSD.py: Line 1

Change in vdsm[master]: storage: add copyright info

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: storage: Move storage_exception module to lib

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: storage: Move storage_exception module to lib

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: (8 comments) https://gerrit.ovirt.org/#/c/54467/7/tests/blockVolumeTests.py File tests/blockVolum

Change in vdsm[master]: storage: Move storage_exception module to lib

2016-03-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: qemuimg: Add missing validation for qcow2 format

2016-05-15 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: qemuimg: Add missing validation for qcow2 format .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57456 To unsubscribe, visit https://g

Change in vdsm[master]: tests: Separate broken test from good tests

2016-05-16 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: tests: Separate broken test from good tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57481 To unsubscribe, visit https://gerrit

Change in vdsm[master]: directio: Keep line terminators in readlines()

2016-05-16 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: directio: Keep line terminators in readlines() .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54701 To unsubscribe, visit https://ger

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

2016-05-16 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: directio: Add failing test for DirectFile.readlines() .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54694 To unsubscribe, visit http

Change in vdsm[master]: directio: Add test for reading entire file

2016-05-16 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: directio: Add test for reading entire file .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54700 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: misc: Remove unused readspeed function

2016-05-16 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: misc: Remove unused readspeed function .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57471 To unsubscribe, visit https://gerrit.ovir

<    1   2   3   4   5   6   >