Freddy Rolland has posted comments on this change.
Change subject: sdm: Move create_volume parent uuids into separate type
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55830
To unsubscribe, visit ht
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit https://gerrit.ovi
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Validate qcow2_compat configuration
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56110
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Validate qcow2_compat configuration
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56110
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: virt: storage: avoid empty serials to domain XML
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56274
To unsubscribe, visit https://g
Freddy Rolland has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit https://gerrit.ovirt.
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56522
To unsubscribe, visit https://gerrit.ovi
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Validate qcow2_compat configuration
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56523
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/sett
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Add from_lines factory method
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerr
Freddy Rolland has posted comments on this change.
Change subject: mount: Streamline backing file path building
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56518
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit https://gerrit.ovirt.org
Freddy Rolland has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56548/1/lib/vdsm/storage/mount.py
File lib/vdsm/storage/mount
Freddy Rolland has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: tests: Add missing test for deleted mounts
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56547
To unsubscribe, visit https://gerrit.
Freddy Rolland has posted comments on this change.
Change subject: tests: Add tests for un-escaping spaces
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56549
To unsubscribe, visit https://gerrit.ovi
Freddy Rolland has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56571/1/vdsm/storage/storage_mailbox.py
File vdsm
Freddy Rolland has posted comments on this change.
Change subject: storage: move threadLocal module to vdsm storage lib
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/56575/3/vdsm/storage/sdm/api/base.py
File vdsm/s
Freddy Rolland has posted comments on this change.
Change subject: storage: organize imports in misc.py
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56613
To unsubscribe, visit https://gerrit.ovirt.
Freddy Rolland has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56571
To unsubscribe, visit https:
Freddy Rolland has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/56576/6/tests/outOfProcessTests.py
File tests/o
Freddy Rolland has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 1:
(9 comments)
https://gerrit.ovirt.org/#/c/56614/1/tests/mountTests.py
File tests/mountTests.py:
Freddy Rolland has posted comments on this change.
Change subject: storage: move fuser module to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56620
To unsubscribe, visit https://ger
Freddy Rolland has posted comments on this change.
Change subject: storage: move clusterlock.py to vdsm storage lib
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56641
To unsubscribe, visit https://g
Freddy Rolland has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerr
Freddy Rolland has posted comments on this change.
Change subject: storage: move curlImgWrap.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56642
To unsubscribe, visit https://g
Freddy Rolland has posted comments on this change.
Change subject: storage: move clusterlock.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56641
To unsubscribe, visit https://g
Freddy Rolland has posted comments on this change.
Change subject: storage: organize imports in imageSharing.py
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56890
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerr
Freddy Rolland has posted comments on this change.
Change subject: storage: organize imports in devicemapper.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56887
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56888
To unsubscribe, visit https://
Freddy Rolland has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56889
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: storage: move imageSharing.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56891
To unsubscribe, visit https://
Freddy Rolland has posted comments on this change.
Change subject: storage: organize imports in iscsiadm.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56893
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: storage: move imagetickets.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56892
To unsubscribe, visit https://
Freddy Rolland has posted comments on this change.
Change subject: storage: move iscsiadm.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56894
To unsubscribe, visit https://gerr
Freddy Rolland has posted comments on this change.
Change subject: storage: organize imports in iscsi.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56895
To unsubscribe, visit https://gerrit.ovirt
Freddy Rolland has posted comments on this change.
Change subject: storage: move iscsi.py to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56896
To unsubscribe, visit https://gerrit.
Freddy Rolland has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56576
To unsubscribe, visit http
Freddy Rolland has posted comments on this change.
Change subject: storage: move iscsi.py to vdsm storage lib
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56896
To unsubscribe, visit https://gerrit.
Freddy Rolland has posted comments on this change.
Change subject: storage: organize imports in iscsi.py
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56895
To unsubscribe, visit https://gerrit.ovirt
Freddy Rolland has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerr
Freddy Rolland has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56889
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56888
To unsubscribe, visit https://
Freddy Rolland has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: issci: Fix equality and hash when username or password are None
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50939
To unsubscribe,
Freddy Rolland has posted comments on this change.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50940
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: fileSD: improve error handling in deleteImage
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerr
Freddy Rolland has posted comments on this change.
Change subject: fileSD: use fileVolume constants for file extensions
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51040
To unsubscribe, visit https
Freddy Rolland has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/48477/7//COMMIT_MSG
Commit Message:
Line 14: de
Freddy Rolland has posted comments on this change.
Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit http
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/51295
to review the following change.
Change subject: build: update libvirt dependency for fedora
..
build: update libvirt depend
Freddy Rolland has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit https
Freddy Rolland has posted comments on this change.
Change subject: build: update libvirt dependency for fedora
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.o
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 24: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit https://gerrit.ovi
Hello Nir Soffer, Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/51369
to review the following change.
Change subject: build: update libvirt dependency for fedora
..
build: update li
Freddy Rolland has posted comments on this change.
Change subject: build: update libvirt dependency for fedora
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51369
To unsubscribe, visit https://gerrit.ov
Freddy Rolland has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53688
To unsubscribe, visit https://gerrit.ovirt.or
Freddy Rolland has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53680
To unsubscribe, visit https://gerrit.ovirt
Freddy Rolland has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 11: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/53785/11//COMMIT_MSG
Commit
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54381
to review the following change.
Change subject: storage: create lib storage directory
..
storage: create lib storage direct
Freddy Rolland has posted comments on this change.
Change subject: storage: create lib storage directory
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54381
To unsubscribe, visit https://gerrit.ovirt.or
Freddy Rolland has posted comments on this change.
Change subject: storage: create lib storage directory
..
Patch Set 1:
Verified by :
- Build RPM
- Install
- Check that dir is created
[root@RHEL7 /]# ll /usr/lib/python2.7/sit
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54404
to review the following change.
Change subject: storage: Move constants module to site-packages
..
storage: Move constants
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerri
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54424
to review the following change.
Change subject: storage: Move securable module to site-packages
..
storage: Move securable
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54431
to review the following change.
Change subject: storage: add storage folder to spec
..
storage: add storage folder to spec
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/fileSD.py
File vdsm/storage/file
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54439
to review the following change.
Change subject: spec: add virt and netinfo dir in spec
..
spec: add virt and netinfo dir in
Freddy Rolland has posted comments on this change.
Change subject: storage: add storage folder to spec
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54431
To unsubscribe, visit https://gerrit.ovirt.org/
Freddy Rolland has posted comments on this change.
Change subject: storage: Move securable module to site-packages
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: virt: Add the missing tests for Drive.getLeasesXML
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54324
To unsubscribe, visit https:/
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 2:
(12 comments)
https://gerrit.ovirt.org/#/c/54404/2/lib/vdsm/storage/Makefile.am
File lib/vdsm/s
Freddy Rolland has posted comments on this change.
Change subject: storage: Move securable module to site-packages
..
Patch Set 2:
(10 comments)
https://gerrit.ovirt.org/#/c/54424/2/lib/vdsm/storage/Makefile.am
File lib/vdsm/s
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54451
to review the following change.
Change subject: hsm: group vdsm imports in hsm.py
..
hsm: group vdsm imports in hsm.py
Gro
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54467
to review the following change.
Change subject: storage: Move storage_exception module to lib
..
storage: Move storage_exce
Freddy Rolland has posted comments on this change.
Change subject: spec: add virt and netinfo dir in spec
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54439
To unsubscribe, visit https://gerrit.ovirt.o
Freddy Rolland has posted comments on this change.
Change subject: hsm: group vdsm imports in hsm.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54451
To unsubscribe, visit https://gerrit.ovirt.org/se
Freddy Rolland has posted comments on this change.
Change subject: spec: add virt and netinfo dir in spec
..
Patch Set 2:
I verified by installing and check that the directories were removed.
Before this patch the directories w
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: storage: Move securable module to site-packages
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerri
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 4:
(8 comments)
https://gerrit.ovirt.org/#/c/54467/4/tests/functional/storageTests.py
File tests/fun
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 6:
(7 comments)
https://gerrit.ovirt.org/#/c/54467/6/debian/vdsm-python.install
File debian/vdsm-pyt
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54508
to review the following change.
Change subject: storage: add copyright info
..
storage: add copyright info
Add copyright i
Freddy Rolland has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py
File vdsm/storage/imageti
Freddy Rolland has posted comments on this change.
Change subject: storage: add copyright info
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterSD.py
File vdsm/storage/glusterSD.py:
Line 1
Freddy Rolland has posted comments on this change.
Change subject: storage: add copyright info
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 7:
(8 comments)
https://gerrit.ovirt.org/#/c/54467/7/tests/blockVolumeTests.py
File tests/blockVolum
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Add missing validation for qcow2 format
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57456
To unsubscribe, visit https://g
Freddy Rolland has posted comments on this change.
Change subject: tests: Separate broken test from good tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57481
To unsubscribe, visit https://gerrit
Freddy Rolland has posted comments on this change.
Change subject: directio: Keep line terminators in readlines()
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54701
To unsubscribe, visit https://ger
Freddy Rolland has posted comments on this change.
Change subject: directio: Add failing test for DirectFile.readlines()
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54694
To unsubscribe, visit http
Freddy Rolland has posted comments on this change.
Change subject: directio: Add test for reading entire file
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54700
To unsubscribe, visit https://gerrit.
Freddy Rolland has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57471
To unsubscribe, visit https://gerrit.ovir
201 - 300 of 574 matches
Mail list logo