Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move simple metadata getters and setters
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41997
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44042
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/42003/17/vdsm/storage/blockVolume.py
File
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/44043/6/vdsm/storage/blockVolume.py
File
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 7: -Code-Review -Verified
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: jobs: By default jobs do not support abort
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49449
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 20: Code-Review-1
(2 comments)
setMetadata is missing in FileVolume or should be moved from BlockVolume to
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move the getParent API
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41848
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41849
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44566
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 20: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41998/20/vdsm/storage/fileVolume.py
File
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: alerts: Introduce the alerts module
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49474
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49387
To unsubscribe, visit
Hello Fred Rolland, Allon Mureinik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49205
to review the following change.
Change subject: spec: Require newer qemu version for el7
..
spec: Require
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 1: Verified+1
[root@venus-vdsa ~]# rpm -qa | grep qemu qemu-img-rhev-2.3.0-31.el7.x86_64
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/41847/19/vdsm/storage/fileVolume.py
File
Freddy Rolland has posted comments on this change.
Change subject: fileUtils: Convert unhelpful warnings to debug messages
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/36764
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: fileUtils: Warn about callers of fileUtils.createdir()
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37003
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: mount: Remove unneeded return
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43973
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48705
To unsubscribe, visit
Hello Adam Litke, Fred Rolland, Allon Mureinik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48705
to review the following change.
Change subject: hsm : Do not resize on disconnectStorageServer
Freddy Rolland has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43974
To unsubscribe, visit
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48962
to review the following change.
Change subject: spec: Require newer lvm2 version for el7
..
spec: Require newer lvm2
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44834
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer lvm2 version for el7
..
Patch Set 1: Verified+1
Package available in rhel 7.2.
[root@venus-vdsa ~]# cat /etc/redhat-release
Red Hat
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48972
to review the following change.
Change subject: spec: Require newer lvm2 version for el7
..
spec: Require newer lvm2
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer lvm2 version for el7
..
Patch Set 1: Verified+1
Package available in rhel 7.2.
[root@venus-vdsa ~]# cat /etc/redhat-release
Red Hat
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer lvm2 version for el7
..
Patch Set 2: Verified+1
Package available in rhel 7.2.
[root@venus-vdsa ~]# cat /etc/redhat-release
Red Hat
Freddy Rolland has posted comments on this change.
Change subject: spec: Require newer lvm2 version for el7
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48962/1/vdsm.spec.in
File vdsm.spec.in:
Line 195: %if
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49009
to review the following change.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46382
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46383
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46384
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: doc: Add SDM overview document
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48876
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: suppport: 3.5 not supported in 4.x
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59504
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: api: unexpected response when a verb returns nothing
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59469
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: api: unexpected response when a verb returns nothing
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59469
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: jsonrpc: Return back mistakenly removed line in _serveRequest
..
Patch Set 1:
already in https://gerrit.ovirt.org/59469
--
To view, visit
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/59865
to review the following change.
Change subject: storage: Remove unneeded multipath call
..
storage: Remove unneeded
Freddy Rolland has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
..
Patch Set 1:
Verified with targetcli by adding a lun and increasing a lun.
Need to verify in FC
--
To view, visit
Freddy Rolland has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53680
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53688
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: net: IP address hostport split tool
..
Patch Set 4:
I tend to agree that this tool should be in a common space.
We should try to separate the packages. Adding
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54582
to review the following change.
Change subject: storage: move persistent to lib
..
storage: move persistent to lib
Moving
Freddy Rolland has posted comments on this change.
Change subject: storage: add copyright info
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54508
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: add copyright info
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterSD.py
File vdsm/storage/glusterSD.py:
Line
Freddy Rolland has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py
File
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 7:
(8 comments)
https://gerrit.ovirt.org/#/c/54467/7/tests/blockVolumeTests.py
File
Freddy Rolland has posted comments on this change.
Change subject: storage: remove duplicate code of transformPath
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55472
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55292
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 16: Code-Review-1
(2 comments)
Please remove vdsm/storage/sdm/jobs/__init__.py
Freddy Rolland has posted comments on this change.
Change subject: sdm: create_volume: remove duplicated args check
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56053
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: schema: SDM.create_volume split parent params
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55829
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: sdm: Move create_volume parent uuids into separate type
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55830
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: blockVolume: Move _calculate_volume_alloc_size to Manifest
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55986
To unsubscribe,
Freddy Rolland has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: virt: storage: avoid empty serials to domain XML
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56014
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: vm: Add error logging in diskReplicateFinish
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55939
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43974
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: mount: Remove unneeded return
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43973
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: sdm: Add create_volume job
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43969
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: rfh: Remove legacy remoteFileHandler
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54703
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: move persistent to lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54582
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: net: IP address hosttail split tool
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54312/5/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:
Line 18:
Freddy Rolland has posted comments on this change.
Change subject: storage: move persistent to lib
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/54582/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line
Freddy Rolland has posted comments on this change.
Change subject: rfh: Remove legacy remoteFileHandler
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54703
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: tests: Replace magic number with constant
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54954
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50273
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: net: IP address hosttail split tool
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storagetests: Rename make_blocksd
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54569
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storagetests: Create metadata storage area for block domains
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54568
To unsubscribe,
Freddy Rolland has posted comments on this change.
Change subject: storagetests: Add create_block_volume
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54570
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: tests: Add test_overwrite_blocksize test
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54669
To unsubscribe, visit
/storage/mount.py:
PS1, Line 179: ip, path = spec.split(":", 1)
This won't work with IP V6, for example:
[2001:db8::60fe:5bff:febc:912]:/home/frolland
Also path that use ':' will fail
Maybe you should use the new tool :
https://gerrit.ovirt.org/#/c/54312/
--
To view, v
Freddy Rolland has posted comments on this change.
Change subject: storagetests: add tests for mounting domains
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55255
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Organize imports in storage.iscsiadm
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55261
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Organize imports in storage.outOfProcess
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55256
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Organize imports in storage.imagetickets
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Oraganize imports in storage.sdc
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55260/1//COMMIT_MSG
Commit Message:
PS1,
Freddy Rolland has posted comments on this change.
Change subject: storage: Organize imports in storage.threadPool
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55259
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storage: Move constants module to site-packages
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54467
to review the following change.
Change subject: storage: Move storage_exception module to lib
..
storage: Move
Freddy Rolland has posted comments on this change.
Change subject: virt: Add the missing tests for Drive.getLeasesXML
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54324
To unsubscribe, visit
301 - 400 of 573 matches
Mail list logo
