Martin Betak has posted comments on this change.
Change subject: vdsm: Remove dead code in MigrationSourceThread.run
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18336
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28:
(4 comments)
File vdsm/vm.py
Line 1734:
Line 1735:
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 30: Verified+1
The retry check success mechanism in VmPowerDown enabled us to drop support
for timeouts in
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 31: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 9:
(2 comments)
File lib/vdsm/utils.py
Line 984: returning
Hello Federico Simoncelli, Dan Kenigsberg, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21521
to review the following change.
Change subject: vdsm: Accents in the vm name break the migration
Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 4876:
Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21521
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 11:
(1 comment)
File tests/utilsTests.py
Line 160:
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while not
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 12:
(1 comment)
File lib/vdsm/utils.py
Line 997:
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(2 comments)
File client/vdsClient.py
Line 1922:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
File vdsm/vm.py
Line 1729:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has abandoned this change.
Change subject: vdsm: Fix potential leak in Vm.destroy()
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/18337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1764: # flag for
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 39: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1729: self.timeout
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add support for Guest Reboot
..
vdsm: Add support for Guest Reboot
Added optional parameter reboot to shutdown in vdsm and vdsClient.
This parameter
Martin Betak has abandoned this change.
Change subject: vdsm: Reboot capability for VM
..
Abandoned
Abandoned in favor of a more lightweight patch http://gerrit.ovirt.org/22440
adding only guest agent reboot support without
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(3 comments)
Commit Message
Line 12: backwards
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 2546: except:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
vdsm: Utilize CallbackChain in vm.shutdown
Refactor the existing shutdown/reboot code to utilize the
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
Add support for configuring the
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
Add support for configuring the
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 3:
Modified specfile, set required version of libvirt to = 1.2.3
--
To view, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/31991
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 5:
Fixed debian packaging rebase issue and refactored the caps._getVersionInfo
libvirt
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/31992/5/vdsm/API.py
File vdsm/API.py:
Line 504:
Martin Betak has uploaded a new change for review.
Change subject: caps.py: Drop support for Fedora 19
..
caps.py: Drop support for Fedora 19
Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d
Signed-off-by: Martin Betak
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/31991
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34191
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit
Martin Beták has uploaded a new change for review.
Change subject: vdsm: [WIP] Reboot capability for VM
..
vdsm: [WIP] Reboot capability for VM
Added optional boolean parameters 'reboot' and 'force' to shutdown
both in API.py
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 5: (3 inline comments)
File vdsm_api/vdsmapi-schema.json
Line
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 10: (1 inline comment)
File vdsm/vm.py
Line 4099: def
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 11: Fails
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: Verified
New callback design, with support of QEMU-GA.
--
To view, visit http://gerrit.ovirt.org/15829
To
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: (6 inline comments)
File lib/vdsm/utils.py
Line 929:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14:
(7 comments)
File lib/vdsm/utils.py
Line 913:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 16: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1631:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1619: return m
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Fix potential leak in Vm.destroy()
..
vdsm: Fix potential leak in Vm.destroy()
The deleteVm method is now always called when destroying the VM.
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove dead code in MigrationSourceThread.run
..
vdsm: Remove dead code in MigrationSourceThread.run
Removed the mstate variable and the corresponding if
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Fix potential leak in Vm.destroy()
..
Patch Set 1:
Git blame traced this back to the initial commit by 'Tabula Rasa' so no help
there. But my concern was
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18:
(1 comment)
File vdsm/vm.py
Line 1631:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
(1 comment)
File vdsm/guestIF.py
Line 298:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Dan: First of all, sorry for this incomplete patch set. Its purpose was to
serve as a quick check if all the
Martin Betak has uploaded a new change for review.
Change subject: utils: Introduce CallbackChain
..
utils: Introduce CallbackChain
Added new utility class encapsulating the pattern
of invoking multiple alternative methods to
Martin Betak has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Accents in the vm name break the migration
..
vdsm: Accents in the vm name break the migration
Added utf-8 encoding of the configuration xml on the
Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19684
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 2:
(5 comments)
http://gerrit.ovirt.org/#/c/23457/2/vdsm/vm.py
File vdsm/vm.py:
Line 2617
Line 2618
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Enable config of VM serial number
..
vdsm: Enable config of VM serial number
Added support for passing explicit serial number
as a part of vmParams from
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24274/1/vdsm/vm.py
File vdsm/vm.py:
Line 1013:
Line 1014:
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 2:
The goal of this feature is to give user better control over the resulting
serial number of the VM. At
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 3: Verified+1
updated commit message
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/23457/3/vdsm/vm.py
File vdsm/vm.py:
Line 1891:
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 3:
(6 comments)
http://gerrit.ovirt.org/#/c/23457/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/23457/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py
File vdsm/vmCommands.py:
Line
Martin Betak has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
vdsm: Add force and timeout options to VM.shutdown
Added optional boolean parameters 'timeout' and 'force'
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 3: -Verified
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 4:
(7 comments)
http://gerrit.ovirt.org/#/c/27054/4/lib/vdsm/config.py.in
File
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
1 - 100 of 249 matches
Mail list logo
