Martin Polednik has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/19321
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19331
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19348
To
Martin Polednik has uploaded a new change for review.
Change subject: virtTests: fix initramfs permission detection
..
virtTests: fix initramfs permission detection
Initramfs permission was being detected using os.access
which
Martin Polednik has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 1: Verified+1
fixes bug that testInitramfsReadable would report true but any subsequent
attempt to
Martin Polednik has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 2: Verified+1
initramfs generator works as expected and tests are being skipped on unreadable
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
vdsm: prepareVolumePath correct path handling for cdrom
prepareVolumePath checked looked 'path'
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 2: Verified+1
path is now set even if specParams['path'] is empty
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
Patch Set 4:
(1 comment)
File vdsm/vm.py
Line 4673:
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 3:
(1 comment)
File
Martin Polednik has posted comments on this change.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/19928
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 4:
(2 comments)
File vdsm/vm.py
Line 1873:
Martin Polednik has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 2: -Verified
(1 comment)
Martin Polednik has posted comments on this change.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line
Martin Polednik has uploaded a new change for review.
Change subject: [WIP]vdsm: add support for TPM device passthrough
..
[WIP]vdsm: add support for TPM device passthrough
This patch adds basic support for TPM (to be expanded)
Martin Polednik has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 16: Verified+1
rebased
--
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 12: Verified+1
rebased and locally tested, migration should not cause problems unless hwrng VM
is
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 13: Verified+1
pushing 1st seems like a good idea...
rebased and locally tested, migration should not
Martin Polednik has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 17: Verified+1
rebased
--
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: add __slots__ to devices
..
vmDevices: add __slots__ to devices
VDSM devices are created using setattr over **kwargs, making the
initialization
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 1167:
Line 1168:
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: add mechanism to persist vmDevice defaults
..
vmDevices: add mechanism to persist vmDevice defaults
Multiple vmDevices such as BalloonDevice or
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: introduce VmDeviceContainer
..
vmDevices: introduce VmDeviceContainer
EARLY WORK IN PROGRESS: VmDeviceContainer is structure that will allow
us to
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: replace self.conf['devices'] by VmDeviceContainer
..
vmDevices: replace self.conf['devices'] by VmDeviceContainer
This patch servers as an
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: change network sampling interval to 15 seconds
..
vdsm: change network sampling interval to 15 seconds
Change-Id:
Martin Polednik has posted comments on this change.
Change subject: vdsm: change network sampling interval to 15 seconds
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21257
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5: Verified+1
cdrom path is always passed in specParams when starting VM from template
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: handle migration abort before semaphore acquiration
..
vdsm: handle migration abort before semaphore acquiration
If cancelMigration is called before
Martin Polednik has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
..
Patch Set 1: Code-Review+1
exactly what Tony said
--
To view, visit http://gerrit.ovirt.org/21560
Martin Polednik has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 5: Verified+1
(1 comment)
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19928
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21832
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: tests/functional/virt: drop ever-failing test
..
Patch Set 1: Code-Review-1
The previous test implementation always required that the system initramfs will
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Verified+1
fixed wrong specParams handling, verified XML against standard cdrom, empty
Martin Polednik has posted comments on this change.
Change subject: tests/functional/virt: drop testInitramfsReadable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21854
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: Revert vdsm: refactor buildConfDevices and getConfDevices into
single function
..
Patch Set 1: Code-Review-1
the only caller should be fixed by
Martin Polednik has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Verified+1
manually verified that the function is passed the same parameters as before
using log messages
Martin Polednik has posted comments on this change.
Change subject: vdsm: migration progress: count memRemaining also
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/15124
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 15: Verified+1
Implemented caps suggestion, fixed API, functional test is now robust in a way
that it
Martin Polednik has uploaded a new change for review.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
tests: validate cdrom path sent to/received from vdsm
related to http://gerrit.ovirt.org/#/c/20074/
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1: Verified+1
correctly detects failure without the fix applied / success with fix applied
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6:
Test added in http://gerrit.ovirt.org/#/c/22194/
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 6:
This patch in its current form without rebase and a bit of work wouldn't test
anything: we would only see if
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
File
Hello Federico Simoncelli, Dan Kenigsberg, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22324
to review the following change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22324
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5: Verified+1
Verified by testing on real VMs with QGA installed
--
To view, visit
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsm: add support for PCI passthrough
..
[WIP] vdsm: add support for PCI passthrough
required functionality:
* report PCI devices available on host [x]
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
vdsm: add support for hot(un)plug of pci-passthrough devices
Hot(un)plug ability for
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 2:
(1 comment)
File
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for PCI passthrough
..
Patch Set 5: Verified+1
Verified by manually starting devices with passthrough hardware assigned and
checking logs
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2264:
Line 2265: def
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Polednik has uploaded a new change for review.
Change subject: tests: fix possible test failure due to reboot event
..
tests: fix possible test failure due to reboot event
Virt tests currently have a chance of failing
Martin Polednik has posted comments on this change.
Change subject: vmDevices: introduce VmDeviceContainer
..
Patch Set 7:
currently outdated but still relevant, will get to it as this branch progresses
--
To view, visit
Martin Polednik has uploaded a new change for review.
Change subject: Added functional test for hotplugNic() call
..
Added functional test for hotplugNic() call
Change-Id: I2b5b4e3e5cf21e1f2f0ea39cd133ee7038aadeda
Martin Polednik has uploaded a new change for review.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Refactored xmlrpcTests to allow for more complex tests using running VM
Martin Polednik has abandoned this change.
Change subject: Added functional test for hotplugNic() call
..
Abandoned
Abandoning in favor of http://gerrit.ovirt.org/#/c/17893/ as this
implementation does not really attempt to
Martin Polednik has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 3:
Tried to implement most of the suggestions as they seem to make
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vm: cleanup of vm.py - removed old api references
..
[WIP] vm: cleanup of vm.py
- removed old api references
Change-Id:
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsmapi schema: optional/required parameter fixes
..
[WIP] vdsmapi schema: optional/required parameter fixes
Change-Id:
Martin Polednik has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 5:
Current version doesn't wait for the VM at all - are there any cases,
Martin Polednik has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 7:
This implementation is most versatile in allowing specification of
Martin Polednik has uploaded a new change for review.
Change subject: vdsClient: hibernate now sends required hiberVolHandle
..
vdsClient: hibernate now sends required hiberVolHandle
- vdsClient did not pass hiberVolHandle,
Martin Polednik has posted comments on this change.
Change subject: vdsmapi-schema: optional/required params fix
..
Patch Set 8: Verified+1
verified for (host, passthrough) modes and (spicevmc) protocol
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsClient: hibernate now sends required hiberVolHandle
..
Patch Set 2: Verified+1
verified through functional tests - hiberVolHandle gets correctly passed to
Martin Polednik has posted comments on this change.
Change subject: xmlrpcTests: refactoring
..
Patch Set 17: Verified+1
both storage and virt tests run as they should, storage tests currently using
old method and virt new
Martin Polednik has uploaded a new change for review.
Change subject: tests: vdsProxy remove need to duplicate api
..
tests: vdsProxy remove need to duplicate api
Currently, every API call to be made has to be appended to
Martin Polednik has posted comments on this change.
Change subject: tests: vdsProxy remove need to duplicate api
..
Patch Set 1:
(1 comment)
File tests/functional/utils.py
Martin Polednik has posted comments on this change.
Change subject: tests: vdsProxy remove need to duplicate api
..
Patch Set 3: Verified+1
rebase ontop of http://gerrit.ovirt.org/#/c/17893/ - less duplication
--
To view,
Martin Polednik has posted comments on this change.
Change subject: xmlrpcTests: Detect Ubuntu initramfs when booting VM
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17810
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsClient: hibernate now sends required hiberVolHandle
..
Patch Set 2: -Verified
keeping this open for S3/S4 sleep implementation
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsProxy pass calls to undefined methods to API and return
msg/status
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/18417
To
Martin Polednik has posted comments on this change.
Change subject: cleanup of vm.py
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsm: add support for virtiorng device
..
[WIP] vdsm: add support for virtiorng device
Adds support for virtiorng with basic capabilities
- TODO:
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: remove afterMigrationStatus
..
vdsm: remove afterMigrationStatus
Not supported by any vdsm anymore
Change-Id:
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
vdsm: move balloon logic out of buildConfDevices
Encapsulates empty balloon creation logic outside of
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
vdsm: move watchdog default params to WatchdogDevice
Watchdog device creation is currently for no
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
vdsm: refactor buildConfDevices and getConfDevices into single function
Removes
Martin Polednik has uploaded a new change for review.
Change subject: [WIP]vdsm: add support for S3/S4 suspend calls
..
[WIP]vdsm: add support for S3/S4 suspend calls
Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Martin Polednik has posted comments on this change.
Change subject: vdsm: remove afterMigrationStatus
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19306
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19331
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19321
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsProxy pass calls to undefined methods to API and return
msg/status
..
Patch Set 4:
(1 comment)
File
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19348
To
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 8:
The possible paths (/dev/random and /dev/hwrng) are predefined by libvirt and
no other path
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 3: Code-Review-1
(2 comments)
File vdsm/vm.py
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsProxy pass calls to undefined methods to API and return
msg/status
..
Patch Set 4:
(1 comment)
File
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 10: Verified+1
small fix in virtTests (egd version isn't used anymore)
-- verified through functional
Martin Polednik has posted comments on this change.
Change subject: vdsProxy pass calls to undefined methods to API and return
msg/status
..
Patch Set 4:
(1 comment)
File
Martin Polednik has posted comments on this change.
Change subject: vdsProxy pass calls to undefined methods to API and return
msg/status
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/18417
To
Martin Polednik has posted comments on this change.
Change subject: vdsProxy pass calls to undefined methods to API and return
msg/status
..
Patch Set 6: Verified+1
rebased
--
To view, visit http://gerrit.ovirt.org/18417
To
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 4:
Backwards compatibility is also taken into account: old calls with
hiberVolHandle will be served by
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit
1 - 100 of 163 matches
Mail list logo
