Change in vdsm[master]: vmxml: add appendNumaTune return value

2016-07-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vmxml: add appendNumaTune return value .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/61106/2//COMMIT_MSG Commit Message: Line 6: Lin

Change in vdsm[master]: log: Use INFO log level as default

2016-07-22 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: log: Use INFO log level as default .. Patch Set 1: Code-Review-1 I support this change but it needs rebase and update -- there have been added new level=DEBUG i

Change in vdsm[master]: virt: Limit the number of workers in executor

2016-07-25 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 20: (3 comments) https://gerrit.ovirt.org/#/c/57754/20/tests/executorTests.py File tests/executorTest

Change in vdsm[master]: log: Use INFO log level as default

2016-07-25 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: log: Use INFO log level as default .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/32504 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: log: Use INFO log level as default

2016-07-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: log: Use INFO log level as default .. Patch Set 2: Verified+1 Verified that DEBUG messages are no longer present in the log and the higher level messages are st

Change in vdsm[master]: vm: periodic: fix stats age reporting

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 7: Code-Review+1 (4 comments) It looks fine to me, I just suggest improving the commit message. https://gerr

Change in vdsm[master]: docs: add README about logging configuration

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/60533/5/README.logging File README.logging: Line 23: Lin

Change in vdsm[master]: docs: add README about logging configuration

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60533 To unsubscribe, visit https://gerrit

Change in vdsm[master]: vm: periodic: fix stats age reporting

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 8: > Commit message was updated. It's better now, thanks! -- To view, visit https://gerrit.ovirt.org/61310

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG Commit Message: Line 7: virt: sa

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61420 To unsubscribe, visit https://g

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG Commit Message: Line 33: DomainDescri

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 7

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 7

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 7

Change in vdsm[master]: makefile: remove unused all-local section

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: makefile: remove unused all-local section .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61545 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: configs: introduce static dir

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: configs: introduce static dir .. Patch Set 1: Code-Review+1 I'm not sure `static' is a good name, otherwise OK. -- To view, visit https://gerrit.ovirt.org/6159

Change in vdsm[master]: autoconf: properly sort makefiles

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: autoconf: properly sort makefiles .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61600 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: configs: move logger to static

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: configs: move logger to static .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61601/1/static/Makefile.am File static/Makefile.am: Line

Change in vdsm[master]: yajsonrpc: use proper exception in the recovery

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 2: Code-Review+1 Thanks for handling this problem. -- To view, visit https://gerrit.ovirt.org/6161

Change in vdsm[master]: configs: move mom

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: configs: move mom .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61602/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-07-28 09

Change in vdsm[master]: configs: move mom to static

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: configs: move mom to static .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61602 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: configs: move logger to static

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: configs: move logger to static .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61601 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: configs: move sudoers to static

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/61603/2/static/Makefile.am File static/Makefile.am: Line 39:$

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61631 To unsubscribe, visit https://ger

Change in vdsm[master]: virt: periodic health check - WIP

2016-07-28 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: periodic health check - WIP .. Patch Set 3: I like the general idea. However I don't like much vmhealth.py. We should try to centralize all information ab

Change in vdsm[master]: periodic: always re-schedule operations

2016-07-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/61685/2/tests/periodicTests.py File tests/periodi

Change in vdsm[master]: virt: Fix of Executor._active_workers crash on modification

2016-07-29 Thread mzamazal
Milan Zamazal has uploaded a new change for review. Change subject: virt: Fix of Executor._active_workers crash on modification .. virt: Fix of Executor._active_workers crash on modification Executor._active_workers doesn't use

Change in vdsm[master]: virt: Fix of Executor._active_workers crash on modification

2016-07-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61690/1/lib/vdsm/executor.py File lib/vdsm/

Change in vdsm[master]: virt: Fix of Executor._active_workers crash on modification

2016-07-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 1: Verified+1 Verified by running ExecutorTests.test_discarded_workers (where this bug w

Change in vdsm[ovirt-4.0]: virt: Fix of Executor._active_workers crash on modification

2016-08-15 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61770 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: virt: Limit the number of workers in executor

2016-08-15 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61769 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-4.0]: periodic: always re-schedule operations

2016-08-15 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61889 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: virt: periodic health check - WIP

2016-08-15 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: periodic health check - WIP .. Patch Set 4: Thank you, this looks like a better direction. -- To view, visit https://gerrit.ovirt.org/61592 To unsubscrib

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-08-16 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: > Not having a value is an exceptional situation, No, it's not an exceptional situation when we know

Change in vdsm[ovirt-3.6]: virt: Fix of Executor._active_workers crash on modification

2016-08-17 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62403 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: periodic: always re-schedule operations

2016-08-17 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62401 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[ovirt-3.6]: virt: Limit the number of workers in executor

2016-08-17 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62402 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-3.6]: tests: sampling: add FakeClock helper

2016-08-18 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: tests: sampling: add FakeClock helper .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62416 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[ovirt-3.6]: virt: sampling: add is_empty() method to StatsSample

2016-08-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: sampling: add is_empty() method to StatsSample .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62417 To unsubscribe, visit https:

Change in vdsm[ovirt-3.6]: vm: periodic: fix stats age reporting

2016-08-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62418 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: virt: vmchannels: use shorter name for thread

2016-08-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: vmchannels: use shorter name for thread .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62276 To unsubscribe, visit https://gerri

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

2016-08-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: migration: switch to concurrent.thread() .. Patch Set 9: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/61463/9/vdsm/virt/migration.py File vdsm/v

Change in vdsm[master]: virt: migration: rename classes

2016-08-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: migration: rename classes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62588 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: api: Move getAllVmStats hooks and logging from API to clientIF

2016-08-23 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: api: Move getAllVmStats hooks and logging from API to clientIF .. Patch Set 2: No problem, I don't think we are in an urgent need of this patch so we can wait w

Change in vdsm[master]: migration: coalesce join() into stop()

2016-08-24 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: migration: coalesce join() into stop() .. Patch Set 3: Code-Review+1 Good idea. -- To view, visit https://gerrit.ovirt.org/62587 To unsubscribe, visit https://

Change in vdsm[master]: vmdisk hook: add support for booting from image file

2016-08-24 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vmdisk hook: add support for booting from image file .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/58748/6/vdsm_hooks/vmdisk/before_vm_start.py File

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-08-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py File vdsm/virt/migration.

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-08-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py File vdsm/virt/migration.p

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-08-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py File vdsm/virt/migration.p

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-08-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py File vdsm/virt/migration.p

Change in vdsm[master]: Using %{?_smp_mflags} for make calls

2016-08-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: Using %{?_smp_mflags} for make calls .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in File vdsm.spec.in: Line 743: %endif Line 744

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-08-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 4: (2 comments) I additionally disabled compression with post-copy due to the QEMU bug, in order to

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-08-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 5: Another safety check: Let's not crash on post-copy switch when it is in the schedule but not suppo

Change in vdsm[master]: Using %{?_smp_mflags} for make calls

2016-08-30 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: Using %{?_smp_mflags} for make calls .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in File vdsm.spec.in: Line 743: %endif Line 744

Change in vdsm[master]: tests: install fake-virt-v2v.err to fix tests

2016-09-05 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: tests: install fake-virt-v2v.err to fix tests .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63273/2//COMMIT_MSG Commit Message: PS2, L

Change in vdsm[master]: py3: taskset.py/tasksetTests.py compliance.

2016-09-05 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: py3: taskset.py/tasksetTests.py compliance. .. Patch Set 11: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63223/11//COMMIT_MSG Commit Message: PS11,

Change in vdsm[master]: tests: split vmfakecon out of vmfakelib

2016-09-05 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: tests: split vmfakecon out of vmfakelib .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63197 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: rng: allow urandom as virtio rng entropy source .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59031 To unsubscribe, visit https://ge

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

2016-09-08 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: net libvirt hook: Adjust hook to vmList report change. .. Patch Set 1: Verified+1 It fixes the problem I experienced with migrations on my setup. -- To view, v

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

2016-09-08 Thread mzamazal
Milan Zamazal has uploaded a new change for review. Change subject: virt: Minor typo fixes in Vm.getStats docstring .. virt: Minor typo fixes in Vm.getStats docstring Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2 Signed-o

Change in vdsm[master]: virt: Block stuck VMs in executor

2016-09-11 Thread mzamazal
Milan Zamazal has abandoned this change. Change subject: virt: Block stuck VMs in executor .. Abandoned -- To view, visit https://gerrit.ovirt.org/57755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageTy

Change in vdsm[master]: virt: Prevent running periodic operations on stuck VMs

2016-09-12 Thread mzamazal
Milan Zamazal has abandoned this change. Change subject: virt: Prevent running periodic operations on stuck VMs .. Abandoned -- To view, visit https://gerrit.ovirt.org/59736 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: virt: Prevent running stuck periodic operations

2016-09-12 Thread mzamazal
Milan Zamazal has abandoned this change. Change subject: virt: Prevent running stuck periodic operations .. Abandoned -- To view, visit https://gerrit.ovirt.org/59737 To unsubscribe, visit https://gerrit.ovirt.org/settings Ge

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

2016-09-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO .. Patch Set 15: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in File lib

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-14 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: net libvirt hook: revert vmList change .. Patch Set 1: Verified+1 I verified that migration works for me with this patch. -- To view, visit https://gerrit.ovir

Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff

2016-09-15 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63972 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

2016-09-15 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63974 To unsubscribe, visit https:/

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-09-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (7 comments) Thank you all for the comments and suggestions, I hope things get clarified and we can

Change in vdsm[master]: cmdutils: enhance systemd_run

2016-09-20 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 29: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

2016-09-20 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO .. Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py File vdsm/virt/vm.py: PS16,

Change in vdsm[master]: virt: utils: add is_kvm helper

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 33: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 29: Hm, do we really want to permit starting/stopping any service with those APIs? For instance, why should it

Change in vdsm[master]: logging: Improve log level alignment

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 2: (1 comment) I like the change, let's just replace the reference in the commit message. https://gerrit.ovir

Change in vdsm[master]: logging: Document the secret TRACE log level

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: Document the secret TRACE log level .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64218 To unsubscribe, visit https://gerrit

Change in vdsm[master]: logging: More standard logging format

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 3: Code-Review+1 Thanks for putting module:lineno back. It's fine for me as it is now (as well as if Michal's

Change in vdsm[master]: logging: Use same log format in the tests

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: logging: Unify SimpleLogAdapter format

2016-09-21 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 1: (1 comment) Except for the commit comment I support this change. https://gerrit.ovirt.org/#/c/64227/1//C

Change in vdsm[master]: logging: Unify SimpleLogAdapter format

2016-09-22 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: logging: Improve log level alignment

2016-09-22 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-09-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py File vdsm/virt/migration.

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-09-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py File vdsm/virt/migration.

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

2016-09-26 Thread mzamazal
Milan Zamazal has uploaded a new change for review. Change subject: virt: Don't crash in migration progress on compression bytes .. virt: Don't crash in migration progress on compression bytes If compression is not enabled for a

Change in vdsm[master]: virt: Don't crash in migration progress on compression bytes

2016-09-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Don't crash in migration progress on compression bytes .. Patch Set 2: Verified+1 (1 comment) I verified that migration still works and that the KeyError'

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

2016-09-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Minor typo fixes in Vm.getStats docstring .. Patch Set 3: Verified+1 Just a documentation change, I checked build works. Jenkins test failures on Fedora a

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-09-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in File vdsm.spec.in: Line 187: Requ

Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

2016-09-26 Thread mzamazal
Milan Zamazal has uploaded a new change for review. Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message .. virt: Typo fix in Vm._acquireCpuLockWithTimeout error message Change-Id: Id93bec2881040566261cc

Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

2016-09-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message .. Patch Set 6: Verified+1 Trivial change, Jenkins is enough. -- To view, visit https://gerrit.ov

Change in vdsm[ovirt-4.0]: virt: Don't crash in migration progress on compression bytes

2016-09-27 Thread mzamazal
Hello Francesco Romani, Michal Skrivanek, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64499 to review the following change. Change subject: virt: Don't crash in migration progress on compression bytes .

Change in vdsm[master]: API: modernize VM methods

2016-09-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 18: Code-Review-1 (6 comments) Nice change, but we should be careful and double check. I'm afraid there are some oversig

Change in vdsm[ovirt-4.0]: docs: add README about logging configuration

2016-09-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64515 To unsubscribe, visit https://gerrit

Change in vdsm[master]: API: modernize VM methods

2016-09-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 19: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 125: Line 126:

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

2016-09-29 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60640 To unsubscribe, visit https://ge

Change in vdsm[master]: virt: Make boolean values from boolean migration options

2016-09-30 Thread mzamazal
Milan Zamazal has uploaded a new change for review. Change subject: virt: Make boolean values from boolean migration options .. virt: Make boolean values from boolean migration options `compressed' and `autoConverge' migration o

Change in vdsm[ovirt-4.0]: virt: Don't crash in migration progress on compression bytes

2016-09-30 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Don't crash in migration progress on compression bytes .. Patch Set 2: Verified+1 Bug number added. Verified that with this change the crash (KeyError) is

Change in vdsm[master]: virt: Make boolean values from boolean migration options

2016-10-03 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: > This is "just" about polishing the code or you hit a bug caused by this? I wanted to

Change in vdsm[master]: virt: Make boolean values from boolean migration options

2016-10-03 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Verified+1 Verified that with this change and "minimal downtime" migration policy migra

Change in vdsm[master]: virt: Make boolean values from boolean migration options

2016-10-04 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 2: Verified+1 No code change since the last verification, so Jenkins is enough. -- To vie

Change in vdsm[master]: virt: Make boolean values from boolean migration options

2016-10-04 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 2: TODO added. -- To view, visit https://gerrit.ovirt.org/65007 To unsubscribe, visit htt

Change in vdsm[ovirt-4.0]: virt: Make boolean values from boolean migration options

2016-10-05 Thread mzamazal
Hello Nir Soffer, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65108 to review the following change. Change subject: virt: Make boolean values from boolean migration options ..

<    3   4   5   6   7   8   9   >