Milan Zamazal has posted comments on this change.
Change subject: vmxml: add appendNumaTune return value
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61106/2//COMMIT_MSG
Commit Message:
Line 6:
Lin
Milan Zamazal has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 1: Code-Review-1
I support this change but it needs rebase and update -- there have been added
new level=DEBUG i
Milan Zamazal has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 20:
(3 comments)
https://gerrit.ovirt.org/#/c/57754/20/tests/executorTests.py
File tests/executorTest
Milan Zamazal has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit https://gerrit.ovirt.org
Milan Zamazal has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Verified+1
Verified that DEBUG messages are no longer present in the log and the higher
level messages are st
Milan Zamazal has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 7: Code-Review+1
(4 comments)
It looks fine to me, I just suggest improving the commit message.
https://gerr
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60533/5/README.logging
File README.logging:
Line 23:
Lin
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit
Milan Zamazal has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 8:
> Commit message was updated.
It's better now, thanks!
--
To view, visit https://gerrit.ovirt.org/61310
Milan Zamazal has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG
Commit Message:
Line 7: virt: sa
Milan Zamazal has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://g
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG
Commit Message:
Line 33: DomainDescri
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 7
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 7
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 7
Milan Zamazal has posted comments on this change.
Change subject: makefile: remove unused all-local section
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61545
To unsubscribe, visit https://gerrit.ov
Milan Zamazal has posted comments on this change.
Change subject: configs: introduce static dir
..
Patch Set 1: Code-Review+1
I'm not sure `static' is a good name, otherwise OK.
--
To view, visit https://gerrit.ovirt.org/6159
Milan Zamazal has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit https://gerrit.ovirt.org/
Milan Zamazal has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61601/1/static/Makefile.am
File static/Makefile.am:
Line
Milan Zamazal has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 2: Code-Review+1
Thanks for handling this problem.
--
To view, visit https://gerrit.ovirt.org/6161
Milan Zamazal has posted comments on this change.
Change subject: configs: move mom
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61602/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-07-28 09
Milan Zamazal has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit https://gerrit.ovirt.org/settin
Milan Zamazal has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit https://gerrit.ovirt.org/set
Milan Zamazal has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/61603/2/static/Makefile.am
File static/Makefile.am:
Line 39:$
Milan Zamazal has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61631
To unsubscribe, visit https://ger
Milan Zamazal has posted comments on this change.
Change subject: virt: periodic health check - WIP
..
Patch Set 3:
I like the general idea. However I don't like much vmhealth.py.
We should try to centralize all information ab
Milan Zamazal has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/61685/2/tests/periodicTests.py
File tests/periodi
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
virt: Fix of Executor._active_workers crash on modification
Executor._active_workers doesn't use
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61690/1/lib/vdsm/executor.py
File lib/vdsm/
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Verified+1
Verified by running ExecutorTests.test_discarded_workers (where this bug w
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61770
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61769
To unsubscribe, visit https://gerri
Milan Zamazal has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61889
To unsubscribe, visit https://gerrit.ovir
Milan Zamazal has posted comments on this change.
Change subject: virt: periodic health check - WIP
..
Patch Set 4:
Thank you, this looks like a better direction.
--
To view, visit https://gerrit.ovirt.org/61592
To unsubscrib
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
> Not having a value is an exceptional situation,
No, it's not an exceptional situation when we know
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62403
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62401
To unsubscribe, visit https://gerrit.ovir
Milan Zamazal has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62402
To unsubscribe, visit https://gerri
Milan Zamazal has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62416
To unsubscribe, visit https://gerrit.ovirt.
Milan Zamazal has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62417
To unsubscribe, visit https:
Milan Zamazal has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62418
To unsubscribe, visit https://gerrit.ovirt.
Milan Zamazal has posted comments on this change.
Change subject: virt: vmchannels: use shorter name for thread
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62276
To unsubscribe, visit https://gerri
Milan Zamazal has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 9: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/61463/9/vdsm/virt/migration.py
File vdsm/v
Milan Zamazal has posted comments on this change.
Change subject: virt: migration: rename classes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62588
To unsubscribe, visit https://gerrit.ovirt.org/se
Milan Zamazal has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
No problem, I don't think we are in an urgent need of this patch so we can wait
w
Milan Zamazal has posted comments on this change.
Change subject: migration: coalesce join() into stop()
..
Patch Set 3: Code-Review+1
Good idea.
--
To view, visit https://gerrit.ovirt.org/62587
To unsubscribe, visit https://
Milan Zamazal has posted comments on this change.
Change subject: vmdisk hook: add support for booting from image file
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/58748/6/vdsm_hooks/vmdisk/before_vm_start.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.p
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.p
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.p
Milan Zamazal has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in
File vdsm.spec.in:
Line 743: %endif
Line 744
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 4:
(2 comments)
I additionally disabled compression with post-copy due to the QEMU bug, in
order to
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 5:
Another safety check: Let's not crash on post-copy switch when it is in the
schedule but not suppo
Milan Zamazal has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in
File vdsm.spec.in:
Line 743: %endif
Line 744
Milan Zamazal has posted comments on this change.
Change subject: tests: install fake-virt-v2v.err to fix tests
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63273/2//COMMIT_MSG
Commit Message:
PS2, L
Milan Zamazal has posted comments on this change.
Change subject: py3: taskset.py/tasksetTests.py compliance.
..
Patch Set 11: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63223/11//COMMIT_MSG
Commit Message:
PS11,
Milan Zamazal has posted comments on this change.
Change subject: tests: split vmfakecon out of vmfakelib
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63197
To unsubscribe, visit https://gerrit.ovir
Milan Zamazal has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://ge
Milan Zamazal has posted comments on this change.
Change subject: net libvirt hook: Adjust hook to vmList report change.
..
Patch Set 1: Verified+1
It fixes the problem I experienced with migrations on my setup.
--
To view, v
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
virt: Minor typo fixes in Vm.getStats docstring
Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Signed-o
Milan Zamazal has abandoned this change.
Change subject: virt: Block stuck VMs in executor
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/57755
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageTy
Milan Zamazal has abandoned this change.
Change subject: virt: Prevent running periodic operations on stuck VMs
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59736
To unsubscribe, visit https://gerrit.ovirt.org/setti
Milan Zamazal has abandoned this change.
Change subject: virt: Prevent running stuck periodic operations
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59737
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File lib
Milan Zamazal has posted comments on this change.
Change subject: net libvirt hook: revert vmList change
..
Patch Set 1: Verified+1
I verified that migration works for me with this patch.
--
To view, visit https://gerrit.ovir
Milan Zamazal has posted comments on this change.
Change subject: virt: Pass missing parameter on desktopLogoff
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63972
To unsubscribe, visit https://gerri
Milan Zamazal has posted comments on this change.
Change subject: virt: Correct disconnectAction parameter extraction
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63974
To unsubscribe, visit https:/
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(7 comments)
Thank you all for the comments and suggestions, I hope things get clarified and
we can
Milan Zamazal has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/set
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS16,
Milan Zamazal has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 33: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/se
Milan Zamazal has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 29:
Hm, do we really want to permit starting/stopping any service with those APIs?
For instance, why should it
Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2:
(1 comment)
I like the change, let's just replace the reference in the commit message.
https://gerrit.ovir
Milan Zamazal has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit
Milan Zamazal has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 3: Code-Review+1
Thanks for putting module:lineno back. It's fine for me as it is now (as well
as if Michal's
Milan Zamazal has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit https://gerrit.ov
Milan Zamazal has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 1:
(1 comment)
Except for the commit comment I support this change.
https://gerrit.ovirt.org/#/c/64227/1//C
Milan Zamazal has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64227
To unsubscribe, visit https://gerrit.ovirt
Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit https://gerrit.ovirt.o
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Don't crash in migration progress on compression bytes
..
virt: Don't crash in migration progress on compression bytes
If compression is not enabled for a
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2: Verified+1
(1 comment)
I verified that migration still works and that the KeyError'
Milan Zamazal has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
Patch Set 3: Verified+1
Just a documentation change, I checked build works. Jenkins test failures on
Fedora a
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in
File vdsm.spec.in:
Line 187: Requ
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
Change-Id: Id93bec2881040566261cc
Milan Zamazal has posted comments on this change.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
Patch Set 6: Verified+1
Trivial change, Jenkins is enough.
--
To view, visit https://gerrit.ov
Hello Francesco Romani, Michal Skrivanek,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64499
to review the following change.
Change subject: virt: Don't crash in migration progress on compression bytes
.
Milan Zamazal has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18: Code-Review-1
(6 comments)
Nice change, but we should be careful and double check. I'm afraid there are
some oversig
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit https://gerrit
Milan Zamazal has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 19: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 125:
Line 126:
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://ge
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make boolean values from boolean migration options
..
virt: Make boolean values from boolean migration options
`compressed' and `autoConverge' migration o
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2: Verified+1
Bug number added.
Verified that with this change the crash (KeyError) is
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1:
> This is "just" about polishing the code or you hit a bug caused by this?
I wanted to
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Verified+1
Verified that with this change and "minimal downtime" migration policy
migra
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2: Verified+1
No code change since the last verification, so Jenkins is enough.
--
To vie
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2:
TODO added.
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit htt
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65108
to review the following change.
Change subject: virt: Make boolean values from boolean migration options
..
701 - 800 of 808 matches
Mail list logo