Piotr Kliczewski has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45613
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/1/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py
Piotr Kliczewski has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43974
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: mount: Remove unneeded return
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43973
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43969
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: rfh: Remove legacy remoteFileHandler
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54703
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: fix integration tests
..
Patch Set 2: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/55871
To unsubscribe
Piotr Kliczewski has uploaded a new change for review.
Change subject: vdsmapi: prepare for event naming
..
vdsmapi: prepare for event naming
Change-Id: I31f119b7809ae7536d3cab4de6298c648402614d
Signed-off-by: pkliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 2:
(3 comments)
Migration is using non-blocking code it should not break. I will update the
Piotr Kliczewski has uploaded a new change for review.
Change subject: utils: remove unused variable warning
..
utils: remove unused variable warning
Change-Id: I2796a212883c21d2d8902d9e9665e5dee1da8b6e
Signed-off-by
Piotr Kliczewski has posted comments on this change.
Change subject: utils: remove unused variable warning
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56022/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 849
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55872/2/lib/vdsm/utils.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43581/4/tests/Makefile.am
File tests/Makefile.am:
Line 57
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: ignore events when jsonrpc binding not available
..
events: ignore events when jsonrpc binding not available
When vdsm is booting and jsonrpc
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: verify data before sending
..
events: verify data before sending
We want to check whether event contents aligns with the schema before
sending it to
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 31: Verified+1
Verified by updating vdsm and changing the status of a vm several times.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 15: Verified+1
Verified by updating vdsm and changing the status of a vm several times.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 2: Verified+1
Verified by updating vdsm and changing the status of a vm several times.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 11: Verified+1
(1 comment)
Verified by updating vdsm and changing the status of a vm several times.
https
Piotr Kliczewski has posted comments on this change.
Change subject: events: ignore events when jsonrpc binding not available
..
Patch Set 1: Verified+1
Verified by updating vdsm and changing the status of a vm several times
Piotr Kliczewski has posted comments on this change.
Change subject: events: verify data before sending
..
Patch Set 1: Verified+1
Verified by updating vdsm and changing the status of a vm several times.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55872/2/lib/vdsm/utils.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55872/2/lib/vdsm/utils.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: events: ignore events when jsonrpc binding not available
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56028/1//COMMIT_MSG
Commit Message:
Line
Piotr Kliczewski has abandoned this change.
Change subject: stomp: make sure that we are connected before sending data
..
Abandoned
We do not need this patch anymore.
--
To view, visit https://gerrit.ovirt.org/54578
To
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 20: Verified+1
Fixed failing test. No code changes.
--
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 16: Verified+1
Rebase only, no code changes.
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55872/4/lib/vdsm/protocoldetector.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: set default timeout value
..
Patch Set 2: Verified+1
Verified by running tests.
--
To view, visit https://gerrit.ovirt.org/55397
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: events: ignore events when jsonrpc binding not available
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56028/1/vdsm/clientIF.py
File vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
Looking at API.py and the schema we do not have it optional but on hsm level we
you None as default value
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55999/3//COMMIT_MSG
Commit Message:
Line 4: Commit
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 20:
(9 comments)
https://gerrit.ovirt.org/#/c/53919/20/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS20, Line 34
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/54528/15/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py
Piotr Kliczewski has posted comments on this change.
Change subject: events: ignore events when jsonrpc binding not available
..
Patch Set 2:
This patch has no dependencies. It is ok to merge as it is.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: remove unused variable warning
..
Patch Set 2: Verified+1
I verified it by running conversion tests.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 33: Verified+1
Updated schema with newly merged patches. Verified by updating already
installed vdsm and performing
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 21: Verified+1
Fixed Francesco's comments. Verified by updating already installed vdsm and
performing bun
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 17: Verified+1
Rebase only no code changes. Verified by updating already installed vdsm and
performing bunch of
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 4: Verified+1
Updated commit message, no code changes. Verified by updating already installed
vdsm and
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 13: Verified+1
Fixed tests due to previous changes. Verified by updating already installed
vdsm and performing
Piotr Kliczewski has uploaded a new change for review.
Change subject: asyncore: make sure to handle sslerror on send
..
asyncore: make sure to handle sslerror on send
Change-Id: I28fd1accb04c74c8ed2f11ba47fa5ef7fee67883
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: make sure to handle sslerror on send
..
Patch Set 1: Verified+1
I checked the sources of m2c and I can see that send can raise the same set of
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: handle strings as correct response
..
jsonrpc: handle strings as correct response
Change-Id: I57b3e5c325dc41754f795c54de03f92043027d79
Signed-off
Piotr Kliczewski has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 10:
I would be great to know about schema changes. It would save me some time to
convert the change to
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 34: Verified+1
Rebase and update of new schema based on merged storage patch.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 22: Verified+1
Make sure to use six to compare with text type. Verified but running local
build.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 18: Verified+1
Rebase only, no code changes.
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: handle strings as correct response
..
Patch Set 2: Verified+1
Verified by Simone on previous patch set.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 3:
The change looks good to me. Please let me know when this WIP is done and I
will ack it.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 10:
It is a matter of knowing that the change was merged and not learning about it
when the tests fail
Piotr Kliczewski has uploaded a new change for review.
Change subject: client: do not protect requests on client side
..
client: do not protect requests on client side
We need to keep message content without any changes before
Piotr Kliczewski has posted comments on this change.
Change subject: init: run post-vdsm stop hook
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56289
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 1:
Simone can you verify it if it works for you?
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG
Commit Message:
Line 7: client
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG
Commit Message:
Line 7: client
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: handle strings as correct response
..
Patch Set 3:
Commit message updated. Francesco please take a look.
--
To view, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: externalize api_strict_mode
..
schema: externalize api_strict_mode
This patch prepares the code to generate api doc based on yml schema.
During the
Piotr Kliczewski has uploaded a new change for review.
Change subject: yml: generate api doc from the schema
..
yml: generate api doc from the schema
Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c
Signed-off-by
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/56387
To
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 35: Verified+1
Rebase only no code changes.
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 19: Verified+1
Rebase only, no code changes.
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 1: Verified+1
Verified by running local build with api doc generation.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 15: Verified+1
Rebase only, no code changes.
--
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56288/1/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/54528/18/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS18, Line
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/56387/1/lib/api/Makefile.am
File lib/api/Makefile.am:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/54754/15/lib/api/vdsm-events.yml
File lib/api/vdsm-events.yml
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 35:
(9 comments)
https://gerrit.ovirt.org/#/c/52864/35/lib/api/json_schema.py
File lib/api/json_schema.py:
Line 1
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56288/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: m2c: use custom certificate validation function
..
Patch Set 1:
We still want to fix this issue.
--
To view, visit https://gerrit.ovirt.org/53398
To
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/54528/18/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS18, Line
Piotr Kliczewski has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56386/1/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 75
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56387/1/vdsm.spec.in
File vdsm.spec.in:
Line 1562
Piotr Kliczewski has posted comments on this change.
Change subject: Let the engine control the guest lifecycle events
..
Patch Set 6: Code-Review+2
Based on Franceso's score and schema change being OK I raise.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: marking temporarily as broken
..
tests: marking temporarily as broken
Change-Id: Id673e92e73ae93994e002ac47b83af7031faeec0
Signed-off-by
Piotr Kliczewski has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 1:
It is sad that I need to do :/. Hopefully will have some time soon to fix them.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: marking temporarily as broken
..
Patch Set 1: Verified+1
Verified by building locally
--
To view, visit https://gerrit.ovirt.org/56650
To
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
Yaniv's comments fixed. Simone can you verify it one more time?
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 20: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 21: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 25: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 17: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works
Piotr Kliczewski has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 3: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 3: Verified+1
Rebased, added changes to build-artifacts.sh ask Yaniv requested. Verified by
updating a
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 37: Verified+1
Rebased and yaml schema updated. Verified by updating a host and seeing that
communication works
Piotr Kliczewski has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/11/lib/vdsm/tool
Piotr Kliczewski has posted comments on this change.
Change subject: require NetworkManager-config-server
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py
Piotr Kliczewski has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: automation: Run make check over el7 in automation CI
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Removing generationID from clientIF
..
Patch Set 6: Code-Review+2
I checked engine code and not found it being used. Fake vdsm is sending it as
well but
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: lvm: Fail loudly if called with unexpected input
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37329
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/13/vdsm.spec.in
File
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 28: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
801 - 900 of 2910 matches
Mail list logo