Sandro Bonazzola has posted comments on this change.
Change subject: stats: return domain lockspace status
..
Patch Set 1: Verified+1
Verified with both:
- http://gerrit.ovirt.org/19762
- http://gerrit.ovirt.org/19867
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 2: Verified+1
Verified with both:
- http://gerrit.ovirt.org/20099
- http://gerrit.ovirt.org/19867
See
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 3: Verified+1
Addressed my comments as per Dan Kenigsberg request.
Verified with both:
-
Sandro Bonazzola has posted comments on this change.
Change subject: WIP vdsStats: return HA agent score when applicable
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: caps: return HA agent score when applicable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: fix [start|stop]MonitoringDomain introduction version
..
Patch Set 1: Code-Review+1
Waiting for 4.14 release for updating hosted engine packages
Sandro Bonazzola has posted comments on this change.
Change subject: caps: return HA agent score when applicable
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File vdsm_api/vdsmapi-schema.json
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 28: Verified-1
vdsm-tool configure --force lead to vdsmd inactive dead for me.
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 29: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return domain lockspace status
..
Patch Set 2:
Any chance to have this in oVirt 3.3.2 ?
--
To view, visit http://gerrit.ovirt.org/20193
To
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 2:
Any chance to have this in oVirt 3.3.2 ?
--
To view, visit http://gerrit.ovirt.org/20194
To
Sandro Bonazzola has posted comments on this change.
Change subject: gluster prepareImage: return gluster-specific information
..
Patch Set 4: Code-Review+1
python code looks good to me.
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: gluster prepareImage: return gluster-specific information
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21151
To unsubscribe,
Sandro Bonazzola has uploaded a new change for review.
Change subject: Tune dirty_ratio and dirty_background_ratio also on Fedora = 19
..
Tune dirty_ratio and dirty_background_ratio also on Fedora = 19
Fixing Bug #740887 it has
Sandro Bonazzola has posted comments on this change.
Change subject: Tune dirty_ratio and dirty_background_ratio also on Fedora = 19
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21160
To unsubscribe,
Sandro Bonazzola has posted comments on this change.
Change subject: Tune dirty_ratio and dirty_background_ratio also on Fedora = 19
..
Patch Set 1:
I would put Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf. as the
Sandro Bonazzola has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 2: Verified+1
Updated commit message. No code changes.
--
To view, visit
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21202
to review the following change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Sandro Bonazzola has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21202
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 1:
Do we need more reviewers?
--
To view, visit http://gerrit.ovirt.org/21202
To
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20194
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return domain lockspace status
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20193
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: xmlrpc: Transport wrapper missing request function - vdsClient
..
Patch Set 2:
(2 comments)
File
Sandro Bonazzola has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21695
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 1:
it's a bit ugly having make dist to generate 2 tar.gz maybe we should move all
the debian tree out of the
Sandro Bonazzola has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21795
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21839
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1: Code-Review+1
merge?
--
To view, visit http://gerrit.ovirt.org/22218
To
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm.spec: Add with_vhostmd
..
Patch Set 2: Code-Review+1
David, see above comment by Douglas
--
To view, visit http://gerrit.ovirt.org/23126
To
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm.spec: Add with_vhostmd
..
Patch Set 2:
Rerun-Hooks: all
AFAIK the above doesn't work here. you should trigger it from jenkins:
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm.spec: Add with_vhostmd
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm.spec: Add with_vhostmd
..
Patch Set 3:
Please merge :-)
--
To view, visit http://gerrit.ovirt.org/23126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: netinfo: ifcfg: ignore 0 suffix
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23329
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm.spec: Add BuildRequires to python-argparse
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23475
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL6
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31214
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL6
..
Patch Set 2:
Please ping me when this patch will be merged and cherry-picked to 3.5 branch.
Sandro Bonazzola has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL6
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/31214
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31214
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: don't log the whole backtrace for expected problems
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31432
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: upgrade: vdsm-jsonrpc needs to obsolete vdsm-api
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32857/2/vdsm.spec.in
File vdsm.spec.in:
Line 283:
Sandro Bonazzola has posted comments on this change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
Patch Set 6:
Verified patchset 4 lvm rules working deploying Hosted Engine with
Sandro Bonazzola has posted comments on this change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
Patch Set 6:
please let me know when this patch will be included in a vdsm
Sandro Bonazzola has posted comments on this change.
Change subject: lvm: Fix wrong selinux label for readonly images
..
Patch Set 1: Code-Review-1
I think you can abandon this since http://gerrit.ovirt.org/33875 has been
Sandro Bonazzola has posted comments on this change.
Change subject: lvm: Do not use udev to set permissions on vdsm images
..
Patch Set 1:
Martin, Jiri, does this affect the way hosted-engine-ha get its symlink created?
--
Sandro Bonazzola has posted comments on this change.
Change subject: lvm: Do not use udev to set permissions on vdsm images
..
Patch Set 1: Code-Review+1
Nir thanks for explanation
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/33987/1/vdsm.spec.in
File vdsm.spec.in:
Sandro Bonazzola has posted comments on this change.
Change subject: tc tests: Fix compilation by adhering to and praising PEP8
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34312
To unsubscribe,
Sandro Bonazzola has posted comments on this change.
Change subject: tc tests: Fix compilation by adhering to and praising PEP8
..
Patch Set 1:
Looks like it's failing on a different test:
*** Running tests. To skip this
Sandro Bonazzola has posted comments on this change.
Change subject: spec: fix libvirt dependency for fedora and RHEL7
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34340
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: volume: Log the correct error when creating a volume fails
..
Patch Set 3:
Missing backport to 3.5 branch, Bug-Url is targeted 3.5.1.
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Bugfix: TypeError when using configNetwork.addNetwork with
bootproto as kw param.
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Sandro Bonazzola has posted comments on this change.
Change subject: misc: handle scientific notation in readspeed
..
Patch Set 1: Verified
seems to work fine.
--
To view, visit http://gerrit.ovirt.org/15433
To unsubscribe,
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/16528
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Sandro Bonazzola has uploaded a new change for review.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
ClientIF: avoid runtime errors at VM shutdown
Avoids:
RuntimeError: dictionary changed size during
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: [WIP] Decouple images and volumes from pool path
..
Patch Set 2:
Eduardo, can you rebase this patch?
--
To view, visit http://gerrit.ovirt.org/16055
To
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2: (1 inline comment)
File vdsm/clientIF.py
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
Sandro Bonazzola has abandoned this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Abandoned
Fix will be pushed by Yeela Kaplan
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: removeVmFromMonitoredDomains: Copy keys before traversing and
deleting items in domainVmIds
..
Patch Set 1:
(1 comment)
Sandro Bonazzola has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
..
Patch Set 2:
code looks good to me, but I don't know how storage works enough for giving a
+1 here.
--
To
Sandro Bonazzola has posted comments on this change.
Change subject: clientIF: maintain list of vm's domains inside the vm object
..
Patch Set 3:
code looks good to me, but I don't know how this works enough for giving a +1
Sandro Bonazzola has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17772
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17714
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 13:
(2 comments)
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Sandro Bonazzola has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
..
Patch Set 4:
Any chance to have this patch queue merged soon?
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10:
Any chance to have this patch queue merged soon?
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10:
First, need to fix comments I'm giving -2 since without fixing selinux issue
this must not be introduced (as it will
Sandro Bonazzola has posted comments on this change.
Change subject: vm: extend shared property to support locking
..
Patch Set 8:
(1 comment)
File client/vdsClient.py
Line
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 16:
(1 comment)
Commit Message
Line 9: The number of storage accesses is
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
packaging: spec: selinux-policy-targeted requirements
fixed selinux policy-targeted requirements
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
Patch Set 1: Verified+1
verified selinux-policy-targeted dependency with the version requested by
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: selinux-policy-targeted requirements
..
Patch Set 1:
However, note that the package for fedora 18 has not hit updates-testing yet.
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19470
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: vdsm: prevent stale vm stats if qemu process exits
..
Patch Set 1: -Code-Review
Greg, I think we can abandon this patch. I agree with Dan.
--
To view,
Sandro Bonazzola has uploaded a new change for review.
Change subject: systemd: vdsmd: fixed sanlock requirement
..
systemd: vdsmd: fixed sanlock requirement
Added missing .service.
Change-Id:
Sandro Bonazzola has posted comments on this change.
Change subject: systemd: vdsmd: fixed sanlock requirement
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19572
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(2 comments)
File client/vdsClient.py
Line 1694:
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1: Verified-1
Fails starting the VM for hosted engine setup after disconnecting the pool and
calling
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File client/vdsClient.py
Line 1694:
Sandro Bonazzola has posted comments on this change.
Change subject: Report conflict when python-cpopen is installed
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23632
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
..
Patch Set 2:
(1 comment)
please, remember that this sos plugin doesn't work on Fedora 20 due to API
Sandro Bonazzola has posted comments on this change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
..
Patch Set 2:
See http://gerrit.ovirt.org/#/c/23793/
and
https://bugzilla.redhat.com/1037663
--
To view,
Sandro Bonazzola has posted comments on this change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
..
Patch Set 2:
Please, test vdsm packages on all supported distro :-)
# sosreport -o vdsm -a
--
To view,
Sandro Bonazzola has posted comments on this change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23925/2/vdsm/sos/vdsm.py.in
File
Sandro Bonazzola has posted comments on this change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
..
Patch Set 2:
Sandro, I did not know about that incompatibility. We must fix it before rc.
log-collector
Sandro Bonazzola has posted comments on this change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
..
Patch Set 2:
you can open a bug for tracking needed changes in vdsm sos plugin and add it to
ovirt f20
Sandro Bonazzola has posted comments on this change.
Change subject: spec: replace requires vdsm-python-cpopen
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23942
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Report sanlock not configured when sanlock is down
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Adding configure sanlock on force
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Adding configure sanlock on force
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24153
To unsubscribe, visit
1 - 100 of 380 matches
Mail list logo
