ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 1:
VIR_DUMP_MEMORY_ONLY was support recently buy libvirt and qemu.
So to test DUMP_MEMORY_ONLY, should update libvirt
ShaoHe Feng has posted comments on this change.
Change subject: [WIP]Add text-based console support
..
Patch Set 1: I would prefer that you didn't submit this
why not use fix port?
such as ssh vmuuid@adrress -p port.
or ssh
ShaoHe Feng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7396
To
ShaoHe Feng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 2: Looks good to me, but someone else must approve
I also encounter this problem before. but strangely, this
ShaoHe Feng has uploaded a new change for review.
Change subject: Added an option to create a watchdog device.
..
Added an option to create a watchdog device.
A support for a watchdog device was added to the devices
ShaoHe Feng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
..
Patch Set 3:
remove the 'else' branch and re-document the commit message.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
..
Patch Set 3:
Dan, I find vdsClient.py is difficult to parser the sub-command.
I find some other lib, like python
ShaoHe Feng has uploaded a new change for review.
Change subject: move get-conf-item to vdsm-tool
..
move get-conf-item to vdsm-tool
many items in init scripts and spec file.
move the complexity from out of the init scripts and
ShaoHe Feng has posted comments on this change.
Change subject: move get-conf-item to vdsm-tool
..
Patch Set 1: (1 inline comment)
File vdsm-tool/vdsm_conf_item.py.in
Line
ShaoHe Feng has posted comments on this change.
Change subject: remove the broken support for delivering video to local display
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
ShaoHe Feng has uploaded a new change for review.
Change subject: fix dataProgress of migration
..
fix dataProgress of migration
even if migeration is finished, dataProcessed may be less than
dataTotal, it will not up to 100%.
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 1:
I migrate to file without full copy of disk.
the guest memory is 1G, and at last the migration file is 221548328.
I
ShaoHe Feng has posted comments on this change.
Change subject: Added an option to create a watchdog device.
..
Patch Set 2:
changes to qemu.conf with auto_dump_path will be in another patch.
It is better to add a new API to
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] Initial live storage migration implementation
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
new APIs are added, and these
ShaoHe Feng has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: [WIP]add mem cgroup support to vdsm
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3:
surely, Zhengsheng.
I use the libvirt dom coreDump API to do the migration without copy of disk.
then get job info
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe, visit http://gerrit.ovirt.org/settings
ShaoHe Feng has posted comments on this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 2: (1 inline comment)
File
ShaoHe Feng has posted comments on this change.
Change subject: generate initramfs on demand in VM creation test
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7693
To
ShaoHe Feng has posted comments on this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] Initial live storage migration implementation
..
Patch Set 6: No score
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit
ShaoHe Feng has uploaded a new change for review.
Change subject: schema: add 'class' types to support class constructors
..
schema: add 'class' types to support class constructors
Adam addes class constructors to the schema in
ShaoHe Feng has uploaded a new change for review.
Change subject: schema: Fixup command return values
..
schema: Fixup command return values
There still one is not fixuped, so fix it.
Change-Id:
ShaoHe Feng has posted comments on this change.
Change subject: schema: Fixup command return values
..
Patch Set 1:
Adam:
I still can not run process-schema.py successfully.
you have fixed command return values in
ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 1: (1 inline comment)
File vdsm_cli/vdsClient.py
Line
ShaoHe Feng has uploaded a new change for review.
Change subject: schema: add missing vdsm-version of symbol comment
..
schema: add missing vdsm-version of symbol comment
Two entity comments in the VDSM API schema miss
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe, visit http://gerrit.ovirt.org/settings
ShaoHe Feng has uploaded a new change for review.
Change subject: schema: make the member name of TaskDetails entity same in
comment and definition
..
schema: make the member name of TaskDetails entity same in comment and
ShaoHe Feng has abandoned this change.
Change subject: schema: Fixup the code which handles command return values in
process-schema
..
Patch Set 2: Abandoned
sorry, a mistake. the set 2 is a new patch, but use set 1 changeID.
Hello Zhou Zheng Sheng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/8190
to review the following change.
Change subject: schema: Fixup the code which handles command return values in
process-schema
ShaoHe Feng has abandoned this change.
Change subject: test
..
Patch Set 2: Abandoned
sorry, my fault. because the wrong changID.
--
To view, visit http://gerrit.ovirt.org/8190
To unsubscribe, visit
ShaoHe Feng has uploaded a new change for review.
Change subject: schema: Fixup command return values
..
schema: Fixup command return values
There still one is not fixuped, so fix it.
Change-Id:
Hello Zhou Zheng Sheng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/8193
to review the following change.
Change subject: schema: Fixup the code which handles command return values in
process-schema
ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 4: (2 inline comments)
Commit Message
Line 3: AuthorDate: 2012-08-07
ShaoHe Feng has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
..
Patch Set 3: I would prefer that you didn't submit this
please also
ShaoHe Feng has posted comments on this change.
Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7890
ShaoHe Feng has abandoned this change.
Change subject: schema: Fixup the code which handles command return values in
process-schema
..
Patch Set 1: Abandoned
I have submitted a series of patches to fix all the bugs. all the
ShaoHe Feng has abandoned this change.
Change subject: schema: add 'class' types to support class constructors
..
Patch Set 2: Abandoned
I have submitted a series of patches to fix all the bugs. all the bugs were
earlier than
ShaoHe Feng has abandoned this change.
Change subject: schema: add missing vdsm-version of symbol comment
..
Patch Set 1: Abandoned
Dan, I'm sorry.
I have submitted a series of patches to fix all the bugs. all the bugs were
ShaoHe Feng has abandoned this change.
Change subject: schema: make the member name of TaskDetails entity same in
comment and definition
..
Patch Set 1: Abandoned
I have submitted a series of patches to fix all the bugs. all
ShaoHe Feng has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
..
Patch Set 3:
yes, you are right.
since you have move the files from vdsm-gluster rpm to vdsm
ShaoHe Feng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 3: (5 inline comments)
File
ShaoHe Feng has posted comments on this change.
Change subject: Fix some pep8 errors
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8237
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: schema: add explanation string for the ballonInfo field
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: schema: Add tune element to vmparameter
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
seems reduplicate patch.
ShaoHe Feng has posted comments on this change.
Change subject: schema: New type VmParameters
..
Patch Set 5: (1 inline comment)
File vdsm_api/vdsmapi-schema.json
Line 2385:
ShaoHe Feng has posted comments on this change.
Change subject: Fix some pep8 errors in storageServer.py
..
Patch Set 1: I would prefer that you didn't submit this
please add this file to PEP8_WHITELIST in Makefile.am.
--
To
ShaoHe Feng has uploaded a new change for review.
Change subject: add path instead of file items in PEP8_WHITELIST
..
add path instead of file items in PEP8_WHITELIST
In some of directories, the pep8 of all the python source
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 8: (1 inline comment)
File vdsm/vdsmd.init.in
Line
ShaoHe Feng has posted comments on this change.
Change subject: pep8: Make vdsm_api pep8 clean
..
Patch Set 1: I would prefer that you didn't submit this
you should add these files to PEP8_WHITELIST in Makefile.am
--
To view,
ShaoHe Feng has posted comments on this change.
Change subject: Fix some pep8 errors in storageServer.py
..
Patch Set 1: Looks good to me, but someone else must approve
I have make pep8 on this patch, there are only 3 pep8
ShaoHe Feng has posted comments on this change.
Change subject: Don't require fingerprint
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8647
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: pep8: Make vdsm_api pep8 clean
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8664
To unsubscribe,
ShaoHe Feng has uploaded a new change for review.
Change subject: test
..
test
Change-Id: Ib21db9c7850f68e532b00cdd52d3c726015fa265
Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com
---
M vdsm.spec.in
1 file changed, 10
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 9:
Doron
Thank you for your review.
1. Default action will be set 'none' in the next patch.
2. A VM
ShaoHe Feng has abandoned this change.
Change subject: test
..
Patch Set 1: Abandoned
sorry, this is just a rough draft patch.
--
To view, visit http://gerrit.ovirt.org/8739
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: itmap unit tests
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
File
ShaoHe Feng has posted comments on this change.
Change subject: itmap starts threads for each argument causes too many oop
operations
..
Patch Set 1: (1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Replace 'has_key' with 'in'
..
Patch Set 1: Looks good to me, but someone else must approve
has_key() is deprecated by pep8.
as Make Wu mentioned when pep8 on
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 11: Verified
how to verified this patch.
Maybe there is no a UI in engine to add a watchdog device.
you
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 11:
sorry, but some os version such as ubuntu will not add the watchdog
automatically.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 11:
some format error with my last Message.
after the vm start up, you can use virsh to watch the
ShaoHe Feng has posted comments on this change.
Change subject: trivial: Some style fixes in API logging
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8801
To
ShaoHe Feng has uploaded a new change for review.
Change subject: Remove rebundant plus between two strings in parenthesis
..
Remove rebundant plus between two strings in parenthesis
Python will join them automatically without
ShaoHe Feng has posted comments on this change.
Change subject: Remove rebundant plus between two strings in parenthesis
..
Patch Set 1:
I find these cases by:
git grep -i -E '\(.*\s\+$'
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: Fix string format in storage exception
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8766
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Fix string format in storage exception
..
Patch Set 1:
here is the test result before fix this patch:
# python
Python 2.7.3 (default, Apr 30 2012, 21:18:11)
ShaoHe Feng has posted comments on this change.
Change subject: Remove rebundant plus between two strings in parenthesis
..
Patch Set 1: (1 inline comment)
Commit Message
ShaoHe Feng has posted comments on this change.
Change subject: trivial: Some style fixes in API logging
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: CannotRemoveLogicalVolume is raised with arguments.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: CannotRemoveLogicalVolume is raised with arguments.
..
Patch Set 1: (2 inline comments)
File
ShaoHe Feng has posted comments on this change.
Change subject: Adding threads limitation to misc.tmap
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Remove redundant plus between two strings in parenthesis
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8812
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Applied PEP-8 guideline on code
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: Applied PEP-8 guideline on code
..
Patch Set 3: (2 inline comments)
it is better to sort the pep8 white list.
ShaoHe Feng has posted comments on this change.
Change subject: Adding threads limitation to misc.tmap
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
..
Patch Set 4: (3 inline comments)
File configure.ac
ShaoHe Feng has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
..
Patch Set 5:
I agree with Ryan.
We should not make this patch much simpler.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: itmap unit tests
..
Patch Set 11: Looks good to me, but someone else must approve
(1 inline comment)
File
ShaoHe Feng has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
..
Patch Set 5:
sorry.
I agree with Ryan.
We should make this patch much simpler.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
..
Patch Set 5:
Zhou Zheng Sheng:
agree.
since in vdsm.spec.in, it require xz for logrotate.
we can only
ShaoHe Feng has posted comments on this change.
Change subject: Change in error message format
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: Applied PEP-8 guideline on code
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8933
To unsubscribe,
ShaoHe Feng has posted comments on this change.
Change subject: CannotRemoveLogicalVolume is raised with arguments.
..
Patch Set 1: (1 inline comment)
File
ShaoHe Feng has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
..
Patch Set 2: I would prefer that you didn't submit this
it is better add a comment about vm_sample_memory_interval in
ShaoHe Feng has posted comments on this change.
Change subject: WIP storage: Alert for using vdsm.conf nfs_mount_options
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has uploaded a new change for review.
Change subject: get max_tasks and thread_pool_size from config by getint()
..
get max_tasks and thread_pool_size from config by getint()
It is OK to get max_tasks and
ShaoHe Feng has posted comments on this change.
Change subject: Add callback to the plethora of retry halting possibilities
..
Patch Set 2: (2 inline comments)
File
ShaoHe Feng has posted comments on this change.
Change subject: Fix problem where a 0 error code will cause remoteFileHandler
to become a zombie
..
Patch Set 6: Fails; I would prefer that you didn't submit this
(1 inline
ShaoHe Feng has posted comments on this change.
Change subject: Get oop from object instance
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8920
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Source image exception when querying source image
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Fix problem where a 0 error code will cause remoteFileHandler
to become a zombie
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view,
ShaoHe Feng has posted comments on this change.
Change subject: Make utils pep8 compliant
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9092
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
..
Patch Set 2: No score
sorry.
vdsm.conf.sample is generated by ./vdsm/Makefile.am.
vm_sample_memory_interval will be
1 - 100 of 355 matches
Mail list logo
