Zhou Zheng Sheng has uploaded a new change for review.
Change subject: add simple VM creation functional test
..
add simple VM creation functional test
Create a VM using existing host kernel and initramfs, then destroy it.
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make libvirtvm.py PEP8 compliant
..
Patch Set 1:
The same work has been done in http://gerrit.ovirt.org/#/c/7422/ .
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 1: (4 inline comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 1: (2 inline comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/libvirtvm.py PEP 8 clean
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Rebase to latest master. Run through
Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/libvirtvm.py PEP 8 clean
..
Patch Set 6:
Thanks Antoni!
--
To view, visit http://gerrit.ovirt.org/6561
To unsubscribe, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 2: (2 inline comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 4: Looks good to me, but someone else must approve
Deepak and Shaohe gives +1 to patch set 3.
Base on
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix PEP8 violations in vm.py
..
Patch Set 1: No score
(3 inline comments)
I just located the cases that caught my eye. The current pep8 tool can not
cover
Hello Xu He Jie,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7520
to review the following change.
Change subject: Make vdsm/storage/fileSD.py pep8 clean
..
Make vdsm/storage/fileSD.py pep8
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/storage/fileSD.py pep8 clean
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Run through autobuild.sh. pydiff says the
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: libvirtvm: allow acpi again
..
Patch Set 1: Looks good to me, but someone else must approve
This bug is introduced in my refactor patch. I open the gerrit
Zhou Zheng Sheng has posted comments on this change.
Change subject: libvirtvm: allow acpi again
..
Patch Set 1:
Maybe we could add a unit test to check these kind of error. I can give it a
try.
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 1:
There are two considerations.
1. How do users download the dump file on the host storage? For example, we can
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add a basic xmlrpc functional test
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5788
To unsubscribe, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
..
Patch Set 2:
Shao He, Dan is not against to if...else. In fact he thinks we do not support
argument written as
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7200
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add a basic xmlrpc functional test
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5788
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 2:
Thanks Dan, the bug is at https://bugzilla.redhat.com/show_bug.cgi?id=853674 .
I hope my little script
Zhou Zheng Sheng has posted comments on this change.
Change subject: wait 1 second before umount
..
Patch Set 4: Verified
Run through autobuild.sh, test_mkFloppyFs passed.
--
To view, visit http://gerrit.ovirt.org/6995
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 6: (3 inline comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
..
Patch Set 5:
Thank Dan for reminding me to check the minimum sleep time. The minimum sleep
time to evade
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 7: (3 inline comments)
Creating a initramfs on my machine costs 50s. Using the default arguments,
Zhou Zheng Sheng has posted comments on this change.
Change subject: generate initramfs on demand in VM creation test
..
Patch Set 1:
Dan Kenigsberg suggests me cache the generated initramfs. I am not sure where
to put the
Zhou Zheng Sheng has posted comments on this change.
Change subject: spec: declare mkimageTests' requirement of genisoimage
..
Patch Set 1: Verified
Run through autobuild.sh
Then I remove genisoimage from my system and
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item to vdsm-tool
..
Patch Set 1: (3 inline comments)
The idea is good.
I notice that the script dynamic creates many tools named
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Thanks Yaniv Bronhaim, could you paste the related log messages in
/var/log/vdsm/vdsm.log? I guess
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
And in this case, if we ps aux | grep qemu, you will see there is no qemu
process. Since the VM is
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Thanks Yaniv Bronhaim. This is because in the tests we ask vdsm to use KVM, but
the KVM module is not
Zhou Zheng Sheng has posted comments on this change.
Change subject: [WIP] Add text-based console support
..
Patch Set 2: (2 inline comments)
File vdsm/consoleServer.py
Line
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: remove the broken support for delivering video to local display
..
remove the broken support for delivering video to local display
In vdsClient help message
Zhou Zheng Sheng has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 9:
Thanks Yaniv.
In patch set 9, I let the test detect KVM, if it's not available it just skip.
The
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/configNetwork.py PEP8 clean
..
Patch Set 2: I would prefer that you didn't submit this
(16 inline comments)
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/configNetwork.py PEP8 clean
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Run through autobuild.sh.
pydiff reports 10
Zhou Zheng Sheng has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
..
Patch Set 5:
It's not related to kernel, so I will update the description in the comments.
--
To view,
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 9: Verified
After removing the kvm module, the VM tests are skipped.
After enabling faqemu, the VM tests
Zhou Zheng Sheng has abandoned this change.
Change subject: wait a little time before umount in mkFloppyFs
..
Patch Set 5: Abandoned
The bug is actually a gnome bug. On servers we do not install gnome, so it's
not worth to
Zhou Zheng Sheng has posted comments on this change.
Change subject: remove the broken support for delivering video to local display
..
Patch Set 2: Verified
After removing 'local' from display parameter set, submitting a VM
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 9: (1 inline comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 10: (1 inline comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 1:
I did not conduct an experiment. I just read the related code you mentioned. It
seems you are right. If
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe,
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make netinfo.py PEP8 clean
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
Looks OK.
pydiff says,
pydiff netinfo*.py
2
Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
..
Patch Set 1:
Thanks Ryan Harper, Yaniv Bronhaim, on my machine, when I probe the kvm and
kvm_intel,
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make netinfo.py PEP8 clean
..
Patch Set 4: (1 inline comment)
File vdsm/netinfo.py
Line 187: def
Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
..
Patch Set 1:
Thanks very much Ryan. If it is a bug of Fedora and is not easily to fix
quickly, then
Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
..
Patch Set 1: (2 inline comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
..
Patch Set 2: Verified
Test the patch on my Fedora17. When faqemu is enabled, vdsm deletes the fake
Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8ize vdsm_api
..
Patch Set 1: Fails; I would prefer that you didn't submit this
(2 inline comments)
Found 4 changes in vdsmapi.py. They are changing
Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
..
Patch Set 2: (2 inline comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
..
Patch Set 1:
Good idea Dan. If someone add a .py.in to git but forget to add the .py file to
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
..
Patch Set 1:
Fine, I agree with you Dan.
--
To view, visit http://gerrit.ovirt.org/7890
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8ize vdsm/vdsm entry point
..
Patch Set 1: Verified
(1 inline comment)
Run through autobuild.sh.
pydiff reports same changes, they are splitting big
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 13: Looks good to me, but someone else must approve
Do you have a plan on implementing multi-level
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix some PEP8 violations in vm.py so the pep8 tool would stop
complaining
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 2: (3 inline comments)
Looks fine, but please explain my questions first.
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Zhou Zheng Sheng has posted comments on this change.
Change subject: Remove REST bindings
..
Patch Set 1: I would prefer that you didn't submit this
Please also remove 'rest' from SUBDIRS in vdsm/Makefile.am.
--
To view,
Zhou Zheng Sheng has posted comments on this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 2: (1 inline comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 2: (1 inline comment)
Thanks for your kind remind.
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 13: Verified
Firstly fetch and checkout the patch, run through autobuild.sh.
Then I add another
Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/storage/storage_exception.py PEP 8 clean
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Run autobuild.sh successfully.
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: add VM creation test over localfs storage layout
..
add VM creation test over localfs storage layout
It can be easily extended to use nfs or iscsi storage
Hello Adam Litke, Royce Lv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/8182
to review the following change.
Change subject: storage functional test with multiple storage domains and images
..
Zhou Zheng Sheng has posted comments on this change.
Change subject: storage functional test with multiple storage domains and images
..
Patch Set 1:
I've tested the patch myself.
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: storage functional test with multiple storage domains and images
..
Patch Set 1:
Note: You can run the test successfully the first time, but you have to
Zhou Zheng Sheng has posted comments on this change.
Change subject: add VM creation test over localfs storage layout
..
Patch Set 1:
I've tested the patch myself.
Note: There is a bug in vdsm that prevents us from re-using
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 2: Verified; I would prefer that you didn't submit this
(1 inline comment)
Successfully connect to
Zhou Zheng Sheng has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 4: (2 inline comments)
Commit Message
Line 3: AuthorDate:
Zhou Zheng Sheng has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 4: (1 inline comment)
File vdsm/vm.py
Line 303:
Line 304:
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7695
Zhou Zheng Sheng has posted comments on this change.
Change subject: generate initramfs on demand in VM creation test
..
Patch Set 3: Verified
Run autobuild.sh. Install the rpms and pass the test with host initramfs. When
the
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
..
Patch Set 2: (1 inline comment)
File Makefile.am
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
..
Patch Set 2: Looks good to me, but someone else must approve
Thanks Mark Wu, I see.
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: storage functional test with multiple storage domains and images
..
Patch Set 1:
How to test:
Run autobuild.sh first, then install the generated rpms
Zhou Zheng Sheng has posted comments on this change.
Change subject: add VM creation test over localfs storage layout
..
Patch Set 1:
How to test:
Run autobuild.sh first, then install the generated rpms including vdsm-python,
Zhou Zheng Sheng has posted comments on this change.
Change subject: avoid creating hangover in storage domain cache after formatting
..
Patch Set 1: (1 inline comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: add VM creation test over localfs storage layout
..
Patch Set 2:
Another patch of mine for generate initramfs is mereged to master. That patch
affects the
Zhou Zheng Sheng has posted comments on this change.
Change subject: storage functional test with multiple storage domains and images
..
Patch Set 2:
Another patch of mine on xmlrpcTests.py is mereged to master, so I rebase
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix some pep8 errors
..
Patch Set 2:
Would you add vdsm/storage/misc.py to PEP8_WHITELIST?
--
To view, visit http://gerrit.ovirt.org/8237
To unsubscribe,
Zhou Zheng Sheng has posted comments on this change.
Change subject: modify hsm.py for PEP8 compliance
..
Patch Set 1: I would prefer that you didn't submit this
Inactive patch. I will rebase it soon.
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 2: No score
(1 inline comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix some pep8 errors
..
Patch Set 3: Looks good to me, but someone else must approve
I notice that sdc.py is not in the Makefile.am. Other things are OK. I
Zhou Zheng Sheng has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 1: (1 inline comment)
File tests/functional/xmlrpcTests.py
Zhou Zheng Sheng has posted comments on this change.
Change subject: add VM creation test over localfs storage layout
..
Patch Set 3:
set 3, extract the method for start a VM through kernel boot in a separate
patch.
--
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 1: (1 inline comment)
File tests/functional/xmlrpcTests.py
Zhou Zheng Sheng has posted comments on this change.
Change subject: extract a method for booting a test VM through kernel boot
..
Patch Set 1: (1 inline comment)
File
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: xmlrpcTests: narrow the expected exception when using retry
..
xmlrpcTests: narrow the expected exception when using retry
Change the expected exception
Zhou Zheng Sheng has posted comments on this change.
Change subject: xmlrpcTests: narrow the expected exception when using retry
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8444
To unsubscribe, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: Remove duplicate implementation of tobool
..
Patch Set 2: (1 inline comment)
File vdsm/hooking.py
Line
Zhou Zheng Sheng has posted comments on this change.
Change subject: Remove duplicate implementation of tobool
..
Patch Set 2:
As far as I know there is no obvious way to suppress the warning. I thin keep
hooking.py in the
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: hsm: use misc.parseBool instead of ad-hoc bool convertion
..
hsm: use misc.parseBool instead of ad-hoc bool convertion
Change-Id:
Zhou Zheng Sheng has posted comments on this change.
Change subject: hsm: use misc.parseBool instead of ad-hoc bool convertion
..
Patch Set 1:
Other code in this file use parseBool but tobool, so this patch just follows
the
Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
..
Patch Set 2: Verified
Passes autobuild.sh. pydiff reports two changes, which are of kind changing
Zhou Zheng Sheng has abandoned this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 3: Abandoned
As Adam says.
--
To view, visit http://gerrit.ovirt.org/8020
To unsubscribe,
Zhou Zheng Sheng has posted comments on this change.
Change subject: xmlrpcTests: narrow the expected exception when using retry
..
Patch Set 2: Verified
patch 2
extract a method to do retrying of the assertion in
1 - 100 of 1019 matches
Mail list logo
