Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

2017-08-30 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: Enabled selinux boolean virt_use_glusterd for glusterd .. Patch Set 3: Code-Review+1 Verified+1 copying scores

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

2017-08-30 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: Enabled selinux boolean virt_use_glusterd for glusterd .. Patch Set 2: Code-Review+1 -- To view, visit

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has restored this change. ( https://gerrit.ovirt.org/81155 ) Change subject: [wip] fix vmdevices.storage.makeName .. Restored wrong click. Francesco can abandon again if

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81150 ) Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces" .. Abandoned was a silly attempt

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81155 ) Change subject: [wip] fix vmdevices.storage.makeName .. Abandoned -- To view, visit

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: move sitecustomize to static .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80859 ) Change subject: move sitecustomize to static .. move sitecustomize to static Change-Id:

Change in vdsm[master]: ovs-dpdk: support ovs 2.7

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80818 ) Change subject: ovs-dpdk: support ovs 2.7 .. ovs-dpdk: support ovs 2.7 Compatibility

Change in vdsm[master]: ovs-dpdk: support ovs 2.7

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: ovs-dpdk: support ovs 2.7 .. Patch Set 7: unrelated failure ERROR: test_with_device (loopback_test.TestDevice)

Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80819 ) Change subject: automation: Fix - Add iproute-tc package to fc25 .. automation: Fix - Add

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: move sitecustomize to static .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/80859/6

Change in vdsm[master]: Fix exploding tox

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/81172 ) Change subject: Fix exploding tox .. Fix exploding tox It seems that a new 'pluggy'

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: move sitecustomize to static .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: move sitecustomize to static .. Patch Set 5: (1 comment)

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: move sitecustomize to static .. Patch Set 5: ok, now I recalled. so why do you need to add the static path it in

Change in vdsm[ovirt-4.1]: stomp: introduce restore_subscriptions in client

2017-08-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/78919 ) Change subject: stomp: introduce restore_subscriptions in client .. stomp: introduce

Change in vdsm[ovirt-4.1]: stomp: introduce restore_subscriptions in client

2017-08-29 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: stomp: introduce restore_subscriptions in client .. Patch Set 4: Code-Review+2 -- To view, visit

Change in vdsm[master]: stomp: calls are now blocking

2017-08-29 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: stomp: calls are now blocking .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

2017-08-29 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: Enabled selinux boolean virt_use_glusterd for glusterd .. Patch Set 1: Code-Review-1 (1 comment)

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

2017-08-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Enabled selinux boolean virt_use_glusterd for glusterd .. Patch Set 1: (1 comment)

Change in vdsm[master]: move sitecustomize to static

2017-08-29 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: move sitecustomize to static .. Patch Set 5: mmm... I don't see any usage of this thing... why not just to remove

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: [wip] fix vmdevices.storage.makeName .. [wip] fix vmdevices.storage.makeName it should mimic

Change in vdsm[master]: metrics: stop sending host metrics except storage

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80050 ) Change subject: metrics: stop sending host metrics except storage .. metrics: stop

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

2017-08-29 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Hello Jenkins CI, gerrit-hooks, Irit Goihman, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/81150 to review the following change. Change subject: Revert "dpdk: add only non dpdk nics to aqcu

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/81150 ) Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces" .. Uploaded patch set 1. -- To

Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25

2017-08-29 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: automation: Fix - Add iproute-tc package to fc25 .. Patch Set 2: Code-Review+2 -- To view, visit

Change in vdsm[master]: dpdk: add only non dpdk nics to aqcuired ifaces

2017-08-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80688 ) Change subject: dpdk: add only non dpdk nics to aqcuired ifaces .. dpdk: add only non

Change in vdsm[master]: vdsm-client: help now shows gluster commands

2017-08-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/81000 ) Change subject: vdsm-client: help now shows gluster commands .. vdsm-client: help now

Change in vdsm[master]: move dsaversion to common

2017-08-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80954 ) Change subject: move dsaversion to common .. move dsaversion to common dsaversion is

Change in vdsm[master]: documentation: update README.md

2017-08-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80856 ) Change subject: documentation: update README.md .. documentation: update README.md The

Change in vdsm[master]: virt: Store block job info to metadata

2017-08-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: Store block job info to metadata .. Patch Set 23: Unrelated error. Slave seems to need a reboot. ERROR: Tests

Change in vdsm[master]: virt: Store block job info to metadata

2017-08-27 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: virt: Store block job info to metadata .. Patch Set 23: Code-Review+2 raising score -- To view, visit

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79981 ) Change subject: net: import config from vdsm.common.config .. net: import config from

Change in vdsm[master]: move dsaversion to common

2017-08-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move dsaversion to common .. Patch Set 2: Verified+1 http://jenkins.ovirt.org/job/ovirt-system-tests_manual/1013/

Change in vdsm[master]: spec: split network and common code to subrpms

2017-08-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: split network and common code to subrpms .. Patch Set 2: Verified+1

Change in vdsm[master]: spec: split network and common code to subrpms

2017-08-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: split network and common code to subrpms .. Patch Set 2: ost

Change in vdsm[master]: net: Update tags to reflect backport of getLldp command

2017-08-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80374 ) Change subject: net: Update tags to reflect backport of getLldp command .. net: Update

Change in vdsm[master]: net: Update tags to reflect backport of getLldp command

2017-08-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed a vote on this change. Change subject: net: Update tags to reflect backport of getLldp command .. Removed Verified-1 by Dominik Holler

Change in vdsm[master]: net: Update tags to reflect backport of getLldp command

2017-08-24 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Update tags to reflect backport of getLldp command .. Patch Set 1: Verified+1 code merged to 4.1.6 -- To view,

Change in vdsm[master]: spec: split network and common code to subrpms

2017-08-23 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: split network and common code to subrpms .. Patch Set 2: ci please build -- To view, visit

Change in vdsm[master]: spec: split network and common code to subrpms

2017-08-23 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: split network and common code to subrpms .. spec: split network and common code to subrpms The code of the

Change in vdsm[master]: move vdsm.config to common

2017-08-23 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79980 ) Change subject: move vdsm.config to common .. move vdsm.config to common vdsm.config is

Change in vdsm[master]: hooking: move to lib

2017-08-23 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80842 ) Change subject: hooking: move to lib .. hooking: move to lib As part of broader

Change in vdsm[master]: hooking: move to lib

2017-08-23 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: hooking: move to lib .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80842 To unsub

Change in vdsm[master]: hooking: move to lib

2017-08-23 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: hooking: move to lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/80842 To unsub

Change in vdsm[master]: metrics: stop sending host metrics except storage

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: metrics: stop sending host metrics except storage .. Patch Set 2: Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: stop using hard coded values for heartbeats .. Patch Set 5: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/78918 ) Change subject: stomp: stop using hard coded values for heartbeats .. stomp: stop using

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

2017-08-23 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: stomp: stop using hard coded values for heartbeats .. Patch Set 4: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80911 ) Change subject: stomp: fix AsyncDispatcher next_check_interval .. stomp: fix

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: fix AsyncDispatcher next_check_interval .. Patch Set 2: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/78917 ) Change subject: stomp: handle timeout in server side .. stomp: handle timeout in server

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

2017-08-23 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: stomp: fix AsyncDispatcher next_check_interval .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: handle timeout in server side .. Patch Set 4: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

2017-08-23 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: stomp: handle timeout in server side .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovi

Change in vdsm[master]: metrics: stop sending host metrics except storage

2017-08-23 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: metrics: stop sending host metrics except storage .. Patch Set 2: Code-Review+1 -- To view, visit

Change in vdsm[ovirt-4.1]: stomp: handle incoming heartbeats

2017-08-23 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/78916 ) Change subject: stomp: handle incoming heartbeats .. stomp: handle incoming heartbeats

Change in vdsm[ovirt-4.1]: stomp: handle incoming heartbeats

2017-08-23 Thread Code Review
From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: stomp: handle incoming heartbeats .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: move dsaversion to common

2017-08-23 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: move dsaversion to common .. move dsaversion to common dsaversion is used by infra and network subsystems, and

Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network

2017-08-23 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80835 ) Change subject: network: remove ip from a nic used by a removed network .. network:

Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network

2017-08-23 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: network: remove ip from a nic used by a removed network .. Patch Set 2: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80192 ) Change subject: net: Enable LLDP on NICs .. net: Enable LLDP on NICs lldpad has to be

Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80187 ) Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. net: Introduce

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80194 ) Change subject: net: Report lldp through new getLldp command .. net: Report lldp through

Change in vdsm[ovirt-4.1]: network: add driverloader module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80186 ) Change subject: network: add driverloader module .. network: add driverloader module

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80327 ) Change subject: net: Introduce network initializer module .. net: Introduce network

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80390 ) Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces ..

Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80193 ) Change subject: net: Add info lldp to lldp .. net: Add info lldp to lldp lldp is

Change in vdsm[ovirt-4.1]: network: add driverloader module

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: network: add driverloader module .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovi

Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. Patch Set 6: Code-Review+2 Verified+1 -- To view,

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce network initializer module .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Enable LLDP on NICs .. Patch Set 8: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Add info lldp to lldp .. Patch Set 8: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Report lldp through new getLldp command .. Patch Set 10: Code-Review+2 Verified+1 -- To view, visit

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. Patch Set 5: Code-Review+2 Veri

Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vdsm tool configurators: bond_defaults - do not depend on time .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80804 ) Change subject: net: place bonding defaults under /var/run .. net: place bonding defaults

Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80805 ) Change subject: vdsm tool configurators: bond_defaults - do not depend on time .. vdsm

Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: place bonding defaults under /var/run .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovi

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. Patch Set 5: ci please build -- To view,

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/80327 ) Change subject: net: Introduce network initializer module .. Removed reviewer gerrit-hooks

Change in vdsm[master]: net tests: Setup a network marked with default route but no GW

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net tests: Setup a network marked with default route but no GW .. Patch Set 5: Code-Review-1 (1 comment)

Change in vdsm[master]: net tests func: Fix IPv4 default route assertion

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80777 ) Change subject: net tests func: Fix IPv4 default route assertion .. net tests func: Fix

Change in vdsm[master]: move vdsm.config to common

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/79980 To

Change in vdsm[master]: net tests func: Fix IPv4 default route assertion

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net tests func: Fix IPv4 default route assertion .. Patch Set 3: Code-Review+2 raising -- To view, visit

Change in vdsm[master]: move vdsm.config to common

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 8: passes ost http://jenkins.ovirt.org/job/ovirt-system-tests_manual/996/ --

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 8: Verified+1 passes ost

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 8:

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 8: ci please build -- To view, visit

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80908 ) Change subject: vdsm.tool.service: unbreak tool.service .. vdsm.tool.service: unbreak

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm.tool.service: unbreak tool.service .. Patch Set 2: Verified+1 11:24:19 @ Run test: 002_bootstrap.py: 11:24:19

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm.tool.service: unbreak tool.service .. Patch Set 2:

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm.tool.service: unbreak tool.service .. Patch Set 2: ci please build -- To view, visit

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: vdsm.tool.service: unbreak tool.service .. vdsm.tool.service: unbreak tool.service In commit 53a2562 I have avoided

Change in vdsm[master]: tests: improve faking

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80756 ) Change subject: tests: improve faking .. tests: improve faking This patch avoids this

Change in vdsm[master]: move vdsm.config to common

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/79980/7/tests/config_test.py

Change in vdsm[master]: vhostuser: convert macAddr to string

2017-08-22 Thread Code Review
From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vhostuser: convert macAddr to string .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/8

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

2017-08-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80212 ) Change subject: checkimages hook: avoid using execCmd(sync=False) .. checkimages hook:

Change in vdsm[master]: hooking: move to lib

2017-08-21 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: hooking: move to lib .. Patch Set 1: are you should its working? it failed.. -- To view, visit

Change in vdsm[master]: tool.service: avoid execCmd(raw=False)

2017-08-19 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80213 ) Change subject: tool.service: avoid execCmd(raw=False) .. tool.service: avoid

  1   2   3   4   5   6   7   8   9   10   >