Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 3: Code-Review+1 Verified+1

copying scores after nit fix

-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda <go...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Denis Chapligin <akash...@gmail.com>
Gerrit-Reviewer: Gobinda <go...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda <go...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Denis Chapligin <akash...@gmail.com>
Gerrit-Reviewer: Gobinda <go...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has restored this change. ( https://gerrit.ovirt.org/81155 )

Change subject: [wip] fix vmdevices.storage.makeName
..


Restored

wrong click. Francesco can abandon again if needed

-- 
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81150 )

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
..


Abandoned

was a silly attempt to debug the CI failure

-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81155 )

Change subject: [wip] fix vmdevices.storage.makeName
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80859 )

Change subject: move sitecustomize to static
..


move sitecustomize to static


Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Signed-off-by: Piotr Kliczewski 
---
M Makefile.am
M static/Makefile.am
R static/usr/share/vdsm/sitecustomize.py
M tests/run_tests_local.sh.in
M vdsm/Makefile.am
5 files changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ovs-dpdk: support ovs 2.7

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80818 )

Change subject: ovs-dpdk: support ovs 2.7
..


ovs-dpdk: support ovs 2.7

Compatibility with the old dpdk naming is broken in ovs 2.7, and as
such a device will not be available for use until a valid dpdk-devargs is
specified.
When adding dpdk devices to ovs bridge, the PCI address must be
set using the 'dpdk-devargs' option.
Device naming is arbitrary.

Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Signed-off-by: Irit Goihman 
---
M lib/vdsm/network/link/dpdk.py
M lib/vdsm/network/ovs/driver/__init__.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/network/ovs/switch.py
M vdsm.spec.in
5 files changed, 15 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Edward Haas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ovs-dpdk: support ovs 2.7

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ovs-dpdk: support ovs 2.7
..


Patch Set 7:

unrelated failure

ERROR: test_with_device (loopback_test.TestDevice)
--
Traceback (most recent call last):
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/testValidation.py",
 line 191, in wrapper
return f(*args, **kwargs)
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback_test.py",
 line 42, in test_with_device
with loopback.Device(filename) as device:
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py",
 line 92, in __enter__
self.attach()
  File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py",
 line 56, in attach
raise cmdutils.Error(cmd, rc, out, err)
Error: Command ['losetup', '--find', '--show', '/tmp/tmpzf6_TD/file'] failed 
with rc=1 out='' err='losetup: /tmp/tmpzf6_TD/file: failed to set up loop 
device: No such file or directory\n'

-- 
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80819 )

Change subject: automation: Fix - Add iproute-tc package to fc25
..


automation: Fix - Add iproute-tc package to fc25

On recent fedora25, the tc tool has been extracted out of iproute
package and moved to its own package.
This package is now added as a VDSM dependency (used by
vdsm-networking for QoS).

This patch fixes an older patch where the dependency has not been
correctly added to the spec file:
e23586b6d9c913786b06ec063649c8eb56d73a49

Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Signed-off-by: Edward Haas 
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/80819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/80859/6/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

PS6, Line 21: @top_srcdir@/vdsm
I think that this should be dropped. nothing is left there.


-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Fix exploding tox

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/81172 )

Change subject: Fix exploding tox
..


Fix exploding tox

It seems that a new 'pluggy' version (0.5.0) was added in PyPi and this
causes check-patch.sh to explode when trying to create the Python 3.x
environments.

This patch forces installation of pluggy 0.4.0 or lower.

Change-Id: Ie68af2b3e749f3c670d5031402ea2d10840fd770
Signed-off-by: Barak Korren 
---
M automation/check-patch.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Edward Haas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/81172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie68af2b3e749f3c670d5031402ea2d10840fd770
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Barak Korren 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/80859/5/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

Line 17: NOSE_EVAL_ATTR \
Line 18: NOSE_LOGFORMAT='%(asctime)s %(levelname)-5s (%(threadName)s) 
[%(name)s] %(message)s (%(module)s:%(lineno)d)' \
Line 19: NOSE_VERBOSE=${NOSE_VERBOSE:-3} \
Line 20: PYTHONDONTWRITEBYTECODE=1 \
Line 21: 
PYTHONPATH="@top_srcdir@/static/usr/share/vdsm:@top_srcdir@/lib:@top_srcdir@/vdsm:@top_srcdir@/client:@top_srcdir@/vdsm_api:$PYTHONPATH"
 \
why is this needed?
Line 22: $NULL
Line 23: 
Line 24: "$PYTHON_EXE" @top_srcdir@/tests/testrunner.py --local-modules $@ &
Line 25: runner_pid=$!


-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 5:

ok, now I recalled. so why do you need to add the static path it in 
run_tests_local ?

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: introduce restore_subscriptions in client

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78919 )

Change subject: stomp: introduce restore_subscriptions in client
..


stomp: introduce restore_subscriptions in client

restore_subscriptions is required for persisting subscriptions
after client reconnects to server.

Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncClientTests.py
2 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/78919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: introduce restore_subscriptions in client

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: introduce restore_subscriptions in client
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: calls are now blocking

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: calls are now blocking
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/81167
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia23da36d261251ddd4484479fc4214c461467c86
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/81088/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Enabled selinux boolean virt_use_glusterd for glusterd
Line 8: 
Line 9: bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1458257
Line 10: 
redundant empty line, and please use capital letter for Bug-Url: ..
Line 11: Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12


-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda <go...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Denis Chapligin <akash...@gmail.com>
Gerrit-Reviewer: Gobinda <go...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/81088/1/lib/vdsm/tool/configurators/sebool.py
File lib/vdsm/tool/configurators/sebool.py:

Line 1: # Copyright 2012 Red Hat, Inc.
please change to 2012-2017
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Denis Chapligin 
Gerrit-Reviewer: Gobinda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move sitecustomize to static

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: move sitecustomize to static
..


Patch Set 5:

mmm... I don't see any usage of this thing... why not just to remove it ?

-- 
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] fix vmdevices.storage.makeName

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: [wip] fix vmdevices.storage.makeName
..

[wip] fix vmdevices.storage.makeName

it should mimic 
http://elixir.free-electrons.com/linux/latest/ident/sd_format_disk_name

Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/virt/vmdevices/storage.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/81155/1

diff --git a/lib/vdsm/virt/vmdevices/storage.py 
b/lib/vdsm/virt/vmdevices/storage.py
index a67d4f8..f34deb7 100644
--- a/lib/vdsm/virt/vmdevices/storage.py
+++ b/lib/vdsm/virt/vmdevices/storage.py
@@ -806,8 +806,10 @@
 devindex = ''
 
 i = int(index)
-while i > 0:
+while True:
 devindex = chr(ord('a') + (i % 26)) + devindex
-i //= 26
+i = i // 26 - 1
+if i < 0:
+break
 
 return devname.get(interface, 'hd') + (devindex or 'a')


-- 
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: metrics: stop sending host metrics except storage

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80050 )

Change subject: metrics: stop sending host metrics except storage
..


metrics: stop sending host metrics except storage

stop sending host metrics except storage
to statsd, since they will be collected by collectd.

Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Bug-Url: https://bugzilla.redhat.com/1469109
Signed-off-by: Shirly Radco 
---
M lib/vdsm/host/api.py
1 file changed, 0 insertions(+), 40 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shirly Radco 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Hello Jenkins CI, gerrit-hooks, Irit Goihman, Edward Haas,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/81150

to review the following change.

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
..

Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

This reverts commit 936e6cc89aec8fb6a5894382ea1a349979c3fc06.

Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/81150/1

diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py
index 64930c9..cff51b9 100644
--- a/lib/vdsm/network/ovs/switch.py
+++ b/lib/vdsm/network/ovs/switch.py
@@ -124,8 +124,7 @@
 nic = attrs.get('nic')
 bond = attrs.get('bonding')
 sb = nic or bond
-if not dpdk.is_dpdk(sb):
-self._acquired_ifaces.add(sb)
+self._acquired_ifaces.add(sb)
 
 bridge = self._get_ovs_bridge(sb)
 self._create_nb(bridge, net)


-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/81150 )

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
..


Uploaded patch set 1.

-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: revert
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: automation: Fix - Add iproute-tc package to fc25
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dpdk: add only non dpdk nics to aqcuired ifaces

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80688 )

Change subject: dpdk: add only non dpdk nics to aqcuired ifaces
..


dpdk: add only non dpdk nics to aqcuired ifaces

Acquirement should not be done on DPDK based ifaces
since the actions are not supported on these devices.

Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Signed-off-by: Irit Goihman 
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Edward Haas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm-client: help now shows gluster commands

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/81000 )

Change subject: vdsm-client: help now shows gluster commands
..


vdsm-client: help now shows gluster commands

vdsm-client help will print gluster commands help when passing
"--gluster-enabled" option.
It will work only if vdsm-gluster is installed and gluster schema is present.

# vdsm-client --gluster-enabled -h

...

Namespaces:
namespace method [arg=value]
GlusterEvent
Task
GlusterSnapshot
LVMVolumeGroup
Image
VM
Volume
Host
GlusterHost
ISCSIConnection
StorageDomain
StoragePool
GlusterService
GlusterHook
SDM
GlusterTask
GlusterVolume
Lease

Change-Id: I666cc2fd9a7f976dc60e792384acc2c32bceb864
Signed-off-by: Irit Goihman 
---
M lib/vdsmclient/client.py
1 file changed, 14 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/81000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I666cc2fd9a7f976dc60e792384acc2c32bceb864
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move dsaversion to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80954 )

Change subject: move dsaversion to common
..


move dsaversion to common

dsaversion is used by infra and network subsystems, and should thus be
shipped in common.

Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Signed-off-by: Dan Kenigsberg 
---
M .gitignore
M lib/vdsm/Makefile.am
M lib/vdsm/common/Makefile.am
R lib/vdsm/common/dsaversion.py.in
M lib/vdsm/host/caps.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/vdsmd.py
M vdsm.spec.in
8 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: documentation: update README.md

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80856 )

Change subject: documentation: update README.md
..


documentation: update README.md

The installation paragraph has been rewritten due to some
mistakes.

Change-Id: Ie78a8ecbb75f49e9a73b3ec969d4b72377948419
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1401281
---
M README.md
1 file changed, 14 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/80856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie78a8ecbb75f49e9a73b3ec969d4b72377948419
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Store block job info to metadata

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: virt: Store block job info to metadata
..


Patch Set 23:

Unrelated error. Slave seems to need a reboot.

ERROR: Tests mkimage.mkFloppyFs creating an image and checking its content.

-- 
To view, visit https://gerrit.ovirt.org/80020
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf7312ad524e72010698b024d0524c2271db93e7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Store block job info to metadata

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: virt: Store block job info to metadata
..


Patch Set 23: Code-Review+2

raising score

-- 
To view, visit https://gerrit.ovirt.org/80020
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf7312ad524e72010698b024d0524c2271db93e7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: import config from vdsm.common.config

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/79981 )

Change subject: net: import config from vdsm.common.config
..


net: import config from vdsm.common.config

Change-Id: Id1fc5799d93e4328da288875b9b48d920eaa30c6
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/netrestore.py
M lib/vdsm/network/netupgrade.py
M lib/vdsm/network/restore_net_config.py
7 files changed, 10 insertions(+), 11 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified
  Edward Haas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79981
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1fc5799d93e4328da288875b9b48d920eaa30c6
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move dsaversion to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: move dsaversion to common
..


Patch Set 2: Verified+1

http://jenkins.ovirt.org/job/ovirt-system-tests_manual/1013/ passed

-- 
To view, visit https://gerrit.ovirt.org/80954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: split network and common code to subrpms

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: split network and common code to subrpms
..


Patch Set 2: Verified+1

http://jenkins.ovirt.org/job/ovirt-system-tests_manual/1013/ passed

-- 
To view, visit https://gerrit.ovirt.org/80982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11b663ff23023661017c6045a20925ca6abac69d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: split network and common code to subrpms

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: split network and common code to subrpms
..


Patch Set 2:

ost http://jenkins.ovirt.org/job/ovirt-system-tests_manual/1013/

-- 
To view, visit https://gerrit.ovirt.org/80982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11b663ff23023661017c6045a20925ca6abac69d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Update tags to reflect backport of getLldp command

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80374 )

Change subject: net: Update tags to reflect backport of getLldp command
..


net: Update tags to reflect backport of getLldp command

The API extension for Link Layer Discovery Protocol (LLDP) will be
backported to oVirt 4.1.5.

The 'added:' tags are updated to 4.1 to reflect this.

Change-Id: I2dd21a7cd8aadeb33c333ac0733ae1903e96e21c
Signed-off-by: Dominik Holler 
---
M lib/vdsm/api/vdsm-api.yml
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2dd21a7cd8aadeb33c333ac0733ae1903e96e21c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Update tags to reflect backport of getLldp command

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has removed a vote on this change.

Change subject: net: Update tags to reflect backport of getLldp command
..


Removed Verified-1 by Dominik Holler 

-- 
To view, visit https://gerrit.ovirt.org/80374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2dd21a7cd8aadeb33c333ac0733ae1903e96e21c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Update tags to reflect backport of getLldp command

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: Update tags to reflect backport of getLldp command
..


Patch Set 1: Verified+1

code merged to 4.1.6

-- 
To view, visit https://gerrit.ovirt.org/80374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd21a7cd8aadeb33c333ac0733ae1903e96e21c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: split network and common code to subrpms

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: split network and common code to subrpms
..


Patch Set 2:

ci please build

-- 
To view, visit https://gerrit.ovirt.org/80982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11b663ff23023661017c6045a20925ca6abac69d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: split network and common code to subrpms

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: spec: split network and common code to subrpms
..

spec: split network and common code to subrpms

The code of the network subsystem still depends on the rest of vdsm.
Despite that, this patch introduces the vdsm-network and vdsm-common
subrpms as a little step to declare file ownership on an installed host.

Please note that at least the following dependencies remain:
* vdsm.network.api and vdsm.network.configurators.ifcfg depnend on vdsm.hooks,
  which in turn depends on execCmd
* vdsm.network.link.sriov depends on vdsm.udevadm
* vdsm.netswitch.configurators depends on vdsm.tool.service
* vdsm.network.initilizer.init_unprivileged_network_components still
  depends on vdsm.supervdsm
* vdsm.network.restore_net_config depends on vdsm.hostdev

Change-Id: I11b663ff23023661017c6045a20925ca6abac69d
Signed-off-by: Dan Kenigsberg 
---
M contrib/shell_helper
M vdsm.spec.in
2 files changed, 84 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/80982/1

diff --git a/contrib/shell_helper b/contrib/shell_helper
index 8e782d5..93fbe49 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -11,7 +11,7 @@
 
 _latest_rpms() {
 local VERSION=$(_latest_version)
-find "$RPMDIR"/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|client|http|jsonrpc|tests|api|hook-vmfex-dev"
+find "$RPMDIR"/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|client|http|jsonrpc|tests|api|hook-vmfex-dev|common|network"
 }
 
 vdsm_configure_force() {
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 5ffcd65..96d3c54 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -124,6 +124,7 @@
 Requires: safelease >= 1.0-7
 Requires: mom >= 0.5.8
 Requires(pre): shadow-utils
+Requires(preun): %{name}-network
 
 Obsoletes: %{name}-infra < 4.19
 
@@ -301,6 +302,8 @@
 BuildArch:  noarch
 Requires:   python-cpopen >= 1.5
 Requires:   python-ioprocess >= 0.16.1-1
+Requires:   %{name}-common = %{version}-%{release}
+Requires:   %{name}-network = %{version}-%{release}
 
 %description python
 Shared libraries between the various VDSM packages.
@@ -317,6 +320,22 @@
 rm -f %{python2_sitearch}/%{vdsm_name}/__init__.py*
 fi
 fi
+
+%package common
+Summary:common VDSM python libraries, required by all subsystems
+BuildArch:  noarch
+
+%description common
+VDSM libraries that are imported by all subsystems
+
+%package network
+Summary:VDSM network libraries
+BuildArch:  noarch
+Requires:   %{name}-common = %{version}-%{release}
+Requires:   %{name} = %{version}-%{release}
+
+%description network
+VDSM network libraries
 
 %package tests
 Summary:VDSM Test Suite
@@ -871,8 +890,6 @@
 %dir %{_libexecdir}/%{vdsm_name}
 %dir %{_sysconfdir}/%{vdsm_name}/vdsm.conf.d
 %dir %{_sysconfdir}/modprobe.d/
-%dir %{_sysconfdir}/NetworkManager
-%dir %{_sysconfdir}/NetworkManager/conf.d
 %dir %{_sysconfdir}/%{vdsm_name}
 %dir %{_sysconfdir}/%{vdsm_name}/mom.d
 %dir %{_datadir}/%{vdsm_name}
@@ -892,7 +909,6 @@
 %{_tmpfilesdir}/%{vdsm_name}.conf
 %{_sysconfdir}/dhcp/dhclient.d/dhclientmon.sh
 %{_sysconfdir}/modprobe.d/vdsm-bonding-modprobe.conf
-%{_sysconfdir}/NetworkManager/conf.d/vdsm.conf
 %{_sysconfdir}/sudoers.d/50_vdsm
 %{_sysconfdir}/cron.hourly/vdsm-logrotate
 %{_sysconfdir}/libvirt/hooks/qemu
@@ -1008,14 +1024,10 @@
 %{_datadir}/%{vdsm_name}/autounattend/Win2012R2.xml
 %{_datadir}/%{vdsm_name}/autounattend/Win2016.xml
 
-%files python
-%{_mandir}/man1/vdsm-tool.1*
-%{_bindir}/vdsm-tool
-%dir %{python_sitelib}/%{vdsm_name}
-%dir %{python_sitelib}/%{vdsm_name}/common
-%dir %{python_sitelib}/%{vdsm_name}/common/network
-%dir %{python_sitelib}/%{vdsm_name}/gluster
-%dir %{python_sitelib}/%{vdsm_name}/host
+%files network
+%dir %{_sysconfdir}/NetworkManager
+%dir %{_sysconfdir}/NetworkManager/conf.d
+%{_sysconfdir}/NetworkManager/conf.d/vdsm.conf
 %dir %{python_sitelib}/%{vdsm_name}/network
 %dir %{python_sitelib}/%{vdsm_name}/network/configurators
 %dir %{python_sitelib}/%{vdsm_name}/network/ip
@@ -1034,52 +1046,8 @@
 %dir %{python_sitelib}/%{vdsm_name}/network/ovs
 %dir %{python_sitelib}/%{vdsm_name}/network/ovs/driver
 %dir %{python_sitelib}/%{vdsm_name}/network/tc
-%dir %{python_sitelib}/%{vdsm_name}/metrics
-%dir %{python_sitelib}/%{vdsm_name}/tool
-%dir %{python_sitelib}/%{vdsm_name}/tool/configurators
-%dir %{python_sitelib}/%{vdsm_name}/profiling
-%dir %{python_sitelib}/%{vdsm_name}/storage
-%dir %{python_sitelib}/%{vdsm_name}/supervdsm_api
-%dir %{python_sitelib}/%{vdsm_name}/virt
-%dir %{python_sitelib}/%{vdsm_name}/virt/vmdevices
-%{python_sitelib}/%{vdsm_name}/__init__.py*
-%{python_sitelib}/%{vdsm_name}/alignmentScan.py*
-%{python_sitelib}/%{vdsm_name}/API.py*
-%{python_sitelib}/%{vdsm_name}/client.py*
-%{python_sitelib}/%{vdsm_name}/clientIF.py*

Change in vdsm[master]: move vdsm.config to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/79980 )

Change subject: move vdsm.config to common
..


move vdsm.config to common

vdsm.config is used by all subsystems. It should thus sit in common.
This patch keeps a proxy in place, so that existing users of vdsm.config
can be updated in separate patches.

Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Signed-off-by: Dan Kenigsberg 
---
M .gitignore
M lib/vdsm/Makefile.am
M lib/vdsm/common/Makefile.am
R lib/vdsm/common/config.py.in
A lib/vdsm/config.py
M tests/config_test.py
6 files changed, 41 insertions(+), 9 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/79980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80842 )

Change subject: hooking: move to lib
..


hooking: move to lib

As part of broader migration we move hooking.py away from vdsm dir.


Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Signed-off-by: Piotr Kliczewski 
---
M Makefile.am
M configure.ac
M lib/vdsm/Makefile.am
A lib/vdsm/hook/Makefile.am
A lib/vdsm/hook/__init__.py
R lib/vdsm/hook/hooking.py
M lib/vdsm/hooks.py
M vdsm.spec.in
M vdsm/Makefile.am
9 files changed, 33 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: hooking: move to lib
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mbur...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: hooking: move to lib
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mbur...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: metrics: stop sending host metrics except storage

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: metrics: stop sending host metrics except storage
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: stop using hard coded values for heartbeats
..


Patch Set 5: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78918 )

Change subject: stomp: stop using hard coded values for heartbeats
..


stomp: stop using hard coded values for heartbeats

We wish to support incoming heartbeats in JSONRPC client
in order to implement reconnect mechanism.
AsyncClient connect method used to send HEARTBEAT header with
hard coded values, which are now configurable and enable both
ways heartbeats.

Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/stompAsyncClientTests.py
3 files changed, 28 insertions(+), 9 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: stop using hard coded values for heartbeats
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80911 )

Change subject: stomp: fix AsyncDispatcher next_check_interval
..


stomp: fix AsyncDispatcher next_check_interval

If next_check_interval returns 0, asyncore loop is triggerred.
In case of no outgoing heartbeat, the function doesn't ignore the
calculation and returns 0, which causes the loop to be triggerred
constantly and send heartbeats.
On server side outgoing heartbeats are always greater than 0 so we
didn't encounter this behavior before. When we added the same
functionality to client side, where outgoing heartbeat is 0 by default,
we encountered high cpu usage.

Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncDispatcherTests.py
2 files changed, 23 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/80911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: fix AsyncDispatcher next_check_interval
..


Patch Set 2: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/80911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78917 )

Change subject: stomp: handle timeout in server side
..


stomp: handle timeout in server side

When the server stops receiving incoming heartbeats, it should
cleanup subscriptions and close the fd.

Signed-off-by: Irit Goihman 
Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stompreactor.py
M tests/stompAdapterTests.py
2 files changed, 57 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/78917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: fix AsyncDispatcher next_check_interval
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: handle timeout in server side
..


Patch Set 4: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/78917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: handle timeout in server side
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: metrics: stop sending host metrics except storage

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: metrics: stop sending host metrics except storage
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/80050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle incoming heartbeats

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78916 )

Change subject: stomp: handle incoming heartbeats
..


stomp: handle incoming heartbeats

According to stomp specification, Heart-beating can optionally be used
to test the healthiness of the underlying TCP connection and to make sure
that the remote end is alive and kicking. [1]
until now, we ignored incoming heartbeats and raised ValueError
when their value was not 0.
This patch gets the incoming heartbeats and updates the
dispatcher according to their value.
incoming heartbeat will be updated every time a new frame will be
received, indicating connection is still active.
If timeout has exceeded, the frame handler (client or server) will handle
it according to its implementation.

[1] https://stomp.github.io/stomp-specification-1.2.html#Heart-beating

Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncDispatcherTests.py
2 files changed, 38 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/78916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle incoming heartbeats

[Code Review]

From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: handle incoming heartbeats
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move dsaversion to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: move dsaversion to common
..

move dsaversion to common

dsaversion is used by infra and network subsystems, and should thus be
shipped in common.

Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Signed-off-by: Dan Kenigsberg 
---
M .gitignore
M lib/vdsm/Makefile.am
M lib/vdsm/common/Makefile.am
R lib/vdsm/common/dsaversion.py.in
M lib/vdsm/host/caps.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/vdsmd.py
M vdsm.spec.in
8 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/80954/1

diff --git a/.gitignore b/.gitignore
index 7e8c362..f004f9c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,7 +29,7 @@
 lib/vdsm/api/vdsm-api.html
 lib/vdsm/common/constants.py
 lib/vdsm/common/config.py
-lib/vdsm/dsaversion.py
+lib/vdsm/common/dsaversion.py
 lib/sos/vdsm.py
 lib/vdsm/storage/lvm.env
 lib/vdsm/storage/protect/spmprotect.sh
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 1dd66d7..133143c 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -70,7 +70,6 @@
$(NULL)
 
 nodist_vdsmpylib_PYTHON = \
-   dsaversion.py \
$(NULL)
 
 nodist_noinst_DATA= \
@@ -84,7 +83,6 @@
 
 
 EXTRA_DIST = \
-   dsaversion.py.in \
vdsm.conf.sample \
$(NULL)
 
diff --git a/lib/vdsm/common/Makefile.am b/lib/vdsm/common/Makefile.am
index 3dafdc9..ec30777 100644
--- a/lib/vdsm/common/Makefile.am
+++ b/lib/vdsm/common/Makefile.am
@@ -25,6 +25,7 @@
 nodist_vdsmcommon_PYTHON = \
config.py \
constants.py \
+   dsaversion.py \
$(NULL)
 
 dist_vdsmcommon_PYTHON = \
@@ -34,6 +35,7 @@
 EXTRA_DIST = \
config.py.in \
constants.py.in \
+   dsaversion.py.in \
$(NULL)
 
 CLEANFILES = \
diff --git a/lib/vdsm/dsaversion.py.in b/lib/vdsm/common/dsaversion.py.in
similarity index 100%
rename from lib/vdsm/dsaversion.py.in
rename to lib/vdsm/common/dsaversion.py.in
diff --git a/lib/vdsm/host/caps.py b/lib/vdsm/host/caps.py
index 21c02a8..73378f0 100644
--- a/lib/vdsm/host/caps.py
+++ b/lib/vdsm/host/caps.py
@@ -27,13 +27,13 @@
 import libvirt
 
 from vdsm.common import cache
+from vdsm.common import dsaversion
 from vdsm.config import config
 from vdsm.host import rngsources
 from vdsm.storage import hba
 from vdsm import containersconnection
 from vdsm import cpuarch
 from vdsm import cpuinfo
-from vdsm import dsaversion
 from vdsm import hooks
 from vdsm import host
 from vdsm import hostdev
diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index ff16817..2a4c89b 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -32,10 +32,11 @@
 
 import six
 
-from vdsm import dsaversion
 from vdsm import hooks
+
 from vdsm.common import concurrent
 from vdsm.common import constants
+from vdsm.common import dsaversion
 from vdsm.common import fileutils
 from vdsm.common.config import config
 from vdsm.common.conv import tobool
diff --git a/lib/vdsm/vdsmd.py b/lib/vdsm/vdsmd.py
index ee734bc..ff9deaa 100755
--- a/lib/vdsm/vdsmd.py
+++ b/lib/vdsm/vdsmd.py
@@ -30,7 +30,6 @@
 
 from vdsm import commands
 from vdsm import constants
-from vdsm import dsaversion
 from vdsm import health
 from vdsm import jobs
 from vdsm import schedule
@@ -38,6 +37,7 @@
 from vdsm import containersconnection
 from vdsm import taskset
 from vdsm import metrics
+from vdsm.common import dsaversion
 from vdsm.common import sigutils
 from vdsm.common import time
 from vdsm.common import zombiereaper
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4a57f5c..a9e0f83 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -736,7 +736,7 @@
 rawversion=%{version}-%{release}
 sed -i -e 's/^software_version =.*/software_version = "'"${baseversion}"'"/' \
-e 's/^raw_version_revision =.*/raw_version_revision = 
"'"${rawversion}"'"/' \
-   -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' 
lib/vdsm/dsaversion.py
+   -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' 
lib/vdsm/common/dsaversion.py
 
 %install
 make DESTDIR=%{buildroot} install
@@ -1058,7 +1058,6 @@
 %{python_sitelib}/%{vdsm_name}/containersconnection.py*
 %{python_sitelib}/%{vdsm_name}/cpuarch.py*
 %{python_sitelib}/%{vdsm_name}/cpuinfo.py*
-%{python_sitelib}/%{vdsm_name}/dsaversion.py*
 %{python_sitelib}/%{vdsm_name}/dmidecodeUtil.py*
 %{python_sitelib}/%{vdsm_name}/executor.py*
 # gluster.exception is used in many places like Bridge.py. So it is required


-- 
To view, visit https://gerrit.ovirt.org/80954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master

Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80835 )

Change subject: network: remove ip from a nic used by a removed network
..


network: remove ip from a nic used by a removed network

Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Signed-off-by: Petr Horacek 
Bug-Url: https://bugzilla.redhat.com/1432386
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
M tests/network/func_static_ip_test.py
3 files changed, 83 insertions(+), 19 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: network: remove ip from a nic used by a removed network
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phora...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80192 )

Change subject: net: Enable LLDP on NICs
..


net: Enable LLDP on NICs

lldpad has to be configured to provide LLDP on network interfaces.

This change activates LLDP on all NICs.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Signed-off-by: Dominik Holler 
(cherry picked from commit 53d332fa38bb1e4d75dbe9a7760d6e9e961cdde4)
---
M lib/vdsm/network/initializer.py
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80187 )

Change subject: net: Introduce the LLDPAD driver with an LLDP interface
..


net: Introduce the LLDPAD driver with an LLDP interface

The Link Layer Discovery Protocol (LLDP) is a vendor-neutral link layer
protocol in the Internet Protocol Suite used by network devices for
advertising their identity, capabilities, and neighbors on an IEEE 802
local area network, principally wired Ethernet.

This patch introduces an LLDP interface, implemented using the lldpad
service & tool.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Signed-off-by: Edward Haas 
Signed-off-by: Dominik Holler 
(cherry picked from commit 7b47fe3bbac7dd1e126d55b8064f6807819caf5e)
---
M configure.ac
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/lldp/Makefile.am
A lib/vdsm/network/lldp/__init__.py
A lib/vdsm/network/lldp/lldpad.py
A lib/vdsm/network/lldpad/Makefile.am
A lib/vdsm/network/lldpad/__init__.py
A lib/vdsm/network/lldpad/lldptool.py
M static/usr/lib/systemd/system/vdsmd.service.in
A tests/network/lldpad_test.py
M tests/network/nettestlib.py
M vdsm.spec.in
12 files changed, 605 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80194 )

Change subject: net: Report lldp through new getLldp command
..


net: Report lldp through new getLldp command

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Signed-off-by: Dominik Holler 
(cherry picked from commit ada4b07375d8e41782177760b75e7c125430dc5f)
---
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/supervdsm_api/network.py
M vdsm/API.py
4 files changed, 80 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: network: add driverloader module

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80186 )

Change subject: network: add driverloader module
..


network: add driverloader module

DriverLoader class provides tools to gather and provide drivers
(interface implementations).

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I8609f81f3b38f5f88f46c0d020de2b16da26adbd
Signed-off-by: Dominik Holler 
Signed-off-by: Petr Horáček 
(cherry picked from commit 4b40a62ab25fdaca9b23d8121ab00d35e9f76ca4)
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/driverloader.py
A tests/network/driverloader_test.py
M vdsm.spec.in
4 files changed, 82 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8609f81f3b38f5f88f46c0d020de2b16da26adbd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80327 )

Change subject: net: Introduce network initializer module
..


net: Introduce network initializer module

In following commit, the network initialization will require
multiple calls to privileged initialization functions. To avoid
the details of initialization of privileged network components
in supervdsmServer, this patch moves the initialization of
privileged network components to network.initializer.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Signed-off-by: Dominik Holler 
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/initializer.py
M vdsm.spec.in
M vdsm/supervdsmServer
4 files changed, 29 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80327
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80390 )

Change subject: net: Report empty LLDP TLV lists for operationally-down 
interfaces
..


net: Report empty LLDP TLV lists for operationally-down interfaces

Before this patch, a single interface that was never monitored by lldpad
had caused the API level to fail, blocking information about
properly-enabled interfaces.

This change reports interfaces being not in state UP as not
enabled for LLDP with an empty list of TLVs.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Signed-off-by: Dominik Holler 
(cherry picked from commit 347eec3c024c76405e60d97f53ef312614797530)
---
M lib/vdsm/network/lldp/info.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80193 )

Change subject: net: Add info lldp to lldp
..


net: Add info lldp to lldp

lldp is extended to provide informations received by LLDP.
The provided lldp information can be restricted by a filter.
The only implemented filter criteria is to restrict the lldp
information by a list of NIC names received the LLDP information.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Signed-off-by: Dominik Holler 
(cherry picked from commit c859c274ad1de001b0600baf874f4547c13cbbcc)
---
M lib/vdsm/network/api.py
A lib/vdsm/network/lldp/info.py
2 files changed, 52 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80193
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: network: add driverloader module

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: network: add driverloader module
..


Patch Set 3: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8609f81f3b38f5f88f46c0d020de2b16da26adbd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Introduce the LLDPAD driver with an LLDP interface
..


Patch Set 6: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Introduce network initializer module
..


Patch Set 6: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80327
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Enable LLDP on NICs
..


Patch Set 8: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Add info lldp to lldp
..


Patch Set 8: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80193
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Report lldp through new getLldp command
..


Patch Set 10: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Report empty LLDP TLV lists for operationally-down 
interfaces
..


Patch Set 5: Code-Review+2 Verified+1

./run_suite.sh -s 
http://jenkins.ovirt.org/job/vdsm_4.1_check-patch-el7-x86_64/870/ 
basic-suite-4.1

is successful, this can go it.

-- 
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm tool configurators: bond_defaults - do not depend on time
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgold...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80804 )

Change subject: net: place bonding defaults under /var/run
..


net: place bonding defaults under /var/run

vdsm-tool places bonding-defaults.json under /usr/share. However,
the proper place to store application data that is generated every boot
is under /var/run.

Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Bug-Url: https://bugzilla.redhat.com/1482014
Signed-off-by: Dan Kenigsberg 
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/netinfo/bonding.py
M lib/vdsm/tool/configurators/bond_defaults.py
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Leon Goldberg: Looks good to me, but someone else must approve
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/80804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80805 )

Change subject: vdsm tool configurators: bond_defaults - do not depend on time
..


vdsm tool configurators: bond_defaults - do not depend on time

The bond defaults dump is considered updated if it exists (as it is
created per boot, and its content is dependent on the kernel).

The existing time check (verifying if the period elapsed from the file
update is no older then the time elapsed from the system boot) is no
longer needed, as the dump is placed under /var/run which is assured
to be cleaned on boot.
This patch removes the time checks which are not valid when the time is
updated during the boot.

Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Bug-Url: https://bugzilla.redhat.com/1482014
Signed-off-by: Edward Haas 
---
M lib/vdsm/tool/configurators/bond_defaults.py
1 file changed, 1 insertion(+), 17 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Leon Goldberg: Looks good to me, but someone else must approve
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/80805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: place bonding defaults under /var/run
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgold...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: Report empty LLDP TLV lists for operationally-down 
interfaces
..


Patch Set 5:

ci please build

-- 
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Introduce network initializer module

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has removed gerrit-hooks from this change. ( 
https://gerrit.ovirt.org/80327 )

Change subject: net: Introduce network initializer module
..


Removed reviewer gerrit-hooks with the following votes:

* Verified-1 by gerrit-hooks 

-- 
To view, visit https://gerrit.ovirt.org/80327
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests: Setup a network marked with default route but no GW

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Setup a network marked with default route but no GW
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/80739/5//COMMIT_MSG
Commit Message:

PS5, Line 9: expose
the problem is not immediately exposed to the reader. can you elaborate with a 
comment?


-- 
To view, visit https://gerrit.ovirt.org/80739
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40973e3783b2b9ae8e8f5c1eda0b8998c93c0aa1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgold...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests func: Fix IPv4 default route assertion

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80777 )

Change subject: net tests func: Fix IPv4 default route assertion
..


net tests func: Fix IPv4 default route assertion

The request flag of defaultRoute is not directly related to the net caps
property of ipv4defaultroute.
ipv4defaultroute is true when the network gateway is also the host
default route.
However, a request with defaultRoute set and no gateway is valid,
resulting with a false ipv4defaultroute.

This patch updates the assertion check to be in sync with the
described logic.

Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Signed-off-by: Edward Haas 
---
M tests/network/functional/netfunctestlib.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/80777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move vdsm.config to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: move vdsm.config to common
..


Patch Set 8: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/79980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests func: Fix IPv4 default route assertion

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net tests func: Fix IPv4 default route assertion
..


Patch Set 3: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/80777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move vdsm.config to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: move vdsm.config to common
..


Patch Set 8:

passes ost http://jenkins.ovirt.org/job/ovirt-system-tests_manual/996/

-- 
To view, visit https://gerrit.ovirt.org/79980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: import config from vdsm.common.config

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: import config from vdsm.common.config
..


Patch Set 8: Verified+1

passes ost http://jenkins.ovirt.org/job/ovirt-system-tests_manual/996/

-- 
To view, visit https://gerrit.ovirt.org/79981
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fc5799d93e4328da288875b9b48d920eaa30c6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: import config from vdsm.common.config

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: import config from vdsm.common.config
..


Patch Set 8:

http://jenkins.ovirt.org/job/ovirt-system-tests_manual/996/

-- 
To view, visit https://gerrit.ovirt.org/79981
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fc5799d93e4328da288875b9b48d920eaa30c6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: import config from vdsm.common.config

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: import config from vdsm.common.config
..


Patch Set 8:

ci please build

-- 
To view, visit https://gerrit.ovirt.org/79981
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fc5799d93e4328da288875b9b48d920eaa30c6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80908 )

Change subject: vdsm.tool.service: unbreak tool.service
..


vdsm.tool.service: unbreak tool.service

In commit 53a2562 I have avoided execCmd splitting its output to lines,
but I ignored a case where the split was actually used. I do not yet
understand how did this passed my verification.

Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/tool/service.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/80908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.tool.service: unbreak tool.service
..


Patch Set 2: Verified+1

11:24:19 @ Run test: 002_bootstrap.py: 
11:24:19 nose.config: INFO: Ignoring files matching ['^\\.', '^_', 
'^setup\\.py$']
11:24:19   # add_dc: 

11:24:24   # add_dc: Success (in 0:00:04)
11:24:24   # add_cluster: 
11:24:24   # add_cluster: Success (in 0:00:00)
11:24:24   # add_hosts: 

11:26:22   # add_hosts: Success (in 0:01:58)

-- 
To view, visit https://gerrit.ovirt.org/80908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.tool.service: unbreak tool.service
..


Patch Set 2:

http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/991/

-- 
To view, visit https://gerrit.ovirt.org/80908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.tool.service: unbreak tool.service
..


Patch Set 2:

ci please build

-- 
To view, visit https://gerrit.ovirt.org/80908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm.tool.service: unbreak tool.service

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: vdsm.tool.service: unbreak tool.service
..

vdsm.tool.service: unbreak tool.service

In commit 53a2562 I have avoided execCmd splitting its output to lines,
but I ignored a case where the split was actually used. I do not yet
understand how did this passed my verification.

Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/tool/service.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/80908/1

diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py
index 957e777..fdd1b11 100644
--- a/lib/vdsm/tool/service.py
+++ b/lib/vdsm/tool/service.py
@@ -116,7 +116,7 @@
 # If unit file type was specified, don't override it.
 if srvName.count('.') < 1:
 fullName = srvName + ".service"
-for line in out:
+for line in out.splitlines():
 if fullName == line.split(" ", 1)[0]:
 return systemctlFun(fullName)
 raise ServiceNotExistError("%s is not native systemctl service" %


-- 
To view, visit https://gerrit.ovirt.org/80908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: improve faking

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80756 )

Change subject: tests: improve faking
..


tests: improve faking

This patch avoids this error due to insufficient faking
AttributeError: 'NoneType' object has no attribute 'notify'

Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Signed-off-by: Francesco Romani 
---
M tests/virttests/seal_job_test.py
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/80756
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move vdsm.config to common

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: move vdsm.config to common
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/79980/7/tests/config_test.py
File tests/config_test.py:

PS7, Line 47: common_config
> Why patch vdsm.common.config if we still use the vdsm.config?
`from X import *` does not pull _privates


-- 
To view, visit https://gerrit.ovirt.org/79980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vhostuser: convert macAddr to string

[Code Review]

From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: vhostuser: convert macAddr to string
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/80066/3/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:

Line 298: supervdsm.getProxy().add_ovs_vhostuser_port(
Line 299: ovs_bridge, port, socket_path)
Line 300: 
Line 301: def _get_vhostuser_port_name(self):
Line 302: return str(uuid.uuid3(uuid.UUID(self.vmid), 
str(self.macAddr)))
I don't understand how this casting is required here but not in other users of 
self.macAddr. What is the complete value of macAddr provided from Engine? How 
is this related to the host being RHEL-7.4?
Line 303: 
Line 304: def _set_parameters_filter(self, filter):
Line 305: for name, value in self._filter_parameter_map():
Line 306: filter.appendChildWithArgs('parameter', name=name, 
value=value)


-- 
To view, visit https://gerrit.ovirt.org/80066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4d11a154ffd88523b3d7b19ac87891aac2fba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80212 )

Change subject: checkimages hook: avoid using execCmd(sync=False)
..


checkimages hook: avoid using execCmd(sync=False)

I would like to move hooking.py to the common package. However, common
does not have the complex execCmd, and is not likely to ever have
something with sync=False. This patch reimplements exec-with-timeout
using threading.Timer instead of sync=False.

Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962
Signed-off-by: Dan Kenigsberg 
---
M vdsm_hooks/checkimages/before_vm_start.py
1 file changed, 14 insertions(+), 9 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/80212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: hooking: move to lib
..


Patch Set 1:

are you should its working? it failed..

-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tool.service: avoid execCmd(raw=False)

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80213 )

Change subject: tool.service: avoid execCmd(raw=False)
..


tool.service: avoid execCmd(raw=False)

tool.service.execCmd has raw=True as its default,but two places we use
raw=False to split lines in command output. However, we concatenate
these lines immediately afterwards, or ignore them.

Change-Id: I7530451496c41d1f3568e263f1087a92a8f0f3bb
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/tool/service.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/80213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7530451496c41d1f3568e263f1087a92a8f0f3bb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org