Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/65565/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 145: self._elem.appendChild(child)
Line 146: return child
Line 147: 
Line 148: 
Line 149: class Domain(object):
> I don't like this - you are adding one utility used only in one place,  whi
Done
Line 150: 
Line 151: def __init__(self, conf, log, arch):
Line 152: """
Line 153: Create the skeleton of a libvirt domain xml


PS6, Line 524: 
> if this is used just there, with no plan for further enhancments, I'd like 
Ok, Done


-- 
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Fix API schema to align with runtime schema
..


Patch Set 3:

It seems the methods are needed in 4.0 as well.

-- 
To view, visit https://gerrit.ovirt.org/65288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Fix API schema to align with runtime schema
..


Patch Set 3:

If the engine does not call the missing JSON RPC methods in 4.0,
it should be ok to abandon it.

-- 
To view, visit https://gerrit.ovirt.org/65288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..


Patch Set 6: -Verified

-- 
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/65565/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS6, Line 511: mode = numaTune.get('mode', 'strict')
> No support per-memnode numa mode? Any specific reason for that?
I don't know of any specific reason,
engine doesn't support it right now.
It can be added when needed.


-- 
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Fix API schema to align with runtime schema
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65378
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls

[akrejcir]

Hello Piotr Kliczewski, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65377

to review the following change.

Change subject: Fix return value names for VM.ioTune calls
..

Fix return value names for VM.ioTune calls

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/60513
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63478
Reviewed-by: Piotr Kliczewski 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/65377/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 6d38f46..7965317 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -864,7 +864,7 @@
  u'totalBytes': 
  }}
 ]
-self.assertEqual(tunables['ioTunePolicy'], expected)
+self.assertEqual(tunables['ioTunePolicyList'], expected)
 
 def testSetIoTune(self):
 
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index a896f58..bfe61f0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2738,12 +2738,12 @@
 qos = self._getVmPolicy()
 ioTuneList = qos.getElementsByTagName("ioTune")
 if not ioTuneList or not ioTuneList[0].hasChildNodes():
-return response.success(ioTunePolicy=[])
+return response.success(ioTunePolicyList=[])
 
 for device in ioTuneList[0].getElementsByTagName("device"):
 tunables.append(io_tune_dom_to_values(device))
 
-return response.success(ioTunePolicy=tunables)
+return response.success(ioTunePolicyList=tunables)
 
 def getIoTune(self):
 resultList = []
@@ -2776,7 +2776,7 @@
 else:
 return response.error('updateIoTuneErr', e.message)
 
-return response.success(ioTune=resultList)
+return response.success(ioTuneList=resultList)
 
 def setIoTune(self, tunables):
 for io_tune_change in tunables:


-- 
To view, visit https://gerrit.ovirt.org/65377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client

[akrejcir]

Hello Piotr Kliczewski, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65378

to review the following change.

Change subject: Add all MOM calls to jsonrpc client
..

Add all MOM calls to jsonrpc client

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/60492
Reviewed-by: Francesco Romani 
Tested-by: Andrej Krejcir 
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/63479
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
2 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/65378/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index caffb9a..1854869 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -60,6 +60,8 @@
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
 'getDeviceList': 'Host.getDeviceList',
 'getImagesList': 'StorageDomain.getImages',
+'getIoTunePolicy': 'VM.getIoTunePolicy',
+'getIoTune': 'VM.getIoTune',
 'getSpmStatus': 'StoragePool.getSpmStatus',
 'getStorageDomainInfo': 'StorageDomain.getInfo',
 'getStorageDomainsList': 'Host.getStorageDomains',
@@ -93,10 +95,12 @@
 'setBalloonTarget': 'VM.setBalloonTarget',
 'setCpuTunePeriod': 'VM.setCpuTunePeriod',
 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+'setKsmTune': 'Host.setKsmTune',
 'setMOMPolicy': 'Host.setMOMPolicy',
 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
 'setupNetworks': 'Host.setupNetworks',
 'setVmTicket': 'VM.setTicket',
+'setIoTune': 'VM.setIoTune',
 'setVolumeDescription': 'Volume.setDescription',
 'shutdown': 'VM.shutdown',
 'spmStart': 'StoragePool.spmStart',
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 273bd2e..192de42 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -349,7 +349,7 @@
 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
 'Host_getAllVmStats': {'ret': 'statsList'},
 'Host_setupNetworks': {'ret': 'status'},
-'Host_setKsmTune': {'ret': 'taskStatus'},
+'Host_setKsmTune': {'ret': 'status'},
 'Image_cloneStructure': {'ret': 'uuid'},
 'Image_delete': {'ret': 'uuid'},
 'Image_deleteVolumes': {'ret': 'uuid'},
@@ -402,11 +402,12 @@
 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
 'VM_getMigrationStatus': {'ret': 'migrationStats'},
 'VM_pause': {'ret': VM_running_state_change_Ret},
-'VM_setCpuTunePeriod': {'ret': 'taskStatus'},
-'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
+'VM_setCpuTunePeriod': {'ret': 'status'},
+'VM_setCpuTuneQuota': {'ret': 'status'},
 'VM_hotplugMemory':  {'ret': 'vmList'},
 'VM_setNumberOfCpus': {'ret': 'vmList'},
-'VM_setIoTune': {'ret': 'taskStatus'},
+'VM_setIoTune': {'ret': 'status'},
+'VM_setBalloonTarget': {'ret': 'status'},
 'VM_updateDevice': {'ret': 'vmList'},
 'Volume_copy': {'ret': 'uuid'},
 'Volume_create': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/65378
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Fix API schema to align with runtime schema

[akrejcir]

Hello Piotr Kliczewski,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65288

to review the following change.

Change subject: Fix API schema to align with runtime schema
..

Fix API schema to align with runtime schema

Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Bug-Url: https://bugzilla.redhat.com/1348255
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/64477
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/api/vdsm-api.yml
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
3 files changed, 34 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/65288/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 05d17c2..03bc50e 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -2108,36 +2108,39 @@
 description: I/O tune parameters for the VM disk device.
 name: VmDiskDeviceIoTuneParams
 properties:
--   defaultvalue: needs updating
-description: Write throughput limit in bytes per
-second.
-name: write_bytes_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Read I/O operations limit per second.
-name: read_iops_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Read throughput limit in bytes per
-second.
-name: read_bytes_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Total throughput limit in bytes per
-second.
+-   defaultvalue: 0
+description: Total throughput limit in bytes per second.
+Value 0 means unlimited.
 name: total_bytes_sec
 type: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: 0
+description: Read throughput limit in bytes per second.
+Value 0 means unlimited.
+name: read_bytes_sec
+type: uint
+
+-   defaultvalue: 0
+description: Write throughput limit in bytes per second.
+Value 0 means unlimited.
+name: write_bytes_sec
+type: uint
+
+-   defaultvalue: 0
 description: Total I/O operations limit per second.
+Value 0 means unlimited.
 name: total_iops_sec
 type: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: 0
+description: Read I/O operations limit per second.
+Value 0 means unlimited.
+name: read_iops_sec
+type: uint
+
+-   defaultvalue: 0
 description: Write I/O operations limit per second.
+Value 0 means unlimited.
 name: write_iops_sec
 type: uint
 type: object
@@ -2830,6 +2833,10 @@
 -   description: The amount of pages to scan during one cycle.
 name: pages_to_scan
 type: int
+
+-   description:
+name: merge_across_nodes
+type: int
 type: object
 
 LoggingLevel: 
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 1854869..c24a58c 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -87,6 +87,7 @@
 'hotplugNic': 'VM.hotplugNic',
 'hotunplugDisk': 'VM.hotunplugDisk',
 'hotunplugNic': 'VM.hotunplugNic',
+'hotplugMemory': 'VM.hotplugMemory',
 'list': 'Host.getVMList',
 'migrationCreate': 'VM.migrationCreate',
 'ping': 'Host.ping',
@@ -95,7 +96,9 @@
 'setBalloonTarget': 'VM.setBalloonTarget',
 'setCpuTunePeriod': 'VM.setCpuTunePeriod',
 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+'setNumberOfCpus': 'VM.setNumberOfCpus',
 'setKsmTune': 'Host.setKsmTune',
+'setHaMaintenanceMode': 'Host.setHaMaintenanceMode',
 'setMOMPolicy': 'Host.setMOMPolicy',
 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
 'setupNetworks': 'Host.setupNetworks',
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 192de42..5a10cda 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -350,6 +350,7 @@
 'Host_getAllVmStats': {'ret': 'statsList'},
 'Host_setupNetworks': {'ret': 'status'},
 'Host_setKsmTune': {'ret': 'status'},
+'Host_setHaMaintenanceMode': {'ret': 'status'},
 'Image_cloneStructure': {'ret': 'uuid'},
 'Image_delete': {'ret': 'uuid'},
 'Image_deleteVolumes': {'ret': 'uuid'},
@@ -409,6 +410,7 @@
 'VM_setIoTune': {'ret': 'status'},
 'VM_setBalloonTarget': {'ret': 'status'},
 'VM_updateDevice': {'ret': 'vmList'},
+'VM_updateVmPolicy': {'ret': 'status'},
 'Volume_copy': {'ret': 'uuid'},
 'Volume_create': {'ret': 

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: Change description of io tune parameters.

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: schema: Change description of io tune parameters.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb130c7182ba2d618a9618b324fa1537d616a966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: Change description of io tune parameters.

[akrejcir]

Andrej Krejcir has uploaded a new change for review.

Change subject: schema: Change description of io tune parameters.
..

schema: Change description of io tune parameters.

Change-Id: Idb130c7182ba2d618a9618b324fa1537d616a966
Signed-off-by: Andrej Krejcir 
---
M lib/api/vdsm-api.yml
1 file changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/65164/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 9ebac7a..f6b9a18 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -2121,35 +2121,38 @@
 name: VmDiskDeviceIoTuneParams
 properties:
 -   defaultvalue: 0
-description: Total throughput limit in bytes per
-second.
+description: Total throughput limit in bytes per second.
+Value 0 means unlimited.
 name: total_bytes_sec
 type: uint
 
 -   defaultvalue: 0
-description: Read throughput limit in bytes per
-second.
+description: Read throughput limit in bytes per second.
+Value 0 means unlimited.
 name: read_bytes_sec
 type: uint
 
 -   defaultvalue: 0
-description: Write throughput limit in bytes per
-second.
+description: Write throughput limit in bytes per second.
+Value 0 means unlimited.
 name: write_bytes_sec
 type: uint
 
 -   defaultvalue: 0
 description: Total I/O operations limit per second.
+Value 0 means unlimited.
 name: total_iops_sec
 type: uint
 
 -   defaultvalue: 0
 description: Read I/O operations limit per second.
+Value 0 means unlimited.
 name: read_iops_sec
 type: uint
 
 -   defaultvalue: 0
 description: Write I/O operations limit per second.
+Value 0 means unlimited.
 name: write_iops_sec
 type: uint
 type: object


-- 
To view, visit https://gerrit.ovirt.org/65164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb130c7182ba2d618a9618b324fa1537d616a966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 2119
Line 2120
Line 2121
Line 2122
Line 2123
> Lets simplify, we will take this patch, and Andrej will send a patch for th
Ok


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS1, Line 2123: 
This note could be in the description instead, so user knows about the meaning 
of 0.


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Fix API schema to align with runtime schema

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Fix API schema to align with runtime schema
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Correct API schema to align with runtime schema

[akrejcir]

Andrej Krejcir has uploaded a new change for review.

Change subject: Correct API schema to align with runtime schema
..

Correct API schema to align with runtime schema

Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Bug-Url: https://bugzilla.redhat.com/1348255
Signed-off-by: Andrej Krejcir 
---
M lib/api/vdsm-api.yml
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
3 files changed, 33 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/64477/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index c7ab7f5..1f1d569 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -2120,35 +2120,35 @@
 description: I/O tune parameters for the VM disk device.
 name: VmDiskDeviceIoTuneParams
 properties:
--   defaultvalue: needs updating
-description: Write throughput limit in bytes per
-second.
-name: write_bytes_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Read I/O operations limit per second.
-name: read_iops_sec
-type: uint
-
--   defaultvalue: needs updating
-description: Read throughput limit in bytes per
-second.
-name: read_bytes_sec
-type: uint
-
--   defaultvalue: needs updating
+-   defaultvalue: 0 - means unlimited
 description: Total throughput limit in bytes per
 second.
 name: total_bytes_sec
 type: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: 0 - means unlimited
+description: Read throughput limit in bytes per
+second.
+name: read_bytes_sec
+type: uint
+
+-   defaultvalue: 0 - means unlimited
+description: Write throughput limit in bytes per
+second.
+name: write_bytes_sec
+type: uint
+
+-   defaultvalue: 0 - means unlimited
 description: Total I/O operations limit per second.
 name: total_iops_sec
 type: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: 0 - means unlimited
+description: Read I/O operations limit per second.
+name: read_iops_sec
+type: uint
+
+-   defaultvalue: 0 - means unlimited
 description: Write I/O operations limit per second.
 name: write_iops_sec
 type: uint
@@ -2577,20 +2577,6 @@
 type: *VmDeviceAddress
 type: object
 
-HotplugMemoryParams: 
-added: '3.6'
-description: Parameters for VM.hotplugMemory.
-name: HotplugMemoryParams
-properties:
--   description: The UUID of the VM to modify
-name: vmId
-type: *UUID
-
--   description: The memory device specification
-name: memory
-type: *VmMemoryDevice
-type: object
-
 VmInterfaceDeviceSpecParams: 
 added: '3.1'
 description: Additional VM interface device parameters.
@@ -2841,6 +2827,10 @@
 
 -   description: The amount of pages to scan during one cycle.
 name: pages_to_scan
+type: int
+
+-   description:
+name: merge_across_nodes
 type: int
 type: object
 
@@ -9771,9 +9761,10 @@
 name: vmID
 type: *UUID
 
--   description: The VM UUID and memory device information
-name: params
-type: *HotplugMemoryParams
+-   description: The memory device specification
+name: memory
+type: *VmMemoryDevice
+
 return:
 description: The VM definition, as updated
 type: *VmDefinition
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index e276f86..c228e77 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -89,6 +89,7 @@
 'hotplugNic': 'VM.hotplugNic',
 'hotunplugDisk': 'VM.hotunplugDisk',
 'hotunplugNic': 'VM.hotunplugNic',
+'hotplugMemory': 'VM.hotplugMemory',
 'list': 'Host.getVMList',
 'migrate': 'VM.migrate',
 'migrateStatus': 'VM.getMigrationStatus',
@@ -99,7 +100,9 @@
 'setBalloonTarget': 'VM.setBalloonTarget',
 'setCpuTunePeriod': 'VM.setCpuTunePeriod',
 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+'setNumberOfCpus': 'VM.setNumberOfCpus',
 'setKsmTune': 'Host.setKsmTune',
+'setHaMaintenanceMode': 'Host.setHaMaintenanceMode',
 'setMOMPolicy': 'Host.setMOMPolicy',
 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
 'setupNetworks': 'Host.setupNetworks',
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 5dedcc0..ceed1f9 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -356,6 +356,7 @@
 

Change in vdsm[master]: Add all MOM calls to jsonrpc client

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60492
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Apply storage QoS on running VM

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 16: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add MoM scripts to change storage QoS on running VM

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add MoM scripts to change disk QoS on running VM

[akrejcir]

Andrej Krejcir has uploaded a new change for review.

Change subject: Add MoM scripts to change disk QoS on running VM
..

Add MoM scripts to change disk QoS on running VM

Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
Signed-off-by: Andrej Krejcir 
---
M vdsm/Makefile.am
M vdsm/mom.conf.in
M vdsm/mom.d/00-defines.policy
A vdsm/mom.d/05-iotune.policy
4 files changed, 40 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/54208/1

diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 4f6de24..ccdc733 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -94,6 +94,7 @@
mom.d/02-balloon.policy \
mom.d/03-ksm.policy \
mom.d/04-cputune.policy \
+   mom.d/05-iotune.policy \
sourceRoute.sh \
sudoers.vdsm.in \
svdsm.logger.conf.in \
diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in
index 4c57d8e..fbcb56a 100644
--- a/vdsm/mom.conf.in
+++ b/vdsm/mom.conf.in
@@ -25,7 +25,7 @@
 policy-engine-interval: 15
 
 # A comma-separated list of Controller plugins to enable
-controllers: Balloon, KSM, CpuTune
+controllers: Balloon, KSM, CpuTune, IoTune
 
 # Sets the maximum number of statistic samples to keep for the purpose of
 # calculating moving averages.
@@ -81,4 +81,4 @@
 
 [guest]
 # A comma-separated list of Collector plugins to use for Guest data collection.
-collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune
+collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune, 
GuestIoTune
diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy
index 718cf04..206bb7a 100644
--- a/vdsm/mom.d/00-defines.policy
+++ b/vdsm/mom.d/00-defines.policy
@@ -8,4 +8,5 @@
 (defvar ksmEnabled 1)
 (defvar balloonEnabled 0)
 (defvar cpuTuneEnabled 1)
+(defvar ioTuneEnabled 1)
 
diff --git a/vdsm/mom.d/05-iotune.policy b/vdsm/mom.d/05-iotune.policy
new file mode 100644
index 000..3132986
--- /dev/null
+++ b/vdsm/mom.d/05-iotune.policy
@@ -0,0 +1,36 @@
+### Auto-IoTune 

+
+(defvar unlimited_io 0)
+
+### Helper functions
+(def set_io_limits (guest) {
+(with guest.io_tune tune {
+(defvar max_io tune.maximum)
+(tune.setTotalBytesSec max_io.total_bytes_sec)
+(tune.setReadBytesSec  max_io.read_bytes_sec)
+(tune.setWriteBytesSec max_io.write_bytes_sec)
+
+(tune.setTotalIopsSec max_io.total_iops_sec)
+(tune.setReadIopsSec  max_io.read_iops_sec)
+(tune.setWriteIopsSec max_io.write_iops_sec)
+})
+})
+
+(def reset_io_limits (guest) {
+(with guest.io_tune tune {
+(tune.setTotalBytesSec unlimited_io)
+(tune.setReadBytesSec  unlimited_io)
+(tune.setWriteBytesSec unlimited_io)
+
+(tune.setTotalIopsSec unlimited_io)
+(tune.setReadIopsSec  unlimited_io)
+(tune.setWriteIopsSec unlimited_io)
+})
+})
+
+### Main Script
+(if (== True ioTuneEnabled) {
+(with Guests guest (set_io_limits guest))
+}{
+(with Guests guest (reset_io_limits guest))
+})
\ No newline at end of file


-- 
To view, visit https://gerrit.ovirt.org/54208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 13: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 8:

(6 comments)

https://gerrit.ovirt.org/#/c/52746/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2386: self._devices[hwclass.DISK][:]:
> Works. Better alternative:
Done


Line 2392: asDomainID and hasPoolID and hasImageID and hasVolumeID
> hasAnyId = isVdsmImage(dev)
Done


Line 2394: (not hasDomainID or dev.domainID == domainId) and
 : (not hasPoolID or dev.poolID == poolId) and
 : (not hasImageID or dev.imageID == imageId) and
 : (not hasVolumeID or dev.volumeID == volumeId)):
> so it is possible that up to three of those IDs may be False-ish? How so?
I was not sure, if all of them have to be providied to identify a disk.
If yes, I will change this code.


Line 2466: domainId = ioTune.get("domainId")
 : poolId = ioTune.get("poolId")
 : imageId = ioTune.get("imageId")
 : volumeId = ioTune.get("volumeId")
> same comment as per line 2394-2397: Doesn't feel right if one or more of th
See previous reply.


Line 2574: res = {'name': device.name, 'path': device.path, 'ioTune': io_tune}
> We don't need this temporary
Done


Line 2580: return response.error('noVM')
Line 2581: else:
Line 2582: return response.error('updateIoTuneErr', 
e.message)
Line 2583: 
Line 2584: return {'status': doneCode, 'ioTune': resultList}
> return response.success(ioTune=resultList)
Done
Line 2585: 
Line 2586: def setIoTune(self, tunables):
Line 2587: for io_tune_change in tunables:
Line 2588: device_name = io_tune_change.get('name', None)


-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches