Douglas Schilling Landgraf has abandoned this change.
Change subject: service: Add vdsm-tool-configure service
..
Abandoned
I wish we could drop it in vdsm, dropping the package for now.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: service: Add vdsm-tool-configure service
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/64904
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: service: Add vdsm-tool-update service
..
Patch Set 1: Verified+1
Hi,
Additional info from our tests: I have backported this patch to downstream
Hello Fabian Deutsch,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64904
to review the following change.
Change subject: service: Add vdsm-tool-update service
..
service: Add vdsm-tool-update
Douglas Schilling Landgraf has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 4:
Sure, no problem Nir. I can split the patch and try to test all of it. I
Douglas Schilling Landgraf has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 1: Verified+1
make rpm works in branch master, clicking verified.
--
To
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
cleanup: remove persist/unpersist calls for legacy node
This patch removes all related
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Require python-blivet only with gluster-management build
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62625
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62465
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: remove deprecated BuildRoot macro
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm reg: clean up
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/62463
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm reg: clean up
..
vdsm reg: clean up
Reviewing the vdsm spec found some remaning of vdsm reg deprecated
in early 3.6 versions.
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
This would be perfect but using the flag in all make looks like trigger an
issue in jenkins.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62453
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hook-fcoe is arch depended
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62454
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Removing deprecated lines from spec
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62159
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: remove deprecated BuildRoot macro
..
spec: remove deprecated BuildRoot macro
Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 2: Code-Review+1
indeed, needed
--
To view, visit https://gerrit.ovirt.org/61384
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Add shadow-utils as requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60152
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Add shadow-utils as requirement
..
Patch Set 2:
jenkins error not related to the patch.
--
To view, visit https://gerrit.ovirt.org/59900
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Add shadow-utils as requirement
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59900
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: Add shadow-utils as requirement
..
spec: Add shadow-utils as requirement
vdsm uses in the spec file useradd, usermod tools which
came from
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Require sanlock 2.8-3
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59655
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Require sanlock 2.8-3
..
Patch Set 1: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/59656
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Require sanlock 2.8-3
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59655
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 22: Code-Review+1
From the node side, looks good.
--
To view, visit https://gerrit.ovirt.org/55029
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 22:
(1 comment)
https://gerrit.ovirt.org/#/c/55029/21/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 21:
(3 comments)
few comments from my side, but other than that looks good one.
Douglas Schilling Landgraf has abandoned this change.
Change subject: change downloaded ca pem filename
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Douglas Schilling Landgraf has abandoned this change.
Change subject: register: Add --ca-file
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/44576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Douglas Schilling Landgraf has abandoned this change.
Change subject: hooks: Add vdsm-hook-emulator
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/45334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42490/5/vdsm.spec.in
File vdsm.spec.in:
Line 45:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.host.uuid: eliminate obsoleted argument "legacy"
..
Patch Set 2:
just for records +1
--
To view, visit https://gerrit.ovirt.org/54384
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Leave the logging to the vdsm-tool
..
Patch Set 2:
Dan's call.
--
To view, visit https://gerrit.ovirt.org/46978
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Leave the logging to the vdsm-tool
..
Patch Set 2:
looks like that our QE already has been looking to /var/log/vdsm/register.log,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: replace deprecated define to global macro
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51155/1/vdsm.spec.in
File vdsm.spec.in:
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: replace deprecated define to global macro
..
spec: replace deprecated define to global macro
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: replace deprecated define to global macro
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51155
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/47385
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 6: Code-Review+1
Hi Oved, I was wondering if the patch sill valid as it's old one or if it's
Douglas Schilling Landgraf has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 6:
if this patch is not needed anymore, please abandon.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
Patch Set 1: Code-Review-1
Make sense dan's comment, moving to -1 as well.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Pull some vars into the class
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/46977
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 1:
jenkins url not found, not related to the patch.
--
To view, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: utils: replace import for persist/unpersist
..
utils: replace import for persist/unpersist
Use the new ovirt-node Config class for
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 1: Verified+1
Backported only.
--
To view, visit https://gerrit.ovirt.org/47968
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/47829/2/lib/vdsm/utils.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: replace import for persist/unpersist
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/47829
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: replace order of import for persist/unpersist
..
Patch Set 1: Verified+1
I couldn't reproduce the report but the stactktrace is clear. I
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: utils: replace order of import for persist/unpersist
..
utils: replace order of import for persist/unpersist
Preferable use the new ovirt-node
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47385/1/lib/vdsm/tool/register.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/47385
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: handle non uuid machines
..
register: handle non uuid machines
If user machines doesn't provide UUID data this patch
collects a random
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Simplify setting defaults
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46979
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Drop CA path redundancies
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/46980
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Leave the logging to the vdsm-tool
..
Patch Set 1:
I believe the vdsm already provides too much data but Dan is the man to decide.
--
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Drop CA path redundancies
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46980/1/lib/vdsm/tool/register.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Fix certificate validation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46981/1/lib/vdsm/tool/register.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46970
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Limit sleep_millisecs to minimum 10
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45332
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Remove substitutions from dumpStorageTable
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44877
To unsubscribe,
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: hooks: Add vdsm-hook-emulator
..
hooks: Add vdsm-hook-emulator
vdsm-hook-emulator has been created to help users change
the default emulator entry
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hooks: Add vdsm-hook-emulator
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45334
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --vdsm-uuid
..
Patch Set 1: Verified+1
backport only
--
To view, visit https://gerrit.ovirt.org/44887
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: Add --vdsm-uuid
..
register: Add --vdsm-uuid
This patch adds --vdsm-uuid option to user provide
host UUID to be used instead vdsm.utils.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --vdsm-uuid
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/44431
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --ca-file
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44576
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --ca-file option
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44576
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: Add --ca-file option
..
register: Add --ca-file option
Currently, we storage the Engine ca file in /etc/ovirt-engine/ca.pem
which is not
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --vdsm-uuid
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44431
To unsubscribe, visit
Douglas Schilling Landgraf has abandoned this change.
Change subject: register: simplify check fqdn
..
Abandoned
Abandoning for now, we can restore if needed.
--
To view, visit https://gerrit.ovirt.org/44220
To unsubscribe,
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: Add --persist-uuid
..
register: Add --persist-uuid
This patch adds --persist-uuid option for cases where the machine
duplicates UUID.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Add --persist-uuid
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44431
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: remove legacy code for uuid
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44241
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 2:
Dan, should I abandon this one ?
--
To view, visit https://gerrit.ovirt.org/44220
To unsubscribe,
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: general improvements
..
register: general improvements
- replace --node-fqdn to --node-address for a better naming fit
- remove unused
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: general improvements
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44369
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: utils: remove legacy code for uuid
..
utils: remove legacy code for uuid
In 3.6 version we won't support old registration
schema. This patch
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 2:
I prefer to have --nocheck-fqdn as the default is always True but if you prefer
this way, it's not a
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: remove legacy code
..
register: remove legacy code
The legacy code should be dropped. The new registration
schema should only support
Douglas Schilling Landgraf has posted comments on this change.
Change subject: change downloaded ca pem filename
..
Patch Set 1: Code-Review-1
-1 for now
--
To view, visit https://gerrit.ovirt.org/42837
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: simplify check fqdn
..
register: simplify check fqdn
Currently we use --check-fqdn (True or False) which
is unneeded. We can simplify
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsm-tool: remove register verb
..
Abandoned
The verb will remain.
--
To view, visit https://gerrit.ovirt.org/43921
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 1: Verified+1
I could make registration
--
To view, visit https://gerrit.ovirt.org/44219
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44220
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: use node name and fqdn when needed
..
register: use node name and fqdn when needed
Currently, we collect host fqdn before registering
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 2:
doesn't look register error.
02:44:55 FAILED (SKIP=64, errors=3)
02:44:55 Exception AttributeError:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44221
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 3:
I could build vdsm rpms and vdsm_reg is not generated.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 3: Verified+1 Code-Review-1
-1 as pending the official test for new reg approach.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 2:
Can we drop vdsm-store-net-config too ?
--
To view, visit https://gerrit.ovirt.org/43254
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: remove register verb
..
Patch Set 2: Code-Review-1
pending decision.
--
To view, visit https://gerrit.ovirt.org/43921
To unsubscribe,
Douglas Schilling Landgraf has restored this change.
Change subject: change downloaded ca pem filename
..
Restored
--
To view, visit https://gerrit.ovirt.org/42837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 2: Verified+1
make rpm didn't generate the vdsm-reg pkg.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 2: Code-Review-1
-1 as still needs QE approve the approach selected in registration
--
To view,
1 - 100 of 1676 matches
Mail list logo
