Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Douglas Schilling Landgraf has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Dan Kenigsberg has submitted this change and it was merged. Change subject: Check if libvirtd.upstart is present before copying .. Check if libvirtd.upstart is present before copying If the (libvirt) packaged upstart script is present in the rpm list of files but is absent from the filesystem the initscript was failing because the cp command couldn't copy it. This is mostly interesting in stripped down installations as the ovirt-node. RHBZ: 849984 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc --- M vdsm/vdsmd.init.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/679/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Douglas Schilling Landgraf has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Federico Simoncelli has uploaded a new change for review. Change subject: Check if libvirtd.upstart is present before copying .. Check if libvirtd.upstart is present before copying If the (libvirt) packaged upstart script is present in the rpm list of files but is absent from the filesystem the initscript was failing because the cp command couldn't copy it. This is mostly interesting in stripped down installations as the ovirt-node. Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc --- M vdsm/vdsmd.init.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/7375/1 diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index a57649f..a222e21 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -433,7 +433,7 @@ /bin/grep libvirtd.upstart | /usr/bin/tail -1` target=/etc/init/libvirtd.conf -if ! diff -q $packaged $target /dev/null; +if [[ -f $packaged ]] ! diff -q $packaged $target /dev/null; then /bin/cp -p $packaged $target || return 1 /sbin/initctl reload-configuration -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/561/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Douglas Schilling Landgraf has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Dan Kenigsberg has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: was there any functional side effect to this, beyond ugly errors on vdsmd restart? -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Dan Kenigsberg has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: I would prefer that you didn't submit this -1 for visibility only -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Dan Kenigsberg has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: oh, I now see that there *is* a big issue. https://bugzilla.redhat.com/show_bug.cgi?id=849984 would you mention this in the commit message? -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Check if libvirtd.upstart is present before copying
Ayal Baron has posted comments on this change. Change subject: Check if libvirtd.upstart is present before copying .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
