Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: net: netconf owner change should ignore gid
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: netconf owner change should ignore gid
..


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: netconf owner change should ignore gid
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: netconf owner change should ignore gid
..


net: netconf owner change should ignore gid

When changing ownership of the directories/files the group id
does not need to change.
It affects tests which run as non-root (they fail when attempting
to change the gid to root (0).

Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/51148
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M lib/vdsm/netconfpersistence.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: netconf owner change should ignore gid
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netconf owner change should ignore gid

2015-12-29 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: netconf owner change should ignore gid
..

net: netconf owner change should ignore gid

When changing ownership of the directories/files the group id
does not need to change.
It affects tests which run as non-root (they fail when attempting
to change the gid to root (0).

Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Signed-off-by: Edward Haas 
---
M lib/vdsm/netconfpersistence.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/51148/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 82f0b15..053ddbe 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -167,9 +167,9 @@
 
 # Set owner to vdsm (required by ovirt-node)
 vdsm_uid = pwd.getpwnam(constants.VDSM_USER).pw_uid
-os.chown(os.path.dirname(dirPath), vdsm_uid, 0)
-os.chown(dirPath, vdsm_uid, 0)
-os.chown(path, vdsm_uid, 0)
+os.chown(os.path.dirname(dirPath), vdsm_uid, -1)
+os.chown(dirPath, vdsm_uid, -1)
+os.chown(path, vdsm_uid, -1)
 
 @staticmethod
 def _removeConfig(path):


-- 
To view, visit https://gerrit.ovirt.org/51148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches