Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-06 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


net: privatize IFCFG_ZERO_SUFFIXED

Only used inside netinfo.misc

Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/49623
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/netinfo/misc.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-03 Thread ibarkan 
Ido Barkan has uploaded a new change for review.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..

net: privatize IFCFG_ZERO_SUFFIXED

Only used inside netinfo.misc

Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Signed-off-by: Ido Barkan 
---
M lib/vdsm/netinfo/misc.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/49623/1

diff --git a/lib/vdsm/netinfo/misc.py b/lib/vdsm/netinfo/misc.py
index 77bb4a4..9acffa6 100644
--- a/lib/vdsm/netinfo/misc.py
+++ b/lib/vdsm/netinfo/misc.py
@@ -22,7 +22,7 @@
 from ..ipwrapper import getLinks
 
 
-IFCFG_ZERO_SUFFIXED = frozenset(
+_IFCFG_ZERO_SUFFIXED = frozenset(
 ('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
 # TODO: once the unification of vdsm under site-packges is done, this duplicate
 # TODO: of ifcfg.NET_CONF_DIR and ifcfg.NET_CONF_PREF can be removed
@@ -36,7 +36,7 @@
 with open(NET_CONF_PREF + iface) as f:
 for line in shlex.split(f, comments=True):
 k, v = line.split('=', 1)
-if k in IFCFG_ZERO_SUFFIXED:
+if k in _IFCFG_ZERO_SUFFIXED:
 k = k[:-1]
 ifaceCfg[k] = v
 except Exception:


-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: privatize IFCFG_ZERO_SUFFIXED

2015-12-03 Thread ibarkan 
Ido Barkan has posted comments on this change.

Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9cd9a962fbecf916b0f9041fc7f91abeea359c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches