Change in vdsm[master]: spec: require vdsm-client package

2017-02-16 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: require vdsm-client package
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/72382/1//COMMIT_MSG
Commit Message:

PS1, Line 11: We want to ship vdsm
why do we want that? vdsm already pulls a lot of packages, but this one is not 
strictly required for vdsm to run properly.

It is a debug tool, that we should ship in the default installation, but I 
don't think we need to force anyone to have it.


PS1, Line 12: for the build
it is *not* a build requirement.


-- 
To view, visit https://gerrit.ovirt.org/72382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6839346ff4180b97ca3d0dd530dfb329ce0e6402
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: require vdsm-client package

2017-02-16 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: require vdsm-client package
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/72382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6839346ff4180b97ca3d0dd530dfb329ce0e6402
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org