Dan Kenigsberg has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/domain_descriptor.py
File
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
(2 comments)
Partial review
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4489:
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4489:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 24:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 24:
rebased, due to vmxml.py changes introduced since the revision before.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 24:
(2 comments)
some possible improvements I'd like to implement, probably better in follow up
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
fixes tests broken by rebase. Will do any other change but rebase fixes/address
reviewer's
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9745/ :
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 23: Code-Review+1
let's have this in! It owuld be awesome to have also some numbers about the
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(3 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 484:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 15: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 16: Code-Review-1 Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
(2 comments)
Nice, needs little cleanup.
http://gerrit.ovirt.org/#/c/17694/18/vdsm/virt/vm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9670/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 17: Code-Review-1 Verified-1
Build Failed
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
(2 comments)
I'm fine with the domain_descriptor.py;
but just a wild idea, maybe merge into
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
@return value
No, not any more, I just updated it
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 19: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 20: Code-Review-1 Verified-1
Build Unstable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 21: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9693/ :
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(2 comments)
Nice but see comments in
Itamar Heim has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 14:
ping
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 14: Code-Review-1
Please address my comments from patch set 13:
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 14:
Patch set 14: just published a patch of mine on top of this one :\
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8108/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(8 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 484:
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 5108: def
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 4634:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6730/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6731/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 10:
(2 comments)
just a couple of nits. I'm really looking forward to have this merged!
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6732/ : FAILURE
Martin Sivák has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/17694/10/vdsm/vm.py
File vdsm/vm.py:
Line 461: class
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6741/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6743/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6748/ :
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 485:
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13: Code-Review-1
(8 comments)
This is a very nice patch, but it needs some more work.
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 3105:
Michal Skrivanek has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 3105:
49 matches
Mail list logo
