Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: build: Don't use fixed path to systemd directory
..


build: Don't use fixed path to systemd directory

Since commit 9d6f46d9 the project can no longer be built and installed
by non-root user. There is probably nothing wrong with the patch itself.
It's rather the fact that we use fixed path to the systemd directory
which prevents us from installing into some other prefix.

This patch changes the value of SYSTEMD_UNIT_DIR to use ${prefix}
which is normaly set to "/usr" during packaging.

Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Signed-off-by: Tomáš Golembiovský 
Reviewed-on: https://gerrit.ovirt.org/63687
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik 
Reviewed-by: Francesco Romani 
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Tomas Golembiovsky: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread Tomas Golembiovsky 
Tomas Golembiovsky has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 1:

Verified. The files are properly installed into ${prefix} when make install is 
used. The files are in /usr/lib/systemd/system/ in the RPM.

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread Tomas Golembiovsky 
Tomas Golembiovsky has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread Tomas Golembiovsky 
Tomas Golembiovsky has uploaded a new change for review.

Change subject: build: Don't use fixed path to systemd directory
..

build: Don't use fixed path to systemd directory

Since commit 9d6f46d9 the project can no longer be built and installed
by non-root user. There is probably nothing wrong with the patch itself.
It's rather the fact that we use fixed path to the systemd directory
which prevents us from installing into some other prefix.

This patch changes the value of SYSTEMD_UNIT_DIR to use ${prefix}
which is normaly set to "/usr" during packaging.

Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Signed-off-by: Tomáš Golembiovský 
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/63687/1

diff --git a/configure.ac b/configure.ac
index 5756499..2b546d2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -236,7 +236,7 @@
 AC_SUBST([CDROMGROUP], [cdrom])
 
 # Systemd units default path
-AC_SUBST([SYSTEMD_UNIT_DIR], ['/usr/lib/systemd/system'])
+AC_SUBST([SYSTEMD_UNIT_DIR], ['${prefix}/lib/systemd/system'])
 
 # VDSM default paths
 AC_SUBST([vdsmdir], ['${datarootdir}/vdsm'])


-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Don't use fixed path to systemd directory

2016-09-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build: Don't use fixed path to systemd directory
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6306e2e449d3762a7b9dcfac58d09970fac83574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org