Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-18 Thread igoihman 
Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Abandoned

as we agreed

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-13 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

Yes Nir, I really don't understand your concern, we remove here the status 
field to avoid overriding for that key. returning a list means that the value 
of vmList key is a list. all return vals are dicts and those patches don't 
change it.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-13 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

In the engine we always expect a key and a data described by the type from 
schema. As I understand we only remove status information from the response. 
There are no other changes in this patch.

We want to be consistent across the verbs and send status information only when 
the code is not 0 or there is no answer.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-12 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

(6 comments)

Unfortunately, this change the behavior in incompatible way. I did not check 
the schema, but even if it describes the new format this change is wrong since 
all clients are depending on the actual data returned from vdsm.

More: This is not a change in jsonrpsvdscli, but in the Bridge - it effects all 
jsonrpc clients.

https://gerrit.ovirt.org/#/c/63483/3/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 345
Line 346
Line 347
Line 348
Line 349
This returned before a list of pool...


Line 345: 'Host_fenceNode': {'ret': Host_fenceNode_Ret},
Line 346: 'Host_getAllTasksInfo': {'ret': 'allTasksInfo'},
Line 347: 'Host_getAllTasksStatuses': {'ret': 'allTasksStatus'},
Line 348: 'Host_getCapabilities': {'ret': Host_getCapabilities_Ret},
Line 349: 'Host_getConnectedStoragePools': {'ret': remove_status_from_ret},
Now we get a dict with a 'poollist' key - schema conflict - and worse breaking 
all client of this api, expecting list of pools.
Line 350: 'Host_getDeviceList': {'ret': 'devList'},
Line 351: 'Host_getDevicesVisibility': {'ret': 'visible'},
Line 352: 'Host_getExternalVMs': {'ret': 'vmList'},
Line 353: 'Host_getExternalVMNames': {'ret': 'vmNames'},


Line 355: 'Host_getConvertedVm': {'ret': 'ovf'},
Line 356: 'Host_getHardwareInfo': {'ret': 'info'},
Line 357: 'Host_getLVMVolumeGroups': {'ret': 'vglist'},
Line 358: 'Host_getStats': {'ret': 'info'},
Line 359: 'Host_getStorageDomains': {'ret': remove_status_from_ret},
Same
Line 360: 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
Line 361: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 362: 'Host_getVMList': {'call': Host_getVMList_Call,
Line 363:'ret': remove_status_from_ret},


Line 380: 'ISCSIConnection_discoverSendTargets': {'ret': 'fullTargets'},
Line 381: 'LVMVolumeGroup_create': {'ret': 'uuid'},
Line 382: 'LVMVolumeGroup_getInfo': {'ret': 'info'},
Line 383: 'StorageDomain_getFileStats': {'ret': 'fileStats'},
Line 384: 'StorageDomain_getImages': {'ret': remove_status_from_ret},
Same
Line 385: 'StorageDomain_getInfo': {'ret': 'info'},
Line 386: 'StorageDomain_getStats': {'ret': 'stats'},
Line 387: 'StorageDomain_getVolumes': {'ret': remove_status_from_ret},
Line 388: 'StorageDomain_resizePV': {'ret': 'size'},


Line 383: 'StorageDomain_getFileStats': {'ret': 'fileStats'},
Line 384: 'StorageDomain_getImages': {'ret': remove_status_from_ret},
Line 385: 'StorageDomain_getInfo': {'ret': 'info'},
Line 386: 'StorageDomain_getStats': {'ret': 'stats'},
Line 387: 'StorageDomain_getVolumes': {'ret': remove_status_from_ret},
Same
Line 388: 'StorageDomain_resizePV': {'ret': 'size'},
Line 389: 'StoragePool_connectStorageServer': {'ret': 'statuslist'},
Line 390: 'StoragePool_disconnectStorageServer': {'ret': 'statuslist'},
Line 391: 'StoragePool_fence': {'ret': 'spm_st'},


Line 427: 'VM_updateDevice': {'ret': 'vmList'},
Line 428: 'Volume_copy': {'ret': 'uuid'},
Line 429: 'Volume_create': {'ret': 'uuid'},
Line 430: 'Volume_delete': {'ret': 'uuid'},
Line 431: 'Volume_getInfo': {'ret': remove_status_from_ret},
Same
Line 432: 'Volume_getPath': {'ret': 'path'},
Line 433: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 434: 'Volume_extendSize': {'ret': 'uuid'},
Line 435: 'Host_getAllTasks': {'ret': 'tasks'},


-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-12 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

Irit, the previous patch created a conflict in the schema - the schema promise 
list of vms, and the patch return dict with one key (vmList).

Maybe this patch does not change the schema, but we must first fix the errors 
before we reuse the code from that patch.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-12 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

> This looks correct, if https://gerrit.ovirt.org/63408 was correcdt,
 > but
 > I think it was wrong, changing the return value from list of vms to
 > dict with a vmList key, conflicting the schema and possibly
 > breaking engine.

Nir, can we talk about it offline? I don't see any conflict in the schema and a 
dict is returned now and before (just with different keys). We can test it 
further if you'd like.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-12 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Code-Review-1

This looks correct, if https://gerrit.ovirt.org/63408 was correcdt, but
I think it was wrong, changing the return value from list of vms to dict with a 
vmList key, conflicting the schema and possibly breaking engine.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-12 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-11 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-11 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-09 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-07 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-07 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-07 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-07 Thread igoihman 
Irit Goihman has uploaded a new change for review.

Change subject: jsonrpcvdscli: fix results of several commands
..

jsonrpcvdscli: fix results of several commands

There are some commands that return result in a bad format that is
not backword compatible with xmlrpc results.
The result contains an inner dictionary or a list that should be
saved in a dictionary under a certain key, but until now only the
inner dictionary/list were in the result. This caused overriding of
several fields and bad formatting.
It is impossible to change all the commands results since it breaks the
engine so only some commands results have been changed.

Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/63483/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index f264e8d..b281be8 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -346,7 +346,7 @@
 'Host_getAllTasksInfo': {'ret': 'allTasksInfo'},
 'Host_getAllTasksStatuses': {'ret': 'allTasksStatus'},
 'Host_getCapabilities': {'ret': Host_getCapabilities_Ret},
-'Host_getConnectedStoragePools': {'ret': 'poollist'},
+'Host_getConnectedStoragePools': {'ret': remove_status_from_ret},
 'Host_getDeviceList': {'ret': 'devList'},
 'Host_getDevicesVisibility': {'ret': 'visible'},
 'Host_getExternalVMs': {'ret': 'vmList'},
@@ -381,10 +381,10 @@
 'LVMVolumeGroup_create': {'ret': 'uuid'},
 'LVMVolumeGroup_getInfo': {'ret': 'info'},
 'StorageDomain_getFileStats': {'ret': 'fileStats'},
-'StorageDomain_getImages': {'ret': 'imageslist'},
+'StorageDomain_getImages': {'ret': remove_status_from_ret},
 'StorageDomain_getInfo': {'ret': 'info'},
 'StorageDomain_getStats': {'ret': 'stats'},
-'StorageDomain_getVolumes': {'ret': 'uuidlist'},
+'StorageDomain_getVolumes': {'ret': remove_status_from_ret},
 'StorageDomain_resizePV': {'ret': 'size'},
 'StoragePool_connectStorageServer': {'ret': 'statuslist'},
 'StoragePool_disconnectStorageServer': {'ret': 'statuslist'},
@@ -428,7 +428,7 @@
 'Volume_copy': {'ret': 'uuid'},
 'Volume_create': {'ret': 'uuid'},
 'Volume_delete': {'ret': 'uuid'},
-'Volume_getInfo': {'ret': 'info'},
+'Volume_getInfo': {'ret': remove_status_from_ret},
 'Volume_getPath': {'ret': 'path'},
 'Volume_getSize': {'ret': Volume_getsize_Ret},
 'Volume_extendSize': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

2016-09-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org