Petr Horáček has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62705
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ondřej Svoboda has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3:
(9 comments)
https://gerrit.ovirt.org/#/c/62705/3/lib/vdsm/network/ip/resolv.py
File
Edward Haas has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3:
Correcting my last comment: Functional tests will appear in the next patch as
part of OVS + dns setup.
--
To
Edward Haas has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3: Code-Review-1
(1 comment)
We are also missing functional tests for this, please add them.
Petr Horáček has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/62705/3/lib/vdsm/network/ip/resolv.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ondřej Svoboda has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/62705/1/lib/vdsm/network/ip/resolv.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 1:
(2 comments)
very very shallow review on my part
gerrit-hooks has posted comments on this change.
Change subject: net: add a resolv.conf writer
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ondřej Svoboda has uploaded a new change for review.
Change subject: net: add a resolv.conf writer
..
net: add a resolv.conf writer
Change-Id: I41b81b04fbe3e3e2398f28cb16fb0dbbc0382249
Signed-off-by: Ondřej Svoboda
12 matches
Mail list logo
