Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-16 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net libvirt hook: revert vmList change
..


net libvirt hook: revert vmList change

Patch 78ea853e131da3b91b812315a0656b8f99d7fef4 is reverted so the
vmList key change is also reverted.

Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/63762
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Tested-by: Milan Zamazal 
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
---
M tests/network/vm_migrate_hook_test.py
M vdsm/virt/vm_migrate_hook.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Milan Zamazal: Verified
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-16 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63762/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

PS1, Line 182: items
> We need to fix this
pardon, what should be fixed? when? by whom?


-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-16 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63762/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

PS1, Line 182: items
We need to fix this


-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-16 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1: Code-Review+2

As we agreed

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-15 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1:

Ping

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1: Code-Review+1

Waiting for Dan ack.

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-14 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1: Verified+1

I verified that migration works for me with this patch.

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-14 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1: Code-Review+1

Please make sure that the verification includes an actual migration attempt.

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net libvirt hook: revert vmList change
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

2016-09-14 Thread igoihman 
Irit Goihman has uploaded a new change for review.

Change subject: net libvirt hook: revert vmList change
..

net libvirt hook: revert vmList change

Patch 78ea853e131da3b91b812315a0656b8f99d7fef4 is reverted so the
vmList key change is also reverted.

Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Signed-off-by: Irit Goihman 
---
M tests/network/vm_migrate_hook_test.py
M vdsm/virt/vm_migrate_hook.py
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/63762/1

diff --git a/tests/network/vm_migrate_hook_test.py 
b/tests/network/vm_migrate_hook_test.py
index 7f11995..7294734 100644
--- a/tests/network/vm_migrate_hook_test.py
+++ b/tests/network/vm_migrate_hook_test.py
@@ -31,7 +31,7 @@
 class MockVdscli(object):
 @staticmethod
 def fullList(*args, **kwargs):
-return {'vmList': [VM_FULL_LIST]}
+return {'items': [VM_FULL_LIST]}
 
 
 class MockJsonrpcvdscli(object):
diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py
index 5379cef..633e4f0 100755
--- a/vdsm/virt/vm_migrate_hook.py
+++ b/vdsm/virt/vm_migrate_hook.py
@@ -179,7 +179,7 @@
 
 def _vm_item(vdscli, vm_uuid):
 result = vdscli.fullList(fullStatus=True, vmList=(vm_uuid,))
-return result['vmList'][0] if len(result['vmList']) else None
+return result['items'][0] if len(result['items']) else None
 
 
 def _vdscli():


-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org