Nir Soffer has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
(7 comments)
The change is good and important, and having a test for this is even more
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
(1 comment)
Commit Message
Line 12: *
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1:
I think that the commit message should explain which user flow exposes this
severe bug, so that our users
Sergey Gotliv has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+1
Since this patch cost me 2 destroyed VMs I definitely will give it +1.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1:
(1 comment)
Commit Message
Line 12: * a new comment
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Code-Review+2
(1 comment)
Commit Message
Line 12: *
Federico Simoncelli has uploaded a new change for review.
Change subject: oop: improve safety for truncateFile
..
oop: improve safety for truncateFile
In order to make truncateFile safer and to avoid any confusion on its
Federico Simoncelli has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1: Verified+1
Verified using the provided unit test.
--
To view, visit http://gerrit.ovirt.org/20046
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4886/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: oop: improve safety for truncateFile
..
Patch Set 1:
(1 comment)
Commit Message
Line 12: * a new comment
10 matches
Mail list logo
