Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: add setMasterDomain to StoragePool .. sp: add setMasterDomain to StoragePool It turns out that getMasterDomain is used mostly as a setter for the

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-19 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Code-Review-1 I'm confused, I might be missing something... What about : vdsm/storage/hsm.py:1039:

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-19 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: I'm confused, I might be missing something The previous patch removed them. -- To view, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-19 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: -Code-Review -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-19 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6149/ : SUCCESS

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6150/ : SUCCESS

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6156/ : SUCCESS

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Verified+1 Verified for the relevant flows: createStoragePool, connectStoragePool,

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: So this patch is not just cosmetic, it fixes behaviour. @Ayal, this patch is cosmetic only as

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread abaron
Ayal Baron has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-18 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-12 Thread abaron
Ayal Baron has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-12-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5956/ : SUCCESS

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-11-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4958/ : SUCCESS

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-11-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4990/ : SUCCESS

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-11-28 Thread abaron
Ayal Baron has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 4: 1. I've never noticed this 2. You failed to explain that connectStoragePool returns true if you're already

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-11-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4924/ :

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-11-25 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: sp: add setMasterDomain to StoragePool .. sp: add setMasterDomain to StoragePool It turns out that getMasterDomain is used mostly as a setter for the

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

2013-11-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4886/ : SUCCESS