Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: add setMasterDomain to StoragePool
..
sp: add setMasterDomain to StoragePool
It turns out that getMasterDomain is used mostly as a setter for
the
Allon Mureinik has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Code-Review-1
I'm confused, I might be missing something...
What about :
vdsm/storage/hsm.py:1039:
Federico Simoncelli has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8:
I'm confused, I might be missing something
The previous patch removed them.
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: -Code-Review
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6149/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6150/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6156/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Verified+1
Verified for the relevant flows: createStoragePool, connectStoragePool,
Federico Simoncelli has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8:
So this patch is not just cosmetic, it fixes behaviour.
@Ayal, this patch is cosmetic only as
Ayal Baron has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21659
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5956/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4958/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4990/ : SUCCESS
Ayal Baron has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 4:
1. I've never noticed this
2. You failed to explain that connectStoragePool returns true if you're already
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4924/ :
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: add setMasterDomain to StoragePool
..
sp: add setMasterDomain to StoragePool
It turns out that getMasterDomain is used mostly as a setter for
the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4886/ : SUCCESS
21 matches
Mail list logo